From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D467A8045D for ; Wed, 28 Oct 2026 17:12:33 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SHBK1e022270; Wed, 28 Oct 2026 20:11:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SHBK1e022270 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Um5g/gTH" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SHB6hc022246 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 28 Oct 2026 20:11:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SHB6hc022246 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49953abe51fso8956225e9.1 for ; Wed, 28 Oct 2026 10:11:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzSpGIFTSqsLuwuAOjh6o5NLtCaMoXpwvhi3OCOO/FK1K9hsm1ZO2Y9UsgrMx2SpV4vImCT7A==@openvz.org X-Gm-Message-State: AFq9FYLGiGq+RHjH0A4Y1k8eH2F2dQTNNpsHprtRPEuYiOWIEfIFwH2P roKk7nhK4udzcWJJl0vrsG5wbs1pLh0jhPBc+GTXuEgZLlZqcPE0IGgxb3fZ4VaLsXsyMqrkunC Y+gdOv8N7BM/YzzJaPsGo59D4oNKG2jgseDFERS68oYUFE9kZEnhwiQ== X-Gm-Gg: AYBFou0V6yJ6IATOM8Z39qARowwIlk4dtT0iBffLtmQorPTVoa/K27iS6A5H7xvHa14 ESHZkoLDfk8rrkXXgIt8MLF6nuGa6QjOQS9XgAzqKU1nzEk5g2eP8CymGs5IYOAbGepySLPDOr7 qoLEtqu4G5gTg6fXwdlZoaOjUEpo4RjGIb0EJeKyipfrl4rgGcaPTu+5xHAou68syV+ABqnbEGq qB8PdidL1IlszSnBSadqJL1tXzCaMeNa9VpzeMrgDlCA1sWssNobtiUvdJygkQN3T42dYhDQhKa QJWnBjTivqwQUiPU8av298QhpgOHfzY9MTeAExWx5mBIgM9Db3rv+g0aaRzGONRrpJ76aM+uo2/ O9Ma93iMOlgu+jIXe X-Received: by 2002:a05:600c:1d1a:b0:4a1:f688:a5d5 with SMTP id 5b1f17b1804b1-4a966c41de5mr65825035e9.23.1793207466275; Wed, 28 Oct 2026 10:11:06 -0700 (PDT) X-Received: by 2002:a05:600c:1d1a:b0:4a1:f688:a5d5 with SMTP id 5b1f17b1804b1-4a966c41de5mr65823965e9.23.1793207465571; Wed, 28 Oct 2026 10:11:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793207465; cv=none; d=google.com; s=arc-20260327; b=SnB3AlRaK+fs/28TEuWdx12wD1oe9dyweLjs+ZAkHQ2ilOxAmpdoGzUJrmaYHTemE0 JbY/+bOl4mMPkgEtU/3aVfHLcAIUd3VkjyeXRgBuN+e5e9ARbRsBPeUUixhsp40+hgVO NooS36Ui6ouadY/vWOKuBknrS/FxUN7P+lahsbHD0RVtr4pcp7nWZO9sj3a2FaGLfYLd aKwlbPpZSFRGyNuyeu5+0txM0WeZJ4ccyVYys1HcpveyT5Pkaj4p/TVCa5xlJxv7/ufZ E6Y/Vs42rSQPg9ERuKsMeqRs4d1XV9gJEp3p0QarBz4jzaecPDT7sXRIRun56Pi45ttR Q+Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:dkim-signature; bh=ZK8tQ6VbTdRmqZgzU+n8EKO4OoKHnh0NTbHu2BiUJJs=; fh=XcqC0Cib/C4XsQyLUc3b6E9Ii37Wk0LS3yBNHj5szHI=; b=B3LVnqX04lFQ0IGlsf0xGXXwyPf+nL0Arl+4N18NgM5tWorz9tq77pFGYHD7aj2d2p n7/AuiCO6LISgWJL2gOIAB6w04rSQEJbWgRlhcRCjOeh+oQHGHSCkegl7iKdafuyJIrl ANU8Lj08I6fudgjK3HFJtvcErS3brdEbx9mVr/xjGg7bpEU5TTJvTmJss3Xx0hhs3WAm GZXeOqjFfMLjZgtjNhqO3C5QjE4QpONmKpsw9+A3KtcWyI06EUs8kruCQe5/cw4Bj5ab 1Ry4tCvF5CP7QNUb/Btrb6ygtMlWra+2LQP4ZA/jrkcrGqGSywbM7W+9aeKGktr8z1/s 26/Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Um5g/gTH"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e3ece8d92si26999495f8f.183.2026.10.28.10.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:11:05 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Um5g/gTH"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Message-Id:Date:Subject :From; bh=ZK8tQ6VbTdRmqZgzU+n8EKO4OoKHnh0NTbHu2BiUJJs=; b=Um5g/gTHQE5CUfFD0BR F05XDsW50/MhekJ86JufBVxBhwctBolok2e01KORbZ65gtKVkzXtDVntXr8TSY/sWJYX+gn6PkwDF FHFsxOjYnHUdAsmeuvD8OC7MZUolaRDfTzAH4W0P+RyieSz7FYTdetrQg8jzAes4h8g9F/u8EMiSj w1xKlzLIb6b+4lJMt2iviGBMv8FUOhXSSdoUS0nkHK0YdxtSF2VaiKEyJcsVoEpoEZFRVauy3BAtz Y5S0/gcHIhYzN9UUsvSLZJ3IzCiHuuNp3gCleU4/z/yYUG1XNN+v4pDugNl+lFMU9rUcxS3HfQ6qQ jGQ/hWxWQlwTerQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xM77G-00Dgbl-0v; Wed, 28 Oct 2026 18:11:03 +0100 From: Konstantin Khorenko Date: Wed, 28 Oct 2026 18:10:59 +0100 Message-Id: <20261028-b4-prep-khorenko-vstor-151607-numa-migrate-order-v3-0-893494e8db76@virtuozzo.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAKMs4moC/6WPQXLDIAxFr5JhXTEg29jpqvfodAFYDTRjyIDNp M747sXOrst2p68v6X09WKbkKbPX04MlKj77GKpoXk7MOh0uBH6smqFAJQUOYFq4JbrB1cVE4Rq h5DkmkJ1UooewTBomf0l6JohppAQtNVqpVg/nsWX1bN3+9PcD+c6c9TBwyT6eRl7MF9l5B+6jR mcCk3Swbm89K0hOClBcIheAUvIOueSI/M7LWp1Y1n3X+T3X9/FYkQfs7z8UCZWlhqZRHSrV92/ Fp3mJ6xq5jdMRv+B/IVgh5tw3ekDdGWF/Q7Zt+wEcorNzsAEAAA== X-Change-ID: 20261028-b4-prep-khorenko-vstor-151607-numa-migrate-order-4e3a664a89d4 To: Pavel Tikhomirov X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=9567; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=xNiFw2tEfv7cWgOzW5uuWpfE8c7TFdbWiRHwKfybXvw=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq4iynRSKXO88To/69gxHKQDI7/KWObmkEVuvxz mHASjmLq3GJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCauIspwAKCRBRlgpH+WFc KrNmD/0Veub0nti8IqYEtJxkBvZUq5Pn9G6HpeJ0WQZv55q7sSOfqzqmffGNDvP/WVL940AxN7Q OybSxQMmfdw8u5dYNNW7A2liTVmTCk0IeRxbAUXsspI6wSawoRjvHmo5Jsv3fwQwMEE0APmkXH6 nLbN+ZpVwgfNKclIVAAqGHuzkgmyNFvMGOPILomH1nuRr13/o3oNN4qtbgv0TPa2gYaH2PeawVf xSyZ7iYRPOCwdw9B6lmpJlJ6s9J0Kv2PgU7+uoR1orHBFPkd3mmMOQDUBSjuw6AUsj4/O0QCKf8 JnYDdGhRPI/WLmdKx5LCy/428X3EeG25qIVFpOnAdgd2OQgVIlR7YX/Q7DaautKxuD1IAsTcwaE 8Nf8KmJRgVepjoLN1UrJmSFrqUsDQexaid71VBhW+DnjLXYCyoJaZluedHkoaF90uiOaRAYo1pt maGjdzSHjbA2RO61jEtBMZ+9AQXrMDRCIluRAthd6MP7UtRO2MKxnpnrAtPx9gKzQQelOX7a2sT O3A9VnSCTztAJHWv5nlYfxtmUMGgL5q88sDVnpt/MEmhYPoMxnHvHXz4z/Mc1HGkC/HVpWipAMP qKD/VSTt+nbbqgSy0Kzf6OtpFRLNt/dRhKqLCDYTQDUrK9WKEKwe/xv1liulFyp1gYzpYalAUUK G8yZ3069AK3Pfcw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 0/2] mm/memcontrol: numa_migrate destinations of the source folio order X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org memory.numa_migrate, our memcg file that vcmmd uses to move a cgroup's memory between NUMA nodes, allocates a 2 MB destination for every large folio it migrates. Page cache folios of a smaller order get a destination of the wrong size, and the page cache falls apart around it. Patch 1 is the fix, patch 2 a selftest that catches it without crashing the node. What the customer hit ===================== A two-node VMware host runs VMs with vcmmd's NUMA policy enabled, so every few minutes vcmmd writes memory.numa_migrate for a VM's cgroup. qemu writes its backup scratch file on NFS, and NFS sizes each page cache folio to the write, so that file is full of order-1 to order-5 folios. Closing the scratch file dies in nfs4_evict_inode(): kernel BUG at fs/inode.c:737! RIP: 0010:clear_inode+0x75/0x80 mapping->nrpages of the inode is negative, and the vmcore holds order-9 folios of that file with an index not aligned to 512, the refcount of a small folio, and whole xarray ranges of live folios that are no longer in the tree. Reads of the migrated ranges return garbage, so the backups taken on that host while the policy was active should be verified. The same crash was filed as VSTOR-151676. Where the 2 MB comes from ========================= memcg_numa_migrate_new_folio() is the migrate_pages() allocation callback. Its large folio branch dates from vz8 (4.18) and follows what new_page() in mm/mempolicy.c did on the 4.x kernels: if (thp_migration_supported() && PageTransHuge(page)) alloc ... HPAGE_PMD_ORDER A compound page on the LRU could only be a PMD-sized THP then, so the test implied the order. Upstream replaced that with folio_order() of the source when its allocators moved to folios, ffe06786b540 ("mm/migrate: Use a folio in alloc_migration_target()"). Our copy kept the shape, only PageTransHuge() became folio_test_large(), which is folio_test_head() and is true for any order from 1 up. NFS and XFS large folios, shmem and anonymous mTHP now all reach it. Why an oversized destination breaks the page cache ================================================== The two sides of the page cache size the folio differently. On insertion __folio_migrate_mapping() takes everything from the source: nr = folio_nr_pages(old), the xarray state at the old index with no xas_set_order(), newfolio->index = old->index, folio_ref_add(newfolio, nr), and xas_store() replaces exactly the slots the source occupied. folio_copy() copies the source pages only. So a 2 MB folio enters the cache as, say, a 4-page one: 4 xarray slots, 4 extra references, nrpages unchanged, 4 pages of valid data. Everything afterwards asks the folio itself, and it answers order 9: - page_cache_delete(): xas_set_order(index, 9) and nrpages -= 512. 512 slots wiped instead of 4, with the index rounded down to 512 so that other live folios lose their slots, and 512 subtracted instead of 4. That is the negative nrpages and the orphaned folios. - __remove_mapping(): expects 1 + 512 references and finds 1 + 4. Reclaim can never free the folio. - filemap_free_folio(): drops 512 references from a handful at eviction. The refcount goes negative and the folio leaks. - reads: folio_file_page() picks the page by its offset inside the folio, but only the first pages were copied. The data damage shows on the first read of the folio: filemap_read() takes the page at ki_pos & (folio_size - 1) of the destination, which is uninitialised unless the index is 2 MB aligned, and a longer read that starts there continues through the destination past the neighbours. The structural damage waits for the first operation that applies folio_nr_pages() or folio_order() to it: invalidation, truncate, reclaim, inode eviction. On NFS cache invalidation is routine (an attribute change), so the bug shows up there instead of staying a silent 2 MB leak per folio. In short: inserted by the source size, removed by the destination size. That only works when the two match, which for a real THP they always did. A debug kernel says the same on the first migration, in mem_cgroup_migrate(): VM_BUG_ON_FOLIO(folio_nr_pages(old) != folio_nr_pages(new)) The patches =========== Patch 1 allocates the destination with folio_order() of the source, GFP_TRANSHUGE_LIGHT for large folios as before. The thp_migration_supported() test goes: migrate_pages() splits PMD-mappable folios itself when THP migration is unsupported, and every other large folio still needs a matching destination. Patch 2 adds tools/testing/selftests/ve/ve_numa_migrate_test.c. It binds a cgroup to one NUMA node, writes a file on a loop-mounted XFS image in 64K chunks so that the page cache holds large folios, widens cpuset.mems to both nodes (the destination allocation honours the writer's cpuset), migrates the cgroup to the other node through memory.numa_migrate and compares what reads back. The chunks at 2 MB aligned offsets are left out: a folio there reads right even from an oversized destination. memory.current cannot serve as the detector: mem_cgroup_migrate() only transfers the charge, whatever the size mismatch. On an unfixed kernel the comparison fails and the test leaves the image mounted on purpose, since evicting the inode would hit the BUG_ON. The folio sizes are not taken on faith: the test reads the compound flags of the file's pages through /proc/self/pagemap and /proc/kpageflags, and after the migration also the node of every page through move_pages() in query mode. A file without a large folio below the PMD size, or a migration that moved none of them to the target node in one piece, fails the test (PMD-sized folios got a correct destination from the old code too, and migrate_pages() may split or skip folios under memory pressure). That is deliberate: a skip would hide that the test no longer reaches the bug, a failure says the setup needs another way to get large folios. memory.numa_stat is only logged, polled for a few seconds since memcg flushes its per-cpu counters lazily. It needs root, two NUMA nodes with memory (numa=fake=2 is enough), cgroup2 with memory and cpuset, and mkfs.xfs; it skips otherwise. Testing ======= On a VM booted with numa=fake=2: - the reproducer (64K and 8K writes on XFS from a node-bound cgroup, memory.numa_migrate to the other node, unlink) kills the unfixed debug kernel on the VM_BUG_ON above and the release kernel in clear_inode(); with patch 1 migration succeeds and unlink and eviction complete; - the selftest passes on the fixed kernel and fails on the comparison on 22.11 without taking the node down. Other branches ============== The same patch applies as is to the 20.x branch (the customer's kernel); the function is a plain callback, so it is a ReadyKernel candidate. vz9 carries the same PageTransHuge() code, but the file systems we ship on 5.14 (XFS, NFS, ext4, shmem) put no non-PMD large folios on the LRU, so it is not reachable there in practice. https://virtuozzo.atlassian.net/browse/VSTOR-151607 Assisted-by: LLM Signed-off-by: Konstantin Khorenko --- Changes in v3: - Patch 2: the large folio guard requires a folio below the PMD size and the page size comes from sysconf() (Sashiko). After the migration the test checks through move_pages() that at least one such folio sits on the target node in one piece, instead of requiring the whole file in memory.numa_stat, which migrate_pages() does not guarantee (Sashiko); the stat is logged only. - Patch 2: the chunks at 2 MB aligned offsets are not written, so an oversized destination always shows in the read-back, and the image stays mounted until the last check passes; the folio sizes per node are logged before and after the migration; the mkfs.xfs check goes, a failing mkfs skips the test anyway (independent review). - Patch 2: Reviewed-by tags dropped, the test changed too much since the review. - Link to v2: http://lore.virtuozzo.com/20261028-b4-prep-khorenko-vstor-151607-numa-migrate-order-v2-0-b973a82a5b0c@virtuozzo.com Changes in v2: - Patch 1: the commit message says why the thp_migration_supported() check goes (Pavel). - Patch 2: the folio sizes are checked through /proc/self/pagemap and /proc/kpageflags before the migration; a file without a large folio fails the test on purpose (Pavel). - Patch 2: the read-back comparison runs first and the memory.numa_stat check after it, polled for a few seconds, since memory_numa_stat_show() flushes the per-cpu counters only past a per-CPU threshold (Vasileios). - Reviewed-by from Pavel and Vasileios on both patches. - Link to v1: http://lore.virtuozzo.com/20261028-b4-prep-khorenko-vstor-151607-numa-migrate-order-v1-0-268336526677@virtuozzo.com --- Konstantin Khorenko (2): mm/memcontrol: allocate numa_migrate targets of the source folio order selftests/ve: check memory.numa_migrate keeps the folio order mm/memcontrol.c | 11 +- tools/testing/selftests/ve/Makefile | 1 + tools/testing/selftests/ve/ve_numa_migrate_test.c | 494 ++++++++++++++++++++++ 3 files changed, 501 insertions(+), 5 deletions(-) --- base-commit: b499efa17aa9fb8f20512d1831d1cb61b22e60d3 change-id: 20261028-b4-prep-khorenko-vstor-151607-numa-migrate-order-4e3a664a89d4 Best regards, -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel