From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021140.outbound.protection.outlook.com [52.101.70.140]) by lore.virtuozzo.com (Postfix) with ESMTPS id 70A578017D for ; Wed, 28 Oct 2026 12:33:43 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GZotUjRlJifdCP+WR5eq7E5T5iEuWISHFXRFGxPwmhl4H339oVOxiKBdyCsIxOVflg8TdMlRZT6pSjTSxjceW9U2my8BOU0Vl8WmAxs0vXGhDdOjp+tJDABJdrGPaJHnZqUSEU2tNM3mf1LXCRD+D2DyhgpceV3OEwfM1Yq7sHSkTP0p0+TewjSoCmQ5Cpom1a2x4lFAgWiw5KgoM1k+E05IXgh/7yMFpcW9kiq3va/XeUc4hDrNS+VWbvnUDFdwSIofmCy+BeqoB0H23PSKJcSRI5/CJ2lGvElExuKfEReWPt5+AgS/0158TMusTkEds8kPhuaXk8iMto0UFMgXvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eg6+kdwmuVkYljr/G1MucObtIlbb+ijtts05R2geKHY=; b=k4j6lGZ+CArseKb5nANf8nNLtKraxm8wBEuNEnigZ3k+ibd8nBdj8efbEe/19e/QgkyyvRXeyrOMCY31gqkvJllwqlDDDq37iXS0ykHFs4YVA+bkXj6iuanfTlBaKEIlh7irgRS5wZTPzp6R3wdakvAqOjlhGJKSMo0Oxl6pGZoMfzdL+hoWa2EXyEKy1N4joX+smoU1GlzQnvxQkdxxbdfHjnBTwEjquXy22M5WKYcpRfpFpSrhyZ+O2kOrsAqnm3Gk7/yZxvo1W0n4IxCsSOJmOb2eOE1BNMQDPBcYeQAzSwWg33Urd5KQQZEIT+0Nn7UgK6tqi3uD1kfs0qhtXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 130.117.225.111) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=virtuozzo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eg6+kdwmuVkYljr/G1MucObtIlbb+ijtts05R2geKHY=; b=YI6x7BqZaSuGzDQq6PhFq5Z7BuXTD2siJP0iPRLI2b0uCYe0/Ne4ERoaJSvLBq6y4TdY8KpVJRuJgDvbiBlR1ofWkjbQLO1sxtgG773EDtiwzlMKm/0qj/mc6Y65irTzaSWp8yqJxNX+bFXOambnPyt8UXKbbxcbsHa+UyQyXyiil4h8iAW/KeZOBqgWLg03nTgR5QPpY4QRnQWeWXgckAqdnNu5Tm85YiyjHwvNijPrLvvq3m13uyxJJ2V44Q4LJ3ClhZR+F6gg5YqEodXp1Z9oQyElYdGTypMbCwwMmG+ER0lfoWw3cOjaQKWFNDdAMdWhHKwhBkzJzmzAedQt9w== Received: from AS9PR05CA0065.eurprd05.prod.outlook.com (2603:10a6:20b:499::9) by PAWPR08MB9892.eurprd08.prod.outlook.com (2603:10a6:102:342::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.8; Wed, 28 Oct 2026 12:33:39 +0000 Received: from ZR1PEPF0000E461.eurprd04.prod.outlook.com (2603:10a6:20b:499:cafe::6d) by AS9PR05CA0065.outlook.office365.com (2603:10a6:20b:499::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.23 via Frontend Transport; Wed, 28 Oct 2026 12:33:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 130.117.225.111) smtp.mailfrom=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com;dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 130.117.225.111 as permitted sender) receiver=protection.outlook.com; client-ip=130.117.225.111; helo=relay.virtuozzo.com; pr=C Received: from relay.virtuozzo.com (130.117.225.111) by ZR1PEPF0000E461.mail.protection.outlook.com (10.167.241.59) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Wed, 28 Oct 2026 12:33:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=Eg6+kdwmuVkYljr/G1MucObtIlbb+ijtts05R2geKHY=; b=k8yMxHOhiqTW ivBanwYKmfxNeT56QM1hUFhia/ooijPaDjQQaX5VGzfCihQLO1/PF/AZPE5GYwx5mXtNt0SbDvWuF KzDzFwGrkKZen6YmMOMrE5w9fyEP5m0sBDy+xw/jSwwqTO+uOgR+l21rG2GgHjc48w6IJeYigNE20 3+m01wzYdwgzzxefDVcstRUgi4+dhRxx5EvjHczmpv0a6f9rTg9kublGS6CNm4NYuBzpYp48CQB8j naGvtbaX2LjiDL/YET/+aGAvxrsQ+mW+WXmhCZbLtUQwynuIiyY2qB7mL/K8GmQMO/IBrOlmKQhf1 mgXUKM+2ih+E3sZrGOW8OQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xM2mk-007Thg-2l; Wed, 28 Oct 2026 13:33:36 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com Subject: [PATCH hci-8.1 v3 2/4] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES Date: Wed, 28 Oct 2026 13:33:31 +0100 Message-ID: <20261028123333.3145676-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261028123333.3145676-1-alexander.ivanov@virtuozzo.com> References: <20261028123333.3145676-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E461:EE_|PAWPR08MB9892:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c94982d-7ebf-48fe-f1bd-08df34efb082 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|376014|82310400026|36860700016|56012099006|261022105027099003|261009223027099003|261021121427099003|261026140227099003|261021123027099003|10067099003|22082099003|18002099003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: OMFvVXxi6lni7ui+pidMBMj0AgqIOfJ8CoTlIeSrJYK6oAZZA1WlQw0n1m2S8FyW2Cl3MnT9g519HKMM3/PW2f2/p/bSNS+c6j2znJi1Z8VWGFDxZXR3FR49HsUf/JPV7uDUCMgWb+9U1hFDENauGjIIXrlzkJ8V6TNNoNqXRnZdQgO+/NpvxS/3UiLDkWrzQtI8wj85VfUq1XA6Nm/rUHxzwwUDyjhFQa4jZIz8dm2+pf6S52D2WyK5sgwv6cuFbniw8/6o0QN2LSLoMG7aqYaXcSH34I/UR1AgaUR8ASPF/T0h6jqSsW3exhqvyXUjGBRlcidqvP6H2JjxUI5OYNuCdaDned4hoR7PTgeEsJx2XmTLbHtESRoRH6RjXBzucJuSEziu3JH3B/IHTy3GwUgOeZNqZNFjGSBzsm5c/bUva6EqF3NnxCNOsbIB/3bUDR2rOS5idYT199Q21wcCU97A2qrlmRVoN725cAXCv+4yQCjND0jhU0+uNEBD76e+23Y8SikP8ey45dbBL5QgduY/eEHPMk284U108aRzfCChw1/GzrlHN6LNd/Nai4I1ArLcS7pwQqv5WbTfsvsSNWcTi3wgqoF7xJ2TI0LR1XCD7Iem+tJs68WN0/PTVwNcjOV1ULn9Mot10O5bz+molrFMx3/lCMr1Os8Z5g/+C8w= X-Forefront-Antispam-Report: CIP:130.117.225.111;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:relay.virtuozzo.com;PTR:relay.virtuozzo.com;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(376014)(82310400026)(36860700016)(56012099006)(261022105027099003)(261009223027099003)(261021121427099003)(261026140227099003)(261021123027099003)(10067099003)(22082099003)(18002099003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0tvSsoaGl6VXEsgHB4sxhYaWZLw9vtzKC7mh7Gl9ee8DkNIb8Zuukq/0dZrJMjkExyZpsj0EcOUAHmNung1H1q/A+BXxsTGX+hgY4BRaq0QGqTaOadcwrlBchp1m3reOsFGApelHt+T6obhyd0RboFlXYywMVUGJmqdTfQZ3U8Hdib7Z28zMT5i+HtLPEeT4vErieEMuVH3WgsQcRXMWZtGnq4rNjz6gqAkZJAT+pKJ2W7jPHvOBeBJG4yEyvi7c58Z/Z93pPi/j2TRpqzTnD+SvxuMkN/qmxJv7dQJFI/Nc9yIL4FclKdH9gcUrIm43IBTCsAvLf1Zer9lMBG1xs2nFlzFlp2ovAvbpINuo/iXhHzi1NKpHPPnkgRNOUurh3fN+LMVRBDprPDihNb53i7whwDBFakXukcl7i7kMnXUsvQHDkq10YLFs27Tv0IKB X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2026 12:33:37.3044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c94982d-7ebf-48fe-f1bd-08df34efb082 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f;Ip=[130.117.225.111];Helo=[relay.virtuozzo.com] X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9892 Only the automatic num-queues value is capped at VHOST_BLK_MAX_QUEUES, an explicit one is taken as is. The kernel vhost-blk device has that many virtqueues and fails VHOST_SET_VRING_NUM on any vq beyond them, so such a device realizes fine and then never starts. Refuse it at realize instead. https://virtuozzo.atlassian.net/browse/VSTOR-107537 Signed-off-by: Alexander Ivanov --- hw/block/vhost-blk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c index abddff02c6d..8a015d54fa7 100644 --- a/hw/block/vhost-blk.c +++ b/hw/block/vhost-blk.c @@ -598,8 +598,9 @@ static void vhost_blk_device_realize(DeviceState *dev, Error **errp) VHOST_BLK_MAX_QUEUES); } - if (!conf->num_queues) { - error_setg(errp, "vhost-blk: num-queues property must be larger than 0"); + if (!conf->num_queues || conf->num_queues > VHOST_BLK_MAX_QUEUES) { + error_setg(errp, "vhost-blk: invalid num-queues property (%" PRIu16 "), " + "must be 1-%d", conf->num_queues, VHOST_BLK_MAX_QUEUES); return; } -- 2.53.0