From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6826380474 for ; Wed, 28 Oct 2026 13:22:31 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SDLEV7020293; Wed, 28 Oct 2026 16:21:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SDLEV7020293 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793193676; bh=qD4L97vwaiFlaeCYAwEtBg+IeyjKFvlnRPvCA3XVeok=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=WG/9vjmOJtDPQ1UDeK/9VRtEpEJLUMWhR5Q6pjO7ckBYrg653294GEe9rWWSGQJCc MU5n7nHCxudnBf7hxujZnjzzoqtvlkLfzppmkrUq0LLNBE4sHOhyNb00nyXs9oKGdu L1Kpnr3Psr/PbnKi+dLM1Ov1CesYa3u/HgA3NGL0YOoHjSVxlsen9u/s3qVRxndpQc b5+jgDEHMSJ3m8fiPmRYpQ0X6dywf2qIZkG/C79bKM5mYY/sB7ZSwLfTrKF8mVet0r Sbe9mCc87wDOgxK+KyyO8z5RH7Rx/4pJtW4fbcPu4GcXjaQqd67GTZw+vct+pENKE6 FAuh1TJQEzlJA== Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SDLAck020278 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 28 Oct 2026 16:21:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SDLAck020278 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="RwBtLTmC" Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e011829easo698928f8f.3 for ; Wed, 28 Oct 2026 06:21:10 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzMXRMI/EUn786Xk5iuoPThVbUw1jNmjQ/nqHD71RaGyeKc8R4p5EU9VKqigjZd9jE8w/t7Cw==@openvz.org X-Gm-Message-State: AFq9FYK7qiUV0+CozIvJBqlWKF7fxfHtm8qoOSqoPoOICxQygasgyvQ/ Nsv23dV/2qExXc7dXThL3wBr3cd27klzs7xC4SS7o6iYfCHDMeMen52brIc+58WHEx+VhgBIPvK kq0VsK43W8x6iEwhqtTiSC45R+iWqOibLKLz31GVDbhigcLTXtqSmBg== X-Gm-Gg: AYBFou3Lvd6oS8ko4zlxnWDfEmsi1r5JE+CUsM9M+Nw2Cl3nJZJGZuzrPl6rMId6/et QXxZog8fDDfjy/a38TeUyERsDBK70j6l9SzwARgFbu2XH9vJklTyUdyTw2zpdpgDLUbdlt4oWxO aiNM58Aaf/EtapIgBLO6H79rZRQ8J3shUMwTa5qXSixMSHW692K2o+OUBdqjCNwI7KX7N2X1PiR BzfnmuanhmSNtFO+bmIpj5Jys662gLksECw3ZNcVHRWagoM4chYg69mkKDy9mVVXyxrBxWI+bhn 01+tej9OLg== X-Received: by 2002:a05:600c:1d1a:b0:4a1:f688:a5d5 with SMTP id 5b1f17b1804b1-4a966c41de5mr48776515e9.23.1793193669865; Wed, 28 Oct 2026 06:21:09 -0700 (PDT) X-Received: by 2002:a05:600c:1d1a:b0:4a1:f688:a5d5 with SMTP id 5b1f17b1804b1-4a966c41de5mr48775725e9.23.1793193669097; Wed, 28 Oct 2026 06:21:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793193669; cv=none; d=google.com; s=arc-20260327; b=isVB9xq6uLUV60v9qZAPCTkyAve+Q+ls7tatRaoOKRCv3vs7o8PhY2tpvTXmP50j8R PXjIfaVtl+CaWI83uTJy4z8uOtUgFSf5PSI4UappWyDpMQQXdRxsXNwcciLlUFa7dvuc KOZuFQOyn+mh26dudBLVtNqIpDzF/6XqMl/0WKbApGTnXxXRuuLH9Bv8mQC8+aBHRHNc d8dcwdqTUBqHtuSuMefFOYoj9kFj/pnfCGP32baWdkBRuvnwYpSGHWowAmKVaN9OGkbp d/dStPGZhj5/OfDTjiXSzBP0Bx4jLNIqIHULuBqBhNxQbkl/3CU7VDB8tGKwKgmuqSYu Ws9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=z+b0NEkdWKBev18+7XeB5t2Y1GI9YRT24mrM9XD7M+Q=; fh=ZEijZe9QQPTfhNmcYDTHLtSV2UuPdTIgj1I54aggC1M=; b=mrlXRGYefPM5MQ7v5Yk4/IqWC/hW+yvbzjK85/KtnFWLHdpxjj5+W3TtPTqzCkxB0C UqbS1oLw0fFduYPdGqEF6F2JK+rKn4InrOGIfmbZ5Q70pzejkPhvTcwr04zqeYuZ4v9v pq3x5DHvWAMEr8k7NlMeEp9Qg5Tgs1NtHEQCbWlS1YB4jKKHo6gHEI9bFa7rdd3LBlJy spVwBjgvAfxf9u1Q2iIxNR4r2LhJ6MZtIQZ0jcRQGfEWxKriPhA831V1+ffEIuavAscX k0tWg6Klmy8vOWEhQNOHte6zbTQgqX93fFlhem5FbHxfxXTuQAYReq46UwKogKxmqgPB SChQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=RwBtLTmC; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:2c3:d099:6fb:56cf as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48e5e293c51sor300026f8f.2.2026.10.28.06.21.09 for (Google Transport Security); Wed, 28 Oct 2026 06:21:09 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:2c3:d099:6fb:56cf as permitted sender) client-ip=2a06:5b06:b600:300:2c3:d099:6fb:56cf; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=RwBtLTmC; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:2c3:d099:6fb:56cf as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793193669; x=1793798469; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z+b0NEkdWKBev18+7XeB5t2Y1GI9YRT24mrM9XD7M+Q=; b=RwBtLTmCea+SDIHnhXezqD+m16wLyvSlL7UANQaIhgKCKwbiTOaKx6P3oPCzMNdwq0 +0uptvHCwMX7UE4ZOaSBaggf7b2c0Qu3WRQrUeBGDSIrKW7aS3gfjVZNTYz9yHzHuj71 SqrFwpMXhH/Fjk6yAoeyM0W9LNDQjy2LlzEkhWcTMsmcMStqzPQ3Q6NQhyNDb9VVP9P1 lXC5j4HLgZvsCXWIXsVd3cWCF00ALFrx3gVoyOAm4MphANmQR+xQM3kV/Z8pXr9/J1sr P6Tm1P5oVBJqwtYi9dF051yF0/j5Me9RVqjVGaLUVrEWH9sxuvdXTYrEojkpRm+VB00t 9o9w== X-Forwarded-Encrypted: i=1; AKwUvBy4ENmGqAZEKU+oTzNkGKOdQ1c4eB9wPJwTwaIEQMlhuyRkd+SW6Gcoli/+WRgARWixl39b4Q==@openvz.org X-Received: by 2002:a5d:584b:0:b0:48c:6f3a:fe30 with SMTP id ffacd0b85a97d-48e5d5c26f9mr6064949f8f.15.1793193668540; Wed, 28 Oct 2026 06:21:08 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:2c3:d099:6fb:56cf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ecd3418sm25625739f8f.41.2026.10.28.06.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 06:21:07 -0700 (PDT) From: "Denis V. Lunev" To: andrey.zhadchenko@virtuozzo.com Date: Wed, 28 Oct 2026 14:21:03 +0100 Message-ID: <20261028132104.2885097-2-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261028132104.2885097-1-den@openvz.org> References: <20261028132104.2885097-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 1/2] dm-ploop: fix a failed merge failing every later merge on the host X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev ploop_process_merge_latest_snapshot() collects the status of its fake merge pios in a function-local static. It is never reset and it is shared by every ploop device, so once a single pio fails, every later merge on any device stops after its first pio and returns that old error, until the module is reloaded. A failure on one device also aborts a merge running on another. Keep the status on the stack. The pios carry a pointer to it, so the function must not return while one of them is outstanding: every exit already waits for service_pios to drain. Fixes: 6ddad5a4d226 ("dm-ploop: Add ploop target driver") Signed-off-by: Denis V. Lunev Reviewed-by: Andrey Zhadchenko Feature: dm-ploop: ploop target driver --- drivers/md/dm-ploop-cmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c index 5fa78e6cff9a..9084ca37f45b 100644 --- a/drivers/md/dm-ploop-cmd.c +++ b/drivers/md/dm-ploop-cmd.c @@ -671,7 +671,7 @@ static void service_pio_endio(struct pio *pio, void *data, blk_status_t status) static int ploop_process_merge_latest_snapshot(struct ploop *ploop) { - static blk_status_t service_status; + blk_status_t service_status = BLK_STS_OK; struct bio_vec bvec = {0}; struct pio *pio; int ret = 0; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel