From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 18D5C8017D for ; Wed, 28 Oct 2026 14:49:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SEm71X020803; Wed, 28 Oct 2026 17:48:08 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SEm71X020803 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793198891; bh=WUkXEnvghcmX1PvlJey/qGnK69iGemEimDMhcvirrkc=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=eolAQauX7Z5EGwDoUWg+R9bMqk7kEdE5ON1EGoOEMHj0LnXWtt9VggTpXRKD5m4G/ zD6RRLf3QjkoxuzwVaDaqVDaYUGrnEvzzBchwA5UuhV8nyqr3CIkAA6Vz1GukJJhUR xQoh/fsjaYPK87dzc5SfHonn8AY7KGRIJOaji869OgMF6srYc+M0xHuUlT0PN2u9hq ExPUV0qHHnLcg+qSW5kXkYxvBB8XM7YEGm79xCnCIA8VYld0YuHFSaUHFheHlD4m6Y ognCg4zQj+9u5ZqbxHMk3FQ0dpRViZz5vAVw3ebmKNKckhBp+rieHnHZgw1YECoai/ +83jHwy1tynyA== Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SEm5Im020799 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 28 Oct 2026 17:48:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SEm5Im020799 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="kr1okeYj" Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c25501f4aa2so142883566b.1 for ; Wed, 28 Oct 2026 07:48:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzyx5gMoxBwrUDyEAGMZJKLbYtHRGrgDZB+9VQ4VgpY8KCc5GGo/hwbxk8pKHQT1Fm33O6krA==@openvz.org X-Gm-Message-State: AFq9FYIXoyFj9VcbJKVFvJyFRegDi6IHyTa7VGuSVcg+vD8/o5irOHTh PfET3vbLIPJ0iF7Fh3a9K08es/f97I2SIRYVXbIAQNlJGSmYGerAfMtFQtvzh0yQ99VXm7tnubS wBIGQ9gMEix9oaG1O+zn3pACPPwlRQuLJ1QRzVUlRU62R0fdei053pw== X-Gm-Gg: AYBFou2hTM/azQVRc5NHEOslOOZazqPtkWoBbA3OAgCEph3u27gkWKeSuxJx8eiqzme c+S36j8ZvCjiCiG1jSWGv4KF9X9cN+eh1ONz4z6H7EoL383lFFQlDixwgMe/1EsWVLut8HiYird 35t3Aik/h2pmerEaX4O74RqwTR52bkVUoLmGCrD5TyUJ+R5iKg7VFFoy9485jm5W6/gZVw4raqg +nXUN9u5Y2AWSKZu8Vv4DTp9jvPsJFYtzFcKnwiro3Ey546cRfSObNlIrAXA4lkECr5RQWWniNz GoJwh6qCBw== X-Received: by 2002:a05:6000:18cd:b0:48d:fce6:884e with SMTP id ffacd0b85a97d-48e6020ad45mr3078085f8f.12.1793198214283; Wed, 28 Oct 2026 07:36:54 -0700 (PDT) X-Received: by 2002:a05:6000:18cd:b0:48d:fce6:884e with SMTP id ffacd0b85a97d-48e6020ad45mr3078024f8f.12.1793198213640; Wed, 28 Oct 2026 07:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793198213; cv=none; d=google.com; s=arc-20260327; b=TJP6sClosTFmNlAwelP/07K2+c5emmJdXHA9T+DQ1bWhR31GY+VcvGA9j2JR9ySoBL QAngmWqlUyEu5Gi3QoNlv+axWbMj7dcemKUS0m1VnZyj7tVH5U7QRt07HkCBd86NWmfr jjxfwpJkRLSY4Dx0DN/Sp5xso2R2XSgVfWmFIWHvoQ0CsMHuxBcU4H0wawAsF/PMs2DD CmYLCP+eZ5gRjP13AaDyl+YzmtsvWBBiCOqU8pP2z2zUlffPIt157+WNYw85VGG6Evns Kb620qg4m5g01GJ3uQ0XN7cIX2hsfj6d0Ne0/zhgIkVwKcwmMF57au1Hs/6ZU4Qt2jiB Mbgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=I1jH5sG2di1E3TqbFjIBLQRs0GJDwLZNm7Jcm/FIZRs=; fh=x2+aHSJrNVaBp1cxBveJJY3jZmqNsMcacT3vvi9eYbQ=; b=LlQXSvPT8IGIHIqpugh0VTc5ojufzcOnUOuyoD6RxW2dXeuRfi6FardF4bHsfVulcH 61Q81mOuwMcypG9FkMDMZsYO6F8dS1nQqTIoUcIWJB2GuqVKiTFK45Jqplwm1IcMrIf1 op443PSZfUa9c73AevtHjljrpWshhuoEaLELLZ1swwVL7ueUEywcsJ6W1qvQIJOFi44l dNzisJi81K1Hc1ynvwUWnJwyYSR9oVI1cjmnsJ7rGhWSz8ZAytFTEpENc3PaCE2b/AWS XQ4RtQSojFImH6nZr1nQB555FrXCoW7HsfJ3D5zDX3rRCtYxXn0BMg0vzKaVxZUpq0Bv p4kA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=kr1okeYj; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:2c3:d099:6fb:56cf as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48e3ebc8b27sor1100705f8f.8.2026.10.28.07.36.53 for (Google Transport Security); Wed, 28 Oct 2026 07:36:53 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:2c3:d099:6fb:56cf as permitted sender) client-ip=2a06:5b06:b600:300:2c3:d099:6fb:56cf; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=kr1okeYj; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:2c3:d099:6fb:56cf as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793198213; x=1793803013; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I1jH5sG2di1E3TqbFjIBLQRs0GJDwLZNm7Jcm/FIZRs=; b=kr1okeYjqBBWR9sc4MAolzh8+Fjx1w+uNIIXhKTMD6aoYRfVcehPRIZgVKY49J09G3 GmyhiUH5fE5oMAirzKrJrRogBwRsVlghr6uWJ93s5PloptLgtK/BGnVfRVDFKwGo1FYG PVX8g+mtLV37QcC6lCQMwQ8P30EqDUkK6Wz8Bgk8AB0wu5a8LCdLYvnq9cVfYydAEcX7 9wsnPFnu8ljsxanDWrVN4lyvOG59bZ+J2d4PsT00L/d7+VNAmXdEp9NwvdECAynKbqVg 37Bzlong3fmudIEKucU2E4pgI0uX2i2wWdzEHR4sCslw+D3cl76BaOg3jzwt6rBM8Gee ACBw== X-Forwarded-Encrypted: i=1; AKwUvBySU+PtV/FfHZzXtwz3NSgB92QfS6MMQoRgQVJ5wAS1SNtUcb8fji5ZSbWc8L6kXdwE1bhMsg==@openvz.org X-Received: by 2002:a05:6000:1081:b0:48d:f5c1:dc24 with SMTP id ffacd0b85a97d-48e55a377d4mr11455654f8f.6.1793198213163; Wed, 28 Oct 2026 07:36:53 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:2c3:d099:6fb:56cf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ebd4d8dsm30321335f8f.36.2026.10.28.07.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 07:36:52 -0700 (PDT) From: "Denis V. Lunev" To: andrey.zhadchenko@virtuozzo.com Date: Wed, 28 Oct 2026 15:36:46 +0100 Message-ID: <20261028143647.2972030-4-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261028143647.2972030-1-den@openvz.org> References: <20261028143647.2972030-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 3/4] dm-ploop: drop the dead PLOOP_DELAYWB code X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev "dm-ploop: disable metadata writeback delay" fenced the code that published new mappings in the local BAT before their index writeback completed with #ifdef PLOOP_DELAYWB, because the delay hung pios in the md wait list. Nothing defines the macro, so the code is not built, and the blocks keep describing a scheme the rest of the driver no longer follows. Remove them. https://virtuozzo.atlassian.net/browse/VSTOR-151979 Signed-off-by: Denis V. Lunev Feature: dm-ploop: ploop target driver --- drivers/md/dm-ploop-map.c | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index 34bf6487107f..2f8abfa8905b 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -840,10 +840,6 @@ static void ploop_advance_local_after_bat_wb(struct ploop *ploop, /* holes bit map requires bat_lock */ spin_lock(&md->md_lock); -#ifdef PLOOP_DELAYWB - if (piwb->type == PIWB_TYPE_ALLOC) - goto skip_apply; -#endif for (; i < last; i++) { if (piwb->type == PIWB_TYPE_DISCARD) { /* discard completed */ @@ -873,9 +869,6 @@ static void ploop_advance_local_after_bat_wb(struct ploop *ploop, ploop_hole_set_bit(dst_clu[i], ploop); } } -#ifdef PLOOP_DELAYWB -skip_apply: -#endif WARN_ON_ONCE(!test_bit(MD_WRITEBACK, &md->status)); @@ -1347,10 +1340,6 @@ static int ploop_alloc_cluster(struct ploop *ploop, struct ploop_index_wb *piwb, map_index_t *to; int ret = 0; u32 tmp_clu; -#ifdef PLOOP_DELAYWB - unsigned long flags; - map_index_t *tomd; -#endif /* Cluster index related to the page[page_id] start */ clu -= piwb->page_id * PAGE_SIZE / sizeof(map_index_t) - PLOOP_MAP_OFFSET; @@ -1371,13 +1360,6 @@ static int ploop_alloc_cluster(struct ploop *ploop, struct ploop_index_wb *piwb, goto out; WRITE_ONCE(to[clu], *dst_clu); -#ifdef PLOOP_DELAYWB - spin_lock_irqsave(&piwb->md->md_lock, flags); - tomd = piwb->md->kmpage; - WRITE_ONCE(tomd[clu], *dst_clu); - WRITE_ONCE(piwb->md->bat_levels[clu], ploop_top_level(ploop)); - spin_unlock_irqrestore(&piwb->md->md_lock, flags); -#endif out: kunmap_local(to); return ret; @@ -1686,15 +1668,6 @@ static void ploop_submit_cow_index_wb(struct ploop_cow *cow) WRITE_ONCE(to[clu], cow->dst_clu); kunmap_local(to); -#ifdef PLOOP_DELAYWB - spin_lock_irqsave(&md->md_lock, flags); - to = md->kmpage; - WRITE_ONCE(to[clu], cow->dst_clu); - WRITE_ONCE(md->bat_levels[clu], ploop_top_level(ploop)); - spin_unlock_irqrestore(&md->md_lock, flags); - - ploop_md_up_prio(ploop, md); -#endif /* Prevent double clearing of holes_bitmap bit on complete_cow() */ cow->dst_clu = BAT_ENTRY_NONE; @@ -1810,9 +1783,7 @@ static bool ploop_locate_new_cluster_and_attach_pio(struct ploop *ploop, goto error; } -#ifndef PLOOP_DELAYWB ploop_attach_end_action(pio, piwb); -#endif attached = true; if (add_to_wblist) ploop_add_dirty_for_wb(ploop, md); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel