From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 3EBC880E7E for ; Wed, 28 Oct 2026 15:08:18 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SF75xP021114; Wed, 28 Oct 2026 18:07:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SF75xP021114 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="BNdlXul/" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SF6q05021056 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 28 Oct 2026 18:06:52 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SF6q05021056 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e4d1e29f3so895553f8f.3 for ; Wed, 28 Oct 2026 08:06:52 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxQIjvE/CVEK2pi37tleuc7djG8XBoFW8pUqoOdpMn5bEbXP3zRbE6wzpz9nTrHLij/eaOS9Q==@openvz.org X-Gm-Message-State: AFq9FYKgQG5uh77ctTWW+lwYd+/QEAP/zPzulC5L3Gx+NkFIRnUbH7QI nIOlbbz0UPtF60hb1u9IJzTrD7c7ERQ+zURKltXj8TxsKNd/Vt66J0JOaz16hNfnx3UAAQjsaF5 r0tzMfnSJSuOZ1Hm3YZy1S281UQLcLmrCCVu/1HJd4xnmgX0RyD3lTQ== X-Gm-Gg: AYBFou3/32z8CDiSu5uHnHNZvkbvNkcGZlUJCRUNrXmzZAo+fhfDOLXAEIcGWDM7D3E YtzvKYZ5X3JhVQzEn1aaF6kCZwYoPW2ACk/dwf4AtedJQFdropZ/elZAt+yELApqvLt2LZFoJpN 5+3Nj1nZf2wvFuIRsZkbO0K+8m0+PsrNfdRuASZKPpK8YEXUhY1XCW67CafyQTi2zbGYJF4NAq7 GgkTatU2iLWtJxSkEih+UHPsXJWhcn4WKZ67/2KpWyu7zjnJZ3R2iMySd1AkZsUo/sgUM/m9Pht Xh6uB3QDiCkzvMCpYNINBlbi2rddGJ+cAtz7U3DFusnK9Q0p0I/gneFYa9kuApa4SPnE7F8z8NB zheAFL5iadHO0ZvGB3dN2zeJdMCS4 X-Received: by 2002:a5d:5f52:0:b0:48e:2108:4d28 with SMTP id ffacd0b85a97d-48e5d2e4affmr6998907f8f.13.1793200012283; Wed, 28 Oct 2026 08:06:52 -0700 (PDT) X-Received: by 2002:a5d:5f52:0:b0:48e:2108:4d28 with SMTP id ffacd0b85a97d-48e5d2e4affmr6998813f8f.13.1793200011574; Wed, 28 Oct 2026 08:06:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793200011; cv=none; d=google.com; s=arc-20260327; b=DgvKOQ2TbNYzlDmrQa4ebv9LYU8KmULq4yKMw/ivF/N2LUjgOpZvCrPDe/x+EeVraw eqVivnwLYG6ft3YYFKbagO1SvbCKHa81/C4GyBsZP/n3ERdDkKw8jnDnwBVdu7VecTV4 LJ3fY97kvONRECSSUDuPK3IFlk2p7Z4QUw6uwH5zN3jQT2/uuTkrAQ9uESaVq0Nxshqz wD9tQF7xpk088zzt7BYex/wlmA0uxby+3q12dcd+RU+oBGlE4RQpw9cxYzLH2GC+TeYZ rEFsJp8AeVzaiqOkxbpyIaDvaATDlJTxZj5kcb/dRTWnEyVWRle4Rg0RdLKO7S3vLLoM aMXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=sK/TlinDaKnB1tPV7EIehMCCvv5ilZ2j/FwA3Pe/fI8=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=HB+XDED8QFrYt67Ytup/kTwn5Ag36qI9LtMJyAY5lCJXoNuT2/e+9ZnXZL7WML5Ae7 FEUosNq4iU33d5QsD9s250jExQ8zM16nZ8MBGaJ/vwsBVkfL8Dtsa74f4F1c2WJKRFkJ aK7KdiUWsrdheKzKCbX/Mx7mJwI6xEwehv25eh4U8B/k9vvOmoGPrcCuL7qNi4mdGiKx lleojLUme6shWbjOKNpkDPqxqmZOVez6EdvjKNlXETRQVgCdTgBbcX0jBJ3GOahaDKiG zKO5m8fEO9Aj6qaPiLzIDGb+UVokjrh3f73EoBwlBZqwRshGkV67NH/aGpxXzlBKEOxv jDpw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="BNdlXul/"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e3ed0cd6asi25004730f8f.329.2026.10.28.08.06.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 08:06:51 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="BNdlXul/"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=sK/TlinDaKnB1tPV7EIehMCCvv5ilZ2j/FwA3Pe/fI8=; b=BNdlXul/DwfN gPpnyZ4WLnSqrqN/v+4XeMS1ctdkjHep8ZLNybeYZjSbp/NZ7lKclLLriH6xpcV9qpNYuAoTEG8fp +BzJ1oNk/ekY3pN+GtzMIoXDnflc+5rqU22TDEcumdu7KqL17pX3MljPUrCWniR8lbRbj8Ir1OV0s zYMihDhxBt+1MfZVTX4pb+4Bilbk2re3dskHOQT6zBaP97mwMDnqY+Co9KYWEc50vJsS+PB4W2RNm Pndb6eMAtFrA8GIkRGEoy7m1drO3QgR1PXumrtGjGA8576uq5GUyzAoNc4bhci2cpPhmcRgsxEloq 6d3ZCfvlqnIJm0WeFfiOrQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xM5B2-00AtLl-2l; Wed, 28 Oct 2026 16:06:50 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Wed, 28 Oct 2026 16:06:38 +0100 Message-ID: <20261028150645.3222391-4-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v9 03/10] dm-qcow2: extend the file for a new refblock in allocate_cluster() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org place_r2() links a new refblock into R1, but moves neither file_size nor file_preallocated_area_start. The refblock stays at or above the watermark if truncate_prealloc_safe() in allocate_cluster() fails after place_r2(), or if a parallel mark_cluster_unused() lowers free_cluster_search_pos before the second pass of find_unused_cluster(). Truncation of preallocations on suspend then cuts the file under the refblock: R1 on disk points past EOF, and the next session gets -EIO on allocations in the range it covers. Make find_unused_cluster() report a position not covered by R2 instead of placing the refblock there itself. allocate_cluster() prepares that cluster the same way as a data cluster, with the punch, extend and watermark update moved into prepare_unused_cluster(), and calls place_r2() before searching again. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-map.c | 88 ++++++++++++++++++++++----------------- 1 file changed, 50 insertions(+), 38 deletions(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index 78ee7cf5e881..5952b5feb8bf 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -2085,21 +2085,12 @@ static int parse_metadata(struct qcow2 *qcow2, struct qio **qio, * and connects it to R1 table entry. */ static int place_r2(struct qcow2 *qcow2, struct qcow2_map_item *r1, - struct qcow2_map_item *r2, loff_t r2_pos, struct qio **qio) + struct qcow2_map_item *r2, loff_t r2_pos) { struct dm_target *ti = qcow2->tgt->ti; u64 page_id = r2_pos >> PAGE_SHIFT; int ret; - if (delay_if_writeback(qcow2, r1->md, r1->index_in_page, qio, true)) - return 0; - - ret = qcow2_punch_hole(qcow2->file, r2_pos, qcow2->clu_size); - if (ret) { - QC_ERR(ti, "punch hole: %d", ret); - return ret; - } - ret = qcow2_alloc_and_insert_md_page(qcow2, page_id, &r2->md); if (ret < 0) { QC_ERR(ti, "Can't alloc: ret=%d, page_id=%llu", ret, page_id); @@ -2115,7 +2106,7 @@ static int place_r2(struct qcow2 *qcow2, struct qcow2_map_item *r1, spin_unlock_irq(&qcow2->md_pages_lock); mark_cluster_used(qcow2, r2->md, r2->index_in_page); - return 1; + return 0; } static s32 find_unused_block_entry(struct qcow2 *qcow2, struct md_page *md, @@ -2137,11 +2128,13 @@ static s32 find_unused_block_entry(struct qcow2 *qcow2, struct md_page *md, static loff_t find_unused_cluster(struct qcow2 *qcow2, struct qio **qio, struct qcow2_map_item *r1, - struct qcow2_map_item *r2) + struct qcow2_map_item *r2, bool *needs_r2) { u32 clu_size = qcow2->clu_size; s32 index, ret; loff_t pos; + + *needs_r2 = false; again: pos = READ_ONCE(qcow2->free_cluster_search_pos); if (pos >= qcow2->reftable_max_file_size) @@ -2153,15 +2146,15 @@ static loff_t find_unused_cluster(struct qcow2 *qcow2, struct qio **qio, return ret; /* * Since pos is not covered by R2, the whole cluster - * must be unused. Use it to store R2 cluster. + * must be unused. The caller stores R2 cluster there. * Both indexes must be 0 here, because of we allocate * clusters from small to big. */ WARN_ON_ONCE(r2->index_in_page != 0 || r2->index != 0); - ret = place_r2(qcow2, r1, r2, pos, qio); - if (ret <= 0) - return ret; - goto again; + if (delay_if_writeback(qcow2, r1->md, r1->index_in_page, qio, true)) + return 0; + *needs_r2 = true; + return pos; } spin_lock_irq(&qcow2->md_pages_lock); @@ -2432,6 +2425,37 @@ static int relocate_refcount_table(struct qcow2 *qcow2, struct qio **qio) return -EIO; } +/* + * Zero the unused cluster at @pos and make the file size and + * file_preallocated_area_start cover it. + */ +static int prepare_unused_cluster(struct qcow2 *qcow2, loff_t pos) +{ + loff_t off, end = pos + qcow2->clu_size; + loff_t old_size = qcow2->file_size; + int ret; + + if (pos < qcow2->file_preallocated_area_start) { + /* Clu at @pos may contain dirty data */ + off = min_t(loff_t, old_size, end); + ret = qcow2_punch_hole(qcow2->file, pos, off - pos); + if (ret) { + QC_ERR(qcow2->tgt->ti, "punch hole: %d", ret); + return ret; + } + } + + if (end > old_size) { + ret = truncate_prealloc_safe(qcow2, end, __func__); + if (ret) + return ret; + } + + if (end > qcow2->file_preallocated_area_start) + qcow2->file_preallocated_area_start = end; + return 0; +} + /* * This function is aimed to be called only from main work. * In case of wish to use it from more places, it's needed @@ -2441,13 +2465,12 @@ static int relocate_refcount_table(struct qcow2 *qcow2, struct qio **qio) static loff_t allocate_cluster(struct qcow2 *qcow2, struct qio *qio, struct md_page **r2_md, u32 *r2_index_in_page) { - u32 clu_size = qcow2->clu_size; - struct file *file = qcow2->file; - loff_t pos, off, end, old_size; struct qcow2_map_item r1, r2; + bool needs_r2; + loff_t pos; int ret; again: - pos = find_unused_cluster(qcow2, &qio, &r1, &r2); + pos = find_unused_cluster(qcow2, &qio, &r1, &r2, &needs_r2); if (unlikely(pos == -ENOENT)) { ret = relocate_refcount_table(qcow2, &qio); if (ret <= 0) @@ -2457,28 +2480,17 @@ static loff_t allocate_cluster(struct qcow2 *qcow2, struct qio *qio, if (pos <= 0) return pos; - end = pos + clu_size; - old_size = qcow2->file_size; - - if (pos < qcow2->file_preallocated_area_start) { - /* Clu at @pos may contain dirty data */ - off = min_t(loff_t, old_size, end); - ret = qcow2_punch_hole(file, pos, off - pos); - if (ret) { - QC_ERR(qcow2->tgt->ti, "punch hole: %d", ret); - return ret; - } - } + ret = prepare_unused_cluster(qcow2, pos); + if (ret) + return ret; - if (end > old_size) { - ret = truncate_prealloc_safe(qcow2, end, __func__); + if (needs_r2) { + ret = place_r2(qcow2, &r1, &r2, pos); if (ret) return ret; + goto again; } - if (end > qcow2->file_preallocated_area_start) - qcow2->file_preallocated_area_start = end; - mark_cluster_used(qcow2, r2.md, r2.index_in_page); if (r2_md) *r2_md = r2.md; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel