From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id C83DE8017D for ; Wed, 28 Oct 2026 15:08:26 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SF7AQD021128; Wed, 28 Oct 2026 18:07:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SF7AQD021128 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="W504sdUv" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SF6rH0021063 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 28 Oct 2026 18:06:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SF6rH0021063 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48df730c035so702780f8f.0 for ; Wed, 28 Oct 2026 08:06:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBz8fG86fhzXcnPlg5k8Sd78X1pMdppmBFAZMUhjW2iZaaRL2gAHuCYno9NaPQsfwG6iq1ZYLg==@openvz.org X-Gm-Message-State: AFq9FYKC/N8djRBaTvH+aEYEXYPjV6caRpSxmuqRE3RzWWIui/yK9Yua O7WSrKV9jKVSjCwck1BMPi98X4+DvX+wenidCFx14pVvqfgPxApsHWIndK959p6wEmLjCm1G7CI n/GVZ7lwFZfNmVPy340fzOwwVSJATl7SP99Djpn75piAMqqLEYlXu9A== X-Gm-Gg: AYBFou2e5ESH19CrKvKv0szWJhv78Ga214mtmGE+u8QNN3L+XAPzekymEAuVNGyoz/V xyamQXRH02LHx6wD8ArLEBDXTT0yuNW8S7VMVAPD3O/RnXenJ3JB/JyBP7jWuedtloRPSU8bfyJ yQtqw3KZW2fb0E7JfhSxsAbsK877mXsd3PVVgeHxNfe6dt+3dSfcJkI7tklg4whahN1+6QqMPI7 TKT3+7FgWAc5WZSF7ELh36aLrjfg5Mz5vaT/jy31ycUbocJG5MkbrhWYD668ckGmt63C6aqwbcn NxeNUeQtmpdZMix6c0A9LlLtJm2FW5xPNsE1s6WSWYFQGwHLOetUZJdYlKfy+XiW3zDM61mTmJU LElgDmKI6HGEyDuUsqVl0i77uaZgh X-Received: by 2002:a5d:5d0a:0:b0:48e:25d7:d276 with SMTP id ffacd0b85a97d-48e5d58cc85mr7202277f8f.2.1793200012824; Wed, 28 Oct 2026 08:06:52 -0700 (PDT) X-Received: by 2002:a5d:5d0a:0:b0:48e:25d7:d276 with SMTP id ffacd0b85a97d-48e5d58cc85mr7202162f8f.2.1793200012043; Wed, 28 Oct 2026 08:06:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793200012; cv=none; d=google.com; s=arc-20260327; b=sDEuthMa9dF0bhT1PGM1o1d+g4nhTJaW+iaU7CxDKON5FdhDiqCO1xffHccqdj4xxv pn/Qce3X5YkU4dzJXEtPGhCHY1xG16ifse5lramOPnPInsQSbAK9HX9OdbiqMo+/n65f +cOrKVGgNSpRURpQ4DJBqVdjtpd+A/a9uWO9Rrrkr65YdWyOqJdQPdW5mUPxWGAvpN0s x2sz+Xbf6TV3F7sse2CmFkUj8YpFLdTE0uQ6azVVOOFt95nEP1poAdUl2c8vBTAsWWYU MiCz+y+X9SL3zIqAeREsfVepIiFaL1J/uBI1j1yPucKVweoJ1Jp1sSTU6LPKp+Mvt0qd plBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=JfzO3MH01PDkYoJWzgSMbcZEznHlwS7dKP7Te7/azAI=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=Doa4Ei5ilQM9vE1Bto6vmYeNLMjugzdPwXjlGY65GQlJJFtCACHKnfPBFio56Ymi69 /dp9v/rfFeRtpRYImqOURrm/q2cCOJlwp/1H6Of9az6Ri6k6MjLkJSxuYVP/NWUBjbZy HU+SBndkjS2BM0trBLd76iCtqgNp34/ewH1CyW/BkNy/IfiQQlvOnrXDqFEPS+2yVnkb F2NmaD3W6FP7YqOpvO9Y/6Oroc7FZC7j7731eUf+RWzr1rCUIasVa4y8kmc3/fun6qrH YGbozAOdqQwJjFzIZcKVnRdqWzmJylq3ZHFeGrCF5oJWfknc2bZ+7DvouhzZxaSC843m fbEA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=W504sdUv; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e3ecf6c2fsi26288553f8f.248.2026.10.28.08.06.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 08:06:52 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=W504sdUv; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=JfzO3MH01PDkYoJWzgSMbcZEznHlwS7dKP7Te7/azAI=; b=W504sdUvhQDA zqwsJY/AXVqSDU6r4NspKgTXAKOus3kpoKhVCLS2ERKpZEDl29itB3Ym4eFwj2/y+AuSYutcdJt7u dpSeNCN7vF4Hv09rmrGc5xjTfUSFwNr70p0qUTQMqcp7ltkl/ratRKGMFyX5pekG1fqHgs56eE0dJ nzaglDfNF3oKhtQnRUqGP68kOEvyUSw6t3ob/viquIFo1S5NhlSldEBLj/qnf/m10lYe/8ZmA0vTS nKhgayUrb6/2SDnwLMtkkiadCR5U/Jqjs3ffwYwrbV7EYMCkwpOnbGnMugwr4/Fz5xQzhGgd1H0Cd ehznPY0NHnJxCuAwaG2F+g==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xM5B3-00AtLl-1U; Wed, 28 Oct 2026 16:06:51 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Wed, 28 Oct 2026 16:06:40 +0100 Message-ID: <20261028150645.3222391-6-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v9 05/10] dm-qcow2: flush lower metadata before clearing its dirty bit on merge failure X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When qcow2_merge_common() fails, qcow2_merge_backward_work() clears the dirty bit of the lower image right away. qcow2_service_iter() waits only for the service qios, so delayed md writeback of the lower image may still be pending. With kernel_sets_dirty_bit, a crash at that point leaves the lower image marked clean on disk with L2 tables and refblocks that lag behind the merged data. A failed md writeback of the lower image is also missed: md_writeback_error is set only by qcow2_flush_deferred_activity(), so the next resume is not refused. Flush the deferred activity of the lower image before writing its header, as qcow2_merge_backward_complete() does. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-cmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-qcow2-cmd.c b/drivers/md/dm-qcow2-cmd.c index 2865940cff30..28c2166fd47a 100644 --- a/drivers/md/dm-qcow2-cmd.c +++ b/drivers/md/dm-qcow2-cmd.c @@ -338,6 +338,7 @@ void qcow2_merge_backward_work(struct work_struct *work) ret = qcow2_merge_common(tgt, qcow2); if (ret) { set_backward_merge_in_process(tgt, qcow2, false); + qcow2_flush_deferred_activity(tgt, lower); ret2 = qcow2_set_image_file_features(lower, false); if (ret2 < 0) QC_ERR(tgt->ti, "Can't unuse lower (%d)", ret2); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel