From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020096.outbound.protection.outlook.com [52.101.69.96]) by lore.virtuozzo.com (Postfix) with ESMTPS id 666938105E for ; Fri, 30 Oct 2026 14:45:43 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LcJz1EMa4Vb4fv3yyPPoZcFy8rOlI9XgZ0w1BFL2UoiSeqnvAc9YIWcH10xEpockTsq5OJUI72+NeJAnCEmS0xvaGtuc8O6k/cS6jTdTA4dS7gmY5ZD/u6Vx3c3+m5XWmF4ouuOT6zMJbnmvqKaKfqZ2H8sFCxKfb4FD7xlM6hlIrrhj8ARCPEGkLRheh3OvC5UR9Zrit4cfgkHBUKnzB3vVQilHaEnwrmXvVYs54Xhyn8raNLRW7QOEJ5ayfUxQNK5xfOcmYWVaG2f96/dp/Nw0teqk2Si0glaZSTn0oZqP5OIhEoU9Vpu0v1/riQ49OITwI0gmNIWhzHESKh6+Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=P2OzwHvroHeJQorOcsOt1hQSdtunfXdvfp1hMo4qkaUWON5lYUqZbrS1lzwk6QZr7+nMFAsQXCqHU90R8XJVSX2mob6/A7og7IUZ+rykE8G0n69OOsO6FaEcjZccMg6K5UsJcdfpgW3Uj01lxa7yuuCJJv3sHHbDRJUKdqqdpFnpQOjznr3JhqUXJjWb7k0uVhudngl0Weh2GqNUyqmJKJIEj1RUh1zWkUqA3cCHyJPTn++pNveiOBDlJ5INt0XgAS1VOLTwNnCbj6Di0DqVEB6kQ33ODG3EGoT+EU/DHw2e+3youRxpscVRtEdeZnldZ9+IdqTX4RNP5sP8ItFy2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=THP+adhJMsFBDqmBDQ+2q2SJJiJGnpeejxuLSjpeqbCQEauV+s1qSGq8vYo8yNk+beZKgKqkmliaAeNMwG8W/SdT1A3uC+/7UDc9CrjzgpvWkhR0K1276nxP5WfaciBR9YniWe5/t/itjddj7+rnu9KbyL07OwTK2zRm70vNoyeYLBNCrGjniADjtOBY4tY27U6L6NJ5F9h6fP4zifIuFURAKZFau4VsTsd/3sYWebV11UCjn6qzcW9fZzZdp2BokJdVZS6OsIx3MeUmBlF4NSUpmjT+I4ZZ6SGOsz+HkRT2lsqOgST3utFPkVCE12hcQeDJUO4XssxMljM4OsQE+g== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by VI6PPFE0A0B9321.eurprd08.prod.outlook.com (2603:10a6:808:1::596) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Fri, 30 Oct 2026 14:45:41 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0569.008; Fri, 30 Oct 2026 14:45:40 +0000 From: Andrey Drobyshev Date: Fri, 30 Oct 2026 16:45:32 +0200 Subject: [PATCH QEMU HCI-8.1 v6 01/34] VZ: migration/cpr-exec: fix Error leak in preserve_ram() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261030-vfio_v1-v6-1-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> In-Reply-To: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com X-Mailer: b4 0.16.0 X-ClientProxiedBy: VI1PR0502CA0031.eurprd05.prod.outlook.com (2603:10a6:803:1::44) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|VI6PPFE0A0B9321:EE_ X-MS-Office365-Filtering-Correlation-Id: 0241ed20-6d72-484c-1086-08df3694780f X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|376014|52116014|366016|5113699003|22082099003|261026121527099003|18002099003|38350700014|56012099006|261022105027099003|10067099003|261028144727099003|261021121427099003|261026140227099003; X-Microsoft-Antispam-Message-Info: a455CuW2nW2ZZLw4Xd8a4Zhz9NA7sjGjsuiR8g8H8P/VNbFmIg5a3qVfAt0w2sLznMsehuN1CKdBJ9nJXz541ax3xUQsw4IDU4iiuaeSGTPPRH1S7J3HqL8723AF8f8tBrxi7yQ9uHCmioj4jTZoXTrisDKXQov1HEpBkZqhSECHa3rY46zTYdTJhRczOKwmvL5KvL7+VoouBzp7k3PCsOkdqJ876ZqBtIn/XELZIHtxcTsx17q6guWMnvNSLrxDIU6b5vr9DSe9U8wpKaBNeFD1uV92LKoo20aQHHA6m2mFEG62YG5qcJ8NGQh4pXb0jWgpSW/9PdNG5ICGUXH45FSeRNg0fy5q1xQS2CS6n8gOrNOXqxW7jTXwlZK0wJ4rhYd6COogBfjpreiz/iWAn6+pC0bLI1uqtM6lcTaqmkWfRNU+WfpekAAlyYP/Z/McLwK+wpUbLBkxXan4RHd6H7fDoYyfnP94BfjIASeHsrcSKs3lxjoosF7sIQ6WAHi2xCrvUU/iLUkmupU+fmpBaqXePuemtwsJNlU7VGb3u6kqGrsp34WberQpWDE7ZxSJ3AteQsTAYSJ4KlUcooPLkoAXftmFxhPkLFkEHYiXVt3F+M08V4j3eYVPu64J14EiZM8AAYxRvYjd9SaYm8BszMeO0OUMWAvoFcNY2mJtTru6z0dPmrTxmwBw+yPv0OglLODIxVQTHTSPhpWxUA9rhpkriB7+xlUOy3UU5Y8icxM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(376014)(52116014)(366016)(5113699003)(22082099003)(261026121527099003)(18002099003)(38350700014)(56012099006)(261022105027099003)(10067099003)(261028144727099003)(261021121427099003)(261026140227099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEpjWmN5bFI5NXh1UThhOENJcUZvUlNmK0p6d0ZVcVAxYmNzMTJHQXpVM1RC?= =?utf-8?B?UmlrOXAyMS8xdFlLU2NzaWRCUVNXTUY2Y0NtcitRTnd4aEU2RnQwOHJtMGht?= =?utf-8?B?bDBFbk5va1QrVzJzbFJZWEYvZ0JRRDRJQnNobmhzTCtoL2V2RU92VjMyU21s?= =?utf-8?B?MGxqUzJFalcxZEU1c2V6dWtjTHpSRFQyUUpHYjdpd2JsOGVWVGQ1WkRFQjBQ?= =?utf-8?B?djZLeWhheU5YWms4VEZURWVLVGQwVmxrM0VDR1ljNGFUVHNGQnNiVWpNcWQw?= =?utf-8?B?MzJxby9EMXc5NEI4QzBoZ2RzYnlFNDJQVnVOSkxhT01FS0g0SC95SHJyMHFD?= =?utf-8?B?VHJrTFVVd3ArREZVWnVBUVd6Y1FnQUpJUEEzUkYwQXJxNFNFNWhNN09IQlM2?= =?utf-8?B?bnoycTFQcXVFT3dMVVJ1bUFVUE10eGdiNlhHN1cveGh5UjNHTTh4VzlOdWlm?= =?utf-8?B?WlI4OFRRaktNYjhzZGR3Z3Fhb0tlS1RHSkoyR0hzOGpkQUhMemJpOXFKbFRP?= =?utf-8?B?S1hiT09za2VXTWpCR0YxYlNpSE5ZaGdLVkQ0d1daRkZ5YUhMMytUaWIyQTV3?= =?utf-8?B?ZHlRbXhyVXorUXY3aHVoM0dPOG9OTnV4bmk4clhHZE91MHUrNXhZQXlLV2w4?= =?utf-8?B?VDFXVzcrS1UvVm9mRHRzRVB2Tk9FQkUva2FnSlRwRFVGMTVCN2l2N04vTllj?= =?utf-8?B?aGxJRURURlNsSm5TS0FPYWZPbmliWE54QlJGcHJKSkIrMHA0MGJFWnFWTWp6?= =?utf-8?B?dC9aZkt2Qm40S2t0SXBHMjZkbTlheVlKYUZPMFpNR0xrSGRndmFRWk8zbFdY?= =?utf-8?B?SDQ4L09ueHV5NGx1M3I4ZldZajRNT3ZFQ2NsWUF5YXZUWUIyR1pXZ2dDUWRi?= =?utf-8?B?SHVSc1dIcHJzbkJORTlSc09BRGVON0xFQk1WN2hlYTg1eTJnMVo4aVZUSW9L?= =?utf-8?B?Y0VVUG5lUjFwWHlDZjJJUWYrYU0rU0lENTFVZWtvSDQ2OXRkUkk5RElEVTMr?= =?utf-8?B?L0F3SEo4VHZ1KzhCMTNrOFJsQjVQVTZVN2x0NU5Ud1hEZFJiT2ltZmFwLzFq?= =?utf-8?B?R0ZQWU9zdkJ5dStIQ3BlL3RBR1h0L0haQkk0NzFjb3RBRWhsdVVHTk9YS3FG?= =?utf-8?B?dkw0RHFBam1QUVovdmpOTHFtaTdobUpJSk1PMFU4VFJBTnV1SU1sL2pKaGR4?= =?utf-8?B?bHJtdlVVMm1iUW9FUm1CMHZDRkRNRGszQnd4YmpOaVphV1dMZFU0Y0w5dkpk?= =?utf-8?B?aERQZS9xRyswNFJjcmJLaXRtc3dyQ2JNV1B3OGdDN1psN0VoejZZbVVtamw3?= =?utf-8?B?dDg5a0dhSC9mUTJGYmt4dW44UWFnaDlwZDVNV0VKdFllbmZLT1FkUEs0Z3ZN?= =?utf-8?B?dXJ1N2ZoK0RmODArNU56cmpheXkxN2xwMkYxWEgweEx6SjRPeTExYmlCVVJ3?= =?utf-8?B?TDB0OEMwWjRHbkNXKzdVNHlwb01oZkU1eWV1ZWZhWndpWkZSS28vTm0zVHl4?= =?utf-8?B?K0dHVWNtY0F6MzA4NzJOTjBqTzBxOGVLYXQyTGY5WXpzZDNvdG91Q1VuaXBE?= =?utf-8?B?bU5CV0pYdW1ZNzV1OFloUk1VM0E1UjAvaWR4OUJwRy81UXNHMDg2NSswWk9m?= =?utf-8?B?RDB3UWtHTlUzT2V1cmVOTE82U1BKNjVkZmdyMXZXdXQvRHJMR2RrZW1IZU10?= =?utf-8?B?a0VjSlJUZjFBcnNBVmxrMTBSOC82VVBGZjFncExOVGt5QTA0YzY2dEYveWti?= =?utf-8?B?WWNsdm41TzVRNERjWmVkRGlZNTJzbGU3UUhiSEEraStLdTNXZjNwMUpmK1pB?= =?utf-8?B?eVRTUkhuU3pKbDlmM2JJR2VRUkJLTS9GSDcwcjlTb2N0dXJUVDc2MWFrQ0NI?= =?utf-8?B?K2dKTkJ0d25sSmtjTitDamYrNTF0WHdhbEtoOS9DVU83S1VvTktHeGZLcnZp?= =?utf-8?B?YWxpK1RSTzc1cXdJRElkRlMvNWNNOFBBOHRXNmREdmNFcW00RmdwekF5ejJE?= =?utf-8?B?aXAwRGYydUkvYjNyekRpZkRMdUtCQVZ0MVJrb3ZIRHlCazgwOTlEaGlweVFs?= =?utf-8?B?bnM3a0k0b0dBZzROLzRBNlYrQVI1MlJZcXlBQ3hVNVpxaWoxWTI4ZFVabjFZ?= =?utf-8?B?VWU0dngvNUl6anh1Q3FaOHJxcm12b0ZGR2NBRHR4YmJ6d0d6U1psQnN1YzNZ?= =?utf-8?B?andYYTV0YTBlZ0VlNzhqTGNTdGlnekJ6RFR3RHZBM21qbGhPQzZqRGlFMmEx?= =?utf-8?B?c3dtWnNEcWdCaFllQ1NGZXdaMFB4c2IzR3VQSmJqK2ROdTIrM3Nadlp1RkEz?= =?utf-8?B?MnlSRDQ4bWJwR2YyYlpKV1d6NVhPNnFSbEVibCtTbjh5RkxGRG44ellNOXJN?= =?utf-8?Q?s/d6jINqGIYev/1E=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0241ed20-6d72-484c-1086-08df3694780f X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:45:40.8521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nfCCvmdQtn9SE7njgtzfhiy4yeaYBaEc8RUgG83XFo1ID07a0A/Bf9GaHY2z2tQpbZRKCjdaRFM8wJwwoctZPQygyPDHeccht5wJ6SqVHxo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI6PPFE0A0B9321 migrate_set_error() stores its own copy of the error, so free ours. Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with MADV_DOEXEC before execve") Signed-off-by: Andrey Drobyshev --- migration/cpr-exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/cpr-exec.c b/migration/cpr-exec.c index edace3f0bd8..9fd3515753a 100644 --- a/migration/cpr-exec.c +++ b/migration/cpr-exec.c @@ -148,6 +148,7 @@ static bool preserve_ram(cpr_ramblock_t ram, char *name) error_report_err(error_copy(err)); migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED); migrate_set_error(s, err); + error_free(err); return false; } -- 2.47.1