From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023120.outbound.protection.outlook.com [40.107.159.120]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7D8A58109A for ; Mon, 2 Nov 2026 10:36:26 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=agqH9gFlhD0vLTf7Bsd3S8wpN1374qXq2WDRcAbSOGe6a31EYxHxSCCd9UGjigd4JakOWGhuRnAGPkO2zfIdeBzTJK6i+7bcduDiU4Sk9n34sHIp/JyNRero9Wj4pSzNts02w82esYpcuXmnVIKUMhItyr40nD3U95SjYp2n112lYyFLFlcZj43glLSZ2d+4HDR4XmF+jdqzQj4ApgmPAWjfj/uFybyrwgdKMcL5m14UfcSIdMAkdpVbKCxCB+l7qUv+tnG2vLx86WgKeou1oAxreWfpugUTumdCIBqM7iT4s5Vn5JnSwbfFKK2SO4eMENE8IW+xhi+lHhTVj99NkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZxOeb4Ah+mB7BjkyMeUYqqn4cmd9TpiyWVFTAjD37Ls=; b=bUxHz/3ni1od3rllDyFoHaNDikZXn5GWxXpdyvrF8zgsGWdcdK10t7JHqaNb13F8jC2pV6pdauDo/OHguNtNvrwbc90jvc3MRWU2EtyyzR4M5+qfjRgRK4SLGPOSNtaCpZxMiSYUd+nhx2U8wdNoZUO+L/PUam2VD7F/twFYV2lFaBdLkKcdoAJV6ZPknzC0mZdve5pDUMBBJ3gCNd8gul1ARFGmafuprmTfCrEsEopj0aN0uZ2SjfLmRDDgooUIcgqT2D1RhhkWwBuzhZ0nrH0UORLsmXECuOeKgg7puihbbGS6Zx/CCmhsUbp0w7jl8kRlpfGtoXWjN0i0cjqzQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZxOeb4Ah+mB7BjkyMeUYqqn4cmd9TpiyWVFTAjD37Ls=; b=fZ2xLwdgtxFUyGw2Ri9GSfXUhn/HDIA3b7KfGgUD3fjt1SwC4xalEb+VfRUGlvhGQcrrUHNt/qGwfCj3SeTyFOOxNJRz/5AVyutG/Z4T5dLLDRKHWY90lIwNQjxHuYXfNMOD4gqM2fEGp4CiIHJaSosmuWShHE0qlQonXTicqrh/dZHP/pf+hJwA0eBHkD52BVUoqrJk8n9q7JdBQF+5xDKIDEvYCc/8ZLsr57vXzVbRIEFgBx7f08kCaerKmmjvzUwLETVFk8ZfgV8APM5tAp/JflKEud8pirE0ZC/FB1kz/FOVfO16f8dJcOsOcjjTuzLoN+nmnmnLZm2SbuMUXQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DB4PR08MB8199.eurprd08.prod.outlook.com (2603:10a6:10:381::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:36:24 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0569.011; Mon, 2 Nov 2026 10:36:24 +0000 From: Andrey Drobyshev Date: Mon, 02 Nov 2026 12:36:20 +0200 Subject: [PATCH QEMU HCI-8.1 v6 05/34] migration: close the CPR state if the outgoing channel fails to open Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261102-vfio_v1-v6-5-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> In-Reply-To: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> To: svt-core@virtuozzo.com Cc: Andrey Drobyshev X-Mailer: b4 0.16.0 X-ClientProxiedBy: VIVP296CA0048.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:353::18) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DB4PR08MB8199:EE_ X-MS-Office365-Filtering-Correlation-Id: eff0d44b-ecc6-4911-448e-08df38cd2418 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|52116014|376014|38350700014|56012099006|261009223027099003|261021121427099003|10067099003|18002099003|22082099003|5113699003; X-Microsoft-Antispam-Message-Info: e6PqF79ddRcbT0C+bXmdZjGmIFmq/nwRkP90q3sNiFyCNjc8ni+b6s2AsOdWqBze+UGQ5e0nU3oO2XKfW+TY9AoeYyulJWgfwmBrskH8RmP4Abqrf6lqDFwWwaLapsbi4bLxf0tfiuXIGlYjQbSCp+gq3Jkef2mYkD/2kbBS79E7IzbbuYJVxCyyuxY4PRr+bX3LBP/lYm6kx36xbo2oPf6v/YC7J8s+p8y9/iExGlRhtN6cGI63HwDZeGyFJAFNOtckaGLuTOdsd0MS21eMbsVnyHjeeXU0/AQTACnlWYhBkgCUd6OSFbXfTCidtoPiMYIuUEA9JQ8xOmxWg03IdkI+AcxxWouRsyL280fKRKRkL4R1UTbV0mDy6ikrAKyjg9d8TaWebuootxJiSQgpZOPiZUhZT0SZPanpL7YdL677QvZurCKnyw8qLFBQDlroq3TtyiAk4IbTiniGoar2vH89UAPpPaUm+qIJ/vClLJsWnDoOphFQX2kDdzxbHdRWXWOgxdZcwCkKVBrbKGtyKoeqXjqVE5V/G7Oxft+f8hI/cVlVtcqt6R9rVoVefEFKmqVwIChSwfU7+QIc8DNIo4gOw85khE1kgVT5TQNkqB4aIXw+5bzzz54qNMLG9k9KDvABOlfncAFSw2zDKk7x4uHLZpGlWrQR0jkXSawaHJF7k6hQUpd+dksBg3WjIz+JZr697Z6dicwW3ehjXUCoCZ/d4uy9iEp9Sb3sm0GL7U0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(52116014)(376014)(38350700014)(56012099006)(261009223027099003)(261021121427099003)(10067099003)(18002099003)(22082099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDRBcVEwN2liK01qWU9JQkJ6TitteDBTOURJTlF5SHBySUlCMERmV1VSNkxy?= =?utf-8?B?dWhOVFd2aDgvM3ZlWW8vS2VqSGxocEdDU0pUTHltcXd6MHlTblZSdFZPOEly?= =?utf-8?B?ZjRrdHhkUXcwVmlVbkRtWW5rRWZxRmlOR080bnM1YmJhUDkvYll0YVplUXpa?= =?utf-8?B?cXF1MmFvNTIvclFsbVVkcEVOYUFXWTk3NDJNQ1YrNlljSFNVTGg1bnhodGhD?= =?utf-8?B?akZTQnFJR292OU5ubFpvOGI3S0V1LzBFWWY1SVE2WVNjYk43VDJWa1hoK2w5?= =?utf-8?B?RWVDeVowSnhIYUlVY3h4SE84cFdwVExXOXY3bVhDdy9xSlhyN20xZ1BXQ2Zy?= =?utf-8?B?N3gyZXE3dDFPbGJQek53aGQ4aUttM1FIWUQ2ZGRkRlNFOWkrYjJGNTNZYW9i?= =?utf-8?B?NTlWUTFqUk9lS09GbGZaRWUySU94WU5SeC9PWUdpY1J1NklGTytndW1XZWNL?= =?utf-8?B?dnNpcXFCeGYxMW5sZDR3VEMrektqWlVkSEpvVkdzU0VnaGpQTjV3WTJjV2Zl?= =?utf-8?B?S0pBQjB2eHVTeCtzNkRmeU1PWEYzRElmamFKS0ZSU2VVVGN4dE5oZysxTTFJ?= =?utf-8?B?amwxcHBDM0Z4QVVKem9CcThGdVJDcnVIYUNoVklCNlN5bjdIVzlNYWgweTBL?= =?utf-8?B?dFpPYXYrM3IvU0I5SzJEVkVudy9nblZYTTZHTDU5QkJHc0R5d0NyWmVBQWlu?= =?utf-8?B?NHNRTkhBUkRQaGJKWTZmODNFb1lxL24yTlpEcTJKcTNzYUE2V3NMTmQrZjE3?= =?utf-8?B?cEFTdlpOeHhvVmp3bVl5MnJ3SlhDcjN3alpLOWVDYVlWQ0RkWi9Qb1Y0U1Vy?= =?utf-8?B?ZGsvNXREajQvcnd1NGlXaXRoajBoYkxLMnZyRFRybXVKMXQ5bG04MGxRQ1Ra?= =?utf-8?B?MzJFL2hZbnhNU1ZlWEZqV0lFQ3g4MFdlUHgrK2NJMmJwY0lac1RVTkZnNVho?= =?utf-8?B?ZW5WRFhHWnRsTnp6ZnpzV0Vab1JGMSszOURGczhldVpuaTF4SlNPTG9vRmho?= =?utf-8?B?eHNOYnlrZUh0STdjb3E5VTBZaVlFSWt3RkpDVzIwb2dkSytxT0p1RmFQYXZB?= =?utf-8?B?N1pIVGZRZm53M2FBQXp4dnJEc3lvNGVJSnk4UlRhTG96RVVwV2pCNWJkeHZ2?= =?utf-8?B?UGFsN2NlaUFyQ0pOaVNmaTVpS0tCM29FUENYQnA1UXJ4R25LUFEzVW5yWWJG?= =?utf-8?B?N1NFYnFodDFxakowTXZRUUtOWVdOUHpnRm03ZzV5ZE9Ba2hRRkFXaVltMmk4?= =?utf-8?B?a3lVVjRHdEFmZy9SRmNYbG1wbzErSDBMQkpZbFVOZkNSMm1PVVN1RVh2cXM5?= =?utf-8?B?eXoyMXhlc0Y2Y3VITFh5UnNuTjhTWWdUY3FPbUl6M0RoMjFLYjZPZ3BaQTRW?= =?utf-8?B?Qm91UEVZUE5IVU01K2xibWNPc0tUdW9mVFRrZDkyMGJLRElBUHV4Wkw3Nlhs?= =?utf-8?B?anEyWUpVc0ROZlEwT2xJYUFQV2IzSXZoOUkxS2hIYjRJRzlveko3YmR5MG5u?= =?utf-8?B?SUU2N2tyYUZxT2pzcytOa2RqL1A5SDc4ZERVR2ZBQjhvc1FwbGhJNHpMT0lu?= =?utf-8?B?UG5uRG1Md1JTVkQ2YmE4M21sQjVJYllCcjBSZkJKZEEzc3RBb0Y3c3pJaFpm?= =?utf-8?B?RVhNeHFLR0lnbTRhcDdTd0QrUTgxbjFqRW16WUgvcThFRmxtc2pDbG9idFl4?= =?utf-8?B?Z2syMmg2cXRQcmNXTnZ5aHRGVEZtTVN3eDFNNStxUkFWNTY0U29KVEZlT3Jt?= =?utf-8?B?akVGRFQ2RUZwZGNkNGpzWUZ3aktTc2hlRnBkYjRKYjJlVW4yL0hWZ1Q3NDAy?= =?utf-8?B?eEMycmpGK0N1NGp3bTlmK2ZRS243MzNSQndOV0RxL0xES1VTMFJhMTdpcHU3?= =?utf-8?B?YUJuSXVjSlRtZUxFVXBoaFZRd21yd1RGRENMKzk1VWNzK0N1Y0VoK2s0M1NC?= =?utf-8?B?THBjOXlORTJ6bmlPVXV2cmIycE8zSkEyVkRvcFRSUkxrN2dZbXBaWW1STVM4?= =?utf-8?B?R1UrZ3RPcmdtYmtUWk5vUFJ2bDZDdEVXR0NkL3p0V29nS1RCNnFqbzNRRVBn?= =?utf-8?B?UlJTM2NHaHRoZjVvRFRJUDJWc1htdm9kK2x2UHdDcFhOUjNQaE9jV1I2alNo?= =?utf-8?B?a0phVzZUaHZ1b0N5M2djWTNkOVN0Qlk4QTdRaTJyRDlLUDVSQW1rQUVyWkRp?= =?utf-8?B?OEoxWDB6a2xhQi9Nb3JmN0g5cW40Q25mRENMMDkzbTRTYmpMZ3lUbGp6Wktp?= =?utf-8?B?ek85N3NsUlRwY1hSYkhnMjkzK2xJdjlkVFRnaUR4bkZHZVZrbzkrRlF6NFZX?= =?utf-8?B?QmNQVjdySmdUYkJLNGpJdnRTc3grKzNoZUhvZHZEWG1nVnNTdFI3eHh3aU0z?= =?utf-8?Q?canmHwbo9VvzbOgk=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: eff0d44b-ecc6-4911-448e-08df38cd2418 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:36:23.5991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0/p2mZv4OYWcwtMrtkOoN1qPVxbiWIU420SmKsLKtvjMpV7SWDYYyFWRTOAHh2nV20bhTDZf9UK1f7tlRf/xEPGYwRQOb9AZyHScxXJ0zyw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8199 qmp_migrate() saves the CPR state before it opens the migration channel. If the channel is a file or an exec command and it can't be opened, qmp_migrate_finish() returns right away and migration_cleanup() never runs, so the CPR state file stays open. Close it there, next to the yank instance, which has the same problem. Fixes: 624e6e654e11 ("migration: cpr-transfer mode") Signed-off-by: Andrey Drobyshev --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration/migration.c index 39f70328fc7..132f0d403b7 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2412,6 +2412,7 @@ static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested, if (!resume_requested) { yank_unregister_instance(MIGRATION_YANK_INSTANCE); } + cpr_state_close(); migration_connect_set_error(s, local_err); error_propagate(errp, local_err); return; -- 2.47.1