From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6FAF480F25 for ; Mon, 2 Nov 2026 23:44:29 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhBvb029726; Tue, 3 Nov 2026 02:43:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhBvb029726 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="IERF1BzM" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhA5F029704 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 02:43:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhA5F029704 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48dfaaea30cso2474944f8f.0 for ; Mon, 02 Nov 2026 15:43:10 -0800 (PST) X-Gm-Message-State: APuU4Z+/z5PGgOgxlrXOtc5K2CcQnqajWzQzZUauDsro50ZGl5z3I6hG WXtFSzL6NCtJv10P2YedZSmzlQ+F2zG9IdFSXN4E28DxSIALUrH4FXjxg7QuIDbaqpzVgy25F74 zrlM1FDcduWKs+p9wmnvsSUd+j7MO5G5LWtHEMEXDGmxZpbpXtR4v0g== X-Gm-Gg: AYBFou2vo411JRSc/MCYebaUkIpByYapkZY54KX/45z3GKwwY5eAxS35l2LtzI4Sv6L bWeN8Xe2AsRsU5YuIWfBN340wEAqwgSrPBsOHnRls6a4LscalebkbJln8oISgsLROBXGW/Jsviz nRotfb1zpxp1sYLhcUCVsP4qUMidCNbBJ4m2YdmOvOJrUvHwiXyTQ3D9I4yfT5meO6Q854j30Cz ddBxwzvQwspamTkwKaHW/uSLZHS2UkXG7h2Q4NVVfNiGyEOlgXksOAUg4Rr/YU+cJFII0PGVENx X24+TVsij3VHEY6hZ3MazKut60M50wbds7fM/7z0cg3HSgm2oTFmKX82qjzxCLsdDBZkso9i68Q 9eHSUY1FA3SOAI7+Mp2DjNatNeCio X-Received: by 2002:a05:6000:310c:b0:48c:7387:6b88 with SMTP id ffacd0b85a97d-48e6e2fb059mr25898199f8f.37.1793662989976; Mon, 02 Nov 2026 15:43:09 -0800 (PST) X-Received: by 2002:a05:6000:310c:b0:48c:7387:6b88 with SMTP id ffacd0b85a97d-48e6e2fb059mr25898174f8f.37.1793662989519; Mon, 02 Nov 2026 15:43:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793662989; cv=none; d=google.com; s=arc-20260327; b=F7t0zKvxVOYhvL6OpTYM+/dBeHryUFhoBgoazRNlOY3gSOReWDxn3mph8LAkw6plQG pcxRgsMSzYrbtBhy6gT3pb1CZCZZ4dBk2pkt9gKLv8mJBaEvE4HccQNEv3VmEKEE0cx1 D0mc2Ye5+Kz2FX73w90Jji9FE7YgJHQySVe3QjivkfwnTDDGeNyry1G7Zd6xor3MW+F3 6G9aNI8/ucL1ed7eWoCmwvR56W8gUP9J6grbQCbXFFcZ3I0FV9J4/EILlCYnZnqpV+f3 vSJ5jo7q4TA9WKU/zyB3D6+OIuGo55VSb17gJtuqHM0G6PKohGH1LzjkKtmP62AinN7B Tn2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=FNqkzV8y8tFDvChAFjZ2VKWyTY7ULKOgLKrd8syNjIQ=; fh=9VH7xbtOhOOwoVYPb8YgTvr+erGWPni2iwCEEh8Zz6s=; b=Q/0OINoi1LteTP9xj663TbqW4tjs268kwXr3+C8rmSVkWnez9PbNls4NTvaUc31yxE btFq4RWevmYPL+J6mpF4HyjWm/mztUVqivmHWUlwB/6k2HBjj2+XHXrix5TeTIR1mVF+ KNg7pEuo2wDbbAYE8Ukcop+OmbZrtf3eZBEOPpPzeaC/xWT+8fxKHnF6IcFEjNS22BMk 2MJ+8/IJWgwqtrq3furBSrv7Mwg8DskCIn+n0VIO6iL+TW+7d9yGnO4Wi9n4xnk4Dhtc dYrB4Vp0Flw3M9NMiCe56QajRIfonGcSQM0ED0kM19nnIY3ZUEOMwKGiZzwZO+FssohT Ep4A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=IERF1BzM; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71ba4599si21358330f8f.60.2026.11.02.15.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 15:43:09 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=IERF1BzM; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=FNqkzV8y8tFDvChAFjZ2VKWyTY7ULKOgLKrd8syNjIQ=; b=IERF1BzM6lF9 nKOojNzav78jIz6Uo9K4A/cUq2JvP0kmQM4Bxwt9hZDHf8+cA3LvW0OLt07iq/BYiol65jOwG7NjD gse+mvhoLd7oPBEtTeijyKSwc5o3OzfzbkCSUyNVNi6bSSP06rDgXfkSCpuQNTA5Pob4qeUgIjkKX FX/FTPwyvRMZsmQdXZ00EHkVVEPIAh62ADPUDB9meKJk2ekwsIKM7gHu0ouL7IKltmgqcmzCvS5CQ IHLQICZ4rwKjyZKOlYMnvywOxEOFBwtgfUCGlvlb75vdjleAvIxapegS6SuJYNG30ouJ52nDvzL89 ubVmHmppjHe2sUmjIp9mwg==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO1cI-00BVZo-1v; Tue, 03 Nov 2026 00:43:00 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 02:38:47 +0300 Message-ID: <20261102233849.613155-4-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> References: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 3/5] drivers/md/push_backup: do not re-arm deadline timer in push_backup_write() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org pb_timer_func() checks pb->deadline_jiffies every time it fires, so we actually don't need to re-arm the timer after setting the filed. This is also the only place that arms the timer outside the window push_backup_stop() waits for with synchronize_rcu(). Today it is harmless because write and stop are serialized by pb->ctl_rwsem, but it would re-arm the timer behind timer_delete_sync_try() once the write path is reachable without the rwsem (next patches). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- drivers/md/dm-push-backup.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 1ae4ccc208ffa..8ce84a1a696e5 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -467,8 +467,8 @@ static int push_backup_write(struct push_backup *pb, unsigned int clu, unsigned int nr) { u64 i, key, nr_clus = pb->nr_clus; - bool finished, has_more = false; LIST_HEAD(pbio_list); + bool finished; struct pb_bio *pbio; if (!pb) @@ -519,8 +519,7 @@ static int push_backup_write(struct push_backup *pb, } } - has_more = (pb->nr_delayed != 0); - if (has_more) + if (pb->nr_delayed) pb->deadline_jiffies = get_jiffies_64() + pb->timeout_in_jiffies; else pb->deadline_jiffies = S64_MAX; @@ -529,11 +528,8 @@ static int push_backup_write(struct push_backup *pb, if (finished) wake_up_interruptible(&pb->waitq); - if (!list_empty(&pbio_list)) { + if (!list_empty(&pbio_list)) resubmit_pbios(pb, &pbio_list); - if (has_more) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); - } return 0; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel