From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 434E580E7E for ; Mon, 2 Nov 2026 23:44:40 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhSna029761; Tue, 3 Nov 2026 02:43:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhSna029761 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="MhAzY8Z1" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhA1e029712 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 02:43:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhA1e029712 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48dff112136so2314784f8f.1 for ; Mon, 02 Nov 2026 15:43:10 -0800 (PST) X-Gm-Message-State: APuU4Z+8VCy7fw3NpVa4YA88H0PMUudNTBD28uZSJAtL9adbsgQeF50h RGFeAb05l+FgqqxgIdZ7jP2DVmqLufVPA/5ukAR8rJAMHMF0YNZk0nvI1YO2Fmc7BJoMT8+qbu/ e2smZI94QH73FYs7SlvXewuvoa2N2Zx4HJUWs7CmPhQB9852USw4T6w== X-Gm-Gg: AYBFou15HBkUU6lPl+TsDEIHQkCmk4ml2XtFk1h7x0G7bmyN3Wty9zTMpWh3Zt9s/vQ Vv541AyFnJSOnZfoPGJQgSLEckqi6BQnlN42pqbtFVue+ZERPTtnOlPwWb1GG2jXpQaWQpB9Kgz eoOvUnJCji5NriYKhcyEQ+HfA4459c8GjtIKo7q7lTgxZhDVMUxXDE0kyIaiWr1MXCx8OAgDMUd DHR3xRYVlN1vJgjU3U9WMYyKePaHrlGUwBU830jpidIPyXmQbsQJCTGPInr2ONcY9gpPMK2d8FX 0aZnrsU7Md/ArhPw8moEVsQPLztBmKlwK+CNeDAvmihvKNyDzaWi/+YsirnJ1eHmU4q7J+8QmdF /EPlPkfWbEhA4y88/7BZ8uSkUegq0XQ== X-Received: by 2002:a05:6000:4711:b0:48e:2371:3835 with SMTP id ffacd0b85a97d-48e6e309f7amr26356439f8f.51.1793662990071; Mon, 02 Nov 2026 15:43:10 -0800 (PST) X-Received: by 2002:a05:6000:4711:b0:48e:2371:3835 with SMTP id ffacd0b85a97d-48e6e309f7amr26356409f8f.51.1793662989530; Mon, 02 Nov 2026 15:43:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793662989; cv=none; d=google.com; s=arc-20260327; b=IxxXGjOlxd8/R9e0SpXEDJcttv69t7PiVKBuYiZSBiJKIxvRtlvjxht/D+beSblhz7 slB0/4B3v8k9PS1M8z0G+LZaNfwtTmMbAZHEQVlGFCwkFcUxi/bkAGMTXVv1uR0HQCnq 2l1hrzchS634YkIHu9X1Po7uOuuDnhUpxkqoI5Jj0l+z9xUpU0tu9iOkH90qOq7fXhZZ 3sP1wY+hb2QmVM/0MfeLCqRm0Abo4gR0J918W8QKHsp9N1PvvPkhYvDSs7I0hp9+HEau eyO10yDy3Pd1ofzThSwjGLt0i6yB6cBptjcLaJ5ml9uRS8S/t76Y6F2Q7+0uEr5nkptw 7dpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=9APnl34bUueLxO6s1Pn+FXyU0UoMyUeRhDMEuBk61uI=; fh=9VH7xbtOhOOwoVYPb8YgTvr+erGWPni2iwCEEh8Zz6s=; b=M/d9rwO+RjQiW6jnh5kqw5BR3/8UR4kWdHgfGBRkz/MXnJWbIhL+5WO2ev2qYeC4KR VqyZ0MJVKKpQdArrxShDWk/ykWlAnHF108u4YAOf85J8fyM75f1v0xlKQS21NcghlYzP fr36nqpZ3kd4SygtbMneIoMLbEtn/2wmjGWQ/F+bHLCYfdG+UHdrDYXYHyLwybOZJf9G tUvHmeZb7vPCmAdUsbovsZE656oHQlPYU/3ppXf4x9mBKjjoA+j3BmfES0pn+2vK9YTj GhqiTRw6u9AdNIBrNuocsAarFW6yU18+bCf3irhs4Va9ioGFUv+VXyLsAQPq11mPt8F/ GfqA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MhAzY8Z1; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bb7f15si27480213f8f.229.2026.11.02.15.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 15:43:09 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MhAzY8Z1; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=9APnl34bUueLxO6s1Pn+FXyU0UoMyUeRhDMEuBk61uI=; b=MhAzY8Z1e92Y 6QAUV0lK5N1pL3/0YvyCq0+XjPk4WXj9/qE0zT4mh37TwfW7ox4AT7tAU+gi485AmwNJlIQLYw2dj hgqp4RR2EENt9n2RhINaPU6cuGVXigEms5uut4hMszQvEFwjAWonWRQsTMVF4Obz5NVJS2o5eGFrQ kFwN7W67AigDRKAjv7lc0TSVm4bQUehxZoL+342IzFXSlUrINx7fY1p1QrAdCl6J+AzqngKKMmnDr mQySW/Pv7CZcqKZc3iQojHDBEai9Fay0LtXj96Biwm+WMHBUnHS+yQajs+hkTwDhzw3nlbhB/olNz ZRamb41BfkNEANXbIRGOAQ==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO1cI-00BVZo-2I; Tue, 03 Nov 2026 00:43:00 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 02:38:49 +0300 Message-ID: <20261102233849.613155-6-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> References: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 5/5] dm/push_backup: add event file descriptor interface X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org The backup tool currently waits for the next cluster range to back up by sleeping inside the "push_backup_read" target message. target_message() calls into the target under dm_get_live_table(), i.e. with md->io_barrier SRCU read-locked, so for the whole time the tool waits for a write to be intercepted anything doing synchronize_srcu(&md->io_barrier) on this device is stuck: dm suspend, table reload/remove and in particular dm_internal_suspend_fast() called by "@stats_create". An unrelated dm-stats consumer therefore hangs together with everything that later queues behind md->suspend_lock. Add a file descriptor based interface that does not involve dm messages on the data path: push_backup_get_fd - returns an anon inode fd in the message result read(fd, &range, 16) - next struct push_backup_range to back up; 0 when the backup is finished, -ESTALE when not running, -ENODEV after the target is destroyed write(fd, &range, 16) - acknowledge the range, same as push_backup_write This way we will avoid aforementioned problems. We can't access/uninstall fd across all processes that have it, so add kref on the push_backup struct and tie it to number of fds. Free only when everything is gone. The legacy messages keep working unchanged for compatibility but we will clean it up later. https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- drivers/md/dm-push-backup.c | 197 ++++++++++++++++++++++++---- include/uapi/linux/dm-push-backup.h | 36 +++++ 2 files changed, 205 insertions(+), 28 deletions(-) create mode 100644 include/uapi/linux/dm-push-backup.h diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index b1861204f6e3e..1ea71cb82b9ed 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -15,6 +15,10 @@ #include #include #include +#include +#include +#include +#include #define DM_MSG_PREFIX "push-backup" @@ -46,6 +50,9 @@ struct push_backup { u64 clu_size; u64 nr_clus; + struct kref ref; + bool dead; + bool alive; void *map; u64 map_bits; @@ -69,6 +76,16 @@ struct push_backup { struct rw_semaphore ctl_rwsem; }; +static void pb_release(struct kref *ref) +{ + kfree(container_of(ref, struct push_backup, ref)); +} + +static void pb_put(struct push_backup *pb) +{ + kref_put(&pb->ref, pb_release); +} + static u64 pbio_first_required_for_backup_clu(struct push_backup *pb, struct pb_bio *pbio) { u64 clu; @@ -415,35 +432,41 @@ static int push_backup_stop(struct push_backup *pb, return 0; } -static int push_backup_read(struct push_backup *pb, - char *result, unsigned int maxlen) +static bool pb_has_event(struct push_backup *pb) +{ + return READ_ONCE(pb->dead) || !READ_ONCE(pb->map) || + !READ_ONCE(pb->alive) || !READ_ONCE(pb->map_bits) || + !list_empty_careful(&pb->pending); +} + +/* + * Returns: + * 1 - next range to back up is stored in @clu/@nr + * 0 - backup is finished (nothing left to back up) + * -EAGAIN - nothing pending at the moment + * -ESTALE - backup is not running (not started, stopped or expired) + * -ENODEV - target was destroyed + */ +static int pb_next_range(struct push_backup *pb, u64 *clu, u64 *nr) { - unsigned int left, right, sz = 0; struct pb_bio *pbio; + u64 left, right; int ret; - if (!pb) - return -EBADF; - if (!pb->map) - return -ESTALE; -again: - if (wait_event_interruptible(pb->waitq, - !list_empty_careful(&pb->pending) || - !pb->alive || !pb->map_bits)) - return -EINTR; - spin_lock_irq(&pb->lock); + ret = -ENODEV; + if (pb->dead) + goto unlock; ret = -ESTALE; - if (!pb->alive) + if (!pb->map || !pb->alive) goto unlock; ret = 0; if (!pb->map_bits) goto unlock; + ret = -EAGAIN; pbio = list_first_entry_or_null(&pb->pending, typeof(*pbio), list); - if (unlikely(!pbio)) { - spin_unlock_irq(&pb->lock); - goto again; - } + if (!pbio) + goto unlock; ret = -EBADMSG; left = pbio_first_required_for_backup_clu(pb, pbio); @@ -456,15 +479,47 @@ static int push_backup_read(struct push_backup *pb, else right = pb->nr_clus - 1; - DMEMIT("%u:%u", left, right - left + 1); + *clu = left; + *nr = right - left + 1; ret = 1; unlock: spin_unlock_irq(&pb->lock); return ret; } -static int push_backup_write(struct push_backup *pb, - unsigned int clu, unsigned int nr) +static int pb_wait_range(struct push_backup *pb, bool nonblock, + u64 *clu, u64 *nr) +{ + int ret; + + while (1) { + ret = pb_next_range(pb, clu, nr); + if (ret != -EAGAIN || nonblock) + return ret; + if (wait_event_interruptible(pb->waitq, pb_has_event(pb))) + return -ERESTARTSYS; + } +} + +static int push_backup_read(struct push_backup *pb, + char *result, unsigned int maxlen) +{ + unsigned int sz = 0; + u64 clu, nr; + int ret; + + if (!pb) + return -EBADF; + + ret = pb_wait_range(pb, false, &clu, &nr); + if (ret == -ERESTARTSYS) + ret = -EINTR; + if (ret == 1) + DMEMIT("%llu:%llu", clu, nr); + return ret; +} + +static int push_backup_write(struct push_backup *pb, u64 clu, u64 nr) { u64 i, key, nr_clus = pb->nr_clus; LIST_HEAD(pbio_list); @@ -475,11 +530,13 @@ static int push_backup_write(struct push_backup *pb, return -EBADF; if (clu >= nr_clus || nr > nr_clus - clu) return -E2BIG; - if (!pb->map) - return -ESTALE; spin_lock_irq(&pb->lock); - if (!pb->alive) { + if (pb->dead) { + spin_unlock_irq(&pb->lock); + return -ENODEV; + } + if (!pb->map || !pb->alive) { spin_unlock_irq(&pb->lock); return -ESTALE; } @@ -534,6 +591,73 @@ static int push_backup_write(struct push_backup *pb, return 0; } +static ssize_t pb_fd_read(struct file *file, char __user *buf, + size_t count, loff_t *ppos) +{ + struct push_backup *pb = file->private_data; + struct push_backup_range range; + int ret; + + if (count < sizeof(range)) + return -EINVAL; + + ret = pb_wait_range(pb, file->f_flags & O_NONBLOCK, + &range.clu, &range.nr); + if (ret <= 0) + return ret; + + if (copy_to_user(buf, &range, sizeof(range))) + return -EFAULT; + return sizeof(range); +} + +static ssize_t pb_fd_write(struct file *file, const char __user *buf, + size_t count, loff_t *ppos) +{ + struct push_backup *pb = file->private_data; + struct push_backup_range range; + int ret; + + if (count != sizeof(range)) + return -EINVAL; + if (copy_from_user(&range, buf, sizeof(range))) + return -EFAULT; + + ret = push_backup_write(pb, range.clu, range.nr); + return ret ? : sizeof(range); +} + +static int pb_fd_release(struct inode *inode, struct file *file) +{ + pb_put(file->private_data); + return 0; +} + +static const struct file_operations pb_fops = { + .owner = THIS_MODULE, + .read = pb_fd_read, + .write = pb_fd_write, + .release = pb_fd_release, +}; + +static int push_backup_get_fd(struct push_backup *pb, + char *result, unsigned int maxlen) +{ + unsigned int sz = 0; + int fd; + + kref_get(&pb->ref); + fd = anon_inode_getfd("[push_backup]", &pb_fops, pb, + O_RDWR | O_CLOEXEC); + if (fd < 0) { + pb_put(pb); + return fd; + } + + DMEMIT("%d", fd); + return 1; +} + static int push_backup_statistics(struct push_backup *pb, char *result, unsigned int maxlen) { @@ -612,6 +736,10 @@ static int pb_message(struct dm_target *ti, unsigned int argc, char **argv, ret = push_backup_write(pb, val, val2); } else if (!strcmp(argv[0], "push_backup_statistics")) { ret = push_backup_statistics(pb, result, maxlen); + } else if (!strcmp(argv[0], "push_backup_get_fd")) { + if (argc != 1) + goto unlock; + ret = push_backup_get_fd(pb, result, maxlen); } else { ret = -ENOTSUPP; } @@ -626,18 +754,30 @@ static int pb_message(struct dm_target *ti, unsigned int argc, char **argv, } static void pb_destroy(struct push_backup *pb) { + void *map, *pending_map; + WARN_ON_ONCE(pb->nr_delayed); + spin_lock_irq(&pb->lock); + pb->dead = true; + map = pb->map; /* Is's not zero if stop was not called */ + pb->map = NULL; + pending_map = pb->pending_map; + pb->pending_map = NULL; + spin_unlock_irq(&pb->lock); + + wake_up_interruptible(&pb->waitq); /* pb->dead = true */ + WARN_ON_ONCE(timer_delete_sync_try(&pb->deadline_timer) < 0); if (pb->wq) destroy_workqueue(pb->wq); - kvfree(pb->map); /* Is's not zero if stop was not called */ - kvfree(pb->pending_map); + kvfree(map); + kvfree(pending_map); kvfree(pb->pending_htable); mempool_destroy(pb->pbio_pool); if (pb->origin_dev) dm_put_device(pb->ti, pb->origin_dev); - kfree(pb); + pb_put(pb); } /* @@ -656,6 +796,7 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb = kzalloc(sizeof(*pb), GFP_KERNEL); if (!pb) goto err; + kref_init(&pb->ref); spin_lock_init(&pb->lock); init_rwsem(&pb->ctl_rwsem); bio_list_init(&pb->deferred_bios); @@ -764,7 +905,7 @@ static loff_t pb_llseek_hole(struct dm_target *ti, loff_t offset, static struct target_type pb_target = { .name = "push_backup", - .version = {1, 0, 0}, + .version = {1, 1, 0}, .features = DM_TARGET_SINGLETON, .module = THIS_MODULE, .ctr = pb_ctr, diff --git a/include/uapi/linux/dm-push-backup.h b/include/uapi/linux/dm-push-backup.h new file mode 100644 index 0000000000000..3a56f851a2d56 --- /dev/null +++ b/include/uapi/linux/dm-push-backup.h @@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ +/* + * Copyright (c) 2026 Virtuozzo International GmbH. All rights reserved. + */ + +/* + * Userspace interface of the dm-push-backup target's event file descriptor. + * + * The fd is obtained with the "push_backup_get_fd" target message; the fd + * number is returned in the message result buffer. + * + * read(fd, &range, sizeof(range)): + * sizeof(range) - @range holds the next cluster range that must be backed + * up before the writes postponed on it may proceed. + * Reading does not consume anything: the same (or a wider) + * range is returned until it is acknowledged via write(). + * 0 - backup has finished, nothing is left to back up. + * -EAGAIN - O_NONBLOCK is set and no writes are pending. + * -ESTALE - backup is not running (not started, stopped or expired). + * -ENODEV - the target has been destroyed. + * + * write(fd, &range, sizeof(range)): + * acknowledge that @range has been backed up; equivalent to the + * "push_backup_write clu:nr" message. + */ +#ifndef _UAPI_LINUX_DM_PUSH_BACKUP_H +#define _UAPI_LINUX_DM_PUSH_BACKUP_H + +#include + +struct push_backup_range { + __u64 clu; /* first cluster */ + __u64 nr; /* number of clusters */ +}; + +#endif /* _UAPI_LINUX_DM_PUSH_BACKUP_H */ -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel