From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8FD148017D for ; Tue, 3 Nov 2026 00:38:26 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A30bF6D030716; Tue, 3 Nov 2026 03:37:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A30bF6D030716 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="sXfS914Y" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A30b7bq030683 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 03:37:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A30b7bq030683 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48df730c035so2464626f8f.0 for ; Mon, 02 Nov 2026 16:37:07 -0800 (PST) X-Gm-Message-State: APuU4Z++UtZ66rbTZod9EOi+mKbcbTJHS3SiWdTxUc3GQxTsEEznJIe5 w8n1S1HyaDneCVHAH0mcVi9hltqK8+8WsYpKlsHSIcEzaQIk4GdXeCMzQJbwseWTNHq5X7UG1j7 oO5okt6C5vSUvk078gyr194a1WwCv027SZNkc8ucbFkIjT3VofO8Ywg== X-Gm-Gg: AYBFou08Z2mR4JromlywEH7209pVNFY0/AEGO+SxksX6TX9Eo/9kUgwEehr5YMsBbaF GAqYPBn0qYewQmlvSGfdDmWVMkQp6TQau8N/lw1gk5fcqkbh5+geqx598EpogDk0BScBWUzSUSP 5apk2WL8T9/i+OKxL95C8uDAWZBqL9OfjZlvlj4h6vcWzPXW2X6ml/oYmNhmPISH6xG9oxGzU6Z tP6EbUpng+zjinpDOGHLVrjh02gXYIOkXSgilc7CW3RkWotAdPnMWb11+7MQ1gQuSVY9yVGS/DJ B8jlTf64Uh/A8YvXgAR+9GFgsdqy8iBv9qBxhCwfu/6ygK1hmKz+FY/9OoMrKGEH7ex+9zQBHgX 8xFfk8hKCRh174t6q/MuoVJ1APqPsjw== X-Received: by 2002:a05:6000:1aca:b0:48c:7037:aee9 with SMTP id ffacd0b85a97d-48e6e4fcfacmr25490274f8f.50.1793666227090; Mon, 02 Nov 2026 16:37:07 -0800 (PST) X-Received: by 2002:a05:6000:1aca:b0:48c:7037:aee9 with SMTP id ffacd0b85a97d-48e6e4fcfacmr25490252f8f.50.1793666226550; Mon, 02 Nov 2026 16:37:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793666226; cv=none; d=google.com; s=arc-20260327; b=aaArwaT+CyAZS7jUDkYidZs0zkID4h5QkSp1aFTT7WAbAAh3vc9D6O8CGs8Wf4ribC Oua/OakmdHkRxajAImlcVBweMc7mOOoDn9DXbi8DxdaFiONGIomefxrumJpeZviDGrUn 1slLx+4P05QBFA6fpwiz46UkZa+E4iKxUThiiHLidsHUOsWAoq0gk2xJYDRBpP+FbYNT 02a9zA4C1WOcNcsSKY/aWP9baXUZvf0ZLlWk2ihcbbtCdpZeAVldVbwHIH6z+AliZCaZ PwGyT7GzgMydcoG0VXrg9ZK02Ns9TUdRWLe0jDnxQJpAPR0ODRhLzF8o5qfV+pAvjbQV yrgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=wQWN/gFgYCCW2V9ht//OPyrxZX5twLQZvYC7dNfh7vc=; fh=9VH7xbtOhOOwoVYPb8YgTvr+erGWPni2iwCEEh8Zz6s=; b=g3bblpA1AadnLUc9NjlyydFnJsEH+ywsvfB6PpJ/vGYqPF8YND5mXuy5FyBWB88cnX 0EA1LgvnUe39oaYCiyJafGzL0k2AHQTpDVlx9q6aOXSDY2CIHdLzKflJEn3Cgg+CK1tT f97yvCNul80GST5VHLgZLuC2UVmQl3xFiQOKAGWyq7kZb52bLkrUwl4VxXlY40Sjfwqw Z1odWQ7O/pKsPCjeX1qVtCJ+HYWbaWDrbs6mp8JcLPb6oS/hOVKWa19eCRXatAhbHJiz HDkI89iubufoj+5OmPzEpeQ79F27Wa9V4by88xLh2sXqx+qjfZAqDL0o68jfnFHgAAGy mVHQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sXfS914Y; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71baf937si21544842f8f.168.2026.11.02.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 16:37:06 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sXfS914Y; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=wQWN/gFgYCCW2V9ht//OPyrxZX5twLQZvYC7dNfh7vc=; b=sXfS914YRtsi xij62glWWfJwP/CWURf15QsJAUpmnGx0NAKOZ6lynQIkX+PPblhH5LvZxA1AWNk9MAMvKFL5wD4Ir fNJES71q2B0iIkHauEZ2qieOPLL4Py2ao17xBJD/HqPXfv9QyoWg/wPbFs5NPO4CJqKtZfwvJIW7f AEzDn1pD/QUgeMLBcgTVzqvUMUDmEkdvvxS79LWZ9TBRmuuV4M/YoCBCf3O4zHiztsQhge0lIIg+Y 5RdU2G9Z/Jr009L0PKbvwRX3V5AeOp4n77CK7VUmm0ErnkouQ4EdaigE9yWocrra6kIqSG4YvpZGs A9+36da3MhUGbUU+YP7UKQ==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO2SV-00D56q-1G; Tue, 03 Nov 2026 01:36:56 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 03:32:41 +0300 Message-ID: <20261103003246.712239-2-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103003246.712239-1-andrey.zhadchenko@virtuozzo.com> References: <20261103003246.712239-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/6] drivers/md/push_backup: correct initialization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Allocate pool and htable after lock, waitqueue and deadline timer init so we are sure that pb_destroy() can be called from anywhere. Otherwise we risk timer_delete_sync_try on zeroed timer struct (currently luckily fine). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- v2: no changes drivers/md/dm-push-backup.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 885ea7b31cf67..9a6252f2b21e2 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -658,24 +658,22 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb = kzalloc(sizeof(*pb), GFP_KERNEL); if (!pb) goto err; - - pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, - pbio_cache); - pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, - sizeof(struct hlist_head), - GFP_KERNEL); - if (!pb->pbio_pool || !pb->pending_htable) - goto err; - spin_lock_init(&pb->lock); init_rwsem(&pb->ctl_rwsem); bio_list_init(&pb->deferred_bios); INIT_LIST_HEAD(&pb->pending); timer_setup(&pb->deadline_timer, pb_timer_func, 0); - init_waitqueue_head(&pb->waitq); INIT_WORK(&pb->worker, do_pb_work); + pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, + pbio_cache); + pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, + sizeof(struct hlist_head), + GFP_KERNEL); + if (!pb->pbio_pool || !pb->pending_htable) + goto err; + ti->private = pb; pb->ti = ti; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel