From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id EC2938045D for ; Tue, 3 Nov 2026 08:38:07 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A38ar2I002587; Tue, 3 Nov 2026 11:36:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A38ar2I002587 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793695017; bh=ru/EgvjLV/qnN9vGkZD2KncqZbejwQNLV2B48dQpQlk=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=WNl7QY6BFVzofMljg8Pbdql9kkHegksKgN2rVTe6VvuRS297t/a2NM1AwPebMu48K WyQrxkHutoedhBTznkU2UKapcANfI1GRFvV/iRacH5Fc70EljKXkLAXjD6sp+Q+gS8 Vh6MDOwnHUCOfTmwzVOyMslD5eggn24goXNmx/bnR1+Pa8+44wvDYljehmhWonm5Q5 oppFceuJEKtLG0yWoQsWWZxv356qT6AyCPU/w//AIZYPGGtYLsLwquqPw70Pk0c7Mu n58pkpMYDKoHCCgkPZPjftrKOw1GUBR7YwMtLOMe5B/AyAPYBWHw50p1vt2Aaq9jD1 Fpi6uMOzXq/jQ== Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A38amYX002564 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 11:36:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A38amYX002564 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="XwR/xuE1" Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e0af48c18so2908953f8f.2 for ; Tue, 03 Nov 2026 00:36:48 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBz5F0+DgKKPZ/YcZ6PiHEAkPw0jO4fveSei/WgPeuNhI+3Zs+h/xXezNnCt7Fg1L8/EHSUmbw==@openvz.org X-Gm-Message-State: APuU4Z8sHlQZCKG3VqvHO5EG9OsEzRxQNR6N87kZnpdcCpBzVdveFH5/ zU6mBhz4iTyom7DvFA95CqVAnoOqk547lGLzYI3wSdi2msgvt+V9QO/Ia8KoLeb3+Po6eNN7LeF 5fwIwvod9puGhJJdplHWPTW9v4DZ6gV4rQ1KIWsgkWaUT6ahmun6oSQ== X-Gm-Gg: AYBFou2BnOarcISd53EG6fNjW/fWhdFrexQofBFOIsuQSSiUiLm69Z2brOaJIL6XM7c 2UHvUh24yLBABhp/8icCdIm5cQ8OsUHeM8CwEYYE/HSozePvYDjkAWEFwZCSHnCtoHBRqNNKldx QKKKeOqqhI7Vy6q8/Pr+/h3mzEf+P3Owby3MsEXpwj4I4ZAJkrom9JRojgjceN4LC0h6T47P/Vi s9SnZYxBnc8DQlsOr7xBrrl/afvYPxynIkKVtRdqj/uBS0RitXYw7djqp7F7ShZLabW0rv1ULOu ROczr+HnDg== X-Received: by 2002:a5d:588e:0:b0:48e:bf0:35c with SMTP id ffacd0b85a97d-48e6e4f543cmr25875100f8f.13.1793695007865; Tue, 03 Nov 2026 00:36:47 -0800 (PST) X-Received: by 2002:a5d:588e:0:b0:48e:bf0:35c with SMTP id ffacd0b85a97d-48e6e4f543cmr25875064f8f.13.1793695007461; Tue, 03 Nov 2026 00:36:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793695007; cv=none; d=google.com; s=arc-20260327; b=j4pCNKnz0XUiMG7zbl+iUCo2Poh9PwlvI4Cc/MpoJOU3yX2rMTilS9xQGDdTdCcvsZ I1u0cD44e1crMkoWiOjdk4I0xJqQ/RVfK/dAzRNPnoJs3bDY18E0KYf7LKJ/u2DGpP9K qL5WXfsvW6WYxg/hzPWO5G35GlnIKY1UZbrq6Nglg4X5U4nDuQbADYW60E/H5B3/2CMw wJV1TV7dVyT0S5TACN4BHvdbrGwWLTcl06xtpRuD4INuyUrJI5f7dLNuhUr+YndxJRmP GNROjI8IwSYZnqu+g664VIm8lmbbHUYRkJat82rbGq6tORh1Xl5mGsfRTXgLHObxQkXE GCqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2hGvOLrw4u7HY1UZsT8EeaWGbHhPuQXzGrGinoZXKg4=; fh=JTs+WSDeKz5D5/v7AOkoRcYlvTVmEsO2Cab3uou31DI=; b=l7RUT7pimzK2QTwa928Ce8g87ws69y31obwaLCICVc2TxLto/yhZyd96YwbUx2hh11 6i5g7hJe/XjT1Z2Plq5+xh90u/hgv8+5sFjL5lq4FknQAEEVYi1ZWUPT+iYi6nZ2rxK2 WuJWzezu+2jsSIfVfDXxflrkF6vd/k3bptfieHFhLQL0buVHhbD/1VtTJhBPAnr+T35b 29GRfNBiPlrIjsS/poJGFjX8hqMbpYLLZdQBVi0G48hegCOaUlPA7MNIHLtHMxLJ+8Mk cCOPoi9m6DsjzkSFxhN3XiDm2zQkxrvnrpLOAYkiLeAol2lK09UFAir8hqovGAaKvlLM gbmQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b="XwR/xuE1"; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c789:8bc5:fa8e:d502 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48e8a29254csor287943f8f.9.2026.11.03.00.36.47 for (Google Transport Security); Tue, 03 Nov 2026 00:36:47 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c789:8bc5:fa8e:d502 as permitted sender) client-ip=2a06:5b06:b600:300:c789:8bc5:fa8e:d502; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b="XwR/xuE1"; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c789:8bc5:fa8e:d502 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793695007; x=1794299807; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2hGvOLrw4u7HY1UZsT8EeaWGbHhPuQXzGrGinoZXKg4=; b=XwR/xuE1pO2mXaFV2vOzeorjaiKO9/DdCLaZp8J0aR7pUvQuGqpXeiFJCogtHqKH4/ qV/Otw81F1Lw/4onZWudsxJNmUDPVppuRNbXSwwNxgSeiufe2FTnZCocT2PmqXZGJ0yd NB4vpyFeB9fWr9XgQp9Y7lYSU9p/+kZacwwlP5iWKZOyCa91FaXzwsLdhrjuUQGcsKu4 lwHAVA8RX2m5pMGigjFJEhV04dRF6s/7jD3HoshVy0XR4uhE80b+jyIPLbMmgFwj9x6O sTqIM44+cwjBDFp6owZX5QXhFbzHJzwDtaLrKo6B8PsWN8wGKWjvTU7Yc93cROODlBdW LqQw== X-Forwarded-Encrypted: i=1; AKwUvBz843KjYMbzIg5DGP+zkAhd1Lugm4+VXE2HYvGSr05Hb63HF2t7Vxvo2cvXvr7ICDjainv7cg==@openvz.org X-Received: by 2002:a05:6000:4b17:b0:48d:f7ef:cd1d with SMTP id ffacd0b85a97d-48e6e4f56f7mr28141514f8f.9.1793695007053; Tue, 03 Nov 2026 00:36:47 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:c789:8bc5:fa8e:d502]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71b72715sm23138568f8f.18.2026.11.03.00.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 00:36:46 -0800 (PST) From: "Denis V. Lunev" To: andrey.zhadchenko@virtuozzo.com Date: Tue, 3 Nov 2026 09:36:40 +0100 Message-ID: <20261103083642.130885-3-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261103083642.130885-1-den@openvz.org> References: <20261103083642.130885-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 2/4] dm-ploop: fix a lost wakeup of the ploop_allocator() thread X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev ploop_allocator() tests prealloc_size and only then sets itself TASK_INTERRUPTIBLE before schedule(). A request that lands between the two finds the thread still running, so wake_up_process() does nothing, and the thread goes to sleep with the request pending. A pio whose cluster is past the end of the top delta then waits in ploop_allocate_cluster() until some later request wakes the thread. The dispatcher waits for every runner to go idle before it hands out more work, so the whole device stalls, and an idle device has no later request. Set the task state before testing prealloc_size. Fixes: cf489cf22cd5 ("dm-ploop: make filespace preallocations async") Reported-by: Konstantin Khorenko https://virtuozzo.atlassian.net/browse/VSTOR-152984 Feature: dm-ploop: ploop target driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-map.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index f0832fcefeb8..e64fd8965d46 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -2325,6 +2325,7 @@ int ploop_allocator(void *data) struct file *file; for (;;) { + set_current_state(TASK_INTERRUPTIBLE); /* we do not care about exact number here - risk one extra schedule wrt taking the lock */ if (ploop->prealloc_size) { __set_current_state(TASK_RUNNING); @@ -2348,7 +2349,6 @@ int ploop_allocator(void *data) __set_current_state(TASK_RUNNING); break; } - set_current_state(TASK_INTERRUPTIBLE); schedule(); } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel