From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 524648017D for ; Tue, 3 Nov 2026 08:38:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A38b20A002607; Tue, 3 Nov 2026 11:37:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A38b20A002607 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793695024; bh=UndQFrKsiHrJklNsGNbuFXPToPsY0N69xD8cBYGR6Ak=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=pRmXE2zWXuHux35PdpsWBN6kyWZW88onGzKq0tpSZc12bY0E5q4z6ix0Gp+kuZ4ov DIG5cQLkoihNq1mJY6CnuLQAEj18DehTLuRkW3rs7hlmWTVEDrAhdEE0iVo1wjIc7Z uFhcDo2QaXXNZy3xbkwioM1e1da8lzP1oO+qxtXg0znQ43U2KgSmqGsvBhCF0+3DBz 7lByoZY2Df4ke/OH0rdPiNApyzlfWunK+9zKtsDqGY5tcwGJITOtHSv20IlEuOQSsr pUmGe7UI6tpEsf2QZzFv6vkATCPBxyM7AA05taJ/QgSWOyoEwkmKRKcJR4wSKOSDd2 wGlkve2Doag3g== Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A38aoSV002574 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 11:36:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A38aoSV002574 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="dDiv2Pdw" Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4ae2756fa7aso19830345e9.0 for ; Tue, 03 Nov 2026 00:36:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBwKE/5t/SKBBDsuxnoOLdsTBKHCsgpjke3NXYuzuTzLVc1bwOLFcUG5M2h1XkV1XLnI749t3A==@openvz.org X-Gm-Message-State: APuU4Z/r0wnhXHJt+yEfxruMtXLWpBEOLfoc3SIeF2GobI84hx2/2r+D GdPgZDQtCyXCSaRQu3vRrECf4vDJaGxoOrFLUaCgqMhqOTrnN4TwLWPDdhDutrhcKoovqorrUpj Rc3qU66mS+pQFesP1b7aXGqM5NtPt2PbY/a8p5RLmGIAejvqW34PIjQ== X-Gm-Gg: AYBFou3YQDGROlhfzXdsq6l1bKNtiQCr6v5IlnSEYHogtuCci2zib241I5AXBEecf3h HteeqbmVUbuuIcvDoxOUkdU/ZbOtXID/78yQ1DS8pRyHszgaDDOE6v0IeLb7JV8uDnbuoC5bxbG TqB0ObfnAw8rd+CUv5v1qOi/TBfoVw72reil9Af9znfD99IBeo5nsn5/K2s8tqOsVHqm88WxMb3 mGAJ+hNXA4+Gzuk0bqpPAEuvYYjAab1woIZvWhP/g090/7OBwy7dHcwqsg+3Nm5p0e/EvRTVTaX gxRRB1aRoA== X-Received: by 2002:a05:600c:8116:b0:4a2:150f:160f with SMTP id 5b1f17b1804b1-4ac1913eecdmr279643125e9.25.1793695010106; Tue, 03 Nov 2026 00:36:50 -0800 (PST) X-Received: by 2002:a05:600c:8116:b0:4a2:150f:160f with SMTP id 5b1f17b1804b1-4ac1913eecdmr279642745e9.25.1793695009670; Tue, 03 Nov 2026 00:36:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793695009; cv=none; d=google.com; s=arc-20260327; b=q0+nmKSRCVFP++EUj02ChEEAl0VUdkoHZHXURCauBHxyqZuWu3SgctU/teQTy8k296 qY78GfuemV83BX5XSrufjkg2WWinN3Tbf2u3kUvbojRhlUSLHRnMydv6B6flRgHiwrc2 rouG61XOUei7CRyqmQFHLLNrwSoofEVDuWMSVrj3YnmhbUZNazIH9rd7rC4i4YaU/rT9 rS6nCx+oFzml3jMQ+w+DQ8CnH+UvvuYd4PTvtuMf83DxS+eN68jJzuzAYefy1G/GzFFF P6VSDZk9LjnAEyuWqeQ/3qOZf1rYZxx+tu1A6TZSlMhZMy6SqeFJhb2NTFXTyqEDNYWy hwZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=5qH2lrv2mQZbVEB+qm9NAzrEm6/gR4Uilo/ugmXeLC0=; fh=RpPZPsnE/NPN3g09cdERtSYxxXXKPDREa8SKuHSvndA=; b=GKsdBkYV3XuMGqvdVG/QpcxpmIXAuIMjQPtT6OOlbC29E6XGs0P0zNKwo3ECMMrNeu 2flzlb7xEBxKkRKsG0UHuoHQIuWiKiBXeVsVj4aODLqvuJgQAl6Jv8GOx5VHx8Hh/pPg XOR7FJlhTuwF+EpKYF679lVAG8Uoy++DnBkUdbB5uRR4PewxwNWkBPyOOsJciIIinxR8 2698+KaBDqBVmTDp2AoXjH9QYPKfnOOJXfXTNTa3rzvZivCp3frk5mNtH8o+poEaquUC LrsKocAm9eOebzrJr+vvrpn5g3N9G1MyDKMYnvFN3qzcj5hImRbxNOv5VbVH9Llxcohx rs8Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=dDiv2Pdw; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c789:8bc5:fa8e:d502 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4ad370d4d1bsor18571335e9.11.2026.11.03.00.36.49 for (Google Transport Security); Tue, 03 Nov 2026 00:36:49 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c789:8bc5:fa8e:d502 as permitted sender) client-ip=2a06:5b06:b600:300:c789:8bc5:fa8e:d502; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=dDiv2Pdw; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c789:8bc5:fa8e:d502 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793695009; x=1794299809; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5qH2lrv2mQZbVEB+qm9NAzrEm6/gR4Uilo/ugmXeLC0=; b=dDiv2PdwnewzY6yFoRs2NPiHJu3xgOptTzbZ4UM81SAV/9hSD18vJwkjQfGhx/2VGn NEn+zY/O32puXq7xSOtz4NSqW7awbmsM2YOnbIBZpLKPvtTNR52nf6Hab0bv7XLX21l5 lEs2LNw8vKI3IIC0Qh40oyKy/QV5WrToMT+5gP9WgBhbSzC7zzIVUM8kzOOGkHfMafZB m/4o3pNIDx7UXdecRC+W0vcxDkoSXBIdFoCewAjv1IT+KsAeGBXBdWUuNFuzehEbQdSn RUxAXTo5+vCeLqf9xGwMvZFVEG8cI9uYazjzSa9KUUjhc8h5WclHorFr8lz4JCCtLQVm a0AA== X-Forwarded-Encrypted: i=1; AKwUvBzFMruzEGfG9qywBFuNYFJByNKs4V/2wFzvazknorH8fl852a3bRisf69WpWK+ZSVTu3RRQLw==@openvz.org X-Received: by 2002:a05:600c:e558:10b0:4b0:a307:46f8 with SMTP id 5b1f17b1804b1-4b0a3074938mr85570005e9.10.1793695009280; Tue, 03 Nov 2026 00:36:49 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:c789:8bc5:fa8e:d502]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71b72715sm23138568f8f.18.2026.11.03.00.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 00:36:48 -0800 (PST) From: "Denis V. Lunev" To: andrey.zhadchenko@virtuozzo.com Date: Tue, 3 Nov 2026 09:36:42 +0100 Message-ID: <20261103083642.130885-5-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261103083642.130885-1-den@openvz.org> References: <20261103083642.130885-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 4/4] dm-ploop: fix a failed cluster copy on grow leaving the BAT page busy X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev ploop_prepare_reloc_index_wb() marks the BAT page of a relocated cluster MD_UPDATING and MD_DIRTY and allocates the cluster to copy it to. When ploop_write_cluster_sync() then fails, an I/O error or ENOSPC on the host file system, ploop_grow_relocate_cluster() only frees the piwb. The resize fails and submission resumes with both bits set: - every allocating write, discard or COW on a cluster of that page is parked in md->wait_llist, which only a writeback completion of the page drains, and none comes. These requests never complete, a dm suspend of the device hangs and later ploop cmds time out in the inflight ref switch; - the allocated cluster stays taken in holes_bitmap until the image is reopened. Clear the bits as the error path of ploop_prepare_reloc_index_wb() does and give the cluster back. Submission is stopped for the whole resize, so no pio waits on the page and none has to be resubmitted. Fixes: 018063db0eeb ("dm-ploop: fix resize and grow to use the new way of updating md pages") Reported-by: Konstantin Khorenko https://virtuozzo.atlassian.net/browse/VSTOR-152981 Feature: dm-ploop: ploop target driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-cmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c index 72a9662d2bdb..54458316673e 100644 --- a/drivers/md/dm-ploop-cmd.c +++ b/drivers/md/dm-ploop-cmd.c @@ -351,6 +351,12 @@ static int ploop_grow_relocate_cluster(struct ploop *ploop, PL_ERR("reloc: failed write: %d", ret); /* piwb can not change here we are the only user of md page */ ploop_break_bat_update(ploop, md, piwb); + spin_lock_irq(&ploop->bat_lock); + if (add_for_wb) + clear_bit(MD_DIRTY, &md->status); + clear_bit(MD_UPDATING, &md->status); + ploop_hole_set_bit(new_dst, ploop); + spin_unlock_irq(&ploop->bat_lock); goto out; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel