From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 64CDA810EB for ; Tue, 3 Nov 2026 12:43:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CggDr005209; Tue, 3 Nov 2026 15:42:43 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CggDr005209 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="mn7gMlgG" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CgOA0005149 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 15:42:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CgOA0005149 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a1d1f26a63so39737985e9.1 for ; Tue, 03 Nov 2026 04:42:24 -0800 (PST) X-Gm-Message-State: APuU4Z8C84oL+5GROq13dDdv3P0nePOkmW2ak5YBpW2ejeagu572mC4L 3Pd5Qa2nImgLlOtSn9RJIJOBkav2EDWR8FSbD+wSTm3JP0+SOCs+rmweJivmlLywUpQCkuVLwQQ VLpoKlkMojZkFY54Gogas+O3Bb/4RK1DSTTcMwx9UrthPv6w/xpMN4A== X-Gm-Gg: AYBFou050Lqds3BhGBFm3FaEekpJ9WTCFWYRROmZXUsqJ8g0hbvEZtKK1n8NtqS851Q ShZytzN7NIMSUSOzFKIbPvqS8m/16cj6maFzuB6AJDj15TOQkqmsc7GzbtXXj/kwRbCcLNbMZJD wp73vekuBpV/cI+IP42U/FVS2ipK4axDFmPBi9WYkTZ1lO1HIAuJhnMxbUC3BVKqFFhODTgynfC Wg94OIAVzWx2A8qlxxVFV4UCFuvOrtV/7k2ccNLu1BGyy7X3tjyfcbfMGKoHOqWnON39akpY/9y n7Hlw0BkqMgkYig8AxwSohVmvxjIQcJ5bMWR2XAG+D7OeoWDSrD+KDc/Eeqxgk0iiz2xVnYJ0bg cOFUElmiEuhDwXDDiVIgqtHJjq+9K X-Received: by 2002:a05:600c:8b46:b0:4a0:4a8:d444 with SMTP id 5b1f17b1804b1-4ac18c73238mr304712865e9.33.1793709744045; Tue, 03 Nov 2026 04:42:24 -0800 (PST) X-Received: by 2002:a05:600c:8b46:b0:4a0:4a8:d444 with SMTP id 5b1f17b1804b1-4ac18c73238mr304711875e9.33.1793709743410; Tue, 03 Nov 2026 04:42:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793709743; cv=none; d=google.com; s=arc-20260327; b=o0DSCne/60fFyVMEtTfb253s+6+JNysxEgmZSUGRWfi/OWI++bq7gsPT1L7Guwx8fO lcmBIHPuCR7Q8o6LVA3x9WT+f6sDlNrwmg+q3rxLFg0xyp92CdwhVxvILDuJarb85Tsj 4JqN3XBxyUVJddR3pQxBOX1PDoLCMTgf++9xeCUUtu2uaB8oQ75i91iBkRdGFL6m9Bk9 uv/OJH8wJ+u37EShXHUN7wGmvPAF/IN6LEHh/DfWuTqsqYQLrW1n5G1Kau9NujGeBEd+ ihb+wiYZhfyjpmCp+709qEW/PCq6uwfUV7UHifuKUO1Zf4ASwBaseFgzl1ArEHAF1AOq okqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=gIx1d6fc2Skod3uBAOkQgo5uTKf/aCg54nlpbNAHQzQ=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=qPqP0n4Vh4QGkAPiFqHssLQhyDLaVN9eG3cFNG/TWdcaQydRNXXKsxYrNk7aiuVX92 pvTdgFTTOJ5e+kY7BdW2Gmg4dTClfBNEq18uOCMvHFwc2bHEglyz8TvFh+38XxF++Iob wYer0GCQ0DhzcnPQLooK0YilExVnKfmIgKYmQUZQ43effo9RKoZerdPUURvKRXWOVPlt O4p7utuLqM4MqGECFU1vSofyRbfY6Mp0u+5NczesG3F1kNNeOC8tekvA6GRPO0lSImJ6 4cc+yV6oc/RAukw7/ragZuKHQKlevsjYa6dPJ537qmX3Jq/T+WcedYDh9Pk6GKIwJSYb oazg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=mn7gMlgG; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bc9ebdsi25687046f8f.373.2026.11.03.04.42.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 04:42:23 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=mn7gMlgG; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=gIx1d6fc2Skod3uBAOkQgo5uTKf/aCg54nlpbNAHQzQ=; b=mn7gMlgGk4/s dvLKGCua/AaC7z5Qcpz3JGV+AmcbfdbTG2b/hXnSZ7fHaqgqizyGpFtz9UZLMTlEFVEtu7ZkQKExW v1KL2mdAErBFc9GzSdNGCMxZLlKxkqd0Xb/7wUt8rW+QY3tkvmp4ju8UZoALUuAORO3XvC7Y6+bTY MgA5qrE2vZpCZvNrPdCA9Y3yfHOLCkPHdxFG0MKB2Fh1MSFxEAa976iwFVdlzqzSfYZR4OLfmi980 ybSL6+3UyQ/UGhCWtnYn2r7N9OKAJjEG0EUGB9JS//hdtS9Idfk0hCKGtQnbBHMv33E47lJCWRaSx w1jMzEotSV/3euOAKhEFKA==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xODmN-00FAc4-2L; Tue, 03 Nov 2026 13:42:13 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 15:37:56 +0300 Message-ID: <20261103123802.846676-2-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> References: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 1/7] drivers/md/push_backup: correct initialization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Allocate pool and htable after lock, waitqueue and deadline timer init so that pb_destroy() is safe on every error path of pb_ctr(). Otherwise a failed allocation makes pb_destroy() call timer_delete_sync_try() on a zeroed timer struct. This happens to work on release kernels, but with CONFIG_DEBUG_OBJECTS_TIMERS=y debug_assert_init() reports the uninitialized timer with an ODEBUG warning. https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: no changes v5: commit message: safe on every error path of pb_ctr(); the zeroed timer triggers an ODEBUG warning with CONFIG_DEBUG_OBJECTS_TIMERS=y drivers/md/dm-push-backup.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 885ea7b31cf67..9a6252f2b21e2 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -658,24 +658,22 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb = kzalloc(sizeof(*pb), GFP_KERNEL); if (!pb) goto err; - - pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, - pbio_cache); - pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, - sizeof(struct hlist_head), - GFP_KERNEL); - if (!pb->pbio_pool || !pb->pending_htable) - goto err; - spin_lock_init(&pb->lock); init_rwsem(&pb->ctl_rwsem); bio_list_init(&pb->deferred_bios); INIT_LIST_HEAD(&pb->pending); timer_setup(&pb->deadline_timer, pb_timer_func, 0); - init_waitqueue_head(&pb->waitq); INIT_WORK(&pb->worker, do_pb_work); + pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, + pbio_cache); + pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, + sizeof(struct hlist_head), + GFP_KERNEL); + if (!pb->pbio_pool || !pb->pending_htable) + goto err; + ti->private = pb; pb->ti = ti; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel