From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1407F8045D for ; Tue, 3 Nov 2026 12:43:44 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CgTSo005184; Tue, 3 Nov 2026 15:42:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CgTSo005184 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="sqiY9PNi" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CgO0A005145 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 15:42:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CgO0A005145 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e0461e040so3490515f8f.0 for ; Tue, 03 Nov 2026 04:42:24 -0800 (PST) X-Gm-Message-State: APuU4Z81rwe9kdpmuY0NzAA7yBV3o35jaB3qZ7hDqPzbLsvTuzONnTAZ fEY/C+zY7O6uyQxFdq2rLhhavinH+LlKgpptT2ANZKdu9dN7Me1CGsq6VD83r3WCziLaKn+NZ4B D6eqKHO+JsouT8YC02G+YuHVXgHURX1h1NEkmpsIy1TM+4eeLwewqHQ== X-Gm-Gg: AYBFou3tOLTNcAIVgSkbK21eOJ0lhlh0dXMd+2e0HXzTjawihN4WjYusgKXh4+19avy jeex4NC9b7vlPzwwYuqFO/LzvKzd7fU7tHpamGXdvcDVNZYHmrCn/SLP9MN2yNQxr9AHWfTs8Px hSdxvyXVvfBjde2zkV+fL86yctXH/4dPKy2M1zQU5ROhYJpsnHnEdqukPKU6HZjbDhBoczdPmEX lL6l4sHH/vS87E8q7tB6YGRKtIefDD0lltAZIlpnSjCeX7TghQqseQjuhWwNzNNBZk7M+cLJ9dS pkkxIjuFvjII9lCVQby2chFg04M1K48RLUHlUtnGNRPGS8KsvGp7O8HP93ZNSCa7qP7CzVYaV4n Voypf4Gf0Lbn25qNBE8d49fHfRPBO X-Received: by 2002:a05:6000:420c:b0:48e:5acf:48f8 with SMTP id ffacd0b85a97d-48e6e302726mr28498992f8f.16.1793709743915; Tue, 03 Nov 2026 04:42:23 -0800 (PST) X-Received: by 2002:a05:6000:420c:b0:48e:5acf:48f8 with SMTP id ffacd0b85a97d-48e6e302726mr28498932f8f.16.1793709743406; Tue, 03 Nov 2026 04:42:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793709743; cv=none; d=google.com; s=arc-20260327; b=PxkFkuhb4/xlea4E9l+kUUqE4UvN8UlTiiAEWXwecu4pI6vtS8vmb7TU+tDN4cD9oq sMQ15bj0T7jAmPwlnfzwbBx/4/riT3lld0Onf8Gmh/iCMU777e98OvXm8ICciFhalhSH 2lh53hibGO8BjLA4tH3DjwlBd/4vaH422f3e/4ufMDKijnu7qtPS6f49Mipk53YnrBQb WgMiVDSmqYI3oIVJiblYwHvTqc8Wm9xrseTpE4i6tlNIkDvpRBhDAXpsiwgrDlBF8Jk7 cOwwAJQi5hSAdHS4nxgurVoJ0hJ0SGCTy/I/q9TCcXvLkoDLq8z9REL03ebu4udMCUer Vn5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=4S+hYDb8snaKVnLszC44FY5vx4pxsBCMvUmpiRxF+84=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=Os60PCUIHoF2dSiYDpUoLUuFD8LnmC7LqU9gBh7So5G6RM1MmdpUpClICb/YoO/Zr2 Xz7sNvzJITTjko6y4ifLJFCJzcLvTR2xGeSRhlqPp1ALMT+aHo7oXcDnRrk5HkwnHzoK CKV2GqIR/MgOUmR9Zjbn0XPMsqsiCGBaynqNpF1BsnuVdP1trDWz3wqT5HssSpFN/eeY sjpqf4TaTQFj4Ab1R83LOjgvWgd7jVuqg7vyIAlWlAOHKgd6HiyDMLHnpbnZPPnGbtMH C+rFc/nU8uZgXanjx4PA5VicDjD99WMb2BO1ajjFf4yLuP+KTxVjeqGYw1ZKykfAlrEG iohg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sqiY9PNi; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bbad8esi24165655f8f.252.2026.11.03.04.42.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 04:42:23 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sqiY9PNi; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=4S+hYDb8snaKVnLszC44FY5vx4pxsBCMvUmpiRxF+84=; b=sqiY9PNitsm5 mKnWh0knlQj6LonFo8jnIKMJ23cq5zge4X/lo6wZQQcTlKHBNjebXz+W4jtXDdRouNYMgAi8By0S+ grR9E/Zxk9CWCXXxCTe8xVpV25VHe4hntFGSX8FdyE4jU0PXmecyXcEwkkOKSRMomPFEa+gD+A+Ih EBiAiqVybU12NfDfMF534d2NsOh6ykA90in6alp0CVpW3fNc6F/rqqUUUCXB+RQKV+NaYa8r/TUvW hOINLVthH+Xmrm4HXPLbUFm7bOYcFBkNH1lCRDgnMkxIJYeHLr3gNdUhgA9if1grmB4UvMrPter+9 Aq2YFQ8O9Or7GHuRFGrT5Q==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xODmN-00FAc4-2b; Tue, 03 Nov 2026 13:42:13 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 15:37:57 +0300 Message-ID: <20261103123802.846676-3-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> References: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 2/7] drivers/md/push_backup: return error if workqueue allocation fails X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ret is still 0 from dm_get_device() when alloc_ordered_workqueue() fails, so pb_ctr() frees pb and returns success. The table keeps ti->private pointing to freed memory, and pb_dtr() destroys it a second time. Fixes: 62e07487348e ("dm: Add push backup driver") https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- v5: new patch drivers/md/dm-push-backup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 9a6252f2b21e2..48d6d6a59daf4 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -698,6 +698,7 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb->wq = alloc_ordered_workqueue("dm-" DM_MSG_PREFIX, WQ_MEM_RECLAIM); if (!pb->wq) { + ret = -ENOMEM; ti->error = "could not create workqueue for metadata object"; goto err; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel