From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F349F810EB for ; Tue, 3 Nov 2026 12:43:52 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CgdB4005202; Tue, 3 Nov 2026 15:42:39 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CgdB4005202 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="FJ/zVNwS" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CgOXr005150 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 15:42:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CgOXr005150 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e0389d6f9so2151445f8f.1 for ; Tue, 03 Nov 2026 04:42:24 -0800 (PST) X-Gm-Message-State: APuU4Z9Ipw96xtrZb9TNSHlALYmZojodIeY+vMt0a8N28klsRTANdIe4 o11E73J/gtr5QX2PAPI1j/w6+sfVspSV2T846jjxeLlxWz7gwEoSet2jr5qgRrCNAHGrFEBKoGq +6vounYBewpFRM9H5Rda8g7y//3b/80qOrpDJK5TtKC/GFYrMUKlvMQ== X-Gm-Gg: AYBFou3X+sbA7O9TXS74OHq45dR7Fxl9HNWDl1sy3tyZ0Z6P8eiyaK0++vUOeUlsy4+ AsY5E6sZyR3BiYnDJD+fTLWjue+yZDbXqJTXPFEnUtnxb1lnoTfq+8xLALPrixlgquaZG5k4i1l VkOh0Banm3WF8jt47ZNwZCC4nwUkA0ubptpwTTcDCMYhxe5DGLD0CUZSqn0PNrsx3iPnipgXCXt F66JYDY02l1QTaL1Zf80vHFJXuhlxNXErM194rnndU6DAzPhchBjeiHMwhv8qj909P5Nr4d7Jpe KST3prqSGAcl0hi68ZoxcB1/dT1GA44lYfIcbNCim42gGU4B2jvg+bhGJh/wCxfdMGtEi9ZYIbm uf/h3Jg+90c623cS2gB/5xa79Ut3xhw== X-Received: by 2002:a05:6000:29ce:b0:48d:f7f9:6a29 with SMTP id ffacd0b85a97d-48e6e2f2958mr18352325f8f.20.1793709744082; Tue, 03 Nov 2026 04:42:24 -0800 (PST) X-Received: by 2002:a05:6000:29ce:b0:48d:f7f9:6a29 with SMTP id ffacd0b85a97d-48e6e2f2958mr18352285f8f.20.1793709743520; Tue, 03 Nov 2026 04:42:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793709743; cv=none; d=google.com; s=arc-20260327; b=aNp6PSsf0NO1z1MlzAOCPBhCEdp8dTueiNNGSli4KzsnfKznfhSkZ8PuNfSc6KuC/9 /F5iyux/S76U7TTN0BypQf5sqcnMyF0oAz1gA/PNpvcZbFgegHcg364HRMbdP0lNVZIl bx9/I0kH6m61JBsfZRkjj8sJ5GonQ3KIWtYo7Y01EISKwoXuGMManYhXGh2o97hzVQOO DuEgMIMJodKhoAo1kl34XxviCD5l5QlpEUvBfSDmkPr+6G5PftSERGauMLIEQ8UrptmM 63Q78pOA+jqn1kaptG8x+oZ9uwaIpU31HiLMPM+HGolPOcoTs8DZF79Je7FAe9rZcerS bLng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=HJCktO8okLkudkacRONQJ6eYo/f4DtwaLjhMWrw/pfA=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=RrMz5mad/OEP5rVp8ZR88PYCYhA8zym4Xq8BAcG02DzRwGNpi/ZUTyKft2piYUUhr4 388Xl/x57gbQOKfnZnIjFSy0kZBshvLMVAApiBG7ic+i7MPTBjs7oLZ956bEgO87qah6 B28uImZpu9ekHcsCUYdOjdGb7sOKjeUNbmPKiLOKMWOgUmkUxdKp9gL3tGctSBaGL8x4 upXa7ZdzgXxedUDOifKCgRigMdwBx8xePDl7xnwukID9vm6Cy7zuKqII8GKVu0kOLTfT c/pI87FDW727NbXcG/hGH+5t+8h1mPDmXg91OhYxXoty077A3Pu4R7Sx3okd/lxdNBHS P3Qg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="FJ/zVNwS"; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71ba329fsi23182041f8f.72.2026.11.03.04.42.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 04:42:23 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="FJ/zVNwS"; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=HJCktO8okLkudkacRONQJ6eYo/f4DtwaLjhMWrw/pfA=; b=FJ/zVNwSS02J YNRh1vE7Cxu4l3JAT/NxPler1e1WrGbEL3Xoitx1RLKbwnT5bFOCbBELEk0+bJSm/omBM+bMxxhcT 4EpicGjwq7CYI5iy3yIzYpMzm6usXX0BzrnTAIU16YR3cdfMDlvANypBaw9XAdv70hWiPy7DwiyNU cYw8fxZZG1XVJqHCAFoUE7JaxixeuNyfbBF7PoHkQaRiTFbbsoCt5ucdGcY5kuHA/HF/4mjP/fadc GN5DHvDlbsEfPH61rH5boPpIL4JeubtXx9en2Q+c3IIEQQ4q/atwATUN7+rxM3vD4QZnbLweKPPuR XcIyHN+2bT681vF+j66y0g==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xODmO-00FAc4-06; Tue, 03 Nov 2026 13:42:13 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 15:38:01 +0300 Message-ID: <20261103123802.846676-7-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> References: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 6/7] drivers/md/push_backup: do not re-arm deadline timer in push_backup_write() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org pb_timer_func() checks pb->deadline_jiffies every time it fires and re-arms itself under pb->lock while requests are delayed, and postpone_if_required_for_backup() arms it under pb->lock when the first request is delayed. So the timer is always pending while writes are delayed and we don't need to re-arm it after updating the field. This call is also not done under pb->lock. Today it is harmless because write and stop are serialized by pb->ctl_rwsem, but it would re-arm the timer behind timer_delete_sync() in push_backup_stop() once the write path is reachable without the rwsem (next patch). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: commit message typo v5: moved after "arm deadline timer under pb->lock", so no bisect point re-opens the race; dropped the "only place" claim drivers/md/dm-push-backup.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index f0de26add11c2..52ba80b703ff1 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -463,8 +463,8 @@ static int push_backup_write(struct push_backup *pb, unsigned int clu, unsigned int nr) { u64 i, key, nr_clus = pb->nr_clus; - bool finished, has_more = false; LIST_HEAD(pbio_list); + bool finished; struct pb_bio *pbio; if (!pb) @@ -515,8 +515,7 @@ static int push_backup_write(struct push_backup *pb, } } - has_more = (pb->nr_delayed != 0); - if (has_more) + if (pb->nr_delayed) pb->deadline_jiffies = get_jiffies_64() + pb->timeout_in_jiffies; else pb->deadline_jiffies = S64_MAX; @@ -525,11 +524,8 @@ static int push_backup_write(struct push_backup *pb, if (finished) wake_up_interruptible(&pb->waitq); - if (!list_empty(&pbio_list)) { + if (!list_empty(&pbio_list)) resubmit_pbios(pb, &pbio_list); - if (has_more) - mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); - } return 0; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel