[Devel] [PATCH hci-8.1 v6 2/7] dm/push_backup: return error if workqueue allocation fails

From: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com
Cc: devel@openvz.org
Subject: [Devel] [PATCH hci-8.1 v6 2/7] dm/push_backup: return error if workqueue allocation fails
Date: Wed,  4 Nov 2026 11:38:13 +0300	[thread overview]
Message-ID: <20261104083818.856720-3-andrey.zhadchenko@virtuozzo.com> (raw)
In-Reply-To: <20261104083818.856720-1-andrey.zhadchenko@virtuozzo.com>

ret is still 0 from dm_get_device() when alloc_ordered_workqueue()
fails, so pb_ctr() frees pb and returns success. The table keeps
ti->private pointing to freed memory, and pb_dtr() destroys it a
second time.

Fixes: 62e07487348e ("dm: Add push backup driver")
https://virtuozzo.atlassian.net/browse/VSTOR-152912

Feature: dm-backup: push backup target driver
Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
---
v5: new patch
v6: subject prefix changed to dm/push_backup, added Feature: tag

 drivers/md/dm-push-backup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c
index 9a6252f2b21e2..48d6d6a59daf4 100644
--- a/drivers/md/dm-push-backup.c
+++ b/drivers/md/dm-push-backup.c
@@ -698,6 +698,7 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 
 	pb->wq = alloc_ordered_workqueue("dm-" DM_MSG_PREFIX, WQ_MEM_RECLAIM);
 	if (!pb->wq) {
+		ret = -ENOMEM;
 		ti->error = "could not create workqueue for metadata object";
 		goto err;
 	}
-- 
2.43.5

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
