From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7E290812AD for ; Thu, 5 Nov 2026 14:59:30 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5EwDl7005864; Thu, 5 Nov 2026 17:58:14 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5EwDl7005864 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793890697; bh=Himbl8oTTpXM3xVUyUaZZ6dQlfYOH2XcTV3Bd4mUxss=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=jW2bmn0vjlQvb965VpK9SNEacMfDzrjzqCNLLLAenlhG2DK8m+cxQAGFetlkFZN6R 9FN6mWQlTIIJV0oIKO3yJ/gnLNHIxmwqb04bMl/25cyqDUc0iMQG4HkNLc76EkuXCy U9UcmUwx6LO6LW0dtkKxUOC2EBfyfCCARKQTIwO0/diiE4puZd7rD6r1Q79Cs7rc9T JD7tWlIY1gVCxKxyGc/GVBVDgTXXR9TY3TZwpIoiE3CTAbO8Oqy4Av9+Wzz/K1ixcs e15Yd18v4BHuHHYS9Pz3LRqBhgZLXXOMQe4ILK7GTt5dku9ZUkH74cPC+pw7RkWV3k oORYggnTM5TRQ== Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A5EvtZL005833 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 17:57:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A5EvtZL005833 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="aM5qwCBu" Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4903fc8537aso1298065f8f.0 for ; Thu, 05 Nov 2026 06:57:56 -0800 (PST) X-Gm-Message-State: APuU4Z+q1q3y9PpRUtrsIbetVCBjxlBv75Y0PpcAvhzBNnqELAnNlkyJ PGHyDlMh+/29b+jiDgAOHRoXSWQBAbRojdZfWb/bFN/WaQ/a1SbpRxkgPRoD+iuA12LLSx6OJeT iLBgxjO8htGfxD9ifLdskgHNDEZzlekbaZIrgidVwQoccfc+EZHBuVg== X-Gm-Gg: AYBFou1ELDr/ZQF2FMAc/nFImvXEtfSt3A1lnqaSCRgBBGVn0dYfI/F9f3nHrJvV7A3 1hw/9nILybVllCZONi7BWm9PXqelm3wSd7hMftrMiHCms3o+Ng7QzvPCLHei2yhIMAWvfFy1PhT jlpa2rHisp7l2OdCHhEn1MyQ0QensAKR3M2KCbvZZyrqHzWfbl5fkM++k+9l9/YlxUrodRUINBr 14lmwvh5wLBIzGGa9gWT+vepqdusOBCGfhSiHLpL4s6teoCS06AJL13ufrE1OeCYJQ++P5/ruft 6AYHn1risA== X-Received: by 2002:a05:6000:98e:b0:491:6c24:65f5 with SMTP id ffacd0b85a97d-4916c246792mr4097223f8f.17.1793890675720; Thu, 05 Nov 2026 06:57:55 -0800 (PST) X-Received: by 2002:a05:6000:98e:b0:491:6c24:65f5 with SMTP id ffacd0b85a97d-4916c246792mr4097182f8f.17.1793890675267; Thu, 05 Nov 2026 06:57:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793890675; cv=none; d=google.com; s=arc-20260327; b=cwgrWvMwpm1tQkeMHLOGQcYGYVfwhbX5gO5HEfkRQoSX7yjhCfGF7LICw57tBvzd2X i9gG2tFXUFEhjto06tCGbZPVAiZAhP4qe/oDvMCaFzCz4p3lrJpMVm6uFMNGFIO5aWrL E2fs7QJJYTyHGImzhROAnvmZHQetpoz1VDnPaCKAb47UsmbSnoar8sDdiVWyFjfXq0nh Bs+cpkWqs3Tbv9UpgLoOP24rfSyo6nbE+vu+JJ8bq/01iaduCKlhH1aRapSCpbNcK/Jc X1vsvz79vU6mVMtV4NUX9f7OrwEpxg+EeXwJ3vIVqMP0rpw+uNmb+UoUuDTDuDxb+xVQ sFmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=KtNkOcLyrODPb1g6Sqn8HLfc8h7zURJ5m6iyLNO5W/c=; fh=ozrYJQ1t3QIP6s65KBq5xgJxiFM2qf+5wwn3ABTusyU=; b=AMZs+irWaqp70LalKxBcTi9biL1pwKqERLi2mTbs2W2DGANz1bgQjHCWX/oqYybK2Q mjMaJsFkQBOkePalWTk7hYR1rzZ3I1pGcHz2cyz8dpaj2cXRcibJqqxojUV0RkJ2hAWR m7AYGp35EOTNDTRvEofehEWHb52D8outgMlZ33xrnRy6rgoLOISaKdHzD7gqGGMMpfkO /cwIbkAapM7uuT/ISiG3et85o8kT6e6jglb8UwWyRobM9HARF8Fezsdm7TjIUdZTy/gf NLLXrKfcWOJWnt3jpIf7+q9xP0SMnwIeLw0hHRzqNJufbeFYjDsugzymnw8crbmMSKBH 1eYw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=aM5qwCBu; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:3848:9c8a:8cf7:6236 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48fed17a001sor971134f8f.6.2026.11.05.06.57.55 for (Google Transport Security); Thu, 05 Nov 2026 06:57:55 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:3848:9c8a:8cf7:6236 as permitted sender) client-ip=2a06:5b06:b600:300:3848:9c8a:8cf7:6236; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=aM5qwCBu; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:3848:9c8a:8cf7:6236 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793890675; x=1794495475; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KtNkOcLyrODPb1g6Sqn8HLfc8h7zURJ5m6iyLNO5W/c=; b=aM5qwCBuOHFwSqQ0/L9Pkud9qbdxKU7X0EOzCzr5fA9lq9qGM7x9U5D6xKZxhACm8v pe6zMzSy0b8GDAou21QC0Q2La+0FD/9uqlTBJhbRbFrdRYoOG8LQUBb4evR+hsDjnl9G s3xN48MaRBqksI+46ZJW4s85IIydTgX0p8Voiimhg59aqfsFpKalILAEBxxWbbNkA4YV 5aZlFjSbB2tL1rH+Gh/6IruQponf80hV/Wpv/psrVg621h5MeXjc1emuZYQbR0fUK1Zr feLRMDIhDc/kHhSmEccEOOc1arKQE/vS6yLXGTlP5yXkBA4BSPDhtcIZzWgFsUCtTgkb VC7g== X-Received: by 2002:a05:600c:a012:b0:49f:fd2d:23c7 with SMTP id 5b1f17b1804b1-4ac17b2ce18mr417288565e9.27.1793890674827; Thu, 05 Nov 2026 06:57:54 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:3848:9c8a:8cf7:6236]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48fed92a753sm11719747f8f.45.2026.11.05.06.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 06:57:54 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com Date: Thu, 5 Nov 2026 15:57:49 +0100 Message-ID: <20261105145749.2643035-4-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261105145749.2643035-1-den@openvz.org> References: <20261105145749.2643035-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 3/3] dm-ploop: fix the flip_upper_deltas check skipping the last BAT entry X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev ploop_check_delta_before_flip() means to stop its walk after the BAT page that holds entry nr_be - 1 of the lower delta. It takes the last entry of the page from i after the scan, when i is already end + 1. When entry nr_be - 1 is the first one of its page (nr_be = 1009, for example), the test matches on the full page before it, and the walk stops one page early: a cluster both deltas map at entry nr_be - 1 gets past the check. Otherwise the test never matches and the walk ends with the live BAT, which the previous patch keeps the same size as the BAT of the lower delta. Take the last entry of the page from end, and leave the loop with a plain break. Fixes: 6ddad5a4d226 ("dm-ploop: Add ploop target driver") https://virtuozzo.atlassian.net/browse/VSTOR-153445 Feature: dm-ploop: ploop target driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-cmd.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c index 5549ba448594..2d1fa449b052 100644 --- a/drivers/md/dm-ploop-cmd.c +++ b/drivers/md/dm-ploop-cmd.c @@ -1161,13 +1161,8 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) if (stop) break; - clu = ploop_page_clu_idx_to_bat_clu(md->id, i); - if (clu == nr_be - 1) { - stop = true; - goto unmap; - } -unmap: - if (stop) + clu = ploop_page_clu_idx_to_bat_clu(md->id, end); + if (clu == nr_be - 1) break; d_md = ploop_md_next_entry(d_md); } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel