From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5A76681416 for ; Mon, 9 Nov 2026 12:00:33 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9BxJ1n031365; Mon, 9 Nov 2026 14:59:20 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9BxJ1n031365 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="N3UqTQfH" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9Bx27q031306 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 14:59:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9Bx27q031306 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4b9fde3044dso2885665e9.0 for ; Mon, 09 Nov 2026 03:59:03 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErH6qBHDK4fU2No+Q+A6y4MVq+RqTKFQgHY8a8H15Me5bIbksKvJLgP9W1yuF8KwJFavmRzG7g==@openvz.org X-Gm-Message-State: APuU4Z8PyPNCZEqxuLgCOWq2XqLjqdDSEvfxiK/fFqThsdLhBJmlseUe Lkio9ghOCFLDg9S9LWXHjT+O2Ri2g7cHlZudhssKpkeWLuXBsxVmPuiEwNiJWUbhd3TznwC62AQ qLiCo18XsbP8msxAiUXfNM7U4/TkSUI2laZPhdSHPANCxXzye2iFvqg== X-Gm-Gg: AYBFou2mJ6N0IBh8L5OTcbW0WswAjd5fXIrwhkrB4ueJtwdJ8KE1tN2kVsc1aFr9PR/ 4aQwuyrGUSwgtD5cz6PucQ6PLpWcU/WK/17nKmv3nMOKQyYTT1157Y8hNtVeqHYUl461D64HrL/ NKJbKEphYlZ9p9b2OBwSyPyqEAT+08rntAkVoQ3qweo0qeriuLqGh4W1yvkam84CEz+gLhMp8Rf 3nJoD9KyyQfSV5LorZwrICep3S7GP9WwpkXiPvCBpIDHKhSRFgXjLDpKgcDmJ1dPyNVc9RQPHDF xVk2QpWU3Bulc0tN23FGMtDTkZWBoFcLMo6vtsd1HJQq/lRsCxqjKnr/B7UIyBLCMgFN0I5y2EF 5Xw6S4RscZJt7ERkeoiA7Rmmf4aOr X-Received: by 2002:a05:600c:8b21:b0:4a2:150f:1613 with SMTP id 5b1f17b1804b1-4b960d9aff8mr69797785e9.7.1794225542707; Mon, 09 Nov 2026 03:59:02 -0800 (PST) X-Received: by 2002:a05:600c:8b21:b0:4a2:150f:1613 with SMTP id 5b1f17b1804b1-4b960d9aff8mr69797445e9.7.1794225542176; Mon, 09 Nov 2026 03:59:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794225542; cv=none; d=google.com; s=arc-20260327; b=AHbnJqa21eCMQThT7LQHn7EHI+AvStTV7yGBD4p94XnCuWIM0ETBMW9Eh+awnspZth zB2RZnrVIHtuLlTlEnHJztqzuGYWYqA/wmjXon6mSg62/VpLbanGCeVhyTtO8LOKWPHI ZnYaIsrwmVxEx3RMtrPccQvU4bH0ai0212d2qz1nnvAcbZD3MM3w9t2DpehMLAvEv0v7 5VtRzalZIxxLQhEeSr9kkZu5EiTr+t12R/7PwD6OWUdDTOaTiTuR0TJzvL5wjaFgb2qD T857/kuuW/PcdzJ8FUD2sra3V8veut/2dBWpe5P6RPjkp03GhxoxQf7xwRDFM82fZtZD epUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=x41xuKzHfQaaSRIF55AbVZIszUBpZuQgmc+0qQkH5N8=; fh=E3vCAgcov/hQ3XWh2CqQ9wok33eMAQJstV7H9y+Mjr8=; b=BWhAEo4UD8aNmH1q+t4ukKDO7Hbmb1ZcVw4HYAUaDfBjoDLkV/kv2fhNaEu/jrybO9 5retg2R6DVaTs0tF8Uy1Q4QWNQnvbUwBlnbjz6pQAxgujMf/jIonT6TDn7yTUm9x0oqb zlbwjowkI5+FKFYyNqRh2jJnt2t7GI8iDXl6+skH1pZRHl+F5Z3Dm8rfz7hvkbfKRmlg C/bcbsNbMnQKGRdbwdkTWmXRhJd+Xxaa6poF/4PicwTeHUzUS49KLl+pt/ikSa3ZbvtF 9Hsj5yHtWISI3YtWq1c42uLOM8Q0m1hXgaSlzmFwWAx61CMkjEF6LLKZKD123C54yivc /Jzw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=N3UqTQfH; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49597371041si8044731f8f.166.2026.11.09.03.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 03:59:02 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=N3UqTQfH; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=x41xuKzHfQaaSRIF55AbVZIszUBpZuQgmc+0qQkH5N8=; b=N3UqTQfHS/kh YGbIp9lHeI9PhNnZZeFfYwhGUq7IxKunjDQ59bLpBXEWfapp1Cfl8NsQiBc52da7lVrVvozXizOMi wk64dFmTYsj1Hes2asZmM9r68FgUqijoG8d2k08bFMSkbK/Jr5/OTCx95xTIx2n0tf85dER900R45 b64aEH76jhR5p/tOTIJ/EzGyEBtUwmU+V79hJjHjbNHD7RjUGIQ/cSuhLF20mASmy5YMwKguzzujE 7ka4ZnxbuhZh3/rsQelCWlDFQzeDSXHzIckDmWHwQ5ipjqvLPbZRFFnaxAxy3q4yCZ+wUuycOktAE YiH02ZD0yaFEZ6eH8zL3iA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xQNxZ-003a4R-1Y; Mon, 09 Nov 2026 12:58:53 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Mon, 9 Nov 2026 12:58:48 +0100 Message-ID: <20261109115856.1362416-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261109115856.1362416-1-alexander.ivanov@virtuozzo.com> References: <20261109115856.1362416-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v10 02/10] dm-qcow2: drop duplicate prefix from QC_ERR/QC_INFO messages X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org QCOW2_FMT already adds the "dm-qcow2: : " prefix and the trailing newline, so several messages were printed like: dm-qcow2: : dm-qcow2: Can't parse metadata and some of them were followed by an empty line. Drop the redundant prefix and newlines. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev Reviewed-by: Andrey Zhadchenko --- drivers/md/dm-qcow2-target.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c index 0cbbd8e4f493..bb322254cea9 100644 --- a/drivers/md/dm-qcow2-target.c +++ b/drivers/md/dm-qcow2-target.c @@ -192,7 +192,7 @@ void qcow2_flush_deferred_activity(struct qcow2_target *tgt, struct qcow2 *qcow2 md = rb_entry(node, struct md_page, node); /* FIXME: call md_make_dirty() and try once again? */ if (md->status & MD_WRITEBACK_ERROR) { - QC_ERR(tgt->ti, "qcow2: Failed to write dirty pages"); + QC_ERR(tgt->ti, "Failed to write dirty pages"); tgt->md_writeback_error = true; break; } @@ -840,19 +840,19 @@ static int qcow2_parse_extensions(struct dm_target *ti, struct qcow2 *qcow2, struct Qcow2BitmapHeaderExt bitmaps_ext; if (ext.len != sizeof(bitmaps_ext)) { - QC_ERR(ti, "unexpected bitmap extension size\n"); + QC_ERR(ti, "unexpected bitmap extension size"); return -EINVAL; } if (offset + sizeof(bitmaps_ext) > end) { - QC_ERR(ti, "unexpected end of extension area\n"); + QC_ERR(ti, "unexpected end of extension area"); return -EINVAL; } memcpy(&bitmaps_ext, addr + offset, sizeof(bitmaps_ext)); ret = qcow2_parse_bitmap_ext(ti, qcow2, &bitmaps_ext); if (ret) { - QC_ERR(ti, "unable to pase bitmap extension\n"); + QC_ERR(ti, "unable to parse bitmap extension"); return ret; } break; @@ -886,7 +886,7 @@ static int qcow2_parse_header(struct dm_target *ti, struct qcow2 *qcow2, new_size = PAGE_ALIGN(qcow2->file_size); ret = qcow2_truncate_safe(file, new_size); if (ret) { - QC_ERR(ti, "qcow2: Can't truncate file"); + QC_ERR(ti, "Can't truncate file"); return ret; } /* See md_page_read_complete() */ qcow2->file_size = new_size; @@ -918,14 +918,14 @@ static int qcow2_parse_header(struct dm_target *ti, struct qcow2 *qcow2, ret = -EXDEV; if (upper) { if (upper->clu_size != qcow2->clu_size) { - QC_ERR(ti, "dm-qcow2: clu_size mismatch\n"); + QC_ERR(ti, "clu_size mismatch"); goto out; } if (upper->ext_l2 != qcow2->ext_l2) { if (is_bottom && upper->ext_l2 && !qcow2->ext_l2) { - QC_INFO(ti, "dm-qcow2: using bottom delta without ext_l2\n"); + QC_INFO(ti, "using bottom delta without ext_l2"); } else { - QC_ERR(ti, "dm-qcow2: upper delta without ext_l2 is unsupported\n"); + QC_ERR(ti, "upper delta without ext_l2 is unsupported"); goto out; /* This is not supported yet */ } } @@ -947,11 +947,11 @@ static int qcow2_parse_header(struct dm_target *ti, struct qcow2 *qcow2, ext_end = PAGE_SIZE; if (ext_end > PAGE_SIZE) { - QC_INFO(ti, "extensions are too long, skipping them\n"); + QC_INFO(ti, "extensions are too long, skipping them"); } else { ret = qcow2_parse_extensions(ti, qcow2, ext_start, ext_end, raw_hdr); if (ret) { - QC_ERR(ti, "failed to parse extensions\n"); + QC_ERR(ti, "failed to parse extensions"); goto out; } } @@ -986,7 +986,7 @@ static int qcow2_parse_metadata(struct dm_target *ti, struct qcow2_target *tgt) ret = 0; out: if (ret) - QC_ERR(ti, "dm-qcow2: Can't parse metadata"); + QC_ERR(ti, "Can't parse metadata"); return ret; } @@ -1067,7 +1067,7 @@ static void qcow2_truncate_preallocations(struct dm_target *ti) ret = qcow2_truncate_safe(qcow2->file, end); if (ret) { - QC_ERR(ti, "dm-qcow2: Can't truncate preallocations"); + QC_ERR(ti, "Can't truncate preallocations"); tgt->truncate_error = true; return; } @@ -1153,7 +1153,7 @@ static void qcow2_postsuspend(struct dm_target *ti) if (dm_table_get_mode(ti->table) & FMODE_WRITE) { ret = qcow2_set_image_file_features(qcow2, false); if (ret) - QC_ERR(ti, "qcow2: Can't set features"); + QC_ERR(ti, "Can't set features"); } } static int qcow2_preresume(struct dm_target *ti) @@ -1162,7 +1162,7 @@ static int qcow2_preresume(struct dm_target *ti) int ret = 0; if (qcow2_wants_check(tgt)) { - QC_ERR(ti, "qcow2: image check and target reload are required"); + QC_ERR(ti, "image check and target reload are required"); return -EIO; } @@ -1183,7 +1183,7 @@ static int qcow2_preresume(struct dm_target *ti) if (dm_table_get_mode(ti->table) & FMODE_WRITE) { ret = qcow2_set_image_file_features(tgt->top, true); if (ret) - QC_ERR(ti, "qcow2: Can't set features"); + QC_ERR(ti, "Can't set features"); } if (!ret) qcow2_set_wants_suspend(ti, false); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel