From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2F0E481377 for ; Mon, 9 Nov 2026 12:00:45 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9BxYAc031405; Mon, 9 Nov 2026 14:59:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9BxYAc031405 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="L0vy/llD" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9Bx3Zh031318 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 14:59:04 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9Bx3Zh031318 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4923b9fdd43so758381f8f.3 for ; Mon, 09 Nov 2026 03:59:03 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHbuiMVrm2uzYv89Oqd9HM4hiXw8vi1i5qaA7Sin9QsRhouvEi3XjTMuBTs2krepOX1PRALEQ==@openvz.org X-Gm-Message-State: APuU4Z+5nLzeRO3XpXqloPtpe6fQIKhlFPq5IHsb7yjTpZum4aF1pK4k 0I7TmGNd8XJv401/CUxL0ROI6ZY8h64nB9deqMiD69girqkQ3nsKNoTseRM0p6SsgctiKIx1Fwr Da1/CAzD+vPzBxDqmtZVA7kwFA0koZHg8SZqF3vCueulboq+XrY7c0w== X-Gm-Gg: AYBFou33Joxy/bqwqb/deEp/dNZRABeXhkMhJgX3v5SvAc8oPNF49AcvSfYeiTbn5Ak gTd7avmMcNs8QYpr2PxwW+xVrQ5ifplvS6gZMeoM5pN1lgazPU0xw3R4HMfLLak2uHlbqVrKkZI yX2hNNo7voK56xs9T4fLlFTKQ+gS2uLTyVC6BmkOmybkBdlX6NTsxbxpH9ElcSdti6a3xzbEszy 34Y6yA1vB+YfCREu4Rk8ThyVQt2FdC8UpSb0eaS0yfJsg3q7FIzR5DZfkR8fGfnHHjyRTFclPF7 Ho9duvoJmMkMyn7Hvf6lJUkNRCZg754lJp7TMHKpkjy8prtGv+H/fkUuJZC1pxwQpQ0J84gW/UT KtPbACdbeISwm2o1inmDzp9RDXAE= X-Received: by 2002:a05:6000:260b:b0:48e:870:7791 with SMTP id ffacd0b85a97d-495844a3471mr6263602f8f.26.1794225543174; Mon, 09 Nov 2026 03:59:03 -0800 (PST) X-Received: by 2002:a05:6000:260b:b0:48e:870:7791 with SMTP id ffacd0b85a97d-495844a3471mr6263572f8f.26.1794225542646; Mon, 09 Nov 2026 03:59:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794225542; cv=none; d=google.com; s=arc-20260327; b=Lv6rc2T2AGuipGWSEht1RHx4LCsjFFZD3/iZcWZhHpCRjK/LbQHtMSEWGW64nH4bVt eZEV2d+fAAbsIOWrljyfscKkPcGeeYVRex1oNFuWk4xMf1JcJZhAJAqnl3SES3aixwhz Mw+/Bm1fXK/TSdMo6EBBn6IyQd4MdVincZ9NVtbugPPz+AZT7R4kGW+6z9VkrYggdv96 VLfdVA75stwqr9JxG3pWutOjDJ5u8VwzTatxZcqVzJF9IGRGpX67FtwHhzINbEqUPPY/ gYl31QQQg6/9SxbIK0TE2mN4Sp+hIP5NJtcVUu/bzPfL2fgnWboV5azZaWchFhpLyHuq CXwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=hTcbmeOi1Q9h5AIgaqcABnxcM5cC9shohV/G9PHFK6s=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=jftFux35r2Zsys4Bo5jYsA2vZlmsXUNaxv2fc4hF/UJO/Az0WHAJV3l47aapFYPW1s i4LDfwZAW1wXw/ZRUtwssNMaB+Ai2SsOqwNGiIin3EkBJ9dBNyiLogGGNxRsi7+rQEsJ DSD03sz0RD4tgosE4iwyEGDIHSTGwWaf2anovuJSIbBg7GLJ4wQt6+jV6EZC2fCKrcHQ BVhnN5opAm1wqK6y4dn0oRGdV1IO5rMtegPnxG1RXD6eqw9a/eX0ALyBmgPC1l7xGfyX vELk19qdcsMF4h+FIzgHdnFM542j9L8bpHHvAg9nd4GOj1cqKqRMiUrdJJELbhFq6SeV yFfQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="L0vy/llD"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-495984ba28asi7754495f8f.369.2026.11.09.03.59.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 03:59:02 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="L0vy/llD"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=hTcbmeOi1Q9h5AIgaqcABnxcM5cC9shohV/G9PHFK6s=; b=L0vy/llDJK6/ 1R0AXpTXSVr3+oz1lO/yFKyaDXzDfIyLGGaXV4fZO2jfYZOMZAyxihbx3ByrJC9agQShKUXfY5iNx caj4x0DKLDTuhS42dMLjZ+1vpvPObMH4IQDrStsXFQsgezMu+2/lHdPaABYWBBwHrqDD85V3ZXXRB JU7IHTPFyN2AHDMS6ELeNRzROv9DfYY4fMrHiLnoecvaaqOmMNMAolC3yhcJQ9YAG2Bs/fI6bKH/s 0n2clkkFKXNaVfYG5I7WF1DUqb5xW8gDxa0ShmVMM/rOd6xyWxgxZ6VipoLwHAQb+sECjiSCyvcc1 02k2SWKa5WB1UiPnM9dfFw==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xQNxa-003a4R-0E; Mon, 09 Nov 2026 12:58:54 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Mon, 9 Nov 2026 12:58:51 +0100 Message-ID: <20261109115856.1362416-6-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261109115856.1362416-1-alexander.ivanov@virtuozzo.com> References: <20261109115856.1362416-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v10 05/10] dm-qcow2: flush lower md before clearing dirty bit on merge failure X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When qcow2_merge_common() fails, qcow2_merge_backward_work() clears the dirty bit of the lower image right away. qcow2_service_iter() waits only for the service qios, so delayed md writeback of the lower image may still be pending. With kernel_sets_dirty_bit, a crash at that point leaves the lower image marked clean on disk with refblocks that lag behind the merged data. Flush the deferred activity of the lower image before writing its header, as qcow2_merge_backward_complete() does. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Fixes: 222b6f1291c1c ("dm-qcow2: Introduce driver to create block devices over QCOW2 files") Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-cmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-qcow2-cmd.c b/drivers/md/dm-qcow2-cmd.c index 45c517ce0ef8..3bccce090f01 100644 --- a/drivers/md/dm-qcow2-cmd.c +++ b/drivers/md/dm-qcow2-cmd.c @@ -330,6 +330,7 @@ void qcow2_merge_backward_work(struct work_struct *work) ret = qcow2_merge_common(tgt, qcow2); if (ret) { set_backward_merge_in_process(tgt, qcow2, false); + qcow2_flush_deferred_activity(tgt, lower); ret2 = qcow2_set_image_file_features(lower, false); if (ret2 < 0) QC_ERR(tgt->ti, "Can't unuse lower (%d)", ret2); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel