From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5002B8017D for ; Mon, 9 Nov 2026 14:03:31 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9E2JbI032583; Mon, 9 Nov 2026 17:02:20 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9E2JbI032583 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ZD4XAmWW" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9E1l6T032506 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 17:01:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9E1l6T032506 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a359c7f47bso8314515e9.2 for ; Mon, 09 Nov 2026 06:01:48 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFjjqL0vylwQGD9gmR0zCzUmhu3U2nmIQO2DHG50l5LzHhA8tFt9AAD6S3zFj/EKTgYPr28bQ==@openvz.org X-Gm-Message-State: APuU4Z+lH64K2P9nvQ9fFq5LY6d7EcRtSwisoZjHCpOzAp/vgKFdDBYa uYqSqg8TTorhx3zxRbCCEodkzjYBeEEFCGWmUpF7iFMeayhEQZiQex0rFTgtqFBtVJLTbbVvX0p fjpwDzGqzWNUykUyCU9lpN70mQBdkTOz1QrUd9u02I80t8PfyBW+28w== X-Gm-Gg: AYBFou37VMK+EnfFVThEO8WStCX1KJeLOLA04QDVV052KwsXbT74/g9KVqFNEMXf/+W qMFqJKCjydI3kBRoFAECsYhLshj+iuUgKgCt3TwGN6553RvWXjU1YfYpGl+cyd7F6dPH1hWIQee kqEOls3WxgOZ8K6P205E6+oHBM2ebCZtwcwSJXyWbWIsAMWdTwW1Z7xj4bOVbZlAndp+7jri24t u0EsFHfM7iA2ssm81bZVH5LF2gnQ4vksGleSZMgUcIVdExvqPQV8tPHmjTlsz6hcr5gqRQ4ze1S POQkznc8/TdBjUiU1MuqcZbwtzruP4KW/ti88aPPT/uUKR4Qmci79HDhkPIpdHfDd/Pjs8F3la2 Q0ozW1oAxloD7C7/eXempw3akJ4FR X-Received: by 2002:a05:600c:348f:b0:4a2:cbe:bebc with SMTP id 5b1f17b1804b1-4b963c6d9d0mr81351825e9.23.1794232907524; Mon, 09 Nov 2026 06:01:47 -0800 (PST) X-Received: by 2002:a05:600c:348f:b0:4a2:cbe:bebc with SMTP id 5b1f17b1804b1-4b963c6d9d0mr81351235e9.23.1794232906918; Mon, 09 Nov 2026 06:01:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794232906; cv=none; d=google.com; s=arc-20260327; b=cQh16zUwSklaQcrbWH0c8X0nxAFj+Zm1XVeGtT+VaobZa1woG3UV5SFuK9XTraBwmH kFYsmgR0wDrlfPu6IeUAzIFXkLGgcvqaWPjmtgE8lFSZfcXogVuF72fMD2BwKVycG2bW N58ib5C3CMu9AvtIWuT1dT+az83UIZ2qUqujYMJkD8/S0HKPImc0KqbRvxU3qS7GAyWJ BRF54W+DxRQyRqlwZgwPmxL3Y6UIvRA5dc1STiwV8+idp0WShNOmdVuw4iLZUmHSEQu3 ovedlv7fVS0NO+hM1jr6lsOPLSVdspCoVA/eQgFp5hW4y4eD+4KQ4iGkCRXUrSAJRii8 p2LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=hTcbmeOi1Q9h5AIgaqcABnxcM5cC9shohV/G9PHFK6s=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=dIOXI8KwZ+u+q/yaVz6J1eaf08DnFFzYVMlCPfEM5Di8k6bdZkBwaMaTpkrX2mebi+ pNy3FCCncvuGewGaalaHvTF4Ezy5dUXnRHN3lUqpWxktRIYvOzvTLvLt3Pe4GBlA6QEo FfoL45J722sm5kkDKKRudRhGyzEEYil77kQHkeVMFAWeIREVU4rwwMPN9pmt1Y7+Ng9Y qGOCHfXrnPGHbFfziOp4syk5rInkOg6I9rEiPxnrwc5eRDOUtNlvZx/OdmAmo6Lg0D9S jUFfl10dySlz3kn/ISEifRnsfKWpuEZL4eQmZplyM2m91ovmT04GpsN1NF54L3KeJMfv kP3w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZD4XAmWW; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49597b1f7bfsi8045151f8f.242.2026.11.09.06.01.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 06:01:46 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZD4XAmWW; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=hTcbmeOi1Q9h5AIgaqcABnxcM5cC9shohV/G9PHFK6s=; b=ZD4XAmWWq0OH Y1T4ca3eGvP8pkrZt87KvvNuVJ8otJkKZRfJ/1wV0cRzc8tHaypITowOIbLm3itHsYoS+HHSob+O7 j+yfbPq1pzzwjo+pVWOL+HacxowqwwyQzhU0WxkF1JU+zr9/BfAETjMx/DYqJWaP/UtuXMN2g6qeZ 0h18IhfG/qXocJsKLA9ZkPcy0B2loRhhYi1/Jfx9bTGm+/DYbxg+pZGWtKxRY9Xi2DzzHbf+HSyy1 z3b5mpghBSl3OhgrY+bsKuT23NlFIi0azx/vaTd2DKPwDqb2/2SgDcdlPAqTbAaVABg+eTjoFn9aP uvzINVqkMwLqLJqQ6f9nVQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xQPsM-005vFF-07; Mon, 09 Nov 2026 15:01:38 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Mon, 9 Nov 2026 15:01:38 +0100 Message-ID: <20261109140143.1408038-6-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> References: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v11 05/10] dm-qcow2: flush lower md before clearing dirty bit on merge failure X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When qcow2_merge_common() fails, qcow2_merge_backward_work() clears the dirty bit of the lower image right away. qcow2_service_iter() waits only for the service qios, so delayed md writeback of the lower image may still be pending. With kernel_sets_dirty_bit, a crash at that point leaves the lower image marked clean on disk with refblocks that lag behind the merged data. Flush the deferred activity of the lower image before writing its header, as qcow2_merge_backward_complete() does. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Fixes: 222b6f1291c1c ("dm-qcow2: Introduce driver to create block devices over QCOW2 files") Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-cmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-qcow2-cmd.c b/drivers/md/dm-qcow2-cmd.c index 45c517ce0ef8..3bccce090f01 100644 --- a/drivers/md/dm-qcow2-cmd.c +++ b/drivers/md/dm-qcow2-cmd.c @@ -330,6 +330,7 @@ void qcow2_merge_backward_work(struct work_struct *work) ret = qcow2_merge_common(tgt, qcow2); if (ret) { set_backward_merge_in_process(tgt, qcow2, false); + qcow2_flush_deferred_activity(tgt, lower); ret2 = qcow2_set_image_file_features(lower, false); if (ret2 < 0) QC_ERR(tgt->ti, "Can't unuse lower (%d)", ret2); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel