From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D24E18017D for ; Mon, 9 Nov 2026 19:08:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9J72MU002892; Mon, 9 Nov 2026 22:07:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9J72MU002892 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794251225; bh=gb3SQBMDf95eySkEuJBbaVz/QntEP0kqeITdKw732qA=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe; b=qARtOJkFL4jhI19nxQqJasvCQCE3IXlZkHKX0miYumRWc9Wsl0ZPgQD7Io56+czBz hs1VQBMq/mY69WdBYPZ8fMZOvpZAJbNEzL9gOF8ndtqRI6e1tsd7vyICcjYm/wdNqp Y1Z9lDVyuiSIZh9yHTT6vVs3KA3UcQNTvl4eAzELp6v6qtATEKfKnTsO9wzLj1/RPY uGhkE6hs6Xn1dP1VPBS6P6CUNcNb4kvF/XlWVF0pBBFPIib90eKVKJx4MYwTyt7GJF elP8woaaUENuYvVZj/BVLDhWZELRGt6tsXcaxdpa5/hQzUHag7DYD+1r0NOvl6aeJ8 aF2tEXFsbDHMg== Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9J70La002886 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 22:07:00 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9J70La002886 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="ZoBKV9cC" Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4915ba023d4so830963f8f.0 for ; Mon, 09 Nov 2026 11:07:00 -0800 (PST) X-Gm-Message-State: APuU4Z8n+CJXvW8D8G3mgEAd+vymfRjeqjES3oCf3XtYz3r7XJENENsC C7l4eTbZzXv9n21MMCn58DX2gpjOZvRaZ6AwvT+XDMkVFG17WUHS5guClrq92zQe9Gyq13Co5Sb m3Wo0BQvZFdxObI2aVK+lTP/1KkBy3COfOdlbNYHD5KuikP1k8Y5cxw== X-Gm-Gg: AYBFou1i6ry5kodFqmBf+Xve2URRP0dSYH6bhJRYa40dyAiQqU58fC4bklzehSdNUk9 NezIRrCpnh6rk62In5glF67zyZlR3iQDVsd0P5EoQpCvHG/16q04P08mzrZKbVoBPfpyZlYlfUu +2p8NyfCYQKB/K0en7QhgQrPwzTYKFmWpUDFX1HfnIfZtt2BeCyjz/tRuIM0PXwc54TmJT4qlnA 06Iylc6QSb6eKPnkCRSvNr9mNFDbq5gM0lfLRyCh03/9MaP4HUn37tj6gp7rOMb06C/FYRbwn1b 9yDTyjCLug== X-Received: by 2002:a05:600c:3e14:b0:4a1:ce33:1536 with SMTP id 5b1f17b1804b1-4ba0233fa1dmr2535345e9.9.1794251220445; Mon, 09 Nov 2026 11:07:00 -0800 (PST) X-Received: by 2002:a05:600c:3e14:b0:4a1:ce33:1536 with SMTP id 5b1f17b1804b1-4ba0233fa1dmr2535125e9.9.1794251220067; Mon, 09 Nov 2026 11:07:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794251220; cv=none; d=google.com; s=arc-20260327; b=AZElkhSeFhDDLDWFQALJVpxc3X2j/1OuncRsgUIW4NKCwqqo0UbP/HVH9My2okWNtp SI9pEtCAeqdwovXxMKyjGfFFNDXptQBopUC1o1J3Q+i7WdsKTAkxMJ5i7l5yyzeG6Jty DtfBDb+DvrPdu+EHUdnjXVKLcd2JLDzejzDeCC8GebCebPRuJ6V6FI7Uar4GXhrNmhp8 pedsTaxrT6viLHHy9MpURdbcph14MTX9Y3QIuQ8YkjkOh0qmxnaQ1aa53ykFnGa2PMHt k2OekF16bmpIHC3BlFykYzmWgsGHQvEG5+oGhR1hEqdQBdGNLtNQuoi+ksmr14fgRgrz HmzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=ciw6/dsgaUz4xZht5gDQcTAUT0P/bPWub5a0QcUBF2I=; fh=uKyv8CX20pIv0edA0snNI8OF5jIxi29DT778HkdeB4k=; b=VHygGw9gd4B/mbgjkl/wIIdWtDqUx5u/hvF8RzdN2x0ddo+/mt7qpLotcfe4zVl5zH eIOaxnCcQWy0U0WygDFwD2PEZ58B762CtvZcIyFuR7ymGOweJAHOqNaPkOtwDSlWBTjH qW98DklpTb+WU5ITkqZ/y70i3okf/kPCxvFEhqKnmGP6DQmNxW+/f6Va3kenbEp33qw/ oS7DV776TB/4KepWG34qwZzZJJ0kp4n6g3P4u3Yn5ZF98FhgvdtBkCEGnH36a/kWui5z k1Oo4D1MxtzcoCkP24P2V8c/L0xERRGwyBzMKUSAepR9ijgolvmROLNnGKhbfFGDolGa Dm2g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=ZoBKV9cC; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:dcbf:4b53:b63f:3b41 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-49832a36e6bsor60906f8f.5.2026.11.09.11.07.00 for (Google Transport Security); Mon, 09 Nov 2026 11:07:00 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:dcbf:4b53:b63f:3b41 as permitted sender) client-ip=2a06:5b06:b600:300:dcbf:4b53:b63f:3b41; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=ZoBKV9cC; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:dcbf:4b53:b63f:3b41 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794251220; x=1794856020; darn=openvz.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ciw6/dsgaUz4xZht5gDQcTAUT0P/bPWub5a0QcUBF2I=; b=ZoBKV9cC9NlX/OW6AtlsKvE7QwocMS/8QnjroQPo7Ti+Et2xs5Z2NqfL9cCL//gjOs 7cdS0ckVf7bCr2hBgiTb+zZiA7wY1gwq0vYgCdGFDyrOLX36WFUCgIsi0ZMPCI71lcYF DIlOEBEh/riTgi1ehC9yWVTfO15A+zMId7INJfNL7UOM2v6wpO1a4LQIjISSHchR2J0y KdHOgCvNDZ4SnQwoL3r4tc4fce72x5+7jWPUtWiR+VMAAo4DQsuqab6OTMHj9qz2dR/q EQvGLRkirDAS5cflV/XZuS3cpu5m2GZAHCWmRS4OPUqE/H7OadxEPmwDQfTbdZfkqzHO N6xA== X-Received: by 2002:adf:e004:0:10b0:490:39ba:4359 with SMTP id ffacd0b85a97d-4982ecf6efamr490565f8f.23.1794251219671; Mon, 09 Nov 2026 11:06:59 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:dcbf:4b53:b63f:3b41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-498366c30b1sm542084f8f.46.2026.11.09.11.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 11:06:59 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com, andrey.zhadchenko@virtuozzo.com Date: Mon, 9 Nov 2026 20:06:55 +0100 Message-ID: <20261109190657.1851487-1-den@openvz.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 0/2] dm-ploop: fix writes held on ENOSPC never being retried X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org A write that fails with ENOSPC on the image is held and retried by enospc_timer, so that I/O resumes once space is freed. The timer only sets a flag that the dispatcher consumes, and nothing wakes the dispatcher, so the held writes are retried only when other I/O reaches the device. On a device whose only I/O is the held writes, the writers stay in D state for good after the space is freed (patch 2, VSTOR-154182). Patch 1 makes the destructor shut the timer down first. Nothing stops it there today, and with patch 2 the callback dereferences the dispatcher thread as well as struct ploop. Found in a vmcore: 16 writers in D state, submit_enospc set, all 16 pios on enospc_pios, the timer expired 12 s before the crash. Tested on 6.12.0-211.52.1.22.19.vz10, dm-ploop built out of tree: - 16 O_DIRECT writers held on a full host ext4, then the space freed with no other I/O on the device. Stock: still stuck after 60 s, one unrelated read releases them. With the series: done 8 s after the space is freed, on the next timer tick; - ploop test suite, make -j48 test on dev-cl04, green for ploop and qcow2 with this series together with the VSTOR-154096 one. Denis V. Lunev (2): dm-ploop: stop enospc_timer in ploop_destroy() dm-ploop: fix the ENOSPC retry timer not waking the dispatcher drivers/md/dm-ploop-map.c | 9 +++++---- drivers/md/dm-ploop-target.c | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel