From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2E2B7813D0 for ; Mon, 9 Nov 2026 19:08:17 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9J76Pv002905; Mon, 9 Nov 2026 22:07:06 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9J76Pv002905 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794251227; bh=GFCwE66QKig7Otc+h0gPGie9Icre+5ivInFmmNB7fU4=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=gUX/wBfnkCgdM1pXjokuNttqiCGsButANq9X2K/M0owoGw6vgDxjFIf10J6NS/EbB meZD4hh9AqG/uMLqb1ZchSMWqYC7qnPo29Z+45BqJolPPhyent+t89+i14USR/RFCn 4k0w0G+rYkwsLwNenywl7IwXE5R8NTkejcrC3ZCrL0qnXzs6YoMv27XYLt8+aMhB3o 3KnBbbsbCx37ca2ttCI5gRClpcFKLM+tl5hBEqmBgZFmtfL7kyZFN9msXFYlCRa+dm smGQjS/O1ILNSix/bsiASP8wGlvE9BaQYl0ddkDQcBfL7ZqhjxhaBdSkYc/Xi1oE4E IJMBE86REHzyw== Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9J72MN002890 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 22:07:02 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9J72MN002890 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="Opj+/nyi" Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a70b42bab0so11765535e9.1 for ; Mon, 09 Nov 2026 11:07:02 -0800 (PST) X-Gm-Message-State: APuU4Z9PJDCmeYXsxhr8qw8d3s8iZi+IRdpdMjpQ9ub8oa5nYCXVACSI fWwa+VUtAv9KNtF8THPnVH1YcaVagBVJyxV1YU52cpuW3KcKvRlQ1M+ROaxhKvkbawHMCpHJ+zX bbKbCQDcnbFq48dMYLjJ/RTaLVdM7H8oZKgBU5/ki8HVlnIvMXQipPw== X-Gm-Gg: AYBFou3W7i2in2GBnBNf9xgRu7YwlzC3VzlQPIYq9/kXOZIn4vHEj563zqOqOXEJiLD 2u2vl1GhrsFHMkIc2qgIyV7p7YWfAmVQpAAd8PBb2xIvIhjk8rOLvLBXBvgFtxInpmQty8tOP0l iQtL5zJV1lzng1dOpKwuaJzLTm31MNyXP2JgfgLNda1p9ngkrpeCbzLSk7JsjEkpB1roiSfMUFd zUPrv9kSO1VgcAEWdMoWU9lDhOg9FKIsQ+XDegrKA+RE4W/v/Yw+FZl6oQDB0vHX37C0JmlQGKM RBoAwixMnA== X-Received: by 2002:a05:600c:870e:b0:49f:c5aa:9ef4 with SMTP id 5b1f17b1804b1-4ba0234267amr2958135e9.8.1794251221886; Mon, 09 Nov 2026 11:07:01 -0800 (PST) X-Received: by 2002:a05:600c:870e:b0:49f:c5aa:9ef4 with SMTP id 5b1f17b1804b1-4ba0234267amr2957685e9.8.1794251221429; Mon, 09 Nov 2026 11:07:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794251221; cv=none; d=google.com; s=arc-20260327; b=nWFF4HC6Ve/W5MFU49XFLB0J4tA+gMgRq2OTsP7nr84FAYXfEHI2M7CZngezp5y36g VrNL4sDR56gaIjNdpUykDoQNXYMI14i3dlFDH4rAjSJHOvcrz3OiErYfTwglf2RqM/jG OeNQZVi99tLinTCj2qsnTSHV9oELHYtzeEXAOjpXV5RmNa/TEVHTwLNvLjYWlDqwE8N8 xdTQwjEmuFScoSpN41wIld74YGIQE/LcLM1AswPWpveSOUQIWn78qtF8Bz7jqA+7RR+w vrIIZe/5WUt02y927Crcg6Yz+ppvjLsm14c63X5qut/Re3f4eYMlLcRVBJjr6jTSeuRO rnRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=hP6gPaDaKC/qjeGmMdb640zc3wgkaklo5JhjA6h3a1Y=; fh=uKyv8CX20pIv0edA0snNI8OF5jIxi29DT778HkdeB4k=; b=W+bhwud4Ug8sJO5aInZwta0fQ/GGDRzAg+gBNeRcJ2FOFHTCUKTOzfCzUjakEEtP2F BmyVPRnEjIWmIU04SeCM4XyKZuez1xLXijzbrJczgGBUChYCD4kjNUq1jkw3jIjDWIkX mthu8dpPutouSDRH2iwO2Yqw/21JXBX1o1m3kdhZQGpity9lwWWTDKUySztGvj2hmVZs 9A7wSObG+tjNHLD6mgMWEQNnoDkazVrmmssDov5kHToqklB6OXKAnl+Ih3A9h0K76C6a PNGxIxtaykbIXaQGv2y2OcoSVc267ycY42U3LLmxEp0N7x80eaByCxUIs9F3TZT3pI/A I0GA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b="Opj+/nyi"; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:dcbf:4b53:b63f:3b41 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4ba0223c2aesor516965e9.8.2026.11.09.11.07.01 for (Google Transport Security); Mon, 09 Nov 2026 11:07:01 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:dcbf:4b53:b63f:3b41 as permitted sender) client-ip=2a06:5b06:b600:300:dcbf:4b53:b63f:3b41; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b="Opj+/nyi"; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:dcbf:4b53:b63f:3b41 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794251221; x=1794856021; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hP6gPaDaKC/qjeGmMdb640zc3wgkaklo5JhjA6h3a1Y=; b=Opj+/nyi0OgnG5QMSmIsN4WHurFZT0DFmuohKvJzFQFZyEPkklR0MBl66c8A9SgHTi kwNQg1tQiKBeYYONxZzbXtZ9/OvGgsEgzhaBhWK77hckr2FVrGkCPn7MOPGvl0QtoC49 3+Adrurh8f7l0j9h8GNXirvvDX4glj/QRAJkquJgdU1PiwKMIgo/Sr7BwqB1ijq7AtQd 8rymFmWR0T5scvkA7VEMuXGXTyW+hzY2Kq2jihsfIxnb0UpWacUe+BTC6gKQFINYCwFf vAoLMlre00ZJtuo8x9+wq/OTwg6ouCKSFVX0fMOWep75gXEBh3G5fzW1Omfb17FG6SWW TtjA== X-Received: by 2002:a05:600c:540f:b0:4a1:d766:758 with SMTP id 5b1f17b1804b1-4ba01dbe8e8mr7898055e9.16.1794251220964; Mon, 09 Nov 2026 11:07:00 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:dcbf:4b53:b63f:3b41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-498366c30b1sm542084f8f.46.2026.11.09.11.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 11:07:00 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com, andrey.zhadchenko@virtuozzo.com Date: Mon, 9 Nov 2026 20:06:56 +0100 Message-ID: <20261109190657.1851487-2-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261109190657.1851487-1-den@openvz.org> References: <20261109190657.1851487-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 1/2] dm-ploop: stop enospc_timer in ploop_destroy() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev The destructor never stops enospc_timer. ploop_presuspend() deletes it with timer_delete_sync_try(), which does not wait for a callback that runs on another CPU, and ploop_try_delay_enospc() tests wants_suspend without deferred_lock, so a write that fails with ENOSPC around the presuspend can arm the timer again. The callback dereferences the struct ploop that ploop_dtr() frees. Shut the timer down at the start of ploop_destroy(), which waits for a running callback and keeps the timer from being armed again. The timer is set up before kt_worker is created, so it is valid wherever ploop_destroy() finds kt_worker set. https://virtuozzo.atlassian.net/browse/VSTOR-154182 Fixes: 6ddad5a4d226 ("dm-ploop: Add ploop target driver") Feature: dm-ploop: ploop target driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c index d8279c79ef56..5ab25cbd5c32 100644 --- a/drivers/md/dm-ploop-target.c +++ b/drivers/md/dm-ploop-target.c @@ -164,6 +164,7 @@ static void ploop_destroy(struct ploop *ploop) int i; if (ploop->kt_worker) { + timer_shutdown_sync(&ploop->enospc_timer); ploop->force_md_writeback = 1; wake_up_process(ploop->kt_worker->task); /* try to send all pending - if we have partial io and enospc end bellow */ -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel