From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DC7CB803BB for ; Tue, 10 Nov 2026 07:53:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA7qaeb011981; Tue, 10 Nov 2026 10:52:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA7qaeb011981 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ZEb3a1NW" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA7qZ97011977 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 10:52:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA7qZ97011977 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48fbcf023dcso1000434f8f.2 for ; Mon, 09 Nov 2026 23:52:35 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHKveNhRaRTAG2IAEthqKjHudzXUcdZiidBv/YEL/6XKj1AId9DbuxIvkquMDhvPOuxrF3WKQ==@openvz.org X-Gm-Message-State: APuU4Z8iouIrlB9QhVeipUdWf9ylouPQuYI3i0xnztczSHReWw9x3SN/ QISr1HWAzSFhAe1DZ8cxaOZWyKw4R1Zo3KTksw7OwDS8rnLFiYyPJ9HPQNgdv5i7jQAvl+0tQQo KUzhHj0Yyeor+NmT7L/42HRbjkvCVNaW5J/Cyhoa/OKiSNO2dpJsGeQ== X-Gm-Gg: AYBFou1r1dreMp6ED754J6SvOMjEhQz8+9glbduBvh9AotIrMCazyA7K2T1YAmbMBH1 QLkvTheRaIVDbUyd8ysxsRoEgNsp+Kd6T3Tb5pcmhrS7NmUjquBPpGLdZq5dTbLPwMguW8VovlX a1D2XjWDOSCzj11PkqJBQYbB1GFqVwj1gT45Pc4meuwf3qvbNzRv8XR30cCpon4f47vt4OpDONC HBDsfX2g3xh+3TFQED/sJZHJ1Rs/VkjhLngz11wnkdaV1oTbnHpZSdsqLFyGK1JuSOK2g+BsdwE ccPgaTDdmrZr5VjjXLn/9HKxWzZjswnAEj8Fmcs1Z52zs2IijW68Dd8iuP4YXPqmvDR4HllD2Hz iFoYCusGlu+Fgeozl7nyPz/TF+Q8= X-Received: by 2002:a05:6000:24c1:b0:490:ef5a:bf39 with SMTP id ffacd0b85a97d-4982c7991efmr3601597f8f.6.1794297155311; Mon, 09 Nov 2026 23:52:35 -0800 (PST) X-Received: by 2002:a05:6000:24c1:b0:490:ef5a:bf39 with SMTP id ffacd0b85a97d-4982c7991efmr3601566f8f.6.1794297154797; Mon, 09 Nov 2026 23:52:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794297154; cv=none; d=google.com; s=arc-20260327; b=YR6TulAEE8HQCvooZM1EiywuRTqWn51KDXgE/1pDDdi0vLXvuYPOQpE+jO2SnE9x6x d28dTVy0sGgCYgPRo1cEbaLvdht5GlOmPW9ufRKolNj7XUzMfTZXLeEmcre61oJuzqae GTsYlwhQaX8Igq5NLut8ilhaIGeyHG8yvHVJLpOWE1L5LR6mUUC+UDsrHnQnWgKcWNHp Pz2vtUemxKH3QXwnOQvv1SbB19BzPvc5ZsJ8c2eO5uFLKHfGyHpefAyCtZ/zDBtZmLFV VEhvCxQceIuEpiEHy2xUl7kY5L7FmlAcCA7uVlrUqNUMtqm9Tzi6omgDonrDv7B/c74K 36hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=TfGZNBNgNH6PjyW9fRUBOYRQD9pV/Jv6O6vbFOZNnA8=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=Vj5YO+pMg1DXGUV1bgs3p32cGoFIdqr2pVxasO8JSRrDXxKm0oSeBVxHW9HCy1JlFS lFuMWzLgEKNgRhB9d2akRI2PmgTnS4jVoTLzK+JgIf5SBIlwuFu4CpD5dRFjmy2pUMAR mhfDmaOgmgO90O9wPCmeeGIRDnxflVz8ORhEDpqUIrCNG7PH90tswoettWEE4dKVLUKG jAjfA4wHukm612XeQjxcbgJGv/OHmknzDejJX4Abv9vhkP/RgEmQzpXFRVNA6ySJlSXR lvHGur/KY8lB9zatqbRB5N3+LPFfB7JbhPxbhPksdUsRBa8xOgz/FNFkJXhrchTe7R2T 7iGg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZEb3a1NW; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49835f16a28si3283094f8f.167.2026.11.09.23.52.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 23:52:34 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ZEb3a1NW; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=TfGZNBNgNH6PjyW9fRUBOYRQD9pV/Jv6O6vbFOZNnA8=; b=ZEb3a1NWP8fM 00V05HlxiXexWvtE+ZxdhF7QElQLD5QqrnDRj8Z17ssV94Kprg5vCQXdu5tzRaaTQF62OfPUHrzcg q19yIiKVuXIPGDgIeu7n1hiMPwVAXj1PWXTGCmOpShCzldwfUd+Ys08Wkfm2g67MrenavyT7XfmMx ng1be/yxwGlIZocYTckwEFQDOELyTi53nPzybzevys8cGoaqlfQGVM+seQDqxIaOayy8JaFpRMhtH vU68V3zeEW1VRAu+O8HMNKsG56bw7DUh8h34GtQAEX0mgpOm75q3QQZA9F1dbk90XyROYlG+HHK4J 9ra2ylg/6Y9bJ9E+QnbFig==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xQgZp-008dOX-0g; Tue, 10 Nov 2026 08:51:37 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 10 Nov 2026 08:51:40 +0100 Message-ID: <20261110075140.1475607-13-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> References: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v12 12/12] dm-qcow2: fix WARN in qrq_endio() on flush failing with ENOSPC X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org A REQ_OP_FLUSH request is completed by do_qcow2_fsync_work() with errno_to_blk_status() of the vfs_fsync() result, so a failed fsync with -ENOSPC ends it with BLK_STS_NOSPC. qrq_endio() then hits WARN_ON_ONCE(!op_is_write()), as op_is_write(REQ_OP_FLUSH) is false. With panic_on_warn this takes the node down. fsync returns ENOSPC on file systems that allocate on writeback (NFS, FUSE, thin or reflink backends), and when ext4 or xfs report a failed delayed write. Delaying and resubmitting the flush is already correct, so only let the WARN accept REQ_OP_FLUSH. Fixes: 7d49e18c5c36 ("dm-qcow2: Pause IO and notify about ENOSPC events") https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-map.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index 823b2e23644f..c2154c4f6f76 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -4491,7 +4491,8 @@ static void qrq_endio(struct qcow2_target *tgt, struct qio *qio, * callers receive -ENOSPC synchronous without intermediaries. */ if (unlikely(bi_status == BLK_STS_NOSPC)) { - WARN_ON_ONCE(!op_is_write(qio->bi_op)); + WARN_ON_ONCE(!op_is_write(qio->bi_op) && + qio->bi_op != REQ_OP_FLUSH); if (qcow2_try_delay_enospc(tgt, qrq, qio)) return; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel