From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 27A358017D for ; Tue, 10 Nov 2026 07:53:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA7q24E011922; Tue, 10 Nov 2026 10:52:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA7q24E011922 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="lrzY671s" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA7pk0j011860 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 10:51:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA7pk0j011860 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48e4d1e29f3so1627108f8f.3 for ; Mon, 09 Nov 2026 23:51:46 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErG9LJG/P+J/5bF5PCLrd9GmOSrfYpK69aHiGFyLOpFNvuvc6kGUrKTBMesyXIWdsmRYOyQA2w==@openvz.org X-Gm-Message-State: APuU4Z8ztZ/chB1g+SFqt7ZuD4dRjrb5Yo5JGC8fOqQuQuKpz1lJD8Oo CFAv7ZXO6HKBFkTKqYPo2iFy1sTNarkQWWMaMpacSz3esZ/Te1Rqub17LV20tWcKchuFjGuU2iO 7qjAE3OJYX7mSzzcxaaD/HWgegNyqVPMvX7/I3sj1jjk+Rd9g+Zs0rg== X-Gm-Gg: AYBFou1qAWi1NeL4LhwRldISAJBTd7VzFRLacWu0OSD+FrZHyJT02EEoHTHF7eXV5/N d7YU3HAQjnfK2ySHUhmzN2deCHDY1nw8je6B6s3WqDQPj9xKz1HHeOBiZQObySsdPLvQU5FvSyP C+JHprQtPrcEGY6a3q9Qo71m1RYv3kCeC48P4QUTj5Cv09uvh5OuAPaIlShFBOS4Yok5R5y6qPT 0YFaghrNvdn0LA/96rnzBTs2kmVVkgWCksFU1L5xm+COEusEvZcPOupdyaKyQFcNnWq3G8COFm5 grXdugeykqNF9kT2X1nNt2NsafniiLRwNuLlmkj/Rug0sVYMCTU5gCzEPogs7+RD8435lSIy2Ef +Gu6zbTxgc4xS6g15RjYnEldehZM= X-Received: by 2002:a05:6000:310e:b0:48e:932:af0b with SMTP id ffacd0b85a97d-4982fd3e055mr3638891f8f.32.1794297106000; Mon, 09 Nov 2026 23:51:46 -0800 (PST) X-Received: by 2002:a05:6000:310e:b0:48e:932:af0b with SMTP id ffacd0b85a97d-4982fd3e055mr3638861f8f.32.1794297105614; Mon, 09 Nov 2026 23:51:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794297105; cv=none; d=google.com; s=arc-20260327; b=V6E2u2tBAFP64U6wXQqPp+eB0CIGNWht3w+zW7SPPBmgAdhuURREwBHTBc58k7ZV5u /qpG03LTF0ZXCR9qRjm15j/P02eS/2l/lluSKxOnwpCmYT8CBe6YJJC9H51ubdzspMiv KV//B+Q/sh3sl8i3pdYhddYhpcmz11phm3oxHmAXLSWxbu+2hKBMwNvKQdQqzCFOS3yi 6rvVWGATjBS2MlpWJEIYQ0aMX+F05lNd/NDbw3RvlMUA6QAG6P5sL9f2Ebu5t49+nzBv krR1quS24+cRdeYKfPXqpp4lXgJkIWM87R5ZwDUn50pIQ6eXwJymGpRqtXE8tSX5EBX/ tBug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=hTcbmeOi1Q9h5AIgaqcABnxcM5cC9shohV/G9PHFK6s=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=hB6OTXqZX071q1bPKQmtJ5xjbYw/6DDcS4zYzs4jb8TePFU2BydWpl2jR8BfcJ5/xA Rcd0ShC8TII2PLvQs9sI/VvnMufO8oNJZRKYMIBSUA+qOp73IQ7d/LD2Ks7Y3UsK6n+4 CFYXtre6rKXLSbjmmE3MQ3VIidL3Jb+XOl9DKR1lTy509mhlWNkm4joV19g1UPzue//6 0ZdO2MspaRlGzAnBPivg0c3Mf2gW1EDBmIfp3JVRUKl7OHXdVI6VWcPurtd0vAbMVkbS YD08gtMCYkwUB3AvKlh2hc67u9ifFFh4hpIBaEzLyKVyKp0Dh8W7cFIWsMHM1ywdYy3W yEvA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lrzY671s; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983847ccd9si3368050f8f.488.2026.11.09.23.51.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 23:51:45 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=lrzY671s; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=hTcbmeOi1Q9h5AIgaqcABnxcM5cC9shohV/G9PHFK6s=; b=lrzY671s9oU/ uTWySC5dkyr0xuR2I0K+4qt7zdMKyeg2cqbf+xBvV/4Wsyx9HQr9Zd/W5+L1Hk7bwbm7khrzAgjej zSS2fYsG7bd+Joi30kEkBNST+DG+HqwwG6zXQidICn3puLPNhWOPE3jgAaO2vv0ZjeXGJ60LDF6sq Mdo3cyQ///4FVgiXFJGT4dcGEpivfhWlaHyyjilMQqPdRTdSQLj2LXHr/EU2RQcLFNNUv+OH3Q+ES NXN78TmAGSdlp6rbQeTSm4UJopTJOqlEkp4hDvX1gYaqm+xMR/0rHCw6N+TZZ1QGsnU1CKGki1bPn 72Fh/LPMO+1uZ5Www/jRkw==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xQgZn-008dOX-2V; Tue, 10 Nov 2026 08:51:35 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 10 Nov 2026 08:51:33 +0100 Message-ID: <20261110075140.1475607-6-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> References: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v12 05/12] dm-qcow2: flush lower md before clearing dirty bit on merge failure X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When qcow2_merge_common() fails, qcow2_merge_backward_work() clears the dirty bit of the lower image right away. qcow2_service_iter() waits only for the service qios, so delayed md writeback of the lower image may still be pending. With kernel_sets_dirty_bit, a crash at that point leaves the lower image marked clean on disk with refblocks that lag behind the merged data. Flush the deferred activity of the lower image before writing its header, as qcow2_merge_backward_complete() does. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Fixes: 222b6f1291c1c ("dm-qcow2: Introduce driver to create block devices over QCOW2 files") Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-cmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-qcow2-cmd.c b/drivers/md/dm-qcow2-cmd.c index 45c517ce0ef8..3bccce090f01 100644 --- a/drivers/md/dm-qcow2-cmd.c +++ b/drivers/md/dm-qcow2-cmd.c @@ -330,6 +330,7 @@ void qcow2_merge_backward_work(struct work_struct *work) ret = qcow2_merge_common(tgt, qcow2); if (ret) { set_backward_merge_in_process(tgt, qcow2, false); + qcow2_flush_deferred_activity(tgt, lower); ret2 = qcow2_set_image_file_features(lower, false); if (ret2 < 0) QC_ERR(tgt->ti, "Can't unuse lower (%d)", ret2); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel