From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id C1C1A8017D for ; Tue, 10 Nov 2026 19:02:06 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAJ0hTW018273; Tue, 10 Nov 2026 22:00:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAJ0hTW018273 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794337247; bh=0tTmxcJYaBG/K5Q2O0RM5VRbo0/H87+dwMVc4uK7ZiY=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=DSwjymyKnOK4sVKdl+v7SNVTH8vGVMYMa/QY7W20UbvGy6ipWO9fZYPcAl7a6wzHk PtFushv5Oyr9mw+r18zmlNHntTJSOTF4DC8jE0K9aC2KW6eZ9d8XBqQrSAJUKRJ3XJ i5KtSr7Zmii5rzHjyxKF6q02ZgI0OU8g7VE+pSbkDqTjqxtTsGTyXJm15N2666kGZH 3o7+eEVq1g1cpNfnk1NZ7tVV87D6rrRRc59pg4McBfkxxHkLtIHmdKWkHRAFtk3zKZ pVMHwKihIaugqmSgk4SfiJgmWwmQVk4uFKPtwuGSh1+bsBkc7k0RrAVM9Ta42olWHf eJbd1McC783aw== Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAJ0cS9018256 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 22:00:38 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAJ0cS9018256 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="TThXeFZU" Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4b64722b5e6so27313915e9.2 for ; Tue, 10 Nov 2026 11:00:38 -0800 (PST) X-Gm-Message-State: APuU4Z88r1t91sCXfY1S+WiICZtEjHWl/XHgn10V6fxBL3lRMfoDrckJ +sLWGodpdopac4zq6AJACiuLNp7BUDzJ2vJ2q1/Nn/PeFHwq4+nFDG8KZQLKVvVCfTNA+KXLCbj CLTR9GKCOoJ8qYybhXKvQ74elrRZBqdb5evdpZGkrDsX1HFDqu/FK/A== X-Gm-Gg: AYBFou27oTUcTCykXYPQXCT5MUk6VjjR80dRdECzzrOS74hlUSq0JxBvR7xe0/ocFjI aNx8q+KnjMQYdsFdYtpu7kSdJy0BlDWgVtinDeyXlItkl2JMB+8BBReRclht8MgCS2K/vK7WklV xDxq7+7ej/DoJ/A1d2yxjj2pNTPYVlFLpoDixvhBVUbz64qKKWePH806TZJep1jHHqn7ccLOtuT UMNcq31l355zklohQVHRpc31nPLtc4U/dkIJLEU5+PHBW0mmIsw9vU7fvmiRvMZw+rJRuvs5NnX G0FuxtIV4A== X-Received: by 2002:a05:600c:3103:b0:4a1:e00b:a10b with SMTP id 5b1f17b1804b1-4ba09364007mr915085e9.7.1794337237769; Tue, 10 Nov 2026 11:00:37 -0800 (PST) X-Received: by 2002:a05:600c:3103:b0:4a1:e00b:a10b with SMTP id 5b1f17b1804b1-4ba09364007mr914675e9.7.1794337237405; Tue, 10 Nov 2026 11:00:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794337237; cv=none; d=google.com; s=arc-20260327; b=ELlOsyfOT/YxwwHH7u89YnbqI1wlqIdkZf/eSGay0poQjAdkJihDfoT33Rd7N3uTju Nr3MHSWk58Iq7GLRs79ocN6xhaUEskxnUdHVk7uyhqZm23AdyVZRA52TAvtNjK5hCneZ xPn0DUGXe77hrsVsGWwlUn0zaUm8e9z+yh4TuOrg60KfpcUTK385gpFLI2SLg27V1x0t d3glIO2Cj8XGK2/OPcN8AcKRrDeQIrX8wH4JL+aD/oXWKIMYozBzBJxAoEmCGU2ABz3r VGSdewIj3vgKzchRaAHnJn00HAZSp4QPv02YbH469p5HXhn523qce+HzCwfifJjGouKD QlDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=0nvP8Jhvex949cUgPS1MxPjmbUC5gC5Q4jLAihP7hl8=; fh=ozrYJQ1t3QIP6s65KBq5xgJxiFM2qf+5wwn3ABTusyU=; b=lo2VGLVvbDU9wCJvdrYpealWY5iOyzwPei4f5dIronQa/QOx2s8lFkF2PYtCy7KTJX olinymrIXvO0JzChSM8lrMYGF36Z8bVfdvPhnGTV1OfPFwtt1yIbGoGt3hYfUcWf/z1B DUNH0C9js5FLPKJd9zJZzWosNbvrl9pM/O5MjbojSBFzMQ7A3zJ6JOz63eP2ZteDTkid tYJQqJTrhkgKd28uvIMHRJLOGjBEIMxv8X3zRI162q4Erk1W7Tcc72ciPK6VjkC59HBS HWY86tpGJiaEudx3XF6OQUPTUN6QESTjo9yvKjbZ0WPzCMIilyAfP6gXh/d2+b7vQeAU wteg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=TThXeFZU; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4ba01fe8818sor6612435e9.3.2026.11.10.11.00.37 for (Google Transport Security); Tue, 10 Nov 2026 11:00:37 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) client-ip=2a06:5b06:b600:300:4f78:6441:d0f1:22af; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=TThXeFZU; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794337237; x=1794942037; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0nvP8Jhvex949cUgPS1MxPjmbUC5gC5Q4jLAihP7hl8=; b=TThXeFZUdZ5np+CXU/glhoaBFOQ5MhRNP/wqq6/YUrG68I+IXch8OtteKN+2QLNaxE y2QWVp/oNiXjkpSje42lQm0ugz5wlAwHdKJCbzjS5ZXcTT2rylQIZd/EivutGm28R4gK 3eWgOZaYfDP2GP3REBowoBuvbFatrEJva/zWCgQqFzUno60tHKUKK7rnYEdHqB//Mioy O2yaQ2vxS9kmys2pb+j7ApptfveiM6753EEZ+QAsieqZzT5c4Yq4pyFgIlCY89unJ+ii AEoBZRLwJiEj56iHIS9UOGDiEN9RmOYqpMJPt5/vuA8v1Gjr3mkwFR428T8v8syJ0hTw TpSQ== X-Received: by 2002:a05:600d:4121:b0:4a1:c5eb:b445 with SMTP id 5b1f17b1804b1-4ba0939b0damr601075e9.35.1794337236951; Tue, 10 Nov 2026 11:00:36 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:4f78:6441:d0f1:22af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49944d646f9sm2245827f8f.32.2026.11.10.11.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 11:00:36 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com Date: Tue, 10 Nov 2026 20:00:32 +0100 Message-ID: <20261110190033.2976967-2-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110190033.2976967-1-den@openvz.org> References: <20261110190033.2976967-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/2] dm-ploop: stop enospc_timer and event_work in ploop_destroy() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev The destructor never stops enospc_timer or event_work. ploop_try_delay_enospc() arms the timer and queues the work after testing wants_suspend, and nothing orders that against timer_delete_sync_try() and flush_work() in ploop_presuspend(). A write that fails with ENOSPC around the presuspend leaves the timer pending and the work queued after the suspend. Once the device is removed, the timer expires on the struct ploop that ploop_dtr() freed, and do_ploop_event_work() reads ploop->ti from it. Shut the timer down and cancel the work at the start of ploop_destroy(). Both are set up before kt_worker is created, so they are valid wherever ploop_destroy() finds kt_worker set. https://virtuozzo.atlassian.net/browse/VSTOR-154182 Fixes: 6ddad5a4d226 ("dm-ploop: Add ploop target driver") Feature: dm-ploop: ploop target driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-target.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c index d8279c79ef56..54b25fd0cb22 100644 --- a/drivers/md/dm-ploop-target.c +++ b/drivers/md/dm-ploop-target.c @@ -164,6 +164,8 @@ static void ploop_destroy(struct ploop *ploop) int i; if (ploop->kt_worker) { + timer_shutdown_sync(&ploop->enospc_timer); + cancel_work_sync(&ploop->event_work); ploop->force_md_writeback = 1; wake_up_process(ploop->kt_worker->task); /* try to send all pending - if we have partial io and enospc end bellow */ -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel