From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 69AB38017D for ; Tue, 10 Nov 2026 22:29:29 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAMS85g019080; Wed, 11 Nov 2026 01:28:09 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAMS85g019080 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794349691; bh=lhfpk6OfOYwZnOoyDtNmwWtZSjEL9/HCKZRytrGGf40=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=KSf5fJc53wOja1mbVJvwf9O1R9El1d4/pLy+ucjrGdftMSa7hQjRpS/sowW732nsc yHfUfVrh03Govp54prSMk3gov0eXQY69QGHf16YXlpwHbwfuYxYHMnpLJs272A2frZ XA/OvA+RV1rx9Aym63T8nSmMJvyasZYOhPSfCBguldv9RdhHHXtotbjZqKlzbFC6dU eZPhoNS58/G5IgpDR54PHLhe3gGMiLwKzJG06dRA6SfEWRaLjf3fKj/TtA+cxTfWqa BujbjaxWFZKt/VFD/96ASuws+rUne1vLTlPGKuE5OkYN5fd2Eyf9HicyZB2HnKmo4C 3wj78tlv7emVA== Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAMS0Da019055 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 11 Nov 2026 01:28:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAMS0Da019055 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="ddzq577G" Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-490c69dc02bso2126756f8f.1 for ; Tue, 10 Nov 2026 14:28:00 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErG8OJnmojhOUGz08xOoPM/S0Fv3uIYstch8bwzzLT3WnsolTqJuk3/oSTdlXfzu8Kcrjn27Zw==@openvz.org X-Gm-Message-State: APuU4Z8nO/gz6VmtXULmWgKa7JKn83K7hMwtN4LG/68oog50JMlIhF8J eVDZIVVrFqukc+fX4Y8H70+gcwkJ5Zi8VYP0vMYaj0am0rnUW+/X+QchXpssPqV3U9rs/bt7PyG H6JZxm/i/o3kyR7bMltRTCUyy9lK6AYnQjlhDB8DQk3I82WUsGgNoyA== X-Gm-Gg: AYBFou2lIgyeUO9LAs1CHGWUnGN+NfZluYgg3oLSwPydCVxKsECY6HQqdw7Jl232t8T JreKU1Xk8WGLKwGDpmyjR/pkJlhwuxfV+eWqH8Y8Po08BnJFuHdO/chsCwZuVvXp9LNVqCB9EHy nS7Tx7GWP7XENUvEXuvS+JunZd/ieae+TcGgfzIrZyL7hmKs9Mk/kiku9maZheBGVSnAl0Rs8az bx9GQgSlKARRsMKj4kRZNeSxhtu1XCxrc9h58GqP5FETroj3K8WW9fUrAhyPg+jcbC5S9PsUqU5 cgSkJj48nQ== X-Received: by 2002:a05:600c:3151:b0:4a1:fae5:f2e2 with SMTP id 5b1f17b1804b1-4ba09344708mr8290905e9.4.1794349680567; Tue, 10 Nov 2026 14:28:00 -0800 (PST) X-Received: by 2002:a05:600c:3151:b0:4a1:fae5:f2e2 with SMTP id 5b1f17b1804b1-4ba09344708mr8290675e9.4.1794349680226; Tue, 10 Nov 2026 14:28:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794349680; cv=none; d=google.com; s=arc-20260327; b=l6ky9D3sfz++mbtP3CdXarLUoQjh2m3gIPpbLja7DsFldjAPRacVe+/Ce23SdlMYGO QnSoSwOb0476bWkMbFrMf7dqCLWQNxhwM40d2XjT/iaYGPrjPakyTjb/u8n4+gD8jj+D AjobPT6DqMQRgH6/n3tOt4iNH9VIy0bFUP7tXQBJIVF8r6f8zIPsTl0St/qF3hVY21T0 QC/zEpC/U2kCiZy1V02dRgq3wdnd7Snfm5kykKmpw9SV8SlpBqLdPrcZJrsK13kKepTS TbCRbxiF0Tv99wjada7ry52zobgr3aMv8norHkFsfhQjR1bt52FDK57ATCAg3eSnCR2A 5PUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=J2K9QeQCMx0cMggKivp67oDI2HFXa2BxvdOE0umDWjY=; fh=vi39GwDqxCxxVBItFRu2UBddf5JeVsuAYbFuff+SEt0=; b=L5k1bd35KnIqtPu/5RYRF1RHJllOiDGE2C87arMR3n16ElsrYzGAug8NJ02m6rnA5n frTuZUQ3SjsbFFfzt7ec16opHkHIPVw412iWCslqdhq8bwk9wzafwqPzvVUbDDnCazEa JWGFN1mxLINaiYxZ5Cip9njyZAoRs5EVC8OgvDz4kA0rC7wX9Vs+sDb6qehfaREgJPCN eDvgwLPiSQqVWTrIFK4wUOBlXKsN0fXehn3b5PC99Qx2GfSH2RDEMcMY9yKONOlsLnHW MIaED83CyUCFF07qvad54k00epZSUTmaxcyssxwC5bWea23rYadRzTXOfw8oQ+UuBUnQ wg7w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=ddzq577G; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4ba01ff9952sor9185185e9.16.2026.11.10.14.28.00 for (Google Transport Security); Tue, 10 Nov 2026 14:28:00 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) client-ip=2a06:5b06:b600:300:4f78:6441:d0f1:22af; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=ddzq577G; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794349680; x=1794954480; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J2K9QeQCMx0cMggKivp67oDI2HFXa2BxvdOE0umDWjY=; b=ddzq577GbGXjF0w/ese/ja0kSODSibWOS7R7QFVVG+VnRSNW2lUQvSre9Ae41FSeso fTo9MeanUsnaZgqaM51lGSb4LUiIxDEoYhC88RD7MGdexcJrFWIFvFAKWAjiOS4IxSVx hfROZXHa8KJqsqdGo9gUJzAi17ILJjhi2CENwdLW+Ohy196Jtp7XrhYj+RlRY2lrxFbP 0kZbZmWVyM67xBSO4HaXL8/+ygyuq3JwjtBJsOJyOQ1MN5j/d8xVQGqGkKy5vUqym/+p I8h5nKtGMb+MMJT7CzKwXhfU5qefxJqFgUEpM3qFIqyYsxNeK5+UOXj8M2iZwClMjVEN xhxA== X-Forwarded-Encrypted: i=1; AL+hErEOfGGCKeqQ3mNV7877vPIh6BhVw6FK4w5DvEI/EUIaCXizj5a/OsMfIhpqIH6cH1Ghl8klFQ==@openvz.org X-Received: by 2002:a05:600c:3486:b0:4a1:d8fc:8165 with SMTP id 5b1f17b1804b1-4ba093b981fmr6244675e9.20.1794349679850; Tue, 10 Nov 2026 14:27:59 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:4f78:6441:d0f1:22af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba09536ebfsm8923155e9.5.2026.11.10.14.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 14:27:59 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com Date: Tue, 10 Nov 2026 23:27:53 +0100 Message-ID: <20261110222756.3236854-2-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110222756.3236854-1-den@openvz.org> References: <20261110222756.3236854-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/3] xfs: release the balloon inode when xfs_balloon_get() refuses it X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev xfs_balloon_get() looks the balloon inode up with xfs_iget() and returns -EINVAL when it is not a regular file or is immutable, without releasing the reference it took. Every statfs and every open of the balloon then leaks a reference on such an inode, which the VFS reports as a busy inode at unmount. Release the inode before returning -EINVAL. https://virtuozzo.atlassian.net/browse/VSTOR-153590 Feature: fs/xfs: fast online shrink support Signed-off-by: Denis V. Lunev --- fs/xfs/xfs_super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index d24ceb045364..6deab3e5d76c 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -924,8 +924,10 @@ xfs_balloon_get(struct xfs_mount *mp, u64 balloon_ino, uint flags) if (error) return ERR_PTR(error); inode = VFS_I(ip); - if (!S_ISREG(inode->i_mode) || IS_IMMUTABLE(inode)) + if (!S_ISREG(inode->i_mode) || IS_IMMUTABLE(inode)) { + xfs_irele(ip); return ERR_PTR(-EINVAL); + } return ip; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel