From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 061E6803F7 for ; Wed, 11 Nov 2026 11:33:13 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABBVx3h027662; Wed, 11 Nov 2026 14:32:00 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABBVx3h027662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794396722; bh=XsjDlHM7rCBS8rtGGLSDCZI/Y2svLorUJoqB3JJY9gI=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=eRoGjJnO46e/F4AvgJYP/TFUfOGKVCU1tshRocOgT/u7+fussCDGghQHIOEBvZRBR W7aiOn69bLwPANbmM2kROSBS7AViwEFiB+PieMkubbbU2ZBVOXXoL/LIeyYllRmy2N YDyYpLz9pVvut0YGzRuCnuALRtlcHCyCLLSlfKLcMdMp3EtHf4PPNfHhnQmmkptSl3 7WKJ8n4uOvgPmfDTItOG6zb3GD1aC8BL9ukWa3jjYl3FGgxGoP9daLlqSBUX0QFWoq cKdPr4k4l/9StKhQ4t7dKckg0Yd66KrZhH8zgM28cIJfU28Jjc7QaOUTx9mccMo3KI cRWOlj2vFP2Xw== Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABBVgJJ027629 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 11 Nov 2026 14:31:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABBVgJJ027629 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="ew9KhEuh" Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48fcb657f32so2160577f8f.2 for ; Wed, 11 Nov 2026 03:31:42 -0800 (PST) X-Gm-Message-State: APuU4Z+/7S3n9B2Fy/JQH02opiD/SEWq65bdrQXzimQVAbRabhRGpKMA 2O0nYig88ONSKaqEkX2Yx7UdMjgN2eL9+FQTPPMQ3DVtstxasJrD83/KlwC+lz7T8VPKTMrwqrx rwr9mJ7E3TcNWGd2Bh5NBgaZPVfS3NSS1GYDVInCKke4oXVIWNB0bYA== X-Gm-Gg: AYBFou0hphg5Ai61P2kX63+Wy4YNe2UR1/66omhCMIiZP+yqJ2HUpb3KjEXTvNoXdAJ V6QwFyGDW+EZOkfWQ7ZIIIUFISDS5KfYGFWv9dmzBt5G3FPCn+1GsFLxVLQ1f8BdLeBtPokopNu yul+5yJHDDj77SJEmB3FzjZsMhVK6tlnmuxFzYi3KuYEby/ltb0M4xn6P+98SVlnlYjbh3eAUYI 9ha1AeIeeB4eR5M06qxgKFuiAB+Q7N+gZeOLKa4jXt95ZdO6v4RjYUPkGMay0v839asPOuRYZ6m x5710j120g== X-Received: by 2002:a05:600c:4f14:b0:4a6:44b:2593 with SMTP id 5b1f17b1804b1-4ba093b5ec4mr45339225e9.29.1794396701945; Wed, 11 Nov 2026 03:31:41 -0800 (PST) X-Received: by 2002:a05:600c:4f14:b0:4a6:44b:2593 with SMTP id 5b1f17b1804b1-4ba093b5ec4mr45338585e9.29.1794396701391; Wed, 11 Nov 2026 03:31:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794396701; cv=none; d=google.com; s=arc-20260327; b=lZxX86hJkUvlv24L2Y1Mb87Yz1RKw8jULa4fzJiN+Vo04cBS7FmsLPb6XHEKx6CDpd GjL8qSnIdv7NW9x4QluhRrBBrCa+3pLGKHsCO9voVMgrTLXN7ykVWJeE21bhTPIirMPh 4o/b630PsVZn+YMZ8allON/HWgjeo5gowJy/97deFRG6OdQwX//pBNffLrTRoqMS/1n7 f+Bno79GwJo0Zd0+TrHsG7Bx+62BEu1U4zB7Ab7hO1EILxao7p/THIj8bXdO9UreSuiB q1I5fpWz8HyoF/bPfB2nj4/ZbLaZ3wtDKfBi9WUwb4E2nUKCnSIcuewHieb+LEbi0+2q b1ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=mE1MY6uRzAxqEw9uHbcB0RTXhARL3jhVOmBzi+iq3y4=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=qv82und2e3jNHr2lJxrviT533sM9rM8LjAfkqakpnL6I5Wpr0bNWLLVUIL0G+/7XZt jSLUzCnuaKz9PC5goztc9Z2oshAkwjcRibj7fuMr60WeXNa8xQwrdDvcb8WG6bOPFIc1 7RntAuRe9tamCmgMngiAxJZQ2LD0IzWNWeql8aOCxp+kmGl/K3GOoXEQ4VqBOeZ9wxmd 9Bp3ObqrCUroJL02JvstcOzfC3ElYlWUAO3gxF9uAX0nmRVAdYfrZSbfaIjhthhEz4RP 4jv3K+vg5Xl9aWTsaYhGGRd8VOUbXNgCkjLsELTfqUnEG1oz7zpWCtmpFC9ffBtLGLZ2 TjLQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=ew9KhEuh; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c3:490a:ca77:c5a4 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4ba01ff7bb1sor9332365e9.15.2026.11.11.03.31.41 for (Google Transport Security); Wed, 11 Nov 2026 03:31:41 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c3:490a:ca77:c5a4 as permitted sender) client-ip=2a06:5b06:b600:300:c3:490a:ca77:c5a4; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=ew9KhEuh; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:c3:490a:ca77:c5a4 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794396701; x=1795001501; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mE1MY6uRzAxqEw9uHbcB0RTXhARL3jhVOmBzi+iq3y4=; b=ew9KhEuhQBJf8u9PBImpFaWLBR85yenuMsBWtVRR5OXTHiEkuvaXShW5td4tD0wFVr jRErOjsSVsMaSZaR+9iehxQPuNdoJhCNStdO4ZlWkPi1AlR0SOI718AUKR5Kv8mqGEi+ 9ucN5zrBEu78+sUIPLOwQ8VdtyfnJkJ76CTPgmdO+cG9jh9RJbc75Sfa58W7fqAyt0FD JrCYFyKN1um+vRfizIgLE5yf2vz0Hf1KmekD4YRZIlkrrlrBW4K1wgRibAnSA6jQGtaM hr0rftqv5P9xV8bWH5sNXU69dzngt6u0NpVQ1qFHrpr70KINL8rNFOUlNwa00GOe4jX8 h2Lg== X-Received: by 2002:a05:600c:5246:b0:4a2:a9:ed5a with SMTP id 5b1f17b1804b1-4ba09381133mr36585635e9.8.1794396700685; Wed, 11 Nov 2026 03:31:40 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:c3:490a:ca77:c5a4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba08ddbe68sm88679885e9.0.2026.11.11.03.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 03:31:40 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com Date: Wed, 11 Nov 2026 12:31:33 +0100 Message-ID: <20261111113135.4023555-4-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261111113135.4023555-1-den@openvz.org> References: <20261111113135.4023555-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 3/5] xfs: release the balloon inode when xfs_balloon_get() refuses it X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev xfs_balloon_get() looks the balloon inode up with xfs_iget() and returns -EINVAL when it is not a regular file or is immutable, without releasing the reference it took. Every statfs and every open of the balloon then leaks a reference on such an inode, which the VFS reports as a busy inode at unmount. Release the inode before returning -EINVAL. https://virtuozzo.atlassian.net/browse/VSTOR-153590 Feature: fs/xfs: fast online shrink support Signed-off-by: Denis V. Lunev --- Notes: Unchanged since v2. fs/xfs/xfs_super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index d24ceb045364..6deab3e5d76c 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -924,8 +924,10 @@ xfs_balloon_get(struct xfs_mount *mp, u64 balloon_ino, uint flags) if (error) return ERR_PTR(error); inode = VFS_I(ip); - if (!S_ISREG(inode->i_mode) || IS_IMMUTABLE(inode)) + if (!S_ISREG(inode->i_mode) || IS_IMMUTABLE(inode)) { + xfs_irele(ip); return ERR_PTR(-EINVAL); + } return ip; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel