From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DC6EA8017D for ; Wed, 11 Nov 2026 20:37:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABKZxbT030947; Wed, 11 Nov 2026 23:36:00 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABKZxbT030947 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="F/D/hDw9" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABKZYoL030909 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 11 Nov 2026 23:35:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABKZYoL030909 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49febef74e3so982115e9.0 for ; Wed, 11 Nov 2026 12:35:35 -0800 (PST) X-Gm-Message-State: APuU4Z/W5TiX41b6+UBx+jGz7arFWH0JmJiOSU9Dql9LP2IdaixPSFwF buPi99Y2ov8mD10nTTwzj8tSNTy9Q7BW0FuIEu1txLoU570PsduqOKVucq2rZXPo1Sm1/0cnTl1 GaPwc0cjNTYerEFdprErCAdvNlcjGH0wNQpEhERlpZa/oS0z6e709/A== X-Gm-Gg: AYBFou1d9jyqrAerMvTsOYFpmrtFff6fc4rz7Vg+uI6qdfeWUpDDsUi2RtEdvcpHgfT XEeqgywMEOBWy4w/8UHnAPBHFFqGTtnCrWyROI+5LLsarRDh4w7p2SCWNDirAfo2TrC9pePX0dj NLp8flrQGEhECmstS651ui4JFggAFuaxNzeR0yCaBzvHJppXncTNl2MaINqfHFAPpwa2Tc3If7Y sr2jI8pkbLIs6DVkeH1QeLVfsOwmEOzJBRgIoDycFHIy0JoF5yQpIJ7ETaBi+5LZ3ZApwr4n9y2 VQNgVSMQnqPZ0qtqHRz1PpDFq5Lfx4pjZmryihgd1KDKr1mVsh/jurj6FrZTkV3HNf9pz3rgRcB tS3Vcdx2VFq9NZdp/+GtO0g3h X-Received: by 2002:a05:600c:63c1:b0:4ba:1fd:cd84 with SMTP id 5b1f17b1804b1-4bb4e2e9c30mr7201395e9.12.1794429334699; Wed, 11 Nov 2026 12:35:34 -0800 (PST) X-Received: by 2002:a05:600c:63c1:b0:4ba:1fd:cd84 with SMTP id 5b1f17b1804b1-4bb4e2e9c30mr7201265e9.12.1794429334250; Wed, 11 Nov 2026 12:35:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794429334; cv=none; d=google.com; s=arc-20260327; b=IWR20WwVUGUZUCK5br6G+ugUlMnmtdzz6RGjupI+W1X1ISlt0zCsRKIikUNLfsEr2H nFCZqLOkDCR0jYKoXQq8nTzzKbWR/4uIwAqMJ3UXGu0W/NQUKa28fXqdH467r+qyap6+ sCwYNC1BfYikF3diTASIUikj9ePr3NUWrwqx1FbV2r433NOnOzZ7jwJOMqQ5k5OOvOzB tojfIP5Q4xiAula4IZbgLzy7vl5EKuGAfYk3fFhkNkkS57YZ4D77SR2F8uT5xGVDoOyb YUbhbIbhbFM9ke+eKxXEp9xBfTqzTUIMPTkTZvEUdDgfi62Bqno5uZnzPMCxLOEjyRpM Lueg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=22/HKEfsHzb6SEk+4YGEO2oU3ZKEY/yd4XfKgWV/nAA=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=SbOfhPllidb+y67ORqQDmpwDOgYtYBprBy/fYxbIlvaymaYJiw9iAqW/xx4gPk1L5q sxqp98XSgbXVaDFkMvNdrSZOD/b0S9LUAZOhPYTPZhJJ1LaVP0ALUFYTgZZ6om/WJCbs fysC/cv79n6OapAdv5OqtILt8QJi/r4/W+HP/SPggDCXj6H5LwDBGqmXjaQI0Wl45vFR u2LWqsA34L2tLqTlG6Y1F/DVl0kRzLyHDfyT/QoLDOgzvwhGd4BDHm3hcQzarR+Q+Gc3 JkJkxUMZwhqIvdHCCbyM33Nj69tmrZhGmgpXkaarQU8n5hQLp996Q4rs8MmGbhpEUOZw tv0w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="F/D/hDw9"; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49835e21015si13155698f8f.147.2026.11.11.12.35.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 12:35:34 -0800 (PST) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="F/D/hDw9"; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=22/HKEfsHzb6SEk+4YGEO2oU3ZKEY/yd4XfKgWV/nAA=; b=F/D/hDw9hXJQ ALSVrrCxK4Er/3i75f6Ar1Dh9hfF/Odmx6vjgLml037Gwrt3ETph3FnpLZ2fPBZQoVJqXrZ89Oesn WSRjItYcPss1jWdEHE0FZJrnuKDhIolLcqNrkvuYgA9hiOTWbEAfWdM9qLo4pFSfCJHziIHwgb+Am yvavebkJyMPQ25w/koH/vehtnZgJgrPXfAIhdWBHesG9jlkvp+fqCpf2VVowoiJA6FCbgvTYn1i6R vXHsj3Tk8yaqDDFwV0kTVm1Yb4Gsm6F/czwfUJV6QfCYqsDA9CtsKSwzejmb+dEzbJoyv5DHC4Il1 WeAHPYzIODPoTt52nhHCLw==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xREyU-00Fgix-0G; Wed, 11 Nov 2026 21:35:32 +0100 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Wed, 11 Nov 2026 22:34:19 +0200 Message-ID: <20261111203529.363554-4-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261111203529.363554-1-eva.kurchatova@virtuozzo.com> References: <20261111203529.363554-1-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 3/4] ms/eventfs: fix SRCU read lock leak in eventfs_iterate() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Joseph Qi Commit 1b95382da85c ("eventfs: Use children field for rcu head and add memory barriers") added an early bail out to the ei->children loop: smp_rmb(); if (ei->is_freed) return -EINVAL; Upstream wraps eventfs_iterate() in guard(srcu)(&eventfs_srcu), so that return still drops the read lock. The 6.12.y backport instead brackets the function with srcu_read_lock() and a shared "out" label that calls srcu_read_unlock(), so this path returns while still holding eventfs_srcu for reading. The unbalanced reader prevents the grace period from ever completing, so the call_srcu() callback queued by free_ei() never runs and the eventfs_inode is leaked. Every readdir that races with removal adds another reader. Set ret and jump to "out" like the other bail out paths in this function do. Fixes: 1b95382da85c ("eventfs: Use children field for rcu head and add memory barriers") Signed-off-by: Joseph Qi Signed-off-by: Sasha Levin (cherry picked from commit 9e899910695944c4ffbcdc6eac65be6485b146b4) https://virtuozzo.atlassian.net/browse/VSTOR-154529 Feature: fix ms/tracefs Signed-off-by: Eva Kurchatova --- fs/tracefs/event_inode.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index a157b4cf2b30..fbaa64e482e0 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -668,8 +668,10 @@ static int eventfs_iterate(struct file *file, struct dir_context *ctx) * Matches the smp_wmb() in free_ei() */ smp_rmb(); - if (ei->is_freed) - return -EINVAL; + if (ei->is_freed) { + ret = -EINVAL; + goto out; + } if (c > 0) { c--; -- 2.56.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel