From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 117538017D for ; Thu, 12 Nov 2026 00:12:19 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AC0B0Ja032315; Thu, 12 Nov 2026 03:11:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AC0B0Ja032315 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="bcrl9Fzl" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AC0AU5D032279 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 03:10:31 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AC0AU5D032279 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48fcb657f32so2543052f8f.2 for ; Wed, 11 Nov 2026 16:10:31 -0800 (PST) X-Gm-Message-State: APuU4Z/ZoZy4S0P2d7S/WCc8UHvIUyRRVi8HIufru7/+1eDJwdyYJhWI nLZEfnd7gq7F3Cgu+Xq+8NnmTVO8vUwIzMrMIpwjGIY7a7/2RvdwBkYw3g0TTFtzYChSxBXeg6I EUMPtE/WM9bC6UEU4kGLW39U8qeTRHjEMBzAL+c+oiwwPhd4kc9C8lw== X-Gm-Gg: AYBFou1TQ2G5f3IslZN5KrgfZohod/KdIkLpGSXR01+CdhBMgaiW6I5OCYkHHEwQ914 cfzeWitJep1hpesfNmu/ydn9BueLVNxyrXu78RTNzW1OzsvUsAJ92Dq8Bp6xgiDxcvp4+9eVDv2 5nukxGnORMEh6Mfb1mN2nra6Uzpk3fbvux+oh2BOZmtbChkwPShLiNgyUgHJZ9F9ovDRUa7bUH9 gub9xOmktNGPfSzUra1PolqFtUYwDf4IYtIp5mUI62INHk/UyboZjn6CwN3P3rv09/8qVJV9CGb 1QRvyLPCL48jq94TrSzMbrSdwA+U3wQeLdMIXhDykf4afFMW7MopNDYL34sZUBfD7uV4TFOEDix N49NoboMR4TRq+VqR7Cq035gP X-Received: by 2002:a05:6000:40d9:b0:48c:4553:790b with SMTP id ffacd0b85a97d-499c8a7b805mr6762201f8f.48.1794442230508; Wed, 11 Nov 2026 16:10:30 -0800 (PST) X-Received: by 2002:a05:6000:40d9:b0:48c:4553:790b with SMTP id ffacd0b85a97d-499c8a7b805mr6762164f8f.48.1794442230006; Wed, 11 Nov 2026 16:10:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794442230; cv=none; d=google.com; s=arc-20260327; b=WgdoEPkP9nbMFI0F+pLTHb6Zvx2pdiDJS174vEgOOOuftH2ZTyjwY9qgb9eOY46Sgl nDfUpkragq4E6Aclch7hUpXLQij2xoy2hxSd4NXoUcdQe+2nyp23SS0IP1WDsGh7TQPH 4PEahDZa0QS5SOf8cwvph8C7aEYO+h6URDcGTGuqTwEb/V6TEccy4CgeUfBXiakJ9ea7 h3/uB72MkmvrofGPbSilwJzs5mZSuUT3Hx4jxq9PGQWJaP35NuLYa4g3nARtarMtzuNY wO+bboYOxzvfU7/K3VA0uQSHdrjQiT0whJ0LE6AwqVH/XQjbActEIEozhnW3KOFiF+PQ 0PZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ldDWy/FMpodnYxcgIFYkCoaO9wfLeS0Md77PowLrMFk=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=TEzLJWfsDsfNYfYlSWTzPr7CvmH3eT/PBdGqJVO4TFw00tmf93DYIK9mEzfaPLsMTz v4+Rp+ZINA1kHmuf6tRmy+n38YfwtrvkdZGHphxIH6XpNrR3rsuwmE4Ci0KypyHpWfn5 kL35QOd/YexZpmFysLHH1LOTrX6o7cLyolxSdvc/zUS3T92aTptoCoeiQuDAhuth+D6K KZ76w3P31rI1mAlRNRF5mDCxCWGK05WwogaoF24v2x2Ia1kvQeemZwBbe0tdRiLrYUDK 3B7whHqNn8wSIyxb2XCkkMGkZ2t4lBIJmCnwhlzL5cMdrkWkUkGHStDaPjnCfv/dm4Rs jggA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=bcrl9Fzl; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983819b2dcsi13189038f8f.464.2026.11.11.16.10.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 16:10:29 -0800 (PST) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=bcrl9Fzl; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=ldDWy/FMpodnYxcgIFYkCoaO9wfLeS0Md77PowLrMFk=; b=bcrl9FzlWBAP Iut90+E+sgyuAKI8wgPPX6LKEysYkV+PKhFCoZ9smHnkUP0ZGcKtT0VI2MPF8xSMkp5vLDJjdMQx3 mpB7w4hA1ELm0SuEi5/YT8D2gs37CqnRPIxEyN/0sfTtl8ECfnFfqQaLy8+GL7O2ygxgrUy9idG92 e4/Ts4TFLnLQjnydgonChgRuiwoZfBe7+cnz0/tSlmi+OI4u4yaoc/hqVCBeYg5/B13FpdHjUzs8x y//hpV+GInAvP9pZChdd6DVNQ3iFvWQE8BDSTbXszzy1DmP5ZsLknceuWf2hXbl7SHApqogDTZAlQ FFhq1PGbj7cQ66jmiqCQ+w==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRIKS-002DgU-0D; Thu, 12 Nov 2026 01:10:27 +0100 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Thu, 12 Nov 2026 02:07:54 +0200 Message-ID: <20261112000926.381308-4-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261112000926.381308-2-eva.kurchatova@virtuozzo.com> References: <20261112000926.381308-2-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 2/5] ms/eventfs: Fix use-after-free in eventfs_remove_rec() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Shuangpeng Bai eventfs_remove_rec() recursively removes the child at the current loop position. After the recursive call returns, list_for_each_entry() advances by reading list.next from the removed child. If free_ei() drops the final reference, release_ei() reuses the list/rcu union to queue an SRCU callback. The child may be freed before that read. The eventfs_mutex serializes list updates, but it does not keep the removed child alive or prevent the SRCU callback from running. Use list_for_each_entry_safe() to save the next sibling before recursively removing the current child. Cc: stable@vger.kernel.org Fixes: 43aa6f97c2d0 ("eventfs: Get rid of dentry pointers without refcounts") Link: https://patch.msgid.link/20260806022719.375354-1-shuangpeng.kernel@gmail.com Signed-off-by: Shuangpeng Bai Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (cherry picked from commit fd73b691702170d37d66f4b0278530cea8ed419a) https://virtuozzo.atlassian.net/browse/VSTOR-154529 Feature: fix ms/tracefs Signed-off-by: Eva Kurchatova --- fs/tracefs/event_inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index ce61795a7ed5..cc08218d6e26 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -848,7 +848,7 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry */ static void eventfs_remove_rec(struct eventfs_inode *ei, int level) { - struct eventfs_inode *ei_child; + struct eventfs_inode *ei_child, *tmp; /* * Check recursion depth. It should never be greater than 3: @@ -861,7 +861,7 @@ static void eventfs_remove_rec(struct eventfs_inode *ei, int level) return; /* search for nested folders or files */ - list_for_each_entry(ei_child, &ei->children, list) + list_for_each_entry_safe(ei_child, tmp, &ei->children, list) eventfs_remove_rec(ei_child, level + 1); list_del_rcu(&ei->list); -- 2.56.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel