From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id AC67E8017D for ; Thu, 12 Nov 2026 00:12:21 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AC0B6vA032328; Thu, 12 Nov 2026 03:11:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AC0B6vA032328 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="PRYd3q2S" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AC0AX1M032292 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 03:10:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AC0AX1M032292 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4b764ffc014so33973235e9.0 for ; Wed, 11 Nov 2026 16:10:33 -0800 (PST) X-Gm-Message-State: APuU4Z/VB1mJMeEFPNe4F1iZ9VM7Vez+KEYHy1ZgmbThyvDcwXM1kYoL CFnbda2bz3Enuuf+c5YvJxmEFVdY3WIojKr7EYiZ1RkgnMy30PNETSsZrF71llhgO2eduHj+/Gn WGpRySYJBw699tQLiy/mnswYAehrXhiCkXsk5aQkY602uEFhogQTi/w== X-Gm-Gg: AYBFou1ihYyOkZT7X/8sFywJUmfTH7LLtjA/8oT4cwTzQMhTkZEFFY95Se9GqBF/kk+ sQ8b+Prefjxho4FgVRDu1mtN+eG/3RykA8Ldo/VMXIhJj1yqiwWiDT7V0pc5fuuWCCwvYg1+K8F Yu8RBbRuAEpHCYuJC8M0L/2zX7IVN5mtOeVrm1ts15RS9keoUzKu3PTvAN8sLsB31LfoOA5th8e 6vtRbBMsN7buLOolvPsgwIAILf3zeW2A7Fw9fdSEkqcCpTvE8HWkDH9nvmffCd9vwVoRQv16DAo yh/B3IlHwTMNXs1SHWQtA0AT/l9XEEPsNtiuI3uNMUfLNlVvZPUHvxTGXvwPSUa0xzBW1qxDHzt UlruCumo5uD8PRfh/qOFIH17z X-Received: by 2002:a05:600c:3e1a:b0:4a1:acaa:9d4c with SMTP id 5b1f17b1804b1-4ba093c4de5mr73258695e9.25.1794442232777; Wed, 11 Nov 2026 16:10:32 -0800 (PST) X-Received: by 2002:a05:600c:3e1a:b0:4a1:acaa:9d4c with SMTP id 5b1f17b1804b1-4ba093c4de5mr73258435e9.25.1794442232349; Wed, 11 Nov 2026 16:10:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794442232; cv=none; d=google.com; s=arc-20260327; b=rD47GFZIPRFbpWPAk2KtkHwKvzzqpl3rAeXMXkmlomZXmoWmY82tbgnx8BQ/J0pCeo AWep/w0a4g60LSsrsJNPqcqzpBKnIDWjQksLzDmmpPeaEc/hk6q6CEnCvdzuOCKx1oVH kZCsxlSuAgbgH3MHnOdDQ9zp+R1jRJGd6AaXpBtB0XxBJAS598Ef+tsLL4idNnL2NhC2 aRizfmgbkBXJwx5vwdYI8gmipeYmR23f2GOFaMMjBmC0oytu90AqUdagFKGgF6IwoHBM +x1SdYUp+7raypny+RXDwuLFXXZrmbh7S86YgJ6FvWmJorZ+nBMjMjKvaj3mKKQtdP3P q7xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=22/HKEfsHzb6SEk+4YGEO2oU3ZKEY/yd4XfKgWV/nAA=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=bWQ4OzjG5EFZiveVq54ZCgTyYZh6W/gry5cWhfiQ2Z1MOv0MGHAnbxOxaZCWTGxBas Hnq8HKw1hJA/u1jPnD1wDwU//Ach2O4f+yFZc05XvADs7Vxdlu3YL73XtfRdNE+hjcUw 4miVgKpqByg3N2o5TlIkhkexv487IX4GU2WWNRnwD0L0oGU5u4kh0NGPUbQ8JQvOMPGE i4DB6RKqoMgbNIFsuHkNpoPAn59Rxnye/Bxuf9mOkpm5X2FjUckvyF0/1gy02IJXpvmH RoXh1QmnsyvdFPA0Xo1PvkLhGeWrQJOq1Lr+3chErXUhtFwK4SifSNsEE6Q2cRpynUJC pajg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=PRYd3q2S; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4bb4e262230si25716425e9.14.2026.11.11.16.10.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 16:10:32 -0800 (PST) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=PRYd3q2S; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=22/HKEfsHzb6SEk+4YGEO2oU3ZKEY/yd4XfKgWV/nAA=; b=PRYd3q2SuTVZ rKsTxB3jEeXOXJoNMlHkLXhaJj9nkWGynP/dd1S0WOXP/n7nATBZL+IG2jkADhmyBxxQW3kTRfZbH yMrUNn/fSZHZKRgrqjm0NSwSd7L/YUpaT9fhpZ0MDFeA8GBDCUzTz0YB7+p+V3B3jxf+PHXzdARgl PVi0+OGvdSwtXFlCjD+eIyva3IxfoHfhOBlU9Ihd15hNXD468Z85MGOHfmVJ+y/3OPFQmGoJsQM5C g/xS6DwI7Fx2T+wzHKVMVrv1Rpan6tTOcLan9dbcONhjMFiEdL2IR9VdgWM/XGcS0a1F7DWgSj9QP hvQVJOzwMyIjeukjXC1/hQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRIKU-002DgU-0i; Thu, 12 Nov 2026 01:10:29 +0100 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Thu, 12 Nov 2026 02:07:56 +0200 Message-ID: <20261112000926.381308-6-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261112000926.381308-2-eva.kurchatova@virtuozzo.com> References: <20261112000926.381308-2-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 4/5] ms/eventfs: fix SRCU read lock leak in eventfs_iterate() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Joseph Qi Commit 1b95382da85c ("eventfs: Use children field for rcu head and add memory barriers") added an early bail out to the ei->children loop: smp_rmb(); if (ei->is_freed) return -EINVAL; Upstream wraps eventfs_iterate() in guard(srcu)(&eventfs_srcu), so that return still drops the read lock. The 6.12.y backport instead brackets the function with srcu_read_lock() and a shared "out" label that calls srcu_read_unlock(), so this path returns while still holding eventfs_srcu for reading. The unbalanced reader prevents the grace period from ever completing, so the call_srcu() callback queued by free_ei() never runs and the eventfs_inode is leaked. Every readdir that races with removal adds another reader. Set ret and jump to "out" like the other bail out paths in this function do. Fixes: 1b95382da85c ("eventfs: Use children field for rcu head and add memory barriers") Signed-off-by: Joseph Qi Signed-off-by: Sasha Levin (cherry picked from commit 9e899910695944c4ffbcdc6eac65be6485b146b4) https://virtuozzo.atlassian.net/browse/VSTOR-154529 Feature: fix ms/tracefs Signed-off-by: Eva Kurchatova --- fs/tracefs/event_inode.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index a157b4cf2b30..fbaa64e482e0 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -668,8 +668,10 @@ static int eventfs_iterate(struct file *file, struct dir_context *ctx) * Matches the smp_wmb() in free_ei() */ smp_rmb(); - if (ei->is_freed) - return -EINVAL; + if (ei->is_freed) { + ret = -EINVAL; + goto out; + } if (c > 0) { c--; -- 2.56.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel