From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023142.outbound.protection.outlook.com [52.101.72.142]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9381D8017D for ; Thu, 12 Nov 2026 13:48:09 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=APelbRPotyxJr0ep256HHjKGWN0th3lVYAkkiXEWQ+yBx8OlaqERHYEk3N188lLKkekPvj4D7n2OAGywjwwc96nun+4ZXuc5gArg4EIw2Y6xrXNhYytWwqWnKU0XkT7kaMmWLN0+yYKZZ2HgDYyQbh9xQqUWvmY8Q75JqMSjzDWiplXTptZM54/LcjpUcIylxUksx6CqtvYxIFWUJldq+zVPOcww/KG6+RqipdS3GrszhID5iMhexTzsQhFtGfe1HdEp+8Mw7oKTzAWTcR9XU2Vd7jnZdvgdr9+I3tBBcYUcee0v+E8lPTu6D7HyUIhbtKJYks8ApA9vlQIoq/5CpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PTAIGA4c+Ojp/bd3J2jA8E85b18oO4JaT9AuGGMsuio=; b=MXDZJj/ljDe16NQ3Q9tLD12BHaJuHPKbALJZLq20hLYoWNTq/1Ixfw2wom+AmNGjVtw9RVnsJcWDgF+hryrGL93buVEyjXEiSwMyXJQYarJAO5S/6d0K/U0ygSXZL2EGGE731h2IkeNgQdusJ7kjhj4UDCkPQJGiFu0MgbExeeU9QZXc6fBwcqyT6GsSDortl3BAocr4HMj6dtzEBqQyWD4jBhBIJKrKjpgqyKL1TiSV7h8WYODX7vj+XsoWhVGGrN6vn3GYd/0ZWGOSahQeMX5V8LzN8x9fjgP0glAWERcNpHDFVLH48KkDdncb5wj4YldJJVlu/ZCSc49wgJ49Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 2a00:1450:4864:20::335) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=openvz.org; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=openvz.org; dkim=pass (signature was verified) header.d=openvz.org; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PTAIGA4c+Ojp/bd3J2jA8E85b18oO4JaT9AuGGMsuio=; b=FwbvVQB0NGFFqN3qOxNEUcdUk+ilIb+xRzTRlmNZ8OazXO0ivDGfk6QTuk87yDM+Zbhgg7xQ2xxtcGED1TJfL1olaY2ScVVPhZqHekvDN4Eftnm8nuigWykVHehlZUEnXxwu91ln/jEBb6MrChljUusLcOgMbukWWXb3rH03rbk= Received: from AS9PR06CA0603.eurprd06.prod.outlook.com (2603:10a6:20b:46e::12) by DBBPR08MB6281.eurprd08.prod.outlook.com (2603:10a6:10:1f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.9; Thu, 12 Nov 2026 13:48:07 +0000 Received: from AMS1EPF0000009A.eurprd02.prod.outlook.com (2603:10a6:20b:46e:cafe::ab) by AS9PR06CA0603.outlook.office365.com (2603:10a6:20b:46e::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.8 via Frontend Transport; Thu, 12 Nov 2026 13:48:07 +0000 Authentication-Results: spf=pass (sender IP is 2a00:1450:4864:20::335) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org; Received-SPF: Pass (protection.outlook.com: domain of openvz.org designates 2a00:1450:4864:20::335 as permitted sender) receiver=protection.outlook.com; client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com; pr=C Received: from mail-wm1-x335.google.com (2a00:1450:4864:20::335) by AMS1EPF0000009A.mail.protection.outlook.com (2603:10a6:20f:fff8::207) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Thu, 12 Nov 2026 13:48:05 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4a35db1f202so34445575e9.3 for ; Thu, 12 Nov 2026 05:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794491285; x=1795096085; darn=virtuozzo.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=PTAIGA4c+Ojp/bd3J2jA8E85b18oO4JaT9AuGGMsuio=; b=WkgMSxmoVgjxI9fxFUwjxTgmcZ6ldznRaBiAJqW9DBDq/RdLfQ1qr+0i/1a7lB+ING 5h4QmWIrm39uFxeGG+9cUe8KhPJdqtgU1cOQ//WeGvaK74TgnduwXpOQCltSk9Fr7x/z 2s11I+BTjPvcQfip+J9JI/T5hegQkSAwXU0qVhHKEys8e49X9EDiyFK+swCFGgpTMBy7 S1JYM6QMIqBTIK0E8KO1cPmSUvbEfQlZgUaJkDcLsIRC9mJ6OHK1+iH6Olp8g55BJYIj qb2D7EKbY4xVluL/taamHaO7j+UNBNS3PZglYnI0MpjihxPw4n+cjK8P/L8Jgupz3Z7Y CWkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794491285; x=1795096085; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PTAIGA4c+Ojp/bd3J2jA8E85b18oO4JaT9AuGGMsuio=; b=Uz6JZG099nB0TGmDtbweZS/8Lb/hflXxTkvlaLOYJF/JdjCHhb1vG7bkD1k7alIBPn ulAJ+W3QLgBHnKMBIec9ZW69bRM8MVNJhbGXWh2aCQVZM+8mLOMCVNf7I1MEdhkA3r5D FiGE5TMqKlJ7krDqZ5rh9Rr2we2m5UIHUa1pYPSxGcSQB3aP19IyUHPu8KPvkjhsQCSn k40Xv52dUoeEqZZ7LcZlI19+vn/XeeBVPAkZ01TrwGw1Njd08iTTF2OTCDK/Ym8+Z9RL Dr69Uvs0Ww0/BBdraRsCxQ0xBBgNWP4jTHJ2CFix6jOdhrfYiebeDjoyxzvIYMHn0oxS Ftyg== X-Gm-Message-State: APuU4Z/DGqjBVgVLA4HEa3eifpOV02CI/xv0J4/BAKS9MqRBGtXqbQfc Gxh8fWo25ta5KzOcM1hI75kEl4lL8Nq5/U6Bjb4DmwC/oukkVaq1941sTnxNxCfzMnHsxhWY3i+ PX4t4VtQ= X-Gm-Gg: AYBFou0QWYNt99nWICG9jhfwKBNGujJY6jWUGl8vTLF4XcMweZzLdcW5/chp89nhYYh O2L3mTqr/HQVdrGNn67unu/CW+4j+Z1kDSlGn9F7G3sQbm2DdWUiNCEf1v46qm3OjyyfoOviKoq PqIHWZ7OHF0tylKJEJNRJtnBLF7ISdNijgrcGdgvFHEjCkZVPmtjkb+cbqMxUGOFIVUH+8qsuEg 8AfIQ0rLUgHxiUCD3n7OI2oQkPbDqmnT0jihzlZ49s7I0IFAb8oFLmdVVwQqYLw4y4lIsSV9Gjn tHUXbxtzY8nrZqChDlKEtbvdzzz+YLD7rwplaF+/5OGoZDkw9iR+CxMBYComcY+M+gTkQldOUm4 GNhC04WTaNvfo2fdnMgyDaKuPQf58ZAyB68iXB4f7UmI2J75QDKmXCWg4CCX2R8FogYIRKsAFX6 B1azwADbxsp6eBmn1SZbBLz3+jlKczqubwIMO54S61RNi7J6zoQC/oh7Y4bnelIyxotc6S7hCrC Cga9VGnwmTgEFOkwfHo3rQp9agnsJEPvVL7Y1M39VBa9iQyZGy35Q9m+yR9bpIyDX7/tjDvygPa S4ZneGAZzIWoJ5OzafCJ0RkebA== X-Received: by 2002:a05:600c:3b2a:b0:4b7:dc0:89c with SMTP id 5b1f17b1804b1-4ba093ba970mr105408505e9.32.1794491281005; Thu, 12 Nov 2026 05:48:01 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:4137:317f:4748:6f80]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba0953d26asm77837635e9.4.2026.11.12.05.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 05:48:00 -0800 (PST) From: "Denis V. Lunev" To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, den@openvz.org Subject: [PATCH hci-dev 0/1] hw/ide/atapi: fix abort on CD-ROM reads past LBA 2^31 #VSTOR-154795 Date: Thu, 12 Nov 2026 14:47:57 +0100 Message-ID: <20261112134758.646697-1-den@openvz.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000009A:EE_|DBBPR08MB6281:EE_ X-MS-Office365-Filtering-Correlation-Id: b42982c5-17fc-47e8-64de-08df40c393fe X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|6059299003|9140799003|82310400026|43022699015|48200799018|61400799027|376014|18002099003|16102099003|55112099003|261028144727099003|261022075727099003|261022105027099003|261026140227099003|261021121427099003|56012099006|261021123027099003|261102123227099003|5063699009|261009223027099003|10067099003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?C7l/zt1mRbUZBU5wawGfd9URqFnzFShJfKnqRL7IDS9J9XLy8eKKfGO27xGZ?= =?us-ascii?Q?Og15+NTCFg9G5KtqZ0euWrU1OX1uXVChxx5uDf3J6+hoETa2ZlW5mK2NTZ6G?= =?us-ascii?Q?9BUU1ggtp9m4z629ky84PMo9cu/Qb+pApICVWWHUlCie6aohv6QKOLPK5Jdx?= =?us-ascii?Q?KRgRmPKbWv6tgVBILfqNT4vxMA7LdVNOg7u32IciqkiiIkjEDDmr602YyJXh?= =?us-ascii?Q?orOGLbZMs8pZ7HyfefUME7ixAngXI7w/ugusoHBnc4cj0qpOshlqZ95g7iVy?= =?us-ascii?Q?+/FQWWO+wBxS+BSVwFNVBYVi/ajbdzDdMTukV6emayoCoX5euXnZqEF204jU?= =?us-ascii?Q?N68O4eGo8NslRJSkScYt3jTZhqPOtrYJkbprkN3/e4dFBWwhaZsj28HYVcNn?= =?us-ascii?Q?bTdDvstm2Moc3f2XbUw2yvBUtehcS70kVAllKf8rFZdFRC9XET8P6kYU30Cv?= =?us-ascii?Q?zpfHaQDploleODAMiIHX2vU2kzzuBb2fsNydp41DxkvFy0+Vqdh/JE/sWfnu?= =?us-ascii?Q?Wwz4adh7ZFjFMX4MDew31xLO5g9L2UjcNoUhmdMBXgl1fxdqJHlklcp3p1er?= =?us-ascii?Q?/DSY/cCJr/nN1NElZToWoaYlWTi8YVMKYlY7sW2cbSakLjergMsnxIoU0ES9?= =?us-ascii?Q?POCcNf6CAiWF5ysd/Xuq7KgvPE/M7SC0Ts6QvQgPEnqfk8KSBdsWLNDOmPvE?= =?us-ascii?Q?jhBwMLDwC5z6xIDcHHHNy4/LFcTTi4nQ4aNoz0vvyoB9noVK2aIyC/CWslSu?= =?us-ascii?Q?jbMPLrZYyGFf1knlLI9ABcVW4Mi6SED3mgGUGwslcyv8PpZnSdVKUBVuDmug?= =?us-ascii?Q?VDmBDQnOw4CsJqOcBSsjayCkEGeU09/qHoNgfiW1S1jFnhOKQzYCyq8fZ1vs?= =?us-ascii?Q?c194HfuP8tVqp9qUDcpPmp8ULmde1O6eVSNxwikl5A5xaugqrFFysivG0CYo?= =?us-ascii?Q?ACz4pwONdhA00evQoQ+oCxIqGsQ5n/wIv+gUs+4JYWywjSrj6VhuVui9r6Es?= =?us-ascii?Q?oGT9?= X-Forefront-Antispam-Report: CIP:2a00:1450:4864:20::335;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wm1-x335.google.com;PTR:mail-wm1-x335.google.com;CAT:NONE;SFS:(13230040)(704160211799003)(6059299003)(9140799003)(82310400026)(43022699015)(48200799018)(61400799027)(376014)(18002099003)(16102099003)(55112099003)(261028144727099003)(261022075727099003)(261022105027099003)(261026140227099003)(261021121427099003)(56012099006)(261021123027099003)(261102123227099003)(5063699009)(261009223027099003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: f2zyidUkb0MjToY/qy7fNroH85URj2rrou8QIqR3rOxtf/UPgUrHXDm57BB8uwbykA92WQEvQf8G1OB6OpOSTXRsejYbVCVUTTmCdUhszGVLqfsaf9D/8Zr0MOjhcUDwtfUKFMESI6n3snigU62MihJwUfUZtqaejcmjwdfMRzenfY0eBGTmsWIVgvNuziqZjgTsVykRFkAxjMWVzAjihkusvyYpBw6HKmzoPAttfbi0OuLAC8z1d1ooTQ3AFtVGfIdc67O/JTjiA4Ky3WTfGOuzfzZFbTW7lUKGNVH6cHFon4SHHtG6ZmxGd9/QGzqvVnMDzI0nzyShXzDcYDpKSfbIrkF+KJNYW5SSFRqPBIdG4RvQMfL/2dNZnUj3DBGFX0PetBlwfVgoZCoy0V6LsAhLRqIo5ge8g/rybXWTx3wtrztSLRunHA7ipx0Z/Ks4 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2026 13:48:05.5077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b42982c5-17fc-47e8-64de-08df40c393fe X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000009A.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6281 List-Id: A VM with a CD-ROM larger than 4 TiB aborts on the first guest read at LBA 2^31 or above: ide_atapi_cmd_read_pio: Assertion `0 <= lba && lba < (s->nb_sectors >> 2)' failed. VSTOR-154795 hit it on a production node: the cinder volume behind the CD-ROM was 8 GiB at one start of the VM and 8000 GiB at the next, and the VM aborted 10 s after that second start. The 32-bit LBA from the CDB passes the range check, then turns negative when passed on as an int. The patch carries it as uint32_t and widens IDEState.lba to int64_t. Upstream has the same code. The same patch goes to qemu-devel and is not merged yet. The only difference here is hw/ide/trace-events: this tree no longer has the cd_read_sector_sync event. The new qtests /ahci/cdrom/{pio,dma}/high_lba abort on unpatched hci-dev and pass with the patch, and ahci-test and ide-test pass. The x86_64 qtest and unit suites give the same result with and without the patch: ivshmem-test, test-hmp and qom-test abort on this tree either way. The upstream version also passed a full make check on all targets and the raw and qcow2 iotests. Denis V. Lunev (1): hw/ide/atapi: fix abort on CD-ROM reads past LBA 2^31 #VSTOR-154795 hw/ide/atapi.c | 18 +++++++++--------- hw/ide/macio.c | 2 +- hw/ide/trace-events | 8 ++++---- include/hw/ide/ide-dev.h | 2 +- tests/qtest/ahci-test.c | 36 ++++++++++++++++++++++++++++++++++++ 5 files changed, 51 insertions(+), 15 deletions(-) base-commit: b39d755d7ac95c46e771833f558e99196340ac66 -- 2.53.0