From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 41CA0803BB for ; Fri, 13 Nov 2026 11:18:39 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADBGNTt016658; Fri, 13 Nov 2026 14:16:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADBGNTt016658 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="veXMoMqJ" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADBFlHd016583 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 14:15:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADBFlHd016583 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-49187ad6a72so423641f8f.0 for ; Fri, 13 Nov 2026 03:15:47 -0800 (PST) X-Gm-Message-State: APuU4Z9fpgtrnqU0tNPKyCRXZYZaH/TaMOoaQf0clpuJfuLzk0PYqqNP ZLzlGAsIEWShnO7QyfFsegbrqPx9mjxDwH45e4J22a9dmWp9zCeNUsiqIDpl7PiVghK4CjJz/+1 1lJwZ3J8Flydq1v2IPjeNT2SItRLqO9wi5ONcgv0sm+7FoTglD28r8Q== X-Gm-Gg: AYBFou3TKnG92FixhpGhyWZ4o8H292exL0TPnpRocKhsUEXiAQH78k8M5Swq6Ry6lUl rEFgrVy9Z6KsfjOJvVesGCaY26RT9rln1ut/QNE5URfE6k+hTPJfIJ/+l4tdXKuvIufzkQD61N6 AHAQDtMOQcKz9RJbTPpVJmvzWsGrWN2edQ3FP/WTg6tRWA7T2VsVtlxQFQmLzeB1SGyltV0mode FUfSgQtWgWXcquWG1S1uTgWw17PRrl6THiriCs0jXZ+bWIGbAqSDrhYEJFeYMnzNghyNTviEA8J 7yRrsjWIATLuIAgeAwLK78WsVnN9d3plFaSnXzKDFg5m9PjMY8yrAJchDKlbaAPB85BX+WQrsM0 YQVY7lMC9BuiKE1CFpDc2OwgLT/I7lw== X-Received: by 2002:a5d:5f46:0:b0:48d:cda6:4dd7 with SMTP id ffacd0b85a97d-49c72ba6f5emr4565377f8f.44.1794568546990; Fri, 13 Nov 2026 03:15:46 -0800 (PST) X-Received: by 2002:a5d:5f46:0:b0:48d:cda6:4dd7 with SMTP id ffacd0b85a97d-49c72ba6f5emr4565289f8f.44.1794568546254; Fri, 13 Nov 2026 03:15:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794568546; cv=none; d=google.com; s=arc-20260327; b=WxCVa1Hll5PMfBwQ16UVAaY8fjw2BITvMeKJhm3EeP3GY87bqfWhOva6HT/IK1chzo UpeTRvFZKGB3j/s44wzepVf3iZcLSLWJQGUYqLKyDqytLE0yj1pBD56eglgt+v1vlGWg rVTuDHpEPW4vNspCtUTsfdX8qrF7FxpqxF7SGIgGKuULzc4Pbm+fCttOk7kLSoxsF5Pg ZdlkuMswslR75JqLJ04ea7KzfVCqM3QNVRi+Ki4wLcQifQ7HuXFaD7H9qB2uk1jiPb3N EjMvEzDsfL3lOBqcqCBrME8dkNIiAUtlgTG1tiQZHdhpekIAZjOw8Y6lZ8cTU4vJZCuv zfJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=p5C0Y04izLG8fOwUrlFFAPiBQwPnBsNZ9TmCVr37MUc=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=oTtjGDUz7WhbFXcv4JqY0ZzzLXrvN0AjVUehVfvUjI544ZB2j+dOYNge2nmVQy0EsH 395FKy6DK5wBvlXF+1+FRHKMs2bliWP2q5ROOKgNv8nMPkpD6GG5rB3nCwfSFpc10iXn kKBXyT1fuiPXjtNCrpqqIne9FnROoC0ltGd/EAmbKRgbLOMlSFOY/7P75gk/PtuAAq+2 Gv1Nk/uSdkClFIc+oAeyOcV+GPhYnPzjzLRJZv6mPzzFHX54VL6wHa28FPZMh+bASJUb H9uYj/h46Ttc+I8CQiY6WIGFhDLGFk4X1Vwl6CRJycWIPn/NU2gyHqTfPxmbnRQ2tlTf fRjg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=veXMoMqJ; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c600214edsi5238861f8f.27.2026.11.13.03.15.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 03:15:46 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=veXMoMqJ; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=p5C0Y04izLG8fOwUrlFFAPiBQwPnBsNZ9TmCVr37MUc=; b=veXMoMqJ+1ZB uArVLI0vjnMEDy/rLmsSlSWt8IZ+fLTbtom5c1WXKBHkx+zhDfw4j+OagKSM9jbb+TVNL85+qugvG R9ttAQ2r3rkRIVwDy6qJhfoMgbUmhPE2TfK0SvK+CS7IVZhdxx53MLzX556KikmkYBRCnW7EgdSEQ 0264la5C6kdi9tivuH204h1cjl5QtuMLHDTBtm+6YXwbkCTA6uhDWvM/Ai/jyb9oQ0vYPSCYP2fsl qEdTEyQ18693gOqyflRPy45JxGVtzN/qqwGx/Ryr+RBWFcVYcLXQ4WB8L2gtNn8FLvmXUo8F+s1b3 OroqqworjigWk2GbLOZd0A==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRpBn-007Dd6-2F; Fri, 13 Nov 2026 12:15:42 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Fri, 13 Nov 2026 14:11:23 +0300 Message-ID: <20261113111126.793039-6-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com> References: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 5/8] dm-qcow2: implement per-qio fast processing X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Each qio is handled by its own work and process_one_qio() can now work with qios not requiring metadata. Try to process qios right after splitting. Insert all leftovers into respective lists for do_qcow2_work(), keeping the order of the splits. Now process_one_qio() runs in parallel with do_qcow2_work(), so main kwork may change an L2 entry between the fast path parse and the data submit. A fast path write or partial discard is counted in md writers under the lock that checks its L2 entry, so a discard unmapping the cluster waits for it before the cluster is freed. Known limitation: reads are not counted, and nothing pins their cluster between the parse and the submit. Main kwork may discard the cluster, free it and reuse it for another allocation in that window, and a fast path read may then return the data of another guest offset. A follow-up series fixes this in VSTOR-154659. https://virtuozzo.atlassian.net/browse/VSTOR-95494 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Andrey Zhadchenko --- v2: list_add_tail() keeps the order of deferred splits; commit message mentions the race with md writeback; fixed "it's" typo v3: commit message describes the window between the fast path parse and the data submit and the known limitation for reads, which a follow-up series fixes; reworded the line starting with "From" drivers/md/dm-qcow2-map.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index 496fbcc613488..fb2a1c7c42111 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -4817,9 +4817,18 @@ static void handle_cleanup_mask(struct qio *qio) } } +static void qio_try_fast(struct qio *qio, struct list_head *deferred_qios) +{ + list_del(&qio->link); + + if (process_one_qio(qio->qcow2, qio, true)) + list_add_tail(&qio->link, deferred_qios); +} + static void do_qio_work(struct work_struct *ws) { struct qio *qio = container_of(ws, struct qio, worker); + struct qio *i, *next; struct qcow2 *qcow2 = qio->qcow2; struct qcow2_target *tgt = qcow2->tgt; unsigned int pflags = current->flags; @@ -4829,8 +4838,12 @@ static void do_qio_work(struct work_struct *ws) switch (qio->state) { case QIO_STATE_START: { LIST_HEAD(deferred_qios); + LIST_HEAD(split_qios); + + prepare_one_embedded_qio(qio, &split_qios); + list_for_each_entry_safe(i, next, &split_qios, link) + qio_try_fast(i, &deferred_qios); - prepare_one_embedded_qio(qio, &deferred_qios); if (list_empty(&deferred_qios)) break; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel