From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B80918192C for ; Mon, 16 Nov 2026 19:22:04 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGJKlT1030953; Mon, 16 Nov 2026 22:20:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGJKlT1030953 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="rJ4+6rY0" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGJKkLd030931 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 22:20:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGJKkLd030931 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-492b5408dedso2111456f8f.3 for ; Mon, 16 Nov 2026 11:20:46 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFxE2RABjlPQrCWeYrEr8PuXurv6ZB9Ylf+ay3Z+d8vkmOyJSCVN9GviBC+tRyb8/67zK27Dw==@openvz.org X-Gm-Message-State: APuU4Z+MjCbRh1QhaL/ZrMMOza5KS6hz7jIsWeVdppW2mfjt7hZ5SXql 5FQTDs+wmBS6a12RYi5+Q1wRydhmgTjoLblaf4aSoX557h2d3f+08PP5akXEDCmWzqr43l3CxS4 lfpms9+DRUo/cwAtEFSTUqX5xckJrgIS1kA9skqx9T0acKVNfsqmYew== X-Gm-Gg: AZFdTZd3cpge/Eqikupkgx6SbaSnipIq1RI2e3PuhpvCGzee0XVNi1YGnSJLPUeD/1p KTV8+fwubK7vf0gZcdXEa91uttxD5Y+fCN2MQ4H+dOt6rRsT9ykpnRO7RLHh2t3+EwEBJXzhbGW mNx4DIdi7lk3EcXBhfbMDldbVX6VmpArFhEkMYYbc6BwrS4R6SmbGXdsanU7Xj2yz9IQL7hSUZ6 wx2K+jw0ImKQAH+8kxQoRo4S4dzC3RSy+rnbECeDQS4uYpF2d/Z2752mP+USNRHt0NhfI7eh0YY ygnCygR3MmAaJoHLXNoanzwbtqXbJfjKf/COhM3NZnRAau0AeQ26rrV08aHUjzsVFHhP1X7+h0Q mZ6Lpdssdl/7pwBsy4eU/kYDrqAMw X-Received: by 2002:a05:6000:2c0a:b0:4a1:a2ed:bc1d with SMTP id ffacd0b85a97d-4a1a2edbeb1mr8845390f8f.43.1794856845792; Mon, 16 Nov 2026 11:20:45 -0800 (PST) X-Received: by 2002:a05:6000:2c0a:b0:4a1:a2ed:bc1d with SMTP id ffacd0b85a97d-4a1a2edbeb1mr8845327f8f.43.1794856845234; Mon, 16 Nov 2026 11:20:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794856845; cv=none; d=google.com; s=arc-20260327; b=GkmHUzJWYYG2ocB9frD2sC6DgHByGuWDU+BST8tK9KLF6QOame5sawAsxaUemqJnC5 iRcUqwdT91b0kxvyf52A0Uyi6AXCbUfZfIt2W9ogxNhhJwwfRlgGIwfuCqEptAKLk9Nn BnnjGFnd00GL/atDyIq59p/VztaaB2jlYjN+faqH0zlPTtOmxY4n5Njdj/P4Ew+Gvjsg hans80OCFYJbXZrTjlBPJijj1EdnK2wH4nhxXsxabH5ULOMo1Mt2CVJPTAA4grN70eDb V+JVpsmnAmQu7nPr0/MQ2fjmyrYO+1LRWdC/CGVSkN1EUmJVmdLsCXRfMJu5R4L3Mr9e q1mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:dkim-signature; bh=rcgWR4n6CNwu+m9npH6Ei/zxUhVZ+2RMf+wRu5ziiH8=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=ZQJMJ8m5+HET9IMFIH6WjCbfSGgQ5kAQk3bd68/oO77ZU9C/fFCHn/ObLE3mOxQ2gL SRW9MExPY3RTIQE/PVfmki36FKrrowIV7S2sPFY+UdXH9EYMtKejtVNN7TuUjKeT+bYg mANt2sJLMrkKE1UrsN3QeqzNOJxbVA2SIlgqb4s70yM5/E5TeihMPGRgsLGPetuHGW6P 4OPArUeD9HfAYw5V50QQUXDEDQb+OVqXIx3UCEqlHXtxAymd9iJomQeyXrYyA2P7YMtU jDnvih+kiaaE2QwceLsrOYMtMuhqapBv69+sp/F8354Cd9VbE0gT0xEqaIEU9Keqs2i8 7zDw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=rJ4+6rY0; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63123076si23865829f8f.131.2026.11.16.11.20.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 11:20:45 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=rJ4+6rY0; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Message-Id:Date:Subject :From; bh=rcgWR4n6CNwu+m9npH6Ei/zxUhVZ+2RMf+wRu5ziiH8=; b=rJ4+6rY0d7wmOzM4wSi lGM1E6YqORZnkANYpcU0x/0SzrgzBDwpAkO4+L5F5J8Diz+3+XaqZNWZ7WB5afmF6AOU7e0O/+4Fs uujWtpSujsvPUC1QbNMw3a6uf5lyYAG1KxzTRD8hiLsK1q8FXOxOTuzCEZd6bSoGs8TZKJAOvXEjL B61Wsd2bTwf8ho4RTC2uqTDjotBgK4r89oWvdLXDxcxa8xfkbA5zonWLxQcR34eSp5k6mxTiN+Q8v +1ijDb0mtgptKQLeDbTHxF9EK+1nBi+sDAgqcdbCmyXLT1EqgnhS4vy7dkp1ihItuuuMYZIEl/IDb 7E9Sg4rr0YU8y8Q==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xT2Bh-00A2lb-16; Mon, 16 Nov 2026 20:20:36 +0100 From: Vladimir Riabchun Date: Mon, 16 Nov 2026 20:20:38 +0100 Message-Id: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAIZX+2oC/4XQzUrEMBAH8FdZcjZLvpN68j3EQzJJtxHdSNIG3 aXvbloPFlvwMjDMzO8Pc0cl5BgKejzdUQ41lpiurTEPJwSDvV4Cjr71iBGmSEcNTvUNTyXglOM F14CZB65kp1XbQO3qI4c+fq7iMxogYnOm6OVnUCb3GmBcvGV1iGVM+WvNrnQ9WGIoYWwXUykm2 FsjgBAwRMmnGvM4pdstnSG9rwmVbQ21N1gzgnXSuB5YB/bI4L8GJXxv8GZY74lg0KrRR4bYGt3 eEM0wJigpjPAg3ZEhNwYle0M2o+c9c96xLjB+ZKitcfAP1QwNvRMUDHT60ND/GLoZXHtrpSKGB v/XmOf5G7COxJFlAgAA X-Change-ID: 20260918-ovl-use-orig-ve-2dc365976202 To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v8 0/6] Fix kernel crash in overlayfs X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When testing CRIU with containers with docker images, we found an easily reproducible kernel crash: [ 2300.870181] BUG: kernel NULL pointer dereference, address: 0000000000000005 [ 2300.871537] #PF: supervisor read access in kernel mode [ 2300.872577] #PF: error_code(0x0000) - not-present page [ 2300.873595] PGD 800000010a18f067 P4D 800000010a18f067 PUD 10730c067 PMD 0 [ 2300.874900] Oops: Oops: 0000 [#1] SMP PTI [ 2300.875742] CPU: 1 UID: 0 PID: 5419 Comm: criu ve: 0 Kdump: loaded Not tainted 6.12.0-211.39.1.16.6.vz10.x86_64 #1 16.6 PREEMPT(voluntary) [ 2300.878057] Hardware name: Acronis OpenStack Compute/Virtuozzo, BIOS 1.16.1-1.vz9.2 04/01/2014 [ 2300.879684] RIP: 0010:ovl_get_index_name_fh+0x18/0x70 [overlay] [ 2300.880859] Code: ... [ 2300.884128] RSP: 0018:ffffd32582e0f7c0 EFLAGS: 00010246 [ 2300.895807] Call Trace: [ 2300.896397] [ 2300.904435] ovl_create_index+0x82/0x260 [overlay] [ 2300.905406] ovl_copy_up_workdir+0x30a/0x330 [overlay] [ 2300.906427] ovl_do_copy_up+0x10d/0x2e0 [overlay] [ 2300.907387] ovl_copy_up_one+0x456/0x720 [overlay] [ 2300.910736] ovl_copy_up_flags+0x81/0x110 [overlay] [ 2300.911740] ovl_create_object+0x51/0x130 [overlay] [ 2300.912719] vfs_mkdir+0x194/0x250 [ 2300.913470] do_mkdirat+0x14c/0x180 [ 2300.914223] __x64_sys_mkdir+0x46/0x70 [ 2300.915019] do_syscall_64+0x7d/0x160 [ 2300.922814] entry_SYSCALL_64_after_hwframe+0x76/0x7e The cause is that overlayfs does some feature checks on superblock creation using capable/ve_capable and it stores current credentials. But ve_capable check result depends on both current creds and current VE. Later, overlayfs switches credentials only, leading to unexpected feature disappearance. 1. Patch 1 removes separate STOPPED state - VE goes directly to DEAD. 2. Patch 2 adds helpers for overriding tasks VE. 3. Patch 3 delays ve cred drop until final destruction of VE. 4. Patch 4 adds VE owner to overlay superblock. 5. Patch 5 fixes fd leak that appeared after rebase. 6. Patch 6 fixes the bug by switching VE together with creds in overlayfs. As a side effect of this series - CT1 overlayfs mounts won't work in CT2 and this is a good thing. There's still a gap - creds may be overrided in other places and we should handle them - a separate VSTOR-155347 task is for it. https://virtuozzo.atlassian.net/browse/VSTOR-143259 - non-CRIU repro https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- Changes in v8: - One more time updated commit messages to make sashiko happy. - Rebased on hci-8.2. - Returned ve_name print in patch 2 - now we free name in the very end. - In patch 6 did noted other cred usages in commit message and updated ovl_lower_positive to return true on failure. - Link to v7: http://lore.virtuozzo.com/20261116-ovl-use-orig-ve-v7-0-37daa56081ed@virtuozzo.com Changes in v7: - Patch 2: dropped new_ve name printing due to a race with free. - Added new patch to fix rebase-introduced fd leak. - Updated some commit messages. - Link to v6: http://lore.virtuozzo.com/20261116-ovl-use-orig-ve-v6-0-7cfb41c8c973@virtuozzo.com Changes in v6: - Fixed various typos spotted by Kostya. - Updated comments in commit messages and code. - Rebased on rh10-6.12.0-211.75.1.24.1.vz10, overlayfs got one more place with creds override ovl_copyfile. - Patch 2: helper always returns -EPERM for non-host switches. - Patch 5: CT -> Host switch is handled by overlayfs now, code updated with Kostya's suggestions. - Link to v5: http://lore.virtuozzo.com/20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com Changes in v5: - Patch 2: report non-host VE changes, also treat VEx -> VE0 and VEx -> VEy differently. VEx -> VE0 might be allowed, VEx -> VEy - never. Replaced most WARN_ON with normal warnings or WARN_ON_ONCE. - Patch 3: updated commit name. - Patch 5: allow VEx -> VE0 case. Now creds are switched without VE. - Link to v4: http://lore.virtuozzo.com/20261109-ovl-use-orig-ve-v4-0-88e65484dc5b@virtuozzo.com Changes in v4: - Patch 2: clean non-NULL overrided_ve in fork and report it, Report revert_ve(ERR_PTR) usages and reject them. - Patch 5: changed ovl_override_creds signature so it returns error. Added checks for it in all places to avoid. - Link to v3: http://lore.virtuozzo.com/20261103-ovl-use-orig-ve-v3-0-add042cdd087@virtuozzo.com Changes in v3: - Patch 2: added a separate field for ve_override to fix problems Pasha spotted. - Patch 3: new one, delays init_cred destroy so dead CT can still use it. - Link to v2: http://lore.virtuozzo.com/20261026-ovl-use-orig-ve-v2-0-eab58bfc29ca@virtuozzo.com Changes in v2: - Patch 1: updated description as Sashiko suggested.. - Patch 2: moved stubs outside CONFIG_X86 section, added task_lock protection in helpers. Verified via lockdep, no splats after vzctl tests, C/R and crash reproducer. - Patch 4: fixed typo in comment. - Link to v1: http://lore.virtuozzo.com/20261022-ovl-use-orig-ve-v1-0-da84c00c8065@virtuozzo.com --- Vladimir Riabchun (6): ve: Remove STOPPED state ve: Introduce override_ve/revert_ve helpers ve: Defer ve creds drop until ve is completely destroyed ovl: Keep creator VE in overlayfs superblock ovl: Fix leaking fd references in ovl_copyfile ve/overlayfs: Override VE together with creds fs/overlayfs/copy_up.c | 6 ++-- fs/overlayfs/dir.c | 59 ++++++++++++++++++------------ fs/overlayfs/file.c | 74 +++++++++++++++++++++++--------------- fs/overlayfs/inode.c | 94 +++++++++++++++++++++++++++++++----------------- fs/overlayfs/namei.c | 39 +++++++++++++------- fs/overlayfs/overlayfs.h | 10 +++++- fs/overlayfs/ovl_entry.h | 1 + fs/overlayfs/params.c | 3 ++ fs/overlayfs/readdir.c | 36 ++++++++++++------- fs/overlayfs/super.c | 3 ++ fs/overlayfs/util.c | 53 ++++++++++++++++++++++----- fs/overlayfs/xattrs.c | 35 +++++++++++------- include/linux/sched.h | 1 + include/linux/ve.h | 33 +++++++++++++++-- kernel/capability.c | 10 +++--- kernel/fork.c | 2 ++ kernel/ve/ve.c | 10 +++--- net/netlink/af_netlink.c | 2 +- 18 files changed, 325 insertions(+), 146 deletions(-) --- base-commit: d816dd0e4cdc45208ba0c488d295c5b2f943e079 change-id: 20260918-ovl-use-orig-ve-2dc365976202 Best regards, -- Vladimir Riabchun _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel