All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: [Devel] [PATCH hci-8.1] drivers/md/dm-qcow2: set header_length to 72 for v2 images
Date: Mon, 16 Nov 2026 11:05:22 +0100	[thread overview]
Message-ID: <20261116100522.2867539-1-alexander.ivanov@virtuozzo.com> (raw)

qcow2_check_convert_hdr() returns for a v2 image before it fills in
hdr->header_length, so the field stays 0 from kzalloc().
qcow2_parse_header() uses header_length as the start of header
extensions and so parses them from offset 0 of the image, i.e. from
the header itself, instead of from offset 72 right after the v2 header.

Set header_length to the size of the v2 header before the version
check, as qemu does. v3 images overwrite it from the raw header.

https://virtuozzo.atlassian.net/browse/VSTOR-152394
Feature: dm-qcow2: block device over QCOW2 files driver

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 drivers/md/dm-qcow2-target.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c
index f4004f6095a7..3a3964e229e3 100644
--- a/drivers/md/dm-qcow2-target.c
+++ b/drivers/md/dm-qcow2-target.c
@@ -603,6 +603,7 @@ static int qcow2_check_convert_hdr(struct dm_target *ti,
 		return -EOPNOTSUPP;
 
 	hdr->refcount_order = 4;
+	hdr->header_length = offsetof(struct QCowHeader, incompatible_features);
 
 	if (hdr->version == 2)
 		return 0;
-- 
2.53.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

             reply	other threads:[~2026-11-16 10:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:05 Alexander Ivanov [this message]
2026-11-16 10:08 ` no-reply
2026-11-16 17:19 ` Konstantin Khorenko
2026-11-16 17:20 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116100522.2867539-1-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.