From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7C977803BB for ; Mon, 16 Nov 2026 10:39:11 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGAbwRJ022511; Mon, 16 Nov 2026 13:37:58 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGAbwRJ022511 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="aPYsy6ce" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGAbuvt022507 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 13:37:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGAbuvt022507 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48c6a1d4034so2175960f8f.0 for ; Mon, 16 Nov 2026 02:37:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErE3G7JjxTnDx+qcD1+XlNGQ+JNOzfG9ETDolgV8BzNTy0KnNp+Z6QPmA+Sv5vMZFhJ8QQ3wxw==@openvz.org X-Gm-Message-State: APuU4Z9U0UghAej7/u9y4Fjk1h8aRalW38Q5vaR+fXRT+W/DoUPaY/Vl pCQP1Ty1FmaVQ5ZGo1Ist3dllrAI2X0ZjOSOP+ngZ1P/0X4pO6B5W+gNvs6HfZ5ep2BKHTHLqMN U7aNFKnzQ31uzBRmh+vbvKifHf1arodilRhEr4c2NyMsxNMc/PR3iKw== X-Gm-Gg: AZFdTZf7ys4vk+GwuU1gJwuzO2QKWz9MCTa5gWdosFuJZxPmsrUTqFIYv8Y3T2KSYNm PaGP/IACqHU39ucqVtfZj2c64vvR12D/YJHHPP7RXV1VKuuItNoGCkLq0j4ROsw61oDxx3es2U9 oQY8s+VBUCTFTPdQi6ItMW0sOGbiNfbKIp5wfIfRM5POYEnDCkVgCxEBNTltMpOtaAdB9HVKKw9 QZFE6wzh0ziL0liYaC9l4K75u+VW1uVFpj0SPFDmq4qOcGlrOm2IEb3HF9STqah4YiuzC6b5bZ2 9n8cHjKNj1DDqdgVZ6uDhgWxEgS6AlTfNwUmowdl2460bWi82x+dwg1RvbY1mpMEZKoY63Azv7B PFhpXsOd6ZBi1Y5S320pwqnPcwNA= X-Received: by 2002:a5d:5f08:0:b0:492:20e0:f666 with SMTP id ffacd0b85a97d-49c6a645f16mr20027009f8f.0.1794825476430; Mon, 16 Nov 2026 02:37:56 -0800 (PST) X-Received: by 2002:a5d:5f08:0:b0:492:20e0:f666 with SMTP id ffacd0b85a97d-49c6a645f16mr20026964f8f.0.1794825476006; Mon, 16 Nov 2026 02:37:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794825475; cv=none; d=google.com; s=arc-20260327; b=K2aHijp9KjpTGDlI7MNZ6gq43LsR9W0o6SgOzyVxx7CdsDfAoYy6GoGfK/h7xZjtY9 c+WyeEEByovTqhU5hLUZ55YnRFtGLCu9IDQuoW5GAWEO//Nrz4XR2hitkkQG5oQoOV5E jIKzM8XsmUKUAuAAQcbJ6bubQxTSCEA7kUvddBLqvugvtZAsoUvdV65fG2xzimE2UJt1 DKvJp7knyirtPAa3jJ0KG0FtpG82IHi3HhTvsVd/SqCj3ePFm7Cl1puToDqF5BcnBBH6 mNF7L0WOVhisNhaPAAi2vBawDsjk/dXv7AnOg18T96rq35UJOK18szM9CcdwPTjeXkfO SKxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=lZQDxiGVrOlDwNZuboINAzCXN9Ba6MHR4SdH02szpF8=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=F72OWaqGa8CHeYOft5CSO4uQsOsftyY5Mnsa8++8INoGHJNcQDckKf9pqhvnzKADz4 Ye0Nmkb8USmmerKRpqmhvIQ5HCzarv4/iL43gXDzNSyBEzmuB8r+4ZflH4vo4B2HZhOj OasbW2wwdaY5WONeZv++C0i4a4Qe907iw6jauBuyF4UjIZcPXLMvvHoWgPZ5jcMlJVKY 4TmsST/9nlgviEqtLslVGvdtldzfVA+Bdyr7I2yYcck2/RPZK2MRjNNZDxIlk7HVLXsf qIySYjQTGQP9aevS0G9Bl2kQQd711obj3YBBmCx1Z/qvjy5FW0r7aGAUrhntRrCJZ8IW 8rPA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=aPYsy6ce; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c635f86e6si18892272f8f.150.2026.11.16.02.37.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 02:37:55 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=aPYsy6ce; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=lZQDxiGVrOlDwNZuboINAzCXN9Ba6MHR4SdH02szpF8=; b=aPYsy6ce7IcK fWUr3kDGFOqugf/wsYgqNKjFdKNBJDdU9SG9RWRsIy+G9kXRrW3STTOre3WCnnQ6uJkvmAP2yEKXi iTpy7VDQRfYBg+npi21n9D3kI0RP8qodkowsFcBmEMbsaBdqI/jUavEGPu7oLDRan30v0FYLBY0u8 HkqKKZYpX2fzAwnx2nX6l2pr55xwczfrx7Nbm29FmH3/mULgFq/sl0/Cz+Vuon6cf6nsWqpRy2Jrr n1pruh7bHCIjfyfYIZCyOQlOu+7FMVarJ12k6oU2KcjpTAiVn9Lg62zgmzZBkxgq/uFstUlo/8XpP ZYpKpgL9XrCmz4DAyAp59Q==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xSu1k-0009M2-2B; Mon, 16 Nov 2026 11:37:47 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Mon, 16 Nov 2026 11:37:52 +0100 Message-ID: <20261116103752.2878746-1-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1] dm-qcow2: reject v3 images with header_length below 104 X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org qcow2_check_convert_hdr() checks header_length only when the compression bit is set, and only against sizeof(struct QCowHeader). A v3 image with header_length below the fixed v3 header size is accepted, and the header extension parser then starts at header_length and reads the fixed header fields as extensions. The driver used to refuse such images, but the check went under the compression bit when zstd support was added. Fail with -EINVAL when a v3 image has header_length below 104, regardless of its incompatible features, as qemu does ("qcow2 header too short"). Fixes: 66195f78dd3c ("dm-qcow2: add zstd decompression") https://virtuozzo.atlassian.net/browse/VSTOR-152393 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-target.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c index f4004f6095a7..89c3a91f0fec 100644 --- a/drivers/md/dm-qcow2-target.c +++ b/drivers/md/dm-qcow2-target.c @@ -612,6 +612,9 @@ static int qcow2_check_convert_hdr(struct dm_target *ti, hdr->refcount_order = be32_to_cpu(raw_hdr->refcount_order); hdr->header_length = be32_to_cpu(raw_hdr->header_length); + if (hdr->header_length < offsetof(struct QCowHeader, compression_type)) + return -EINVAL; + is_ro = !(dm_table_get_mode(ti->table) & FMODE_WRITE); // if (!is_ro && kernel_sets_dirty_bit != -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel