From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4B8D7817A0 for ; Mon, 16 Nov 2026 10:47:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGAkDBc022677; Mon, 16 Nov 2026 13:46:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGAkDBc022677 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="XWLJbbIZ" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGAk26A022640 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 13:46:02 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGAk26A022640 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-499ca65ae87so865254f8f.1 for ; Mon, 16 Nov 2026 02:46:02 -0800 (PST) X-Gm-Message-State: APuU4Z9sDdRlEVQrsT2wOnjvoWkQyYqPWY/hJWndnhKAROUUA9MsQhZ/ jQSDJ4w6vmpXpIvXLVLnB3LgNaxnMDUGj/3PkMFzjG/qX9M5fVo8mGBaVfSZw912npUlwXdwYVn McJEBRkFQPvrfM00zaan7whpI3IYCTny7RMlNTR+Fadm4bF0UKLzLpw== X-Gm-Gg: AZFdTZcw+RVUXMNSNvezP9d5q4iKND+yZ+0UN24MolgIW7k+LKqpYklmNI89K4CJM41 KJ9PMOvIq+drdfXKUxdhQCy9wZk2Ow5wRmJM4Hau2jSXvRjhbCen04hubYDaZ5xbiyshJcUj0w5 Du9f0XYa+pm47W7EPNeykr1mc6oyNUw4i8JTyeNxW/hgdr7u5ppspi/6XSAAXRsW7mnNUbkiFzW Hl0tDiAELcxlOJgNxqDnoiRMAlPq6FbZxEPGm1cw8BEu9SXjgDwrO0f8PXp2suHMiMvvFmGihrd dnBNZUaOH+CWP5YmeEtlHYluLx2FubOPEEbstADbYZsiOOX/48NsXEK5S2tnlHVF9P8En5nGSMW nUz0T3p9ZK4guwChagc+CcIGE7ZMnxA== X-Received: by 2002:a05:6000:250b:b0:48e:127a:c914 with SMTP id ffacd0b85a97d-49b01734a18mr29287494f8f.5.1794825961917; Mon, 16 Nov 2026 02:46:01 -0800 (PST) X-Received: by 2002:a05:6000:250b:b0:48e:127a:c914 with SMTP id ffacd0b85a97d-49b01734a18mr29287458f8f.5.1794825961439; Mon, 16 Nov 2026 02:46:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794825961; cv=none; d=google.com; s=arc-20260327; b=atLERPHT4fE3ZrgXshISXZLgH+PZIQTeIjxVcLBZC9NYW8nbWs7lnGwog5Ux9dkNoQ eEIKpxWk4JIePNleHzo37XGndoK/gy37aCSTSIjMLfqhZuzGEK5rhTGD0HX759dGciTO 60xhDBJ7CZ4nGeqiwzgFK3ek6AWTs/ipphs/Lv/Lwr/WzYkfza8Z3rVauUbNV0OLkkvL 9Eon8Uk2KhwyIsXVk0z3pMFyFumW4eTHcagjeEVN6zG5hSXCsiAR7ooakXgWNH/hYG+o 5yTiBG9nSSLnpyknwa6aKM8fiuUQ5yBAAd/ZSd6mgc/hMdrTT7arfd3PV2vzYf6g2t/m grBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=p+0ufXYVtmnWXqVZXJPTc/p22L1IsExo6filSnhzSWc=; fh=wpoNUURlquLpJK/14Kny0oMIYkY7mYwjJ/Ils9UT2kk=; b=JaRZusJ4c5oB0BPkGLNl5r78kgMPnxinkru7mfRmPmvAfGOHZIU7O8b2HUVjck1c5u iChQYSwCfOxCOxuiMy9cZrxYsfg7Ti+pZ9GoDA8ATbSr3ep1X14SgvTRRh38s+S1d5P3 w19xlTs3DXtgSMfgI7VJUbhuPS88dytpauJq7n2Ew1rtuOrgVMU4P1t6nFpqCx+AA65T ypu3B5dM3CQZ3mcvQ3uA9qG0mXcJuucqGKMdETArK9nYhdE7jvwAoIsloAyxP1+QQGoG tFM2kD8oRi+WWZGvo9MVKpBjLCuhd4ATurHmU5YW6qohFcDvbCBGdTEIbfpermNXRZCm xLNw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=XWLJbbIZ; spf=pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=mirian.shilakadze@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64cf6034si19575133f8f.424.2026.11.16.02.46.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 02:46:01 -0800 (PST) Received-SPF: pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=XWLJbbIZ; spf=pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=mirian.shilakadze@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=p+0ufXYVtmnWXqVZXJPTc/p22L1IsExo6filSnhzSWc=; b=XWLJbbIZswkf JPqEkFzTlNJnvWsO7PKgD9hx/w4UKgg6AHmoG6zSAp0zGWim1fY24G505ooXRNgHdPpAp/xPNbmAz pz2JNsLJ9MM0FYKTJKeNmN2xtiIiWsOEtMu4cpK6CJDypcxDyzXt2w0NbRqMr0pHa5aISPZWsiYQc eaqw4Bfpfb40Y/16taOX+eI+Rlru81LIrz4GxTRNHMTjjS9dbremDBjtQxtX51vx9JgJs43c9WLNi 9RmEbkw3f5DXfzin1FNgLC3Qe3bHEEuIoCYqF9bObFrzEB9MyLI58uawNrU7nem8pGgSEclXkBwQO 58lT7OxKtyNkhoiL3udBNw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=localhost.localdomain) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xSu9a-000IkS-0o; Mon, 16 Nov 2026 11:45:53 +0100 From: Mirian Shilakadze To: khorenko@virtuozzo.com, ptikhomirov@virtuozzo.com Date: Mon, 16 Nov 2026 14:45:47 +0400 Message-ID: <20261116104552.102938-5-mirian.shilakadze@virtuozzo.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261116104552.102938-1-mirian.shilakadze@virtuozzo.com> References: <20261116104552.102938-1-mirian.shilakadze@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH vz10 4/6] cgroup: give the CT root file writes and hidden roots only to setup tasks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org While a VE is pseudosuper, any task in it may write the read-only files of the container's root cgroup and sees the hidden cgroup roots. That includes the container's own binaries that vzctl and CRIU run during start or restore. quotaon at start can rewrite the root memory.max, and any of them can write 0 to ve.pseudosuper, which ends the window early and makes CRIU's restoring tasks reachable again. Use ve_current_is_pseudosuper() for both, so only setup tasks get them. Feature: ve: CRIU support https://virtuozzo.atlassian.net/browse/VSTOR-151265 Signed-off-by: Mirian Shilakadze --- kernel/cgroup/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 77903a56b79e..b0f2e7a24b5f 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -4765,7 +4765,7 @@ static ssize_t cgroup_file_write(struct kernfs_open_file *of, char *buf, if (!ve_is_super(get_exec_env()) && test_bit(CGRP_VE_ROOT, &cgrp->flags) - && !get_exec_env()->is_pseudosuper + && !ve_current_is_pseudosuper(get_exec_env()) && !(cft->flags & CFTYPE_VE_WRITABLE)) return -EPERM; @@ -6947,7 +6947,7 @@ int ve_hide_cgroups(struct cgroup_root *root) * Hide ve cgroup in CT for docker, still showing it to pseudosuper * (criu), and also hide non-virtualized cgroups. */ - return !ve_is_super(ve) && !ve->is_pseudosuper && + return !ve_is_super(ve) && !ve_current_is_pseudosuper(ve) && ((root->subsys_mask & hidden_mask) || !is_virtualized_cgroot(root)); } -- 2.43.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel