From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id AF700803BB for ; Mon, 16 Nov 2026 14:43:17 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGEg2QA026637; Mon, 16 Nov 2026 17:42:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGEg2QA026637 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="KDzjeSBX" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGEfr6q026614 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 17:41:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGEfr6q026614 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e00f3929bso921595f8f.0 for ; Mon, 16 Nov 2026 06:41:53 -0800 (PST) X-Gm-Message-State: APuU4Z/sfUi2JPsJ8bVocLU6P2/bgC8Ve8yEA78Qp127zjDHBUqiMp3f FNrmFaXLQQoWErQToFvKhKrLSikY6oVUqNpCGqsAhrkLD7qSxr+xqecuwLUgG8UytLhe/PwdN1R PQe1yMC5eN2wdZpe4/wPNoZ4BBH0r+KZ2YmztRyDtZlEGNmIf3juk7w== X-Gm-Gg: AZFdTZdPjU5zYjFrNrpDat3feJXyfUrZWngEsWb4+eRKhM+XVQKWTJ2n+RjybKSjP+O 1s//mjtaVYuaypmRecEHXeMyFeyAlVTK2rvX6t6D4pczzoo68VoeH4AykgaoMavxRQBBAMmUfWx pij8yMwmAE0GEvpWimF54ZLCnE+dMJt64+5GINMdQcffXOnz/MCjuKU20qeVhHCKsGy37DRTKg4 GQdXuda5YA29vhKbc6POkrP4ufBWGurO5mXr/qJauhr7LmgsoAJaMSkL/8ipQcI+Bde4ngI5ZlB wHZNuurV9Pc/5lUgaxaLfHu/ATeEgALs0c35ESw6d1pVZ9ehU9zu5KjgkhxYWpTSwGes/FUxPLo xC+5znE2D0pZU7wGTBCucMHHz X-Received: by 2002:a05:6000:2387:b0:48c:585b:8825 with SMTP id ffacd0b85a97d-49c7072e3famr23413066f8f.18.1794840113192; Mon, 16 Nov 2026 06:41:53 -0800 (PST) X-Received: by 2002:a05:6000:2387:b0:48c:585b:8825 with SMTP id ffacd0b85a97d-49c7072e3famr23412995f8f.18.1794840112633; Mon, 16 Nov 2026 06:41:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794840112; cv=none; d=google.com; s=arc-20260327; b=Y+dGSY7V9Ob376nZ9jDyT+EehLLyOTPVgcb4XUfbbu5HDNSgo1EMOXX3jD7nK0HBOi qULwxBHnrqNAuB61hTWQZaSfRt08fsF7dztU6+QaCs0EBgrwVMgkp3NVqw4+w5z+u79H CoEEEpMLoqpO2NtGNF8aH8WY2Vf8g0cAzWpTVvUi4S5AqqsUnO8HdwV/E0pSyc5maihK TmmVFBMornkHvihI7bOno5Y6jiFq7cX0fZGbyxYQQGeI9fwj4F6fSktGzcCUCs6phQ7B X2YBx6BZ5DE5GsL1xlMAY/9PS1+HING8ArEX0ndlb7L7XiNYWIzWnRzbHRw7aSFMaCcZ Z6CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=vmv1lbN+RiqlfVyuSO+YlQur3sxrXBE+gYf/Qjeo8tQ=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=FVz4SGdnqesA7F+Ic7AbtpjVWn6YYqI91P0wOInp20REkuMlUhdIO7JZiKWO5+PweX dZc2Y8g6RCGL5r2sBeWi8IN/869u66xyqcpF0gjoomC9GQQYwtsSFU28DizRR1PjnBOb XJq2Odq17f+BYDMIVzTshDl3Yov0kPrB2HnYwVJV2lFYhn9W5RHcqk0HLJH4+DOCWp3Z w+U0rk4DMP/G1Hf/oVUFXphjI8RT4wUIvIqDISpp/T/xynJNwqkmCx14S7trysakN003 V3kKihw48Extx3qCLKJzW5CfPHlUFvTuWGFAxxJtFwalQRUUzIjl8btwdqxpHOj/V9h/ FvHw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=KDzjeSBX; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c92e9085bsi20666892f8f.379.2026.11.16.06.41.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 06:41:52 -0800 (PST) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=KDzjeSBX; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=vmv1lbN+RiqlfVyuSO+YlQur3sxrXBE+gYf/Qjeo8tQ=; b=KDzjeSBXPVYl EGNSeCLm7HBNJ1p5aLbH1i+95Pd0WCmqJJw95/bcZK+16cpEc9a/xzH18RzLutsFHBbc4lsjYz+CZ tXtZIJhTQek2+Gft6O8x5fMVWRK/MYUFbL7/rJeLf5aCcsWLqathxUhgXc5y+JqugD8p2AocMXBx4 XJW7hWbScLHLnfuQxVTzVmxbDySTxYO1RyMDErRlRD89wHmsHotbMGVJoBt4P/hsadBAyybI5+muq nOg8I5hUmwH3GbIGqoVaMKzzA97qtkz8io3q4Q+ik/wqmaA2GGvsmAmtGmIPrFaHt4fJ0+7bDMNZ+ YswEuk/7lJHX9r2RWwqwhA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xSxpp-004m0R-0j; Mon, 16 Nov 2026 15:41:44 +0100 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Mon, 16 Nov 2026 16:40:24 +0200 Message-ID: <20261116144143.624802-3-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261116144143.624802-1-eva.kurchatova@virtuozzo.com> References: <20261116144143.624802-1-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 2/2] ms/eventfs: Free the eventfs_inode after an rcu grace period too X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Christian Brauner commit 2cd88c498ecff8e22bf4c397b8eb226db70ac343 upstream. tracefs_d_revalidate() reads ->is_freed of the eventfs_inode that dentry->d_fsdata points to, and ->d_revalidate() is called in rcu pathwalk mode with nothing but rcu_read_lock() held. The dentry itself stays around for such a walker, but tracefs_d_release() drops its reference to the eventfs_inode when the dentry is killed, and release_ei() then frees it after a grace period of eventfs_srcu. An SRCU grace period doesn't wait for rcu_read_lock() sections, so the walker can read an eventfs_inode that is already gone. With a pathwalk held up in tracefs_d_revalidate() while the dentry goes away: BUG: KASAN: slab-use-after-free in tracefs_d_revalidate+0x76/0x90 Read of size 1 at addr ff1100010152d8d0 by task walker/97 Call Trace: tracefs_d_revalidate+0x76/0x90 lookup_fast+0x320/0x640 path_lookupat+0x160/0xb00 filename_lookup+0x1f1/0x5b0 vfs_statx+0xd7/0x3b0 vfs_fstatat+0x4d/0x90 __do_sys_newfstatat+0xa0/0x100 do_syscall_64+0x10e/0x5e0 entry_SYSCALL_64_after_hwframe+0x77/0x7f [...] Allocated by task 1: __kmalloc_cache_noprof+0x249/0x560 eventfs_create_dir+0x7a/0x590 event_create_dir+0x2fb/0xcf0 trace_add_event_call+0xbf/0x150 [...] Freed by task 11: kfree+0x1db/0x5b0 srcu_invoke_callbacks+0x3a3/0x620 process_one_work+0x937/0x1810 worker_thread+0x4f1/0xd60 Before commit 8e556432477e ("eventfs: Use SRCU for freeing eventfs_inodes") release_ei() used call_rcu(), which covered the walker, while eventfs_iterate() needs the SRCU grace period. Wait for both and chain call_rcu() from the SRCU callback. Cc: stable@vger.kernel.org Fixes: 8e556432477e ("eventfs: Use SRCU for freeing eventfs_inodes") Link: https://patch.msgid.link/20261009-work-fixes-rcu-v1-4-7446d2d335e6@kernel.org Signed-off-by: Christian Brauner (Amutable) Signed-off-by: Steven Rostedt Signed-off-by: Greg Kroah-Hartman (cherry picked from commit dd2c767814a876be0f16f0b7f98a403dc176f51e) https://virtuozzo.atlassian.net/browse/VSTOR-154849 Feature: fix ms/tracefs Signed-off-by: Eva Kurchatova --- fs/tracefs/event_inode.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index b1ad4f482f34..357663cfd4ba 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -91,6 +91,14 @@ static void free_ei_rcu(struct rcu_head *rcu) } } +/* read under eventfs_srcu and, by tracefs_d_revalidate(), in rcu pathwalk */ +static void free_ei_srcu(struct rcu_head *rcu) +{ + struct eventfs_inode *ei = container_of(rcu, struct eventfs_inode, rcu); + + call_rcu(&ei->rcu, free_ei_rcu); +} + /* * eventfs_inode reference count management. * @@ -112,7 +120,7 @@ static void release_ei(struct kref *ref) entry->release(entry->name, ei->data); } - call_srcu(&eventfs_srcu, &ei->rcu, free_ei_rcu); + call_srcu(&eventfs_srcu, &ei->rcu, free_ei_srcu); } static inline void put_ei(struct eventfs_inode *ei) -- 2.56.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel