From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 48FB4803F6 for ; Mon, 16 Nov 2026 15:42:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGFfgwh027405; Mon, 16 Nov 2026 18:41:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGFfgwh027405 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="QXI+DnoD" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGFfQch027340 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 18:41:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGFfQch027340 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4923b9fdd43so2578867f8f.3 for ; Mon, 16 Nov 2026 07:41:26 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErF/ATveEZo4pwVvQ+qvSC9FDrM8SBciO5/8GnxiK1SlG8xzOE8VLFcKHBxDFE+TOqdh38gP1w==@openvz.org X-Gm-Message-State: APuU4Z9Dw0IkzVXepV6WsiqGduz/diRJs30xDwrKd76d6/SSrvuE9CQd PgGRiRLc5Cu9O4JOB/gSrcPbix90/+lnmt4ortdlt9Zzm0x7nj9FVqpp3RJHMQTrciCZcLXTwpr 5dYD7cFkA0Y43ZB6++o+N5MUQwVKyzHQXQPaxrXcf5J/tMMAEcqoOXQ== X-Gm-Gg: AZFdTZe7eOwWNp1V+6QQR3jxENN5TzXIuxuNmaWwsTG3mP2gA7BYp0u2wPpEUxKZNuk JaLSCW3O/2dWxkzm0ZP0foZIAW/kESrhBdR0SXjUc2FpWMUc2CYynELrsWe8ZMaDeBOzgrB5p4P lYS8o6mH2p+h40sgCo0T+JzxX/tpPYfL/YhOo3Hxz3QapyDYiEoZcHbibtbECOn2vUgQdKbYAMV qTKiWwP7IEKz0gzsdZimOSdcKJPWPvyiJ7Bn3K5SDIR/19etW/mXgsaYGmHafTLyypiJpd4cdN4 IcNvawWYbDfQaNpmzj/K9hVH4UYgn1E7MvFwa4Q0ysBOteUoPUfrULarbxM+c752VgtepmZB5Dk x/2nHakImSLZ6fdegbYDD3Gzljoz5 X-Received: by 2002:a05:6000:2087:b0:488:57ad:d5c8 with SMTP id ffacd0b85a97d-49c6d453dbbmr29925758f8f.3.1794843686096; Mon, 16 Nov 2026 07:41:26 -0800 (PST) X-Received: by 2002:a05:6000:2087:b0:488:57ad:d5c8 with SMTP id ffacd0b85a97d-49c6d453dbbmr29925670f8f.3.1794843685449; Mon, 16 Nov 2026 07:41:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794843685; cv=none; d=google.com; s=arc-20260327; b=MQrJL9flRsL5WpGFdOyhu99oHjsLR07WsNLjTe0cVlgNC+ah9G7hdjykyGqpVTJRU9 k8Rslpt2Lnlwn4ssnuxXa36LNTnkmVqSsyYFIzbwd6VOtB1Tmm/DV03fJdO7HGhHQtmf k49dapcxTMgjQq4UWnM8Be5d4YiFAGsjjqYwSYVhKzZgQuEg8ZXUX83PlGSPZIyGxqt0 JZ5jtIyupDaDu0codcktSxa9ISyyjOc53s7G27GfVlvQTQ3iOFp3tpucXMhGZ1E5uROo S/PDcVY1uXkZq6MmTjpoHGjqXvUfrBOCN4ivFGj2TaK/LjdTchDzN5MpjC5E4+EsCnMr IyGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=rKwfGOQGOT0CzB44gGWkGsxMKUqUk1979UNojuSUj4Q=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=GCmwEQBnHZ/W1WfBdLSTmpMuXbc8xQE/cS5LMMSz4XGLvBVCGPYqLFjdotntDOBOgC MJ0tDAY+ygu6hilgfvzfun2mhtd1o+1h6RVF9OntLFzqlnuiRMcqzGqSJGWJOXIJyNcK 5KOLI8k0HepKxnjRGaDrxW8U26rtA9TobPUk+YUy3YBaG+qHQPeQ26hyhQmuHaFhpb3T JYJ/gwZoDwx02qHJiTNGi9AB4NMLJ+S8kkQc9/wXI5uWPvZ0n0cMlqo/Oc2o+ik7qoox bjCSYD3S3dADCOi8jhm0Sze40sprTskWQe1qKa4cbPfWkudyivZ7SO1u7V9traTZKXJM WFgg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=QXI+DnoD; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63e98937si23485833f8f.266.2026.11.16.07.41.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 07:41:25 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=QXI+DnoD; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=rKwfGOQGOT0CzB44gGWkGsxMKUqUk1979UNojuSUj4Q=; b=QXI+DnoDoF3b X1QzEykSPXfxZ8aL+t4battdwSD6dayNfFqlM/tdvlpXcWexnkONe8kcN43gWZoZraVVirv5C9bpt AYIJWVrVHErGLqRSYWcmbEmxemuo78JNtx+BNb429VeO09C1tIBFdoGWajCq8CeYpSOW5ZqpR9hvD fXOUizZ7tppcIwqHqmWvvSb72UFoYdvq4FkVe0fyl9tT43mSXLBlpLNoLnRHnmwXiRZ5WvnPASrZ8 spGNR8T+M783HzjVwgjrCYGcw99yzBjUdMjgGIaCCr3hMZgZWVq6ITHOV6EThMXkAHYHc9qisiGdy aOFfWAwhLnfdY1ETbzmhHA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xSylR-005tLh-3D; Mon, 16 Nov 2026 16:41:16 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Mon, 16 Nov 2026 16:41:14 +0100 Message-ID: <20261116154119.2979718-5-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261116154119.2979718-1-alexander.ivanov@virtuozzo.com> References: <20261116154119.2979718-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 4/9] drivers/md/dm-qcow2: arm the hold timer only for the first held request X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Every held request rearms tgt->held_timer, so while new requests keep failing the held ones are never retried. A guest that keeps writing to a full disk is enough to postpone the retry indefinitely. Arm the timer when the held list turns non-empty, so the held requests are retried a fixed period after the first of them failed. https://virtuozzo.atlassian.net/browse/VSTOR-152175 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-map.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index b987d459863d..d6f8bcd98a39 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -4569,7 +4569,7 @@ void do_qcow2_fsync_work(struct work_struct *ws) static bool qcow2_try_hold_error(struct qcow2_target *tgt, struct qcow2_rq *qrq, struct qio *qio, blk_status_t bi_status) { - bool held = true; + bool held = true, first = false; unsigned long flags; if (bi_status != BLK_STS_NOSPC) @@ -4586,11 +4586,12 @@ static bool qcow2_try_hold_error(struct qcow2_target *tgt, struct qcow2_rq *qrq, pr_err_once(QCOW2_FMT("underlying disk is almost full"), qcow2_device_name(tgt->ti)); tgt->event_enospc = true; + first = list_empty(&tgt->held_qios); list_add_tail(&qio->link, &tgt->held_qios); unlock: spin_unlock_irqrestore(&tgt->event_lock, flags); - if (held) + if (first) mod_timer(&tgt->held_timer, jiffies + HOLD_TIMEOUT_JI); schedule_work(&tgt->event_work); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel