From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A4C89803F6 for ; Mon, 16 Nov 2026 18:06:09 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGI4s2G030498; Mon, 16 Nov 2026 21:04:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGI4s2G030498 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="yYV3NSdE" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGI4fQd030472 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 21:04:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGI4fQd030472 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a1f03f2e8aso32377095e9.1 for ; Mon, 16 Nov 2026 10:04:42 -0800 (PST) X-Gm-Message-State: APuU4Z+CodgI51pnsIrPh6kUC0NncFSYSJiCb1QWYHxxtpeC4Pqa95K0 zN/UQ4n0ZatD3A5UczuGZUinugBMRLgznhV6KOMNEDh07sWoVnvssN25z75yXGh2OxKEQgQ+CnA 3eC/2X+aofqyILYle8V4b/hV+8pcxXmYmJWoVumDkKypn3Ak8+qYflQ== X-Gm-Gg: AYBFou2FoaSV7jtDJeomlbDJjc1p0gW78JPkzpUsP5UJs/pwQkU5CrakRr3pOYtVk/B nLPfvRMXUnplQo+hFKVtAsu3zJVNFf/z04gYX1gETwM32COO5Nj72f2QOPar6oyRjBGPSLrsRCf lljFrNx6Rr1tNKcYYNKotUBEkHi0OxQJyhrVYZgzRvsi6UVO+XKwJ9iI696W/JGSPavNWm4Tmni DmWGiF9TmUj1yl2wSA/Md71f1BEgG3xxrnLjSEi4QhNx4NCEtCq1eaPxgiiZp0nrOolRFiNCPEM opAUk0d5OnOBMGOXjCZj789H6hKb/r2j+w0sP88/yHz4N39yJLjbSXI9u4zTG6+MxZc0zTl7MaS Z8OkYTAgpzlrtgNVO+KId8uWc2w== X-Received: by 2002:a05:600c:1f96:b0:4a1:777b:8a12 with SMTP id 5b1f17b1804b1-4bb55a4ea81mr243729275e9.14.1794852281651; Mon, 16 Nov 2026 10:04:41 -0800 (PST) X-Received: by 2002:a05:600c:1f96:b0:4a1:777b:8a12 with SMTP id 5b1f17b1804b1-4bb55a4ea81mr243728555e9.14.1794852281127; Mon, 16 Nov 2026 10:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794852281; cv=none; d=google.com; s=arc-20260327; b=OtzJGz5HvOVbXInJz9KXNyRlQHNIZ6xdkCbh+Z67A2XfHRG2iY2QblF8bWurg50Ima enqwn6HbbaNZWDI4mZrKlK6EsLcFzmszUs16P0l4vcMo7dVABIaPApvXcstVzQL07XM4 /wNeyLpVs9HgGmLNZB3IVII+PzehxWykZx3u/jgHve151T7H761yFEMm174pwl0zjcq5 B/0s1h0K0HtJ4+bu2WkAdZZGtOacSENcqbnrAaumwfRyUHh+jDKuIHSpO7YndNMVMhcu kMg8s1sTNUSZ+hmL8+b2tTH77C6W/EwPWW3n9yt0lwjhrJABIawWaq3kAHvcM2OIT95L bCjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=3NnBl5nXmXRaz2RAGtxQnTmM9QgPWDxHZ9vf19tLp0U=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=oYfnHkYmZklXmLx51y51ojG9+ByNlIB0I7hZpfZ/YcVpN8bFSSddYT6sxFOvU7BaVT MwHd6aiYaHeBnUbMKjHdZQev+7YxPU3RSCPXw/ZAoj2yCxbSMS37Hf9XsHN/v4CsfbAC MAbVCzAnI5E/8r9CQvpvyD+GhvZCbVkJzHaP/9BavZHczAoQ4FtqYAHLTsdeS6LtorJh SOMwziOBqN5p28wRvOom4hGM4PaTJO7F/N69H5RQZ3Q5snzUDrkSH0F8BZ668tUe59/A GqDqWu/w/gLP1wTSwF6pmdQWtqCKcXJ2I/pefp2egO3iaInivDu0hpDtrKMTDge+Q+X6 R2Wg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=yYV3NSdE; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6002132fsi22175161f8f.25.2026.11.16.10.04.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 10:04:41 -0800 (PST) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=yYV3NSdE; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=3NnBl5nXmXRaz2RAGtxQnTmM9QgPWDxHZ9vf19tLp0U=; b=yYV3NSdEPltz zeO55YM0ReLNapjVjiol8KnRjO+8B2vaFS7XOGnpYjjFvP7IJpn0QgcuHEWMthW3nYfDiimxBtd0A BsdaJgbSaN7RIHTTCHkWlHqid6KKnDA4RpHa7ivpqEjup7PBcoZ0c0CJzvlHnHhYVujG5awylGl+B IgsntTLqhA6oyMxjv7e7BRu3jmICyDBbnqqvJrq2DiMA2KQ7c48nx2SMO1wTXWVLFH7ncMH01VDCO dp+HuvWhT4uARGFniz56dajze2UjWCnu8PzNJVS11macgS/vkDswOus7vpfxn5F34NUPPNQAgCPQf RHJ5EECO2/dBTnupa2vMpA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT105-008bMO-0l; Mon, 16 Nov 2026 19:04:32 +0100 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Mon, 16 Nov 2026 20:03:03 +0200 Message-ID: <20261116180419.685520-6-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.56.1 In-Reply-To: <20261116180419.685520-3-eva.kurchatova@virtuozzo.com> References: <20261116180419.685520-3-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 3/4] ms/mptcp: close race between scheduler and state change X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Paolo Abeni The mptcp scheduler may race with subflow sockets state change: data transmission on the selected socket may fail and a later release could try to use mss_now reset to 0 for a divide operation. Address the issue by explicitly checking for the critical scenario. Fixes: c886d70286bf ("mptcp: do not queue data on closed subflows") Cc: stable@vger.kernel.org Reported-by: Shardul Bankar Reported-by: Xinyang Ge Closes: https://lore.kernel.org/20260525194828.1137119-1-shardul.b@mpiricsoftware.com Signed-off-by: Paolo Abeni Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) Link: https://patch.msgid.link/20260917-net-mptcp-misc-fixes-7-3-rc4-v2-2-0cf5c72667c8@kernel.org Signed-off-by: Jakub Kicinski (cherry picked from commit 42064de57fb83231fcc89663a94885f228a1ee53) https://virtuozzo.atlassian.net/browse/VSTOR-155322 Feature: fix ms/net Signed-off-by: Eva Kurchatova --- net/mptcp/protocol.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 1d4754b20cea..685c8a395476 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -1434,7 +1434,9 @@ struct sock *mptcp_subflow_get_send(struct mptcp_sock *msk) static void mptcp_push_release(struct sock *ssk, struct mptcp_sendmsg_info *info) { - tcp_push(ssk, 0, info->mss_now, tcp_sk(ssk)->nonagle, info->size_goal); + if (info->mss_now) + tcp_push(ssk, 0, info->mss_now, tcp_sk(ssk)->nonagle, + info->size_goal); release_sock(ssk); } -- 2.56.1 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel