From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8A56F817C6 for ; Mon, 16 Nov 2026 20:47:21 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGKk4Wp031563; Mon, 16 Nov 2026 23:46:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGKk4Wp031563 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="RiLYQXGQ" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGKk37T031555 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 23:46:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGKk37T031555 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-492b5408dedso2143988f8f.3 for ; Mon, 16 Nov 2026 12:46:03 -0800 (PST) X-Gm-Message-State: APuU4Z/RWhW1Or88bpuMlMf1wOfD9tGintR5SHnDoduM4rI2tprJ5DzZ ARaUI8VHQ+2rbZenURSX35/MogKeNsG483m8c5xn5sQ07MmYxticfoGPuPEcCeLObOkl2xpF6py hAaRfQ4R6Ewa6jNso6WqibQK8W7XxgoOrVbALCazXJzEI+2RkE8S2AA== X-Gm-Gg: AZFdTZebcA2Yq9tcUVNIbM3iJhf20cVL1GQ+gPWZeVIQwEOTd08PjN2lPAlBTO8HrpS Dyu0iyPdbPIX+v9jcUqGGZsTSMAOoYF4H3bOMkBIY0hbCTP4kw82ge4nTNTWzmr1gcqAFIbs8jd NywClkGTjiEyMQKtFPGDY0NeTeM2dbnFrD45s//5+eqW2qay6WNjd07NTW5UpjzxNe6RBPnrals RPFs1kpIjsPuUoTthJ5snGD/clCfNLX8Hiv1jgxW9MjC4nENLRvZZAobbcSiWCnfd5L3h55AhcP F6+ndWn20iDHN16jaNSVRHpNBQ1Nw9a18gotoY1IpRkYMmZ98xOfD5xij5OUM+T/TKKl56JF425 9/3ouPQO2oUL/VWsup6oBvH6x X-Received: by 2002:a5d:5c03:0:b0:492:9630:6a71 with SMTP id ffacd0b85a97d-49c6fc9dbe9mr29062947f8f.1.1794861962794; Mon, 16 Nov 2026 12:46:02 -0800 (PST) X-Received: by 2002:a5d:5c03:0:b0:492:9630:6a71 with SMTP id ffacd0b85a97d-49c6fc9dbe9mr29062923f8f.1.1794861962305; Mon, 16 Nov 2026 12:46:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794861962; cv=none; d=google.com; s=arc-20260327; b=pUPc1Sxl18icyc1ooWlTk1zc4ypkrSxPKyrpYsj4sythlhoR/jMBzgzep/tOI9Xv5p OdDk9RC14nOI6Um/fL5I+mNaLJ37hSMG/Q6CvxTw+7mQDioDbyqPNgig2A1a6VsO2Swb /ss79ZorQOIAqzRzxqf91zHEAGqxczAv3vY1dMYL6vizt6WAOtL9VTPHwCOBwJahGhH5 O0W/QvIdLPbKWLpD/jo0cLS857GVhVfyj7tB3TsWi/2WyD74CoDuOnKQhDcoqV/5bBWD skw0LsGG7lFbvwUsjvKnr2SmM8+gasZd5Q4erLfLazXWLwo+hraHnC2Y0l0uzeac/aZN q+Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=CEw+Wy7rqM3xhMCrp3KSmYi1IohdvPkyxTPn+uwD8Ec=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=gSewtzapInrsEfKPNLjSPlwePiw+pLoUynrd8vgJZBx9VBIt8+FaoUYU9vDS0JVc8p YEa1OFxVyhHqoEBMJGXFKV3PG1bwY6ZdMfv6Y6W+urwKFw7WW7hnw1lc/jPDc2F3cnAM nGL93zbJYpTnKTHcCpjDMVtJAvQQEOliz0uYdNvSh86J2xUknJXj/8ZLYnfR8awkNRTM rg8V53dwl3yC7kwdv/uJOVfSD3AdOEudIBMt4dGj8EXIH0bEmaEqJupDE9hFhZ0pMwD+ z9uFm7DDkl9oNXjIUnso+GaEXcvob0K0Q3x0n5sVuPi6CbJ7XRGmVXi5oOYV4K1d9qRR 928g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RiLYQXGQ; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63122445si22410354f8f.102.2026.11.16.12.46.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 12:46:02 -0800 (PST) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RiLYQXGQ; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=CEw+Wy7rqM3xhMCrp3KSmYi1IohdvPkyxTPn+uwD8Ec=; b=RiLYQXGQGMBY AwQbUaRlQY/1jPn2zXzHcVOBiKWjT3MYsBGUepRzZgHe7H/kQn/l1qAfgEU7U7VrXAS7zQE/g4ew2 24IDYPGNvuiw95f1IwbM/migC2OX2sBCaSyu4RldGu+pruSWmgu3Q11sU9LdKjdvZIfFn7Bl0+lGu HWytc/0KJEPbmL6bJRnjfYdeSHRPsCUOKczf8Lu9Avru8TFQBPYkZYgvkLsfOliGJBLCeTE8Qcct3 748QFN5637J5eWWps8+Wdw1GptRU16UXLtlrfBnfWIFTPhSO0fje0X/QOPMF+oo0eoUhqyEFxlINR Zv4COAA1rYWAbSEeBX3cWA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT3WD-00BfjZ-2v; Mon, 16 Nov 2026 21:45:52 +0100 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Mon, 16 Nov 2026 22:05:52 +0200 Message-ID: <20261116204557.718500-1-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.56.1 MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 00/11] ms/mptcp: stability fixes X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Patchset for task https://virtuozzo.atlassian.net/browse/VSTOR-153491 mptcp_join.sh test 021 never completes in CI: a link fails during a bidirectional transfer and the transfer stalls. The series backports mainline fixes for the two problems behind it: - Endless retransmission with csum enabled: A retransmission can send data beyond snd_nxt, the acks for that data are dropped, and the same data is retransmitted again and again. Patch 1/11 fixes it. - Receive stalls under memory pressure: Incoming data over the receive buffer limit waits in the subflow queue, and may get stuck, blocking further progress. Patch 8 drops it instead and patch 9 prunes the out-of-order queue, both relying on MPTCP-level retransmission. - Patches 10/11 and 11/11 are mainline fixes for patch 9/11. The other patches are prerequisites: - Patches 2/11 and 3/11 are cleanups the later patches are based on. - Patch 4/11 lets one MPTCP retransmit timeout resend more than one data fragment, so the data dropped by 8/11 and 9/11 retransmits sooner. - Patches 5/11 and 6/11 keep the window announced to the peer within receive buffer, so that a peer that behaves correctly does not send data that patch 8/11 would even drop. - Patch 7/11 builds the dummy mapping of a fallback socket from the TCP sequence number instead of msk->ack_seq. Without it, data dropped by patch 8/11 and then a fallback to TCP would give the following bytes the DSN of the dropped ones, and the reader would get a stream with bytes missing. Left out of the mainline series, between patches 8/11 and 9/11: b1224c4b40f6 ("mptcp: enforce hard limit on backlog flushing"), as this tree has no backlog, and 996643574cc8 ("mptcp: avoid code duplication in __mptcp_move_skb()"), a cleanup. Mainline 0e24d17bd966 ("tcp: implement RFC 7323 window retraction receiver requirements"), which patch 6/11 sits on in mainline, is not taken either, and 6/11 rebases the same way it does in upstream stable 6.12.y branch. Tested in QEMU (4 vCPUs): test 021 with a failing link have not failed, against 3 failures on unpatched kernel, and the net/mptcp selftest suite passes with no warnings. The v1 also did fix the failures described here but was arguably a less coherent series of patches. Changes in v3: - Add "ms/mptcp: cleanup fallback dummy mapping generation" before "ms/mptcp: explicitly drop over memory limits". - 6/11: A rebase note on the commit, based on 6.12.y tree observations. - Expand cover letter. - Rebase. Link to v2: http://lore.virtuozzo.com/kernel/179484894400.861498.16940306217017869314.b4-review@b4/T/#t Changes in v2: - Add "ms/mptcp: close TOCTOU race while computing rcv_wnd" and "ms/mptcp: allow subflow rcv wnd to shrink before the drop over memory limits". - 3/10: reword the rebase note. - 8/10: name the two skipped mainline commits in the rebase note. - Rebase. Link to v1: http://lore.virtuozzo.com/kernel/179450441149.4060562.12778470791653323060.b4-review@b4/T/#t Paolo Abeni (11): ms/mptcp: fix retransmission loop when csum is enabled ms/mptcp: move the retrans loop to a separate helper ms/mptcp: move the stale logic out of retrans scheduler ms/mptcp: let the retrans scheduler do its job ms/mptcp: close TOCTOU race while computing rcv_wnd ms/mptcp: allow subflow rcv wnd to shrink ms/mptcp: cleanup fallback dummy mapping generation ms/mptcp: explicitly drop over memory limits ms/mptcp: implemented OoO queue pruning ms/mptcp: being below memory limit is a likely() condition ms/mptcp: avoid pruning for OoW data net/mptcp/mib.c | 1 + net/mptcp/mib.h | 1 + net/mptcp/options.c | 43 ++++---- net/mptcp/pm.c | 43 +++++--- net/mptcp/protocol.c | 226 ++++++++++++++++++++++++++++++++++--------- net/mptcp/protocol.h | 11 ++- net/mptcp/subflow.c | 8 +- 7 files changed, 249 insertions(+), 84 deletions(-) -- 2.56.1 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel