From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
Cc: devel@openvz.org
Subject: [Devel] [PATCH hci-8.2 v2 0/3] mm/memcontrol: tidy up the memory.numa_migrate code
Date: Tue, 17 Nov 2026 17:24:42 +0100 [thread overview]
Message-ID: <20261117-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-v2-0-1dce69bd115c@virtuozzo.com> (raw)
Leftovers found while fixing VSTOR-151607, where the allocator of
memory.numa_migrate had fallen behind the upstream function it was
copied from. Nothing here changes behaviour.
- 1: update_lru_sizes() lost its only caller when the isolation loop
switched to lruvec_del_folio(); static __always_inline, so no
warning ever came.
- 2: the comment in the isolation loop told the rebase history of the
code. It now names the upstream functions the loop and the allocator
copy (isolate_migratepages_block(), isolate_lru_folios(),
alloc_migration_target()), which is what the next rebase has to
compare against. The commented-out conditions and the pre-folio name
of the allocator go with it.
- 3: the comment of memcg_numa_isolate_pages() speaks of pages only,
while the loop stops at @nr_to_scan folios scanned or @nr_to_scan
pages isolated and returns the number of folios scanned.
https://virtuozzo.atlassian.net/browse/VSTOR-152197
Assisted-by: LLM
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
Changes in v2:
- Rebased onto the current branch; the numa_migrate folio order series
it applied on top of is in.
- 1: cite the commit id of the branch, 810e6836a6dc; Fixes: added, as
Pavel suggested.
- 3: only the comment of memcg_numa_isolate_pages() changes, and it
names both limits, folios scanned and pages isolated; the comments of
memcg_numa_migrate_pages() and of MAX_SCAN stay as they were (Pavel).
- Link to v1: http://lore.virtuozzo.com/20261028-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-v1-0-aa959eecd3fd@virtuozzo.com
---
Konstantin Khorenko (3):
mm/memcontrol: drop the unused update_lru_sizes()
mm/memcontrol: say where the numa_migrate code comes from
mm/memcontrol: say what memcg_numa_isolate_pages() limits
mm/memcontrol.c | 49 +++++++++++--------------------------------------
1 file changed, 11 insertions(+), 38 deletions(-)
---
base-commit: f386929460e779a18f354d1b01c051f8af1e5b41
change-id: 20261028-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-dcc488d8d106
Best regards,
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next reply other threads:[~2026-11-17 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 16:24 Konstantin Khorenko [this message]
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 1/3] mm/memcontrol: drop the unused update_lru_sizes() Konstantin Khorenko
2026-11-17 16:27 ` no-reply
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 2/3] mm/memcontrol: say where the numa_migrate code comes from Konstantin Khorenko
2026-11-17 16:28 ` no-reply
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 3/3] mm/memcontrol: say what memcg_numa_isolate_pages() limits Konstantin Khorenko
2026-11-17 16:27 ` no-reply
2026-11-17 16:27 ` [Devel] [PATCH hci-8.2 v2 0/3] mm/memcontrol: tidy up the memory.numa_migrate code Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-v2-0-1dce69bd115c@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.