From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id EB9138017D for ; Tue, 17 Nov 2026 10:11:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAAiZm007805; Tue, 17 Nov 2026 13:10:45 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAAiZm007805 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="KaPxU+Vz" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAAUbx007748 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 13:10:30 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAAUbx007748 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a35e1d2dddso36894655e9.0 for ; Tue, 17 Nov 2026 02:10:30 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErElNtoCGeC5uQ/z1kPWf0upxHXxt986kejS4BFyn3Gb8iG9Pwr90iSzdxNqrO+cgxBXPeyeVw==@openvz.org X-Gm-Message-State: APuU4Z8XdwJId1QAKyrpySi9UpOt/Q1G0iKAdGyf6VFyQ2EPKGvy8bSw kDYXuvywoUOu9roPyGX6s8BgoW8W4us6ASxPR1aAfsxRFHMn2NZJx87aOEX/T/2JH4HkPuLjPTb 5EYKunZpcRx7FOSXJsJkUZ2ZVqtbZ60vOFEyGXw1OtjHS5EaEMaakmw== X-Gm-Gg: AYBFou0RmLSHk9FI/zGq5GNUWOhHjdH4r5i3iJRuWYc/udUn1fFKlJJ+lZapQjLgq2W ejax2DuZ6W+YpxOxkuh8rAO95L5+yHIBNEVyVQa2rARun+zT+kiNi7Pjt6SK7K+W7LpowZ0VaOX /sii8rDtUhGWshmtYrq7wi87eQUFLHVzjBK6OxAtuu+Id5FVzG71HxPhNEHZz1dT2RHoItbmce3 Rdz4QeZwika9qNYQybWYv7wmejlvL2o79jbl9w6kSJBVgXKg/YmTY468oAofNIhHZgSMwxCmkLJ MvJBy7J3CG3n1GtjRDbDAi3R6pJ5mU+H+LkBuvCwWH3mCSqmA+ogcnWzsoPKtRt1JdU3vmBEOCE IBcNbP12fZIEfrPxmKi1+G2PDhDQ= X-Received: by 2002:a05:600c:6309:b0:4a2:5267:3cd4 with SMTP id 5b1f17b1804b1-4bb559f3bb9mr271831355e9.3.1794910230407; Tue, 17 Nov 2026 02:10:30 -0800 (PST) X-Received: by 2002:a05:600c:6309:b0:4a2:5267:3cd4 with SMTP id 5b1f17b1804b1-4bb559f3bb9mr271830755e9.3.1794910229971; Tue, 17 Nov 2026 02:10:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794910229; cv=none; d=google.com; s=arc-20260327; b=SAwy8QlA5gyGVTZ9V2M6Rfc0nq/kTel28xgubQyop/tBlm1JGJU4GLyvu3PnKsQqk+ 1DO5HDdOc5h1wOc2Lu5HLoMrjDQ2VIRZichqMLpscO1ifeaWMsKzPD/Biik+m36qDwWx cPP0vnSFO1OCmjsGAN3H3y9tSK5XfAbeALzFwnWVh1i7BWXJKTKG1acT0nnPhU0HKTjT 8mTTEYvFe+xjQgyviQedM64cx3ZGU5QRtNB/g9k5G9uWy779cG5D2y7Txy/2SzDfy6PQ lqzDnm/hSmzHYsgei8P0AblRlcJZp/Oi2gaBKoBhq43ZntUYAXjRPhDZJSRMREs8bnUG Hs/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Ubafz2R8VCgljJO5n3csQxk3AuOxNu6Fycd0Az4o/9c=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=i8yjtnTADXN7jsAbCMV3cS0IOEfNopr08wFm6x6IQZq+3PuEBNvcwb4c5vQlq8lfMd 5NPhB6euQVVnXieERjAQ8GxORRdm3ZAvcLhkTPvjrqTUhToMy54Yx0TQ5dZz3fUAYLqL bEa/1PRHnfXjqndx9soB2LphiLPjOqFW3m1+ZiSCO86sPoj3DHk/gYWckpX7a+Dg1qw1 8bUj2CAgUZAppmioOYixYeAWf//NyWqYeOoFqsMD+OumGGmD66gFO/Mi6W3+19WKm+ET 5ER9qTLpQNvbOMWFRifhdiUuVGT5OBn93V6T/CZStMAGjepPTcg5locaYwMp8vuhBVzO m9vA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=KaPxU+Vz; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c5ff2d04dsi25701692f8f.8.2026.11.17.02.10.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 02:10:29 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=KaPxU+Vz; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=Ubafz2R8VCgljJO5n3csQxk3AuOxNu6Fycd0Az4o/9c=; b=KaPxU+Vz9vHY IO5/yqLKeuIHu1VkL++RNQ2LFgK+6ZFCfNArO4q9JqQLk6WyDgpT5JkBqeosZwy85XbFyCWuN22bJ OW1qz/OXLX8PhuZYekoj1ePrj8ZhI7QILa5vp24X6teiEs3GsN4kHw19u6tLczwBuBgy5iqgMSFS1 23YIQMvSbaBGK4RJZx2XwNKQbE+MhYSAD+fr3kqzg8N4M8jFngnosaIFpTqC6gQPRa0pFhO3SAbMR klOVT5gyfC1/shIk5RsK449O8AyZfhctFWScRzk0XFCzmEG4dCMsIC4V8uccBTLBc2Fh+wHMC/Zyk dZ6FJubqym8koJDTZaC+Sw==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTG4j-009Isp-1A; Tue, 17 Nov 2026 11:10:20 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 11:10:21 +0100 Message-ID: <20261117101026.3071579-5-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117101026.3071579-1-alexander.ivanov@virtuozzo.com> References: <20261117101026.3071579-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 4/9] drivers/md/dm-qcow2: arm the hold timer only for the first held request X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Every held request rearms tgt->held_timer, so while new requests keep failing the held ones are never retried. A guest that keeps writing to a full disk is enough to postpone the retry indefinitely. Arm the timer when the held list turns non-empty, so the held requests are retried a fixed period after the first of them failed. https://virtuozzo.atlassian.net/browse/VSTOR-152175 Fixes: 6e2ec304689f ("dm-qcow2: Pause IO and notify about ENOSPC events") Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-map.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index b987d459863d..d6f8bcd98a39 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -4569,7 +4569,7 @@ void do_qcow2_fsync_work(struct work_struct *ws) static bool qcow2_try_hold_error(struct qcow2_target *tgt, struct qcow2_rq *qrq, struct qio *qio, blk_status_t bi_status) { - bool held = true; + bool held = true, first = false; unsigned long flags; if (bi_status != BLK_STS_NOSPC) @@ -4586,11 +4586,12 @@ static bool qcow2_try_hold_error(struct qcow2_target *tgt, struct qcow2_rq *qrq, pr_err_once(QCOW2_FMT("underlying disk is almost full"), qcow2_device_name(tgt->ti)); tgt->event_enospc = true; + first = list_empty(&tgt->held_qios); list_add_tail(&qio->link, &tgt->held_qios); unlock: spin_unlock_irqrestore(&tgt->event_lock, flags); - if (held) + if (first) mod_timer(&tgt->held_timer, jiffies + HOLD_TIMEOUT_JI); schedule_work(&tgt->event_work); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel