From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id C783B8017D for ; Tue, 17 Nov 2026 10:45:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAi5bP008364; Tue, 17 Nov 2026 13:44:06 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAi5bP008364 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="qoX4L9Y8" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAhXYw008304 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 13:43:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAhXYw008304 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4b764ffc014so34049005e9.0 for ; Tue, 17 Nov 2026 02:43:33 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHXcNeu8kMbmNEMj93I2RokB6mnWG/3GfVOArr357dw52IoO/VZnlePPSBZhq5glvDqsUh5UA==@openvz.org X-Gm-Message-State: APuU4Z+a6Nw1SfxCOdoTD0FeFXwOErDWeAP4trQz/TmOUfHLSsa76tJX Iuv9h6yRYukc3YOoj3e1b00zj7xOgVCtoKosFCgUffQlOe1guOLP+uL7ESxr5iqnSgoJTyOBGA4 A+QyS24vAdDW0QPufdkMGmtioD9mxHWgRVzIR0ueGp36dcLqjJK20nA== X-Gm-Gg: AYBFou24qGdhNyVFCXb+LQ7kTssuPuHdhrwVgx0a+m/8FOiAQafVpiF6DzjyV0XntB3 C34dBYE3J5U69p7DRVovaVx/x5WWwpT5x7WlQuktjTghJ6tpQAeuaGBQx/jpk3Dpt8D2NtCL8bc 5ILBDsuNRcT9fsczYZGJ1dXqkd18Bwr+O4MTArF+6DSl9cE5PswUKyirjZ5AdS4r7z7mQpaUSs/ KOIXnBiTXGSnhvk5vTKjkxBQx6LQUau+stAvG5fk3w+rfm9pNk+EyiO0QHHXx4YfuBH3I/+mtcX U9TJVh1F3Xoz8+F8ABfp+NKFVeNpOdQYXYglRCFl86EPcVXDGJ4tkwKAWcHRWZxZZ+m8Ojuh2v2 ZavC4H1WAq/FKskIeKMRn2ID6gg+5 X-Received: by 2002:a05:600c:46c9:b0:4a3:d327:6ed with SMTP id 5b1f17b1804b1-4bb55a5fdf6mr297456845e9.17.1794912212712; Tue, 17 Nov 2026 02:43:32 -0800 (PST) X-Received: by 2002:a05:600c:46c9:b0:4a3:d327:6ed with SMTP id 5b1f17b1804b1-4bb55a5fdf6mr297456235e9.17.1794912212210; Tue, 17 Nov 2026 02:43:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794912212; cv=none; d=google.com; s=arc-20260327; b=NkILEB3UCWo8NNOpZxtSRG4ID55j6KdhOLdR7FP/DsIewhBcLrqq3Rqc3tBY1o3LyD aMWUeEN19+ggJIKWubIKdEdw0nrhau6yyQc9OiB+oeIC5rxwLnBWKwZDw+ohr8szHVA7 MdGJnW6yRBfN3idZygPajyKLK5/Sm1Hgm1OqMWjOAUz00vlNpI/sAuW7/xxjmWwm8Osn qb8PZQgSDfM0XOE6IrAqBplEY/2+Rxjw84OnKf2MuV39VncjDgqY4m6WtOJmJVaOcw8a plpSwcTQ+SAntwHbJPUM3s6sk4U57Gt4+Nrr8AP0S67ZZdtnLndEgUzE4JSwOnSYB8R4 9PIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Ubafz2R8VCgljJO5n3csQxk3AuOxNu6Fycd0Az4o/9c=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=HcmxpzPVJzDdHNmPgzwJn95tAgW3giljtmpsIvFvGu6DrcTOxy75P5MzS9u56PXJIz CV4OhOloZ1XiHbxH1OyrYtUgcbZBdsQOE1d8jII+FTUREbxsPvgbEEQdh1/EtMONwbDH +xOF/sCkvi5y70t+DmeeD80ZsZcFeJx9ADCgVh2rr4Ot28hgp9mTKg3SkxbcDq1aStCF N5biJJ7ScVRuQfdbJ6LLOZi3dfFXtElbJ3iY7CYtSux85teTte/HajeRDLY4FPsxzvv/ m0qC0fBgIZUkh7wQGPFDdNzQNFDBgjwbyr456piAIXw015OYqd7x/0QGHB/dBBzl8V1x aM6Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=qoX4L9Y8; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4bb784405e3si47429405e9.14.2026.11.17.02.43.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 02:43:32 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=qoX4L9Y8; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=Ubafz2R8VCgljJO5n3csQxk3AuOxNu6Fycd0Az4o/9c=; b=qoX4L9Y83h6r 1l57YW6eIVXOCukAuDeihxQEn6Aa7v+rw9GxhF2i95/8tF8Pz1P7OqNxl2PS2FnfkadCtNeO4BFpo wuKOs4WcQ9pH+ClhfuUF9/kHHG7PE9NR6eG2Agi+V9AnkB04mX4FVl7Z8qFgs88T+zhHrWQbZ9Bxq jKan0hLT1PKaxN3XVDTz+BWDp+s6uFJhFJlE6iYTxZuEEevAFyqL3WovfSI+fitdKug/eReA3XGDC A0yvI0iw+bV/vj5nIYSjUfsRA+GzNAnDf7a+d9+1G6b+l2Mf7LHX6YlKnXbzoSsIUUMFG4eqCYxqB yRsGRZC3U9jeARUe+hnw5Q==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTGah-009vj8-1u; Tue, 17 Nov 2026 11:43:22 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 11:43:24 +0100 Message-ID: <20261117104329.3079812-5-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117104329.3079812-1-alexander.ivanov@virtuozzo.com> References: <20261117104329.3079812-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 4/9] drivers/md/dm-qcow2: arm the hold timer only for the first held request X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Every held request rearms tgt->held_timer, so while new requests keep failing the held ones are never retried. A guest that keeps writing to a full disk is enough to postpone the retry indefinitely. Arm the timer when the held list turns non-empty, so the held requests are retried a fixed period after the first of them failed. https://virtuozzo.atlassian.net/browse/VSTOR-152175 Fixes: 6e2ec304689f ("dm-qcow2: Pause IO and notify about ENOSPC events") Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-map.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index b987d459863d..d6f8bcd98a39 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -4569,7 +4569,7 @@ void do_qcow2_fsync_work(struct work_struct *ws) static bool qcow2_try_hold_error(struct qcow2_target *tgt, struct qcow2_rq *qrq, struct qio *qio, blk_status_t bi_status) { - bool held = true; + bool held = true, first = false; unsigned long flags; if (bi_status != BLK_STS_NOSPC) @@ -4586,11 +4586,12 @@ static bool qcow2_try_hold_error(struct qcow2_target *tgt, struct qcow2_rq *qrq, pr_err_once(QCOW2_FMT("underlying disk is almost full"), qcow2_device_name(tgt->ti)); tgt->event_enospc = true; + first = list_empty(&tgt->held_qios); list_add_tail(&qio->link, &tgt->held_qios); unlock: spin_unlock_irqrestore(&tgt->event_lock, flags); - if (held) + if (first) mod_timer(&tgt->held_timer, jiffies + HOLD_TIMEOUT_JI); schedule_work(&tgt->event_work); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel