From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023114.outbound.protection.outlook.com [40.107.162.114]) by lore.virtuozzo.com (Postfix) with ESMTPS id 53826803F6 for ; Tue, 17 Nov 2026 10:50:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kfPYucCdNa51yjv74gsZ4V5WP4msPHAfdRKChXVoxIeAiGVYTQXyDxax62lUWJZQK9Kp8zM1kLGzFddQHB9AO+rqVZxn44uodsS7bWwJ9/e5HKHiOZLbzrr9Ro9jyGwujkrgq8Jko3+dVA5nLo2nQrlV+BwLHj0an0CJ4AvfDXKiSQ9g5sDP0bdlRNq2QmbWAeK2mcvvz58Hi0Erx3kRunvsSGdXAQiUBjfBba5o48oLvH941x6nQnJyA99jhvGisznvijMfjVrkt7KEGsdnu0Qub8IOoDJ8xOa4yQarz0F9/gKx6Ak9ueo8RbK3+S7uqxBEuFknthXOr+TV29CKPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6e2EcA1o7+3f8CM7eQGhhyqdD/n+f/sdGAPS4KIjPEE=; b=R6kyH5YGMcuiqXNbx0LKAeyn6noyLEE6mEZLskar+WbLVfmF1fPLI53aZxCSCn0l4+aEJkNvY9c2Ko1j/2sP3pgVOLPpCwf6fjxUriiFlj61tTQ3js7UEHl7k70u1KSY1rNeF++pOgzRdgFobpGexp3+548nAEMaHyt6dE6VVQNHm2z3btHE5SX+TmGLw75X/2Erv9jKfCOZmyBdmsVF0SS+Q6gPttuigb8+WA/iLzlQ6QtZoVR4gzUG3Dmw4u02j1Ty7kI313OHi3TaqzJqkN0w+OIRrDSwEvL5nDwVOFylZlUOM+Bx5Pa5fe/Xxv47wpHTmJAP+Us6b42gOyPr+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 130.117.225.111) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=virtuozzo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6e2EcA1o7+3f8CM7eQGhhyqdD/n+f/sdGAPS4KIjPEE=; b=sp3WVZ53Ix6iq3lp8SCZFasdLEVJ1G5ZpUMZLKJzDMI0TgDLbYSkfUcLFlmZ0EyI9NRxhGbwC5CAdoK5JPi3MlRYlEhHqEJPrZ81UixsOUmHifPZuhsbc9FUprertY85CRnHG9U9oQjbEffFrLsyRJTzd0bvvEMKwuvoYFAfSTFAiaqZwfrDwVEbDEsMJXiXaONhwWaBpwccnLMSMAW0lZa61Sryq8R2JtvNOAdzF46GV4cEc07Fqp/92MXbhLKyE+n0bJ4DGGw4Zkqu++MCmaVPl3nb+nNvnvO9WcU7h5yRVfniUWvF7vL1zDo6CaK+SIuiLwO6t+dul8WWil6uFQ== Received: from OS6P279CA0170.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:38::11) by PAWPR08MB11142.eurprd08.prod.outlook.com (2603:10a6:102:46c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.13; Tue, 17 Nov 2026 10:50:06 +0000 Received: from CPH1EPF0000051A.eurprd04.prod.outlook.com (2603:10a6:e10:38:cafe::9d) by OS6P279CA0170.outlook.office365.com (2603:10a6:e10:38::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.14 via Frontend Transport; Tue, 17 Nov 2026 10:50:06 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 130.117.225.111) smtp.mailfrom=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com;dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 130.117.225.111 as permitted sender) receiver=protection.outlook.com; client-ip=130.117.225.111; helo=relay.virtuozzo.com; pr=C Received: from relay.virtuozzo.com (130.117.225.111) by CPH1EPF0000051A.mail.protection.outlook.com (10.167.241.229) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.639.5 via Frontend Transport; Tue, 17 Nov 2026 10:50:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=6e2EcA1o7+3f8CM7eQGhhyqdD/n+f/sdGAPS4KIjPEE=; b=An4WOsDrLseB bjSM0GEteunj+4t16RJBli8rgNdbnZCKdqSoNH2Xv1npG+D8jTS1jqh8JgEdGnMzB2PerxhGPrH+0 AN+/GGpTVRvg5dPwbQCX4P5OxmXKv2YihHv0aHB7DRJgwjtaME1rglK+DYJYaIE3Shx8b9/+pLwRb EhsD9dkZQz+AiUazsfz/eWyAtbDKggZx4eLokgkvZ6NvouipmUDr9wzd0+zfhqp/k4fxD5rZ5Hp9C /m3a0VDLDScnwklR1riHaWc5bL7We7JjRB88Tqe1pV2VsKe9H3lvP5+SjVUYcYlYf76s9M4UKHz5g LmUSTx7EjpnX1xxaY1F1/w==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTGh3-00A3yD-2m; Tue, 17 Nov 2026 11:49:56 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com Subject: [PATCH hci-8.1 1/2] vhost-blk: add the werror and rerror properties #VSTOR-152175 Date: Tue, 17 Nov 2026 11:50:02 +0100 Message-ID: <20261117105003.3082044-2-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117105003.3082044-1-alexander.ivanov@virtuozzo.com> References: <20261117105003.3082044-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF0000051A:EE_|PAWPR08MB11142:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c5157bc-0790-4dfa-a2b5-08df44988aec X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|23010399003|82310400026|10067099003|56012099006|261026140227099003|261028144727099003|261021121427099003|261022105027099003|261102123227099003|261009223027099003|22082099003|18002099003|5113699003; X-Microsoft-Antispam-Message-Info: hFwfEsscHCkxGk5RaSlIl40ct2odCzJ6ho+AJDz4g4Gxd/l18H1PmyOuVuwgLnAsl4b4DOT4Fml1Hahty78EdpX3BA9dd/4gg0c02BnTQCqPFFvULIsCXUdtKxdV7Y8vCj2VDoox1bUGIucQ4Z9LbFiwMZ4zeglqMVh42GLO0pWLKPt8ahK23yb+ckn7cIcXAgJEO3GNt82WJ445uuIB1q0Iud1ymaopJ1s0r1CMh/Ly9bkDlao1ua5VEBbIgETS4EKy4I/YHdoLuL9mlmIC74QXEfa7uaslTu3/xyHWhsU5Kc2HptiXkxY3OBq/keiNP2td5ql+fKS3G44LnyNmGNqzdfbIGynhS4AbW3kMkjiKD8vvXEqhV3DeT33O+Ut3HHKwhoIS/8zOZCjDILoKDKY8lRhwFjJ3ncIvSm61ag7dJoptxDH8s3rdKp4ByxfymcsRpKWiUZuywuhevqaLNfTLIO5YJxfDO3WU641mI1mjJ9ERwhCN/wcakEvf8ObMdi4kvktFaw2v31BalQNs7FPMuAEVHX9F4YpqA3zLkXSUZ7EoiKL+o/buMPg3C3F870UBRcJWrW8e7CjjPXdpaLm19gM+MWcU3Ccx3claj8J87e/fqJA7NNOu2bIGPOI3I92tdc4sU4iz0EAMnnpBeQ== X-Forefront-Antispam-Report: CIP:130.117.225.111;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:relay.virtuozzo.com;PTR:relay.virtuozzo.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(23010399003)(82310400026)(10067099003)(56012099006)(261026140227099003)(261028144727099003)(261021121427099003)(261022105027099003)(261102123227099003)(261009223027099003)(22082099003)(18002099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5Wn5izFFKz83g39CmmdWL6GZ5B78jgqjRmYb4J4JOxeBr4014qzfstGm5SV83OR/HbL8m5d+YJC9TvHKjTL5fNOqz+CexWv+DQzhYY1FaRo3XMxqiBrg9YdYmn2SoO+UYbIRXWc/NFJwZyrBXSfzjolH4EYdzdB2EzKmVXVy86R1rZTZWRiT5S5PsBlr9bHBTu9f8DnummsOSoLReZLHaHnkC0d2/NLhEqcC+6GXPQAvP4m5kDSf/agg2fFfjJ6wwBio6GWps8lVEQTWPkqqY6r2OVqRXW5coR6zVBKCyPLuhd0nGTQqkwqDT0Agnr7DBjeLsGZQhx88u4zBnSHAc9Get+B0yne86QFAxptZKM5LAFiL4n1nPgv3twdJ0ZjT0g5QMMX/mwU8Au0RhjfSDIhjz/4C4P4epgNRg6R2T19qMK552QOxRTg/4P0flLxr X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 10:50:06.5755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c5157bc-0790-4dfa-a2b5-08df44988aec X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f;Ip=[130.117.225.111];Helo=[relay.virtuozzo.com] X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF0000051A.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB11142 libvirt passes werror and rerror to the device when the disk has error_policy or rerror_policy set, and QEMU refuses to start such a VM with vhost-blk. Accept them with the defaults of other block devices: enospc for writes and report for reads. dm-qcow2 holds the failed requests under the same policy, which libvirt loads into its table. It has no ignore policy, and enospc makes no sense for reads, so reject both. https://virtuozzo.atlassian.net/browse/VSTOR-152175 Signed-off-by: Alexander Ivanov --- hw/block/vhost-blk.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c index abddff02c6d..354111a1b41 100644 --- a/hw/block/vhost-blk.c +++ b/hw/block/vhost-blk.c @@ -617,6 +617,24 @@ static void vhost_blk_device_realize(DeviceState *dev, Error **errp) return; } + if (conf->conf.werror == BLOCKDEV_ON_ERROR_AUTO) { + conf->conf.werror = BLOCKDEV_ON_ERROR_ENOSPC; + } + if (conf->conf.rerror == BLOCKDEV_ON_ERROR_AUTO) { + conf->conf.rerror = BLOCKDEV_ON_ERROR_REPORT; + } + + if (conf->conf.werror == BLOCKDEV_ON_ERROR_IGNORE || + conf->conf.rerror == BLOCKDEV_ON_ERROR_IGNORE) { + error_setg(errp, "vhost-blk: 'ignore' error policy is not supported"); + return; + } + + if (conf->conf.rerror == BLOCKDEV_ON_ERROR_ENOSPC) { + error_setg(errp, "vhost-blk: 'enospc' is not supported as rerror"); + return; + } + if (!vhost_blk_open_backend(s, errp)) { return; } @@ -795,6 +813,7 @@ static const Property vhost_blk_properties[] = { DEFINE_PROP_BIT64("write-zeroes", VHostBlk, host_features, VIRTIO_BLK_F_WRITE_ZEROES, false), DEFINE_PROP_STRING("serial", VHostBlk, conf.serial), + DEFINE_BLOCK_ERROR_PROPERTIES(VHostBlk, conf.conf), }; static const VMStateDescription vmstate_vhost_blk = { -- 2.53.0