From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 70501803F6 for ; Tue, 17 Nov 2026 17:19:09 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHHv6Z011105; Tue, 17 Nov 2026 20:17:58 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHHv6Z011105 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="TOn3D7gQ" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHHnra011057 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 20:17:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHHnra011057 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4a63a3cbcfcso16878f8f.1 for ; Tue, 17 Nov 2026 09:17:49 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHjXBxABxH5urWvNta8MAAMmgaCCqKgwr5OtSI9SRPT1udjiCR3xu3c36pbsRkN7pByXonfGA==@openvz.org X-Gm-Message-State: APuU4Z/II25UWiR0HbCk7uNzLLKr8+n3jFl/0mXrLHNib5ecCAgTiU6F wkgOp/0Aj3p2OZ7ETnoMg4MnRtjDiWphHP/yQKaEkMZwjFPzFESn2COOAVbOtegmBgpM/em2+9V SUZ0Xb1DXdo10gZ81edBA6H928yTcDdQB8Nbma0D4SnAe9AKFpfti9g== X-Gm-Gg: AZFdTZcMqcaScKuW/jPMff74PUllbxZlNiRqFWA7qlzK7Y1q9Wag+LcSQIdJbm1UwKe wL8f+jQaeGJaPDALNb6uZ+SDnipkGHy3cEBO7wJp5ncNsQxdulCbjo+NIoQS8v+bJSwQmfJAgYN lR0KgG8yxsPkxa7j0zV2yJ50+E1WAWrHE8gMedNabg9UdjnXCUAYa41W8eUtj5sNmzzNdla0C8j nAPW+0spL2neNq9YfNQqScVgshBqINHTdRS7bt5yMJKFw/OqmiSJYTtI5Twe8KhnU/D5NxyfZh/ 1pb5omwjoIgzPr/F/93OF81wted2kZ8Obgpm1WdILsUfhO5q3lvKHd0bfbupCOKM4JmAeflcUFN 5J6Jmd6eNG9UvtlLzHXcPqF88+U8= X-Received: by 2002:a05:6000:1a8d:b0:48e:412:3813 with SMTP id ffacd0b85a97d-4a637f6367amr226725f8f.20.1794935869473; Tue, 17 Nov 2026 09:17:49 -0800 (PST) X-Received: by 2002:a05:6000:1a8d:b0:48e:412:3813 with SMTP id ffacd0b85a97d-4a637f6367amr226662f8f.20.1794935868976; Tue, 17 Nov 2026 09:17:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794935868; cv=none; d=google.com; s=arc-20260327; b=S/5A7STbZeRevEq4cG48DLGPddW0CZyImo5On26g2FVMOE60qrRnPfzDE+uixzcWCK YFmOudjI7finNt1+D1yUzwtVHds8E3AzQWylebbUT8VQFtWqLxyoEQh/oBElIWizRq0B OhZdn7sg6shE3JsOw9ZrLPBU75XGPZpC70K2XSw0h7CPy3Xbth5jlKZ5+pTTfde90JTQ b5KPi9fPfTDc7E7gg6mC/HCVtQHiiYSz0HDJ/YiTP4Smd/pd3A/PuVePeA+r56CRzkxz hmrWZLxQeIFnagcPk5BDa+V2Zf836Q2NLQ5uyH10/4sCOvEVTq3bfCyVg0sHRqyFaF1C XLkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=NeKr6Q0JnMs3wKuq3BUhr+8bIjGM5mR1GR0AgRhijZQ=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=ZSBOuHRX6AgxWIRJrezXvF6xLsdYbJCG6ZQYAwt9TtRxDy0O5Ie8Kma89x9zg5sc6V iDNSmH4IexbYmRJYyoAWy4jkmM8vIhlrJEYoiLkp7t+JYCwzIYF2vMJgDb0EEu5JM+Fy gle00wwGJbug0pNjMlmhQ0A1fZXd38iDJ2WuiB2Wn5bg84tDzdb8lJo4qm671anTB8qS RZcUfMIBQRA8BnJY4zdhuu7FRWm/grSjhQRCFLl2rBwR/WqxFe1cuOLg3LFhPiwZY9mf iw4o4rxj3nyWIt5EyHPpus869iQSiGDO5uazEUH1pB0dKw77RuDjcHAjlUp2H2Tp+A3f pkaQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=TOn3D7gQ; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6426ccc5si29026224f8f.292.2026.11.17.09.17.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 09:17:48 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=TOn3D7gQ; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=NeKr6Q0JnMs3wKuq3BUhr+8bIjGM5mR1GR0AgRhijZQ=; b=TOn3D7gQnrt5 uU++uqfIEBa7n9F9VhfNTgeSoDYPk4JWvtEpBAFqMfoJoMDwyNgXNyJklUEiElJZkA0ZsEXilSGVV DPv1mhRrGsb/m0mLdyi6StEM8nSVCBV3XuZjRdW+clbM8g67+QvI5wDTvN35NbE/GBAHAEAWbCrZn +QbyAYmKFTGwPz5wEkgja9IxmJr7Zfe+ip3d8OYyDJ7oGRbRdvwu7z3w+sDqiI99rbRARSDPNjzw/ RCENHFrqDENcncCaYhUU6EdIOCg8qd40LQwU9fUCUmA0LfkbvDTKNlIIH9tt+2sZrL5rJV3IhHGZO N4yMi1lLby72/KhzEuvaNA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTMkF-00HOVM-2Z; Tue, 17 Nov 2026 18:17:38 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 18:17:35 +0100 Message-ID: <20261117171743.3216794-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> References: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v7 02/10] dm-ploop: reject empty deltas X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_delta_check_header() accepts a header with m_Size == 0, and ploop_add_delta() accepts a raw delta of zero size. The BAT iterators can't handle nr_be == 0: ploop_bat_clu_to_page_nr(nr_be - 1) wraps to page 0, so md pages past the first one are iterated whole and the clu == nr_be - 1 stop condition never matches. A non-raw empty delta has a single md page, so ploop_apply_delta_mappings() and notify_delta_merged() (and ploop_check_delta_before_flip() with PLOOP_DEBUG) walk past it and dereference a NULL d_md on a device with more than one md page. A raw delta is not handled as raw yet, as ploop_add_delta() sets is_raw only after applying its mappings; once it is, an empty raw delta would get all the clusters mapped to it. Reject empty deltas in ploop_delta_check_header(), which covers every caller reading a delta header, and in ploop_add_delta() for raw deltas. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-bat.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 7b12b0f9fe81..4fc99400a0a4 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -268,7 +268,7 @@ static int ploop_delta_check_header(struct ploop *ploop, offset_clusters = SEC_TO_CLU(ploop, le32_to_cpu(d_hdr->m_FirstBlockOffset)); bat_clusters = ploop_nr_bat_clusters(ploop, delta_nr_be); - if (delta_nr_be > ploop->nr_bat_entries || + if (!delta_nr_be || delta_nr_be > ploop->nr_bat_entries || bat_clusters != offset_clusters) goto out; @@ -503,6 +503,9 @@ int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_r goto out; } else { nr_be = POS_TO_CLU(ploop, file_size); + ret = -EPROTO; + if (!nr_be) + goto out; } ret = -EBADSLT; /* Lower delta can't be bigger then upper */ -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel