From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4EE4A803BB for ; Tue, 17 Nov 2026 17:19:19 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHI62s011132; Tue, 17 Nov 2026 20:18:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHI62s011132 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Abe3/phb" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHHoZj011067 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 20:17:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHHoZj011067 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4bb69d84053so2730115e9.0 for ; Tue, 17 Nov 2026 09:17:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFl8nWWUYVf/pTWWT5KtUVcgihRu4dCwCMaaDb/CyECTJDCI2PmhKRD9jBSPGFHqozXhJgD7g==@openvz.org X-Gm-Message-State: APuU4Z/8hx2Lru2B4Vi8jH0vPMZJqP7h5NST3paaRJ7KNFcBV0NKyTYX RUAxVYHCEne1u7f1cYlpMfq2S6Y60QmqSPWR5Je/sRDwTGeyFkdGCV2JWk3NeOs+3fDGzU4SO83 rUEvF9tyLK+jPcPYrl8neqiNzjOdVorgnAPFXpdeRsrxJabBu2kThHQ== X-Gm-Gg: AYBFou1mD447EUkuJcvUsqK1nD9zdFxDUjGTzjpVXhbD6rzaa7f/RShUFWTJWkI+tjR LTC778+3vy/7LPw8PoZfnDNYFv/Et3hM6vgBukK/PktZZjkzQJhVNDr642kj/lMK0p+/I39KeWZ e8byZRRu+KQCOdLdAAIL7aOBWNqTSt4q0FRcUJrEajHC81FK+LyLZm3Usako1s7S83K7dOE9god DEpvCBu5rYmfRI3PN2wpkNF5kiqm3FBEEEH8GcUlKoqdfYqfUiVR8OjpbceBLoIMCkceRM/vr0E X/rLDN1CBFzrWnT3tN3UjUUFjpbxwbavt9NToRVR+HOD+/GgZmcjk1VrkR+S5q7zk4wjdoROa/b Qzdsi5D9haSxWJCzNqhRe23ni13g= X-Received: by 2002:a05:600c:34d6:b0:4bb:5c92:ce22 with SMTP id 5b1f17b1804b1-4bb5c92d047mr276127935e9.8.1794935870016; Tue, 17 Nov 2026 09:17:50 -0800 (PST) X-Received: by 2002:a05:600c:34d6:b0:4bb:5c92:ce22 with SMTP id 5b1f17b1804b1-4bb5c92d047mr276127325e9.8.1794935869527; Tue, 17 Nov 2026 09:17:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794935869; cv=none; d=google.com; s=arc-20260327; b=bUM3P1eENeqKI/bY21DIvjMN93Ncp/almj6j6MpehdNVw6n/woFVe/1Or6V58t3W8r pUsfOKja36bz8wsVjmM6huqEZ3qu40jF4EOpPMiSlrq4lL074eRjhndCa7irB0aEsYD6 1aPGIKiHr0DMgJRCz+V1qfEzzGM0AF9CVD8wiAy9C/i6KsBuwZci+bRxYPgnqJX0g4ka nTcf66ho1bh/m2AlILJMxRJ4j+U9GQAABXaH8wGlwVhv+/iVkPJK0FgSDiarW9iNQyyZ 6pr7X2jgdj/LQllaJevsQ9BHdJ9mKivn5x+Z+hPxiZx/Bee/piZzLWwiDwClZqvpdl5E ah5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=0FGX8/JcCruLrokeDY5uCNPGnnH0QZrXnXfDNL9Um7E=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=p8ulfkHYeDvcrbC20/RwQyrSLj/TlY4voGj8uQD2YKXkQAND/ugteIVIflJcMM6+qZ IVFMtLrYm5ZCobTjhFQ18KKnGC9vK49k4ytgV/DSUMsyX2GXgWrj4CVFCdS7JJcTqUwQ daVAnnVILHj3RTitAieRGahWoTSijNpBzZg8nUr54ijrwul89bWtQGrFnUbAA3iDWkHg 4cfMnfS0eBwIiJ26EK/GZca+0hdklX0AoHrop6XHGOkfK8dRl6WEqMLWF1eZKV+d2oMk ihs2XP7DwQaN2uDOqpCEYPEVxTVwSFytKqOMBJN+tU5W+sAYzD3T8ODA0mphn7dShmx1 xBAg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Abe3/phb"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4bb783ec44esi97723065e9.23.2026.11.17.09.17.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 09:17:49 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Abe3/phb"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=0FGX8/JcCruLrokeDY5uCNPGnnH0QZrXnXfDNL9Um7E=; b=Abe3/phb8QqO Ewvsx2noAEN7ZrcetQbKrEeVswM8cJyZnd2v0e70OqstxC01pDjn8K+DlPrpMBMWJhXLM3KGQ/IXk LhxJDAfL9j0xKj3Sv0/c/sIQibn5QN584wevGndG53AZ/XlDgl/1C/lEoQAJXWx7CfTLOo0ZDb6+d VewGzlzM/ssT5MrOxfbXfAjFbckqokF+2dqDajUxT9ZPd/2LlDJTDyP84wEPWlD9IIyy3eGVi0evP i0GcDV6N7OWZQEvo1R1xSuTi34SSgh2opX/+ZpNYsYHXiiyEw7RqIt5822grjYEow0fWnqsdgq9pI VyhfE45HzKk9Xyy6Crovrw==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTMkG-00HOVM-1Q; Tue, 17 Nov 2026 18:17:39 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 18:17:38 +0100 Message-ID: <20261117171743.3216794-6-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> References: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v7 05/10] dm-ploop: take bat_lock around md page lookup in ploop_llseek_hole() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_llseek_hole() walks the md pages tree without any lock, while resize inserts new md pages into it in ploop_add_md_pages(). A lookup racing with rb-tree rebalancing may follow a stale pointer or miss the page and return -EINVAL. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-map.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index 58d1c7092602..1df31bbc5410 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -2773,7 +2773,11 @@ loff_t ploop_llseek_hole(struct dm_target *ti, loff_t offset, int whence) while (clu < READ_ONCE(ploop->nr_bat_entries)) { if (id != ploop_bat_clu_to_page_nr(clu)) { id = ploop_bat_clu_to_page_nr(clu); + + spin_lock_irq(&ploop->bat_lock); md = ploop_md_page_find(ploop, id); + spin_unlock_irq(&ploop->bat_lock); + if (!md) return -EINVAL; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel