From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8F58E81AC3 for ; Tue, 17 Nov 2026 17:19:22 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHIBZU011146; Tue, 17 Nov 2026 20:18:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHIBZU011146 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="sHD4TQPm" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHHoc9011078 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 20:17:51 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHHoc9011078 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48e0ef019a4so3469347f8f.3 for ; Tue, 17 Nov 2026 09:17:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGTo/b9eeirNl4FHa6DD3PRwCSBW3dIeBZFnzoQh6sQgTMhQbpqVJHcZlvies34qWLEUTb2/A==@openvz.org X-Gm-Message-State: APuU4Z8zR/IbnTLUetLZlspQkWDY2FiQoBhg+NASb1pxrRhPWSmA5M0R 2h36B4gu92cOlLa/qmIb1WFdae0zaSwQilKDLfaljVvQIE/8Kds7LSEixxBOoRYHoYEb8QhHFIJ 3dkrTf66FLWMbVgcuTaT50X+S0HgsgIn2jbG2zJ3Hj0BUNvYg06WwMA== X-Gm-Gg: AZFdTZczk2w16h1rkiWOaO94GYCktFBlQuMSoh3gS8uEOP6Nuom+omptYzyLKXCqG6s ii9j1haMGWubVzvKIJ4gX9/kceHRDCA/mc+dEe3L9KhAF6VfIq35HwVGheYYjWZRCgz7Pj64X9+ hQ2QO4Iknw5OTMAuWa/hizfdc30tJWNKPxvWl3Uou7N0d8hIvxzt4YHZyYpi1jnRpLpHhntrurF 1CBgt6I0EJ3OlUgNj8bkMyjPHD2hnPL+Qaln5qJeFw5CqcqSwIDDv+7P4ixA3sugDMqAthUNxM+ UZ1EUnRxvOSsyDz5Sdl/8Ah0ChbbultmlCL5npWfLeMmrvnnCVLiw/02bfVRubtCPoU+cRwq+Ca kmsksB7CzZbKmy1kTOjlf7b/+75Q= X-Received: by 2002:a05:6000:4706:b0:48e:5df9:1ec9 with SMTP id ffacd0b85a97d-4a6389ee18amr231779f8f.24.1794935870590; Tue, 17 Nov 2026 09:17:50 -0800 (PST) X-Received: by 2002:a05:6000:4706:b0:48e:5df9:1ec9 with SMTP id ffacd0b85a97d-4a6389ee18amr231711f8f.24.1794935870085; Tue, 17 Nov 2026 09:17:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794935870; cv=none; d=google.com; s=arc-20260327; b=b1haT/VBnqQRbKj7sicVpUvgqwl48Lva9P/wyPhwdvAx4ya7DrFQtL74OSRMIKlTQ4 3w4Q41OTjLoxZsq+fepiICMMdFlIl73jSv2LxWqO8FYvE76ZHJUqBvSuYMNo2SMfd3bQ ZM4ZzVQf2h1BZFhO6dDAwucwvXjsKOhgqTg60eXDaJ6n6VV20mUgmT3uHT2+i7vpUftk Gxshs2BsL1FHJGYMj6OAKOm6/hlY0O0SVMAO2M65iL25AAc6I0Dje1cOkwSuX/jlBxpo JU+rpn0xiqrzF1v5dzs1KKfrh+uKqfGnNEkMmfEvouN3OUu+ccMA2OYDIFeZoHdGKZ1/ HXSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=USyRzL1cnV0P+Hz4Qqtjq1+uUN1fVX6Wf7kBpA4FDzw=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=Qp1oqd/Tmpz5D3oNyBhzpx3XRdrwo4OddUi8ymt6C1wCyQdDnwvg092qiDioGSuNEf jjNYYe+D+X8Nm/2424AoK6XR6Jpvaownt3gvlIzsnIIWI/mRD5IvpTwpamzZZdUoDFDQ 9VpPT6EQH9D4r1LMRxJ4FK3rjQx0K2+KzAhKZWTNsYBJSzNJiBbDJvt1I/e1ugq4O6c7 CPbtxfVj5Tl3qvKe8SH5LZogrGyVvfS1F7hIoENh6Vyx/O8dzNERJVGyGmb3Tur1SGK7 6+RGPNi6dN7u4fvBi2zoN6EcG6I5vWNgEI0MUrNWVnvqOa3O/ZCO3u/HEwSbL2+jn9Qr MYjQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sHD4TQPm; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49d36fa7daesi25211564f8f.485.2026.11.17.09.17.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 09:17:50 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sHD4TQPm; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=USyRzL1cnV0P+Hz4Qqtjq1+uUN1fVX6Wf7kBpA4FDzw=; b=sHD4TQPmBB7J ZmHSswqqYOLJ8VmI6HyoqLDzis0qM3UFmQpwXOXu/7m+3kKUbh/fRuUjPZKN+1fxQkZHJISPCNaQt IuPT3bkGOSnZXOV8Tb7T7I7ab7Iz0jcAE/xtPbXHBz13PEBvkEYZBQJO+9OikwUH/KcblOPgejBDQ 3315kz7LFELRmOIYHCCukZ5knJy6XvS6KwP48hgdPRQKvSUMB+eRrbXcVk5aqvIuZgVo+u8orNLfs 0ziTkSsc4pcJmsoKfahBV1nGO031SjhpklGX7gcQKVX0D63ro+i5KjqOboD7vfK07miqVbmT1MsYd Kw+i4Cl5vnDw3gHaWChyzg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTMkH-00HOVM-04; Tue, 17 Nov 2026 18:17:39 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 18:17:41 +0100 Message-ID: <20261117171743.3216794-9-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> References: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v7 08/10] dm-ploop: fix flip_upper_deltas racing with resume X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_preresume() checks noresume under ctl_rwsem, drops the lock and only then clears ->suspended. Messages are not serialized with resume: target_message() uses the live table without md->suspend_lock, so "set_noresume 1" followed by "flip_upper_deltas" can pass the check in ploop_flip_upper_deltas() in that gap. The device then goes live with noresume set and the top deltas swapped. Clear ->suspended in the same critical section as the noresume check, and only if it passes. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-target.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c index 3b5f37a58bb1..bfadca7f12ae 100644 --- a/drivers/md/dm-ploop-target.c +++ b/drivers/md/dm-ploop-target.c @@ -764,19 +764,20 @@ static int ploop_preresume(struct dm_target *ti) struct ploop *ploop = ti->private; int ret = 0; - down_read(&ploop->ctl_rwsem); + down_write(&ploop->ctl_rwsem); if (ploop->noresume) ret = -EAGAIN; - up_read(&ploop->ctl_rwsem); - - if (ret == 0) { - /* - * We are singleton target. There will be - * no more reasons to break resume. - */ - ploop_set_suspended(ti, false); + /* + * We are singleton target. There will be no more reasons to break + * resume. Clear it under the same lock as the noresume check, so + * that flip_upper_deltas can't sneak in before the device goes live. + */ + if (ret == 0) + ploop->suspended = false; + up_write(&ploop->ctl_rwsem); + + if (ret == 0) ploop_set_wants_suspend(ti, false); - } return ret; } ALLOW_ERROR_INJECTION(ploop_preresume, ERRNO); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel