From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020134.outbound.protection.outlook.com [52.101.84.134]) by lore.virtuozzo.com (Postfix) with ESMTPS id 15FF781B58 for ; Tue, 17 Nov 2026 17:37:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FrmJ6LYvDcmro5JLKo7cciiKbm2VmP2IYpijCujjkJOiVq4ZPaklBcpY/g4VSJWTlvsqXsxrMQtOeR9ajrIb3H4qBRpHwbH/LozEpiXcqGIv3EkLUQKmaGG57BSq0m9dBSxkdfksUYcBWtXA5qBDEwYX5f6Mi3VNglnu5Ab5dlgV733KW+HNG4XtCiaf60AkwxOXo/H4gcqBRKDaJK+aI62Reu791aVo3Vbg5Dl6IqMQGRYF6hTHdD68gP7/MAn0HkMbLbhQkCgROnh5oNZ0nYX7pvH8CGqzuseEC/xKfC7U7AvktZ+kerZC/luLbA71+lLC7oOCpWAwRAsmVTdNRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iyD+h51mpy/bYyrgoccoLXZHMPavgcSO55Pekw74xVg=; b=twTqQt9CbeLqUIKmyJj0V66AhZYRVEJisrcaC+kpWm2gN3n8lUeHeR2hWikwac5s/l3nFiz/Oo+3Zkkw3+3EWseQCFvLyApqCRysI9b++yzwEk01z8WVZM9ZwBQt+916w/PSwb/w67sVnH6wdcnC8G8PloLgLTiq3jKfsjBAT0UgUVUOQNIqr/8TU085adg/rXqYIS2Krezk2NNDoAJr44KxBj5IV8giC4lqvmOOT8u4qJdzQm7Zwvtks41VOzzD1rRS8V3h5qA2856bakejfaoBnwv3aDC4FMY+q7rIzYfVv+oZDer2dWZ5oFP/mUTk3gIaq58y021ots9atxIomA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 130.117.225.111) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=virtuozzo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iyD+h51mpy/bYyrgoccoLXZHMPavgcSO55Pekw74xVg=; b=TfRLLFbRLxNuPf+lqt3Bp+GPPG250eyDCLLIU/pDmOinm278FoOMvlP1dw7PGK+1JPEL5Sta8UU/bADix2SPLhgPkI2int7Et6cg+clebZmVsBDFgqTFC1PEyiEHx8X83J42e95EE4KiHuROMe9q05TfTF5i6Xq1tDFMNmEm4ALdKAclDlMKw3YYgPxJvU5YVjIrLMhPitDN1gfmqc65lf41oQLxT0gbkY0N593aD3TIM3+Rgn3DG5oYOHnwqUQmcnM2XRC4rWBv67IZYmL097TYyWc+jWamqiQpjnkqALdw/OnSRNhB/wJGeN7n/pPWektqGDXo9F/pHDWlVwP39g== Received: from DUZPR01CA0232.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::6) by AM0PR08MB760621.eurprd08.prod.outlook.com (2603:10a6:20b:7ff::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Tue, 17 Nov 2026 17:37:39 +0000 Received: from MAD0EPF000008BA.eurprd04.prod.outlook.com (2603:10a6:10:4b4:cafe::44) by DUZPR01CA0232.outlook.office365.com (2603:10a6:10:4b4::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.14 via Frontend Transport; Tue, 17 Nov 2026 17:37:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 130.117.225.111) smtp.mailfrom=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com;dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 130.117.225.111 as permitted sender) receiver=protection.outlook.com; client-ip=130.117.225.111; helo=relay.virtuozzo.com; pr=C Received: from relay.virtuozzo.com (130.117.225.111) by MAD0EPF000008BA.mail.protection.outlook.com (10.167.241.169) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.639.5 via Frontend Transport; Tue, 17 Nov 2026 17:37:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=iyD+h51mpy/bYyrgoccoLXZHMPavgcSO55Pekw74xVg=; b=dIlmto3u3w97 o7RdXoFt/S9t38hjdbvnQB12vSNLQo6p+RQ/EKff/XNcVMt14ZELk/UVx8anEfpwJkL9mob6ksmpy cDGFJNrWQZWDV+PydlBVp25S3Jn7Bj/+OTHkBQen31HTzmi1hxx9PQXoi0Q7driVbHzLn78EBFmrL qW0H866CN7rd3Eq8eSLo4NbDGGrY+qQ6aG9nBIzcuVZ1zw5ghj66CZT1jCqXIqdCzI4AQ6Pa8SOQw 1Ikv2qBA6d7dPN6wxA8duO23ZPvxRRM3Dt1eaQ3g/LkNh1UuUKyoL9VRpkBwGhdah9UW7KeMQoT1D VEv+MakV/eUPfjpeb1eNZg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTN3Q-000AxI-0t; Tue, 17 Nov 2026 18:37:27 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com Subject: [PATCH hci-8.1 v6 0/7] vhost-blk: switch from VHOST_SET_NWORKERS to the mainstream worker ioctls Date: Tue, 17 Nov 2026 18:37:27 +0100 Message-ID: <20261117173734.3225443-1-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008BA:EE_|AM0PR08MB760621:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cc78fc1-010a-4a9c-0ddd-08df44d178d4 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|1800799024|376014|23010399003|18002099003|5113699003|261009221227099003|261009223027099003|13003099007|56012099006|261102123227099003|261028144727099003|10067099003|261026140227099003|261026121527099003|261021121427099003|261022105027099003|261021123027099003; X-Microsoft-Antispam-Message-Info: t7q9fdFOtaYwI4e32ds2Hezmmv7sAulzB814cp4rqkPtStquQ6yvAlmilAQIrrKe+yZVEuZwOsxCGkJO6efPgDe9/lY0wf8OSfHZh6/M4D8ZNDWdS0tph4qynvIOz/SDIjvAsSFGQYdMw0FRCYxIHlpq4h0q6cFxfnol9HlxpBfRU6zT4yqBmxyIlMmD8JhXfDuYlMpih/echjcOaVwOAmhgoXIKOwjHZRqLE6gFoxTQemR74e8sLUx3r5V/d6QpaLUyosC4tr8HbNVA4YYihD060wVpxhcv1d7/BPmYRvqeKn5jSoHPS44mHOhdHOKvD8XzTRMINQVgs2zyEJuPEbJtgojwZZZYm1W0t8WU4vjYdebuWIFlvjdsHKSreNUZyLDsOozLVjbfWo7gfmQ/e+ylDMx+VtqtbNHae9BlX4RBMuKXTx2oi5rVjYkMVnLHaRp85KD7Pj8QGef9qbkPoZoXJS2lvqegyH488+M0baWF3Ihjncm2VfTFc8uGtME9SXwytORgdrs5upFPUcEOwYmT7o+eF8CDIfmXJSWnd09+9yzxWdiemDiTsMb/fsUQa7HM2xzts59Uw/BpwbRogBMZ3NKx9r+ejSnNvtBdrwB1loOU5xMQFEp7MrmDUOsQENYRR6huCuWRpRqneK+hlA== X-Forefront-Antispam-Report: CIP:130.117.225.111;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:relay.virtuozzo.com;PTR:relay.virtuozzo.com;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(1800799024)(376014)(23010399003)(18002099003)(5113699003)(261009221227099003)(261009223027099003)(13003099007)(56012099006)(261102123227099003)(261028144727099003)(10067099003)(261026140227099003)(261026121527099003)(261021121427099003)(261022105027099003)(261021123027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Dd07XlfbGqB/LAQRRcK++ruiMtUYGMRNFAR7/uCORlTF31xXD8dyPXGIXi4LWvJzzslQQ7PMmVpU44P1LHsxj912mJlOmC24AAxWI6KT1buJIGV33QVCI6/to/1D+xzwf18Tfkmw5yyyZRjizEykbPKjPGysDfN8Xsc3DX5JN6MIIS2z/CTEDJJp3fP2PkMmB3cIhh/Qo9BblNeG4Ua6Y8VwBMJUTmqFFNqNK5Y2kNEsPTcsn9hhAXMtmILp95Tj8UTwFVljBDzsat8Zw7S9UuVf2Zal28BV/tzEhpVyJRBl9/Ah5cqWO+25nXU9yxYtw0LNls8NDOR2pQqr6TSGLD4NbK/HhzyEbplCwZgyHwmUswdFQH5X0rCOAla1bzUuIQTq3YJBXUQkYHuW719fu+7uIzr+DJ7VqFLLEfJsTJB8py8fZzhQkLUL8bPJ5n2u X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 17:37:37.5647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cc78fc1-010a-4a9c-0ddd-08df44d178d4 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f;Ip=[130.117.225.111];Helo=[relay.virtuozzo.com] X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008BA.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB760621 The kernel drops our VHOST_SET_NWORKERS ioctl in favour of the mainstream VHOST_NEW_WORKER/VHOST_ATTACH_VRING_WORKER, which vhost-blk now supports. Patch 1 wraps VHOST_SET_FORK_FROM_OWNER in a vhost backend op. Patch 2 refuses num-queues above VHOST_BLK_MAX_QUEUES at realize. Patch 3 is a cleanup taking &s->dev into a local pointer. Patches 4 and 5 fix the error path of vhost_blk_start(): it returned 0 on some failures and left QEMU the owner of the vhost device. Patch 6 makes vhost-blk create its num-threads workers with the mainstream ioctls, keeping the same worker layout, and fail to start if the kernel cannot provide them. Patch 7 drops VHOST_SET_NWORKERS from linux-headers. v6: - rebase on the current hci-8.1 - new patch 4: keep the original error in vhost_blk_start() instead of returning the result of unbinding the guest notifiers - new patch 5: undo VHOST_SET_OWNER when vhost_blk_start() fails - patch 6: ignore -ENOTTY from VHOST_SET_FORK_FROM_OWNER, so kernels lacking it still start vhost-blk with a single thread - patch 6: reset the owner when the worker ioctls fail - patch 6: drop the claim that released vz10 kernels have VHOST_SET_FORK_FROM_OWNER from the commit message v5: - patch 4: fail to start vhost-blk on any worker ioctl failure instead of warning and running on fewer threads than requested - patch 4: switch to vhost_task mode for num-threads=1 as well, so the default thread is of the same kind whatever the number of workers v4: - new patch 3: split the &s->dev -> hdev conversion out of patch 4 - patch 2: quote the error realize fails with, add Fixes: - patch 4: do not key on the errno; on any worker ioctl failure warn and continue with the threads created so far instead of failing to start vhost-blk - patch 4: drop the comments, explain in the commit message instead v3: - new patch 1: call VHOST_SET_FORK_FROM_OWNER, VHOST_NEW_WORKER and VHOST_ATTACH_VRING_WORKER through vhost_ops instead of raw ioctls - new patch 2: refuse num-queues above VHOST_BLK_MAX_QUEUES at realize instead of clamping num-threads in patch 3 - patch 3: create each worker right before attaching its first vq v2: - patch 1: clamp num-threads to VHOST_BLK_MAX_QUEUES - patch 1: note in the commit message that our kernel, unlike mainline, defaults to kthreads https://virtuozzo.atlassian.net/browse/VSTOR-107537 Alexander Ivanov (7): vhost-backend: add vhost_set_fork_from_owner op vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES vhost-blk: use a local vhost_dev pointer in start and stop vhost-blk: fix vhost_blk_start() returning 0 on failure vhost-blk: reset the owner when vhost_blk_start() fails vhost-blk: create kernel threads with the mainstream worker ioctls linux-headers: drop VHOST_SET_NWORKERS hw/block/vhost-blk.c | 105 +++++++++++++++++++++++------- hw/virtio/vhost-backend.c | 7 ++ include/hw/virtio/vhost-backend.h | 3 + linux-headers/linux/vhost.h | 9 --- 4 files changed, 93 insertions(+), 31 deletions(-) -- 2.53.0