From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020079.outbound.protection.outlook.com [52.101.69.79]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8E2B4819B5 for ; Tue, 17 Nov 2026 17:37:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TNLD+UT6kQ0WlPJKojcI1gGpkgN1CvE62dud0REs48JZDy5TUCXXWVROq9uDj2XjtnAMPNa5gAskC/j3K5rDYa0d9w2gMSwOoG2DO9JlHaZtcBPiutPK929g/evTeH74nbU9d1qxcbcLYQTG1eKK0bcFO/3jroWpHcwFu7ja+JFIhXXho/h2LWwQt3diMGNHRsmvi+gENnKxamdfDeS8yP2QGA/85K5yDBU3GY93xI8T1MwiYXarTN2Ty6YWvdbHJJv0OHhFEnYTr9dDH5B6a3gWgQLvBJXBMw4Svx3OgD8mQ7oDibLmHk7izbBis11sMIJgAUTYXR/Fj9T5vyq83Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=AMpTri6FV22C96NU1+c43Eio2SCm4/q4hOWtame/db8+i9mDzFRSctOeCD0Mh7+bPrWoI7H57uM8dxs7qIRXmfBGlyhs/pqZ6vJZky/JRtQ4zJ0YPfdMUV1CzZsXXjADc+hsiHcwxqRtZrdZAxQ0yPFdzR0cWzyyZy2UU7nQTgetpIhfBU/A/ZqE1oO8inpgnL4pvfbj8HS8qjMgSqn5dMcdb3+5FNwatEszc4g3BfCkLBA0nP5Y5xQ7z1LAr4jpy3ZOLF4bnQzAlYzekypGk+EeCsJ6VjvaBCx8gzI+Pzp53K/M7Qdqr+wTfBa1cRgxPUTUrsNbSr8BQedlyQG3RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 130.117.225.111) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=virtuozzo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=VSJaSwLdLZdyh3zMAnBoPzAIwh8G2EkXbbvOpz47PXSuBdLNpae8XXp55rgsfdVhgSe4dQNKnAyFN6L2i+V+8i/5MsuZdsr2p/popczqRUIfokJfPDc+9qyIerOzlP00FVaJj9T8xXnfrH613q6WZgJZbqAc1e1fA8KwIvRR+I9+Yo3M3PUw+g8Axi+Z2SV4RiNKouKov/hkxzBxaRGN3JwyO61hRRhCNlTNh/PtdpQIWy4Ng1tHqYD6Wp32TxuPpQehm2QJumG7epLDdIjYA71IEbwuEZ4/Ysh03u+sMVsfjpMTl0Mf3xoaIAF6pHCUSHO/uj+wv/cLmAylBnu60w== Received: from DUZPR01CA0005.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::9) by DU0PR08MB8811.eurprd08.prod.outlook.com (2603:10a6:10:478::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.13; Tue, 17 Nov 2026 17:37:38 +0000 Received: from MAD0EPF000008B2.eurprd04.prod.outlook.com (2603:10a6:10:3c3:cafe::4c) by DUZPR01CA0005.outlook.office365.com (2603:10a6:10:3c3::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.14 via Frontend Transport; Tue, 17 Nov 2026 17:37:38 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 130.117.225.111) smtp.mailfrom=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com;dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 130.117.225.111 as permitted sender) receiver=protection.outlook.com; client-ip=130.117.225.111; helo=relay.virtuozzo.com; pr=C Received: from relay.virtuozzo.com (130.117.225.111) by MAD0EPF000008B2.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Tue, 17 Nov 2026 17:37:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=UldUudELuuvP fJeGCMj7fWxBm3zC+3m27Mlqlp0HAtcVHt7TO8gfZp1DewWEVsL4aHHPI16xGaRf6L6mqcu1To9Qd qk5Ob1rB9Xo06C0oYo0/XvpLFAEk7iqICbkQjA1prvu80axv0B6LcIoN9P7l3giyYvmGgpyDCjjDD l1F9N7ZGDp6INdHrHhikwv5pTRDUAmCLsCODCLj1kjNj7OIP41DwasgK+7zeSKFwOvckNyHTnIqV3 KCg504E/aw827azKZJJOZdrW33M2hflRin7sFYGCgIktIDu7LFA8AW/JwQWxMsLEVFUW5IuVMzGZf OGgrsUu+ajIyfhUDtu/s/Q==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTN3Q-000AxI-2H; Tue, 17 Nov 2026 18:37:27 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com Subject: [PATCH hci-8.1 v6 2/7] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES Date: Tue, 17 Nov 2026 18:37:29 +0100 Message-ID: <20261117173734.3225443-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117173734.3225443-1-alexander.ivanov@virtuozzo.com> References: <20261117173734.3225443-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008B2:EE_|DU0PR08MB8811:EE_ X-MS-Office365-Filtering-Correlation-Id: f3af101d-9fc0-40de-b6e5-08df44d17914 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|82310400026|36860700016|10067099003|56012099006|261021123027099003|261021121427099003|261102123227099003|261026140227099003|261009223027099003|261022105027099003|261026121527099003|261028144727099003|18002099003|22082099003|6133799003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: pGtOrGWwiVT5bY1e5izqNb25Trmur+mRoDRrQUprzG1XjDoOEphZEjiqvlSEZPY0B08gxITHkWU/AJa2HjbMaQIzHITlEYUXM6HPCXmWUtdUnX3XxnoUDWqK30yMsA2ywGarVltLSofpmDHiIxJFtjggSsAmEbYnd5p/M2Jg+Dc6CtwidUyiRKKXGods94JZSMspKmoQNkDN3xEJPKO9muF0zXy5aoBfeEwyNPLccPQgWzIZe766FFlkxuECHrF+Tfh15rV89j9v4K5XOsMCDe3iIynqKijgc1qmnpTKPKtvVYmKQfR69NPzR+VNY0kuz6f1bVhIZEwgnNAyeP/5AGHJP//gNU3pFKFWB/IcOLBHVGypq9paCHXil37kaqY5+sReQ6MATOz1Yfj7KP9EcEKsV8qmh29R77ycQI0CNG+mhT7/e5ZYCyBOjK3gwsEqZlLKRPuyJtGRFjJZ3Vwu41MCCB8Rj1DIC0w5B7LMEa2eROGm/WbyDOXLIAndTRJfCxYGhQb5qD6f/8LpMODLHbHJhpnQhBPfBT7V1noxJ+E3goekpV2C9+QGsh+zTEARH5ZiKd+YdmCG2rTpIUPI4spCiOv3ONI3YJNXZ+DF1MZJNToYCSrtvtnjtVYPn48AI/5B8XAFnuWB1bKP2Hp3Ww== X-Forefront-Antispam-Report: CIP:130.117.225.111;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:relay.virtuozzo.com;PTR:relay.virtuozzo.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(82310400026)(36860700016)(10067099003)(56012099006)(261021123027099003)(261021121427099003)(261102123227099003)(261026140227099003)(261009223027099003)(261022105027099003)(261026121527099003)(261028144727099003)(18002099003)(22082099003)(6133799003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NDz94OMK0YTFd0oCRI5RXVOmsUWDCLiNxb6H5LkqTAYmaONPsrdi59BolgRFO2ojfzkUjXBNzKN1H6z+LMlxVysmDLLG56pYXu7f05ie2KlG6DBF5RKd8v1f+vbJwmxs1rYi+J2V+O6bYFWQwJq4Zd6lHbgbX1+08LOx3yTfVZfjaeOwXPh6DUAkY5IO2fiZjr4b6mWvyXU+d/wkhSpHTiLvYwLcFfC2V/BrBpHOJhS+jYl+K/Pv2ZZAKr5JqldrHkNodPfaGD5I1UhvCf4bdhvpA1INO8TZbTJkfhgudqMlf3rP3UcG0lW7ywoTcISF/KMPNKHKC25PTfwsG2X7UcFSZ3m6wE9+XwTzjrjCumrFNXDWwA94lts4uQSgUZeljMcsQfO8fHZtILxZ0xH/tkKGxD5N+dgPT1ldmKP07aZQKZwPJ40XUwIu9HNsL1OF X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 17:37:37.9881 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3af101d-9fc0-40de-b6e5-08df44d17914 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f;Ip=[130.117.225.111];Helo=[relay.virtuozzo.com] X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008B2.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8811 Only the automatic num-queues value is capped at VHOST_BLK_MAX_QUEUES, an explicit one is taken as is. The kernel vhost-blk device has that many virtqueues and rejects any vq beyond them, so realize fails with an error that does not point at num-queues: qemu-system-x86_64: vhost_set_vring_call failed: No buffer space available (105) qemu-system-x86_64: vhost-blk: vhost initialization failed: No buffer space available Check num-queues against the limit up front instead. https://virtuozzo.atlassian.net/browse/VSTOR-107537 Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend") Signed-off-by: Alexander Ivanov Reviewed-by: Andrey Drobyshev --- hw/block/vhost-blk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c index abddff02c6d..8a015d54fa7 100644 --- a/hw/block/vhost-blk.c +++ b/hw/block/vhost-blk.c @@ -598,8 +598,9 @@ static void vhost_blk_device_realize(DeviceState *dev, Error **errp) VHOST_BLK_MAX_QUEUES); } - if (!conf->num_queues) { - error_setg(errp, "vhost-blk: num-queues property must be larger than 0"); + if (!conf->num_queues || conf->num_queues > VHOST_BLK_MAX_QUEUES) { + error_setg(errp, "vhost-blk: invalid num-queues property (%" PRIu16 "), " + "must be 1-%d", conf->num_queues, VHOST_BLK_MAX_QUEUES); return; } -- 2.53.0